)]}'
{"scripts/files/elements/fedora-mongodb/README.md":[{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"cd5e41c07b2dd63c216d58da6128bf197102afad","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Sets up a MongoDB install in the image."},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"TODO: auto-tune settings based on host resources or metadata service."}],"source_content_type":"text/x-gfm","patch_set":8,"id":"AAAATn%2F9uJU%3D","line":3,"updated":"2013-12-06 18:49:21.000000000","message":"can we remove this TODO? if it\u0027s a reminder to you, file a bug/bp in launchpad.","commit_id":"a81282754e71946fbe16ee1499ce0d1cefad8dfe"}],"scripts/files/elements/fedora-mongodb/install.d/10-mongodb":[{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"e5ff392d48587fd33e49f204011a7a93a4ba6633","unresolved":false,"context_lines":[{"line_number":6,"context_line":"set -e"},{"line_number":7,"context_line":"set -o xtrace"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"yum -y install mysql mongodb"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"AAAATn%2F%2B0Og%3D","line":9,"updated":"2013-11-19 19:20:22.000000000","message":"awaiting consensus on https://review.openstack.org/#/c/50597/28/trove/common/cfg.py. if version pinning is required, apt-related sections might be required here (see https://review.openstack.org/#/c/52666/5/scripts/files/elements/ubuntu-cassandra/install.d/10-cassandra)","commit_id":"888fa3d16a4fb4a2dea6aaafb35dc0ba605fd1fd"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"f2c4db29f921b7852d70ab081f045715378f778e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"set -e"},{"line_number":7,"context_line":"set -o xtrace"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"yum -y install mysql mongodb"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"AAAATn%2F%2BscI%3D","line":9,"in_reply_to":"AAAATn%2F%2B0Og%3D","updated":"2013-11-21 13:02:36.000000000","message":"As it turned out, we now don\u0027t pin versions in Trove code. So this is just one I plan to test the code against","commit_id":"888fa3d16a4fb4a2dea6aaafb35dc0ba605fd1fd"},{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"4c59cc1881d78678cc5c74506f7fc5abda69860f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"set -o xtrace"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# Mysql client is needed by guestagent to store its state into Trove database even in MongoDB-only deployment"},{"line_number":10,"context_line":"yum -y install mysql mongodb"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"AAAATn%2F9uO4%3D","line":10,"updated":"2013-12-06 18:28:37.000000000","message":"Since conductor is not a part of the agent, please remove this.","commit_id":"a81282754e71946fbe16ee1499ce0d1cefad8dfe"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"201ceaa680399db8498c9234d6355af0167a43fb","unresolved":false,"context_lines":[{"line_number":6,"context_line":"set -e"},{"line_number":7,"context_line":"set -o xtrace"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"yum -y install mongodb"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"AAAAUH%2F%2BM38%3D","line":9,"updated":"2014-01-29 04:51:51.000000000","message":"also needs:\n\n    rm -rf /var/lib/mongodb/\n\nto avoid having the guest assume a migration needs to take place, causing an infinite loop on:\n\n2014-01-29 04:22:02.623 DEBUG trove.openstack.common.processutils [req-90b52375-5841-450a-8896-b4fdb4a45f7c 1608984302624e548e8617d1c5983a19 7eec58dd037e488689a920d8ec07cbeb] Running cmd (subprocess): sudo rsync --safe-links --perms --recursive --owner --group --xattrs --sparse /var/lib/mongodb/ /mnt/volume from (pid\u003d1215) execute /home/stack/trove/trove/openstack/common/processutils.py:137\n\nbecause /var/lib/mongodb/ is empty.","commit_id":"9087386955fb837133ccf4ce6b447e2e90f8f56f"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"7fe3d18eaa5b09981844a8274342d54b2e9ab3c1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"set -o xtrace"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"yum -y install mongodb"},{"line_number":10,"context_line":"rm -rf /var/lib/mongodb/"}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"AAAAVX%2F%2F9Ls%3D","line":10,"updated":"2014-02-27 06:20:11.000000000","message":"the \"rm -rf\" logic has been moved to the guest (see https://review.openstack.org/#/c/50597/61/trove/guestagent/datastore/mongodb/manager.py), please remove this line.","commit_id":"5760a8e4d806f10c507634e4a3682c6195599a9f"}],"scripts/files/elements/ubuntu-mongodb/README.md":[{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"cd5e41c07b2dd63c216d58da6128bf197102afad","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Sets up a MongoDB install in the image."},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"TODO: auto-tune settings based on host resources or metadata service."}],"source_content_type":"text/x-gfm","patch_set":8,"id":"AAAATn%2F9uJM%3D","line":3,"updated":"2013-12-06 18:49:21.000000000","message":"can we remove this TODO? if it\u0027s a reminder to you, file a bug/bp in launchpad.","commit_id":"a81282754e71946fbe16ee1499ce0d1cefad8dfe"}],"scripts/files/elements/ubuntu-mongodb/install.d/10-mongodb":[{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"e5ff392d48587fd33e49f204011a7a93a4ba6633","unresolved":false,"context_lines":[{"line_number":6,"context_line":"set -e"},{"line_number":7,"context_line":"set -o xtrace"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"export DEBIAN_FRONTEND\u003dnoninteractive"},{"line_number":10,"context_line":"apt-get -y install libmysqlclient18 mysql-client-5.5 mongodb"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"AAAATn%2F%2B0OU%3D","line":9,"updated":"2013-11-19 19:20:22.000000000","message":"awaiting consensus on https://review.openstack.org/#/c/50597/28/trove/common/cfg.py. if version pinning is required, apt-related sections might be required here (see https://review.openstack.org/#/c/52666/5/scripts/files/elements/ubuntu-cassandra/install.d/10-cassandra)","commit_id":"888fa3d16a4fb4a2dea6aaafb35dc0ba605fd1fd"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"9bf3a5e39e71c112cff147d92042c2069db74699","unresolved":false,"context_lines":[{"line_number":7,"context_line":"set -o xtrace"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"export DEBIAN_FRONTEND\u003dnoninteractive"},{"line_number":10,"context_line":"apt-get -y install libmysqlclient18 mysql-client-5.5 mongodb"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"AAAATn%2F%2FyQ4%3D","line":10,"updated":"2013-10-29 05:03:18.000000000","message":"why would this image need mysql? seems like the point was not to have mysql.","commit_id":"888fa3d16a4fb4a2dea6aaafb35dc0ba605fd1fd"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"f2c4db29f921b7852d70ab081f045715378f778e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"set -o xtrace"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"export DEBIAN_FRONTEND\u003dnoninteractive"},{"line_number":10,"context_line":"apt-get -y install libmysqlclient18 mysql-client-5.5 mongodb"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"AAAATn%2F%2Bsbs%3D","line":10,"in_reply_to":"AAAATn%2F%2B0RM%3D","updated":"2013-11-21 13:02:36.000000000","message":"Good point","commit_id":"888fa3d16a4fb4a2dea6aaafb35dc0ba605fd1fd"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"e5ff392d48587fd33e49f204011a7a93a4ba6633","unresolved":false,"context_lines":[{"line_number":7,"context_line":"set -o xtrace"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"export DEBIAN_FRONTEND\u003dnoninteractive"},{"line_number":10,"context_line":"apt-get -y install libmysqlclient18 mysql-client-5.5 mongodb"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"AAAATn%2F%2B0RM%3D","line":10,"in_reply_to":"AAAATn%2F%2Fxr0%3D","updated":"2013-11-19 19:20:22.000000000","message":"it\u0027d be worthwhile to add a comment explaining this (because it will come up again). add the comment here as well: https://review.openstack.org/#/c/53378/5/scripts/files/elements/fedora-mongodb/install.d/10-mongodb","commit_id":"888fa3d16a4fb4a2dea6aaafb35dc0ba605fd1fd"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"1db3721bb035f5bb950528127cfcdb53729d4390","unresolved":false,"context_lines":[{"line_number":7,"context_line":"set -o xtrace"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"export DEBIAN_FRONTEND\u003dnoninteractive"},{"line_number":10,"context_line":"apt-get -y install libmysqlclient18 mysql-client-5.5 mongodb"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"AAAATn%2F%2Fxr0%3D","line":10,"in_reply_to":"AAAATn%2F%2FyQ4%3D","updated":"2013-10-29 08:10:37.000000000","message":"Before trove-conductor is ready, GA writes its state to Mysql. So client is necessary. Server is not installed.","commit_id":"888fa3d16a4fb4a2dea6aaafb35dc0ba605fd1fd"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"cd5e41c07b2dd63c216d58da6128bf197102afad","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"export DEBIAN_FRONTEND\u003dnoninteractive"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# Mysql client is needed by guestagent to store its state into Trove database even in MongoDB-only deployment"},{"line_number":12,"context_line":"apt-get -y install libmysqlclient18 mysql-client-5.5 mongodb"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"AAAATn%2F9uJY%3D","line":11,"updated":"2013-12-06 18:49:21.000000000","message":"and remove this comment.","commit_id":"a81282754e71946fbe16ee1499ce0d1cefad8dfe"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"ef19e3f7c61d2767c50fdbba2e939f4d383dfb04","unresolved":false,"context_lines":[{"line_number":9,"context_line":"export DEBIAN_FRONTEND\u003dnoninteractive"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# Mysql client is needed by guestagent to store its state into Trove database even in MongoDB-only deployment"},{"line_number":12,"context_line":"apt-get -y install libmysqlclient18 mysql-client-5.5 mongodb"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"AAAATn%2F9uM4%3D","line":12,"updated":"2013-12-06 18:36:28.000000000","message":"remove mysql as well.","commit_id":"a81282754e71946fbe16ee1499ce0d1cefad8dfe"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"201ceaa680399db8498c9234d6355af0167a43fb","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"export DEBIAN_FRONTEND\u003dnoninteractive"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"apt-get -y install mongodb"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"AAAAUH%2F%2BM3U%3D","line":11,"updated":"2014-01-29 04:51:51.000000000","message":"also needs:\n\n    rm -rf /var/lib/mongodb/\n\nto avoid having the guest assume a migration needs to take place, causing an infinite loop on:\n\n2014-01-29 04:22:02.623 DEBUG trove.openstack.common.processutils [req-90b52375-5841-450a-8896-b4fdb4a45f7c 1608984302624e548e8617d1c5983a19 7eec58dd037e488689a920d8ec07cbeb] Running cmd (subprocess): sudo rsync --safe-links --perms --recursive --owner --group --xattrs --sparse /var/lib/mongodb/ /mnt/volume from (pid\u003d1215) execute /home/stack/trove/trove/openstack/common/processutils.py:137\n\nbecause /var/lib/mongodb/ is empty.","commit_id":"9087386955fb837133ccf4ce6b447e2e90f8f56f"},{"author":{"_account_id":8136,"name":"Viswa Vutharkar","email":"vpvutharkar@ebaysf.com","username":"vvutharkar"},"change_message_id":"1841732951000c441f6a1040eca2bb21bbb9a181","unresolved":false,"context_lines":[{"line_number":7,"context_line":"set -o xtrace"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"export DEBIAN_FRONTEND\u003dnoninteractive"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"apt-get -y install mongodb"},{"line_number":12,"context_line":"rm -rf /var/lib/mongodb/"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"AAAAUH%2F9nTI%3D","line":10,"updated":"2014-02-05 17:01:17.000000000","message":"It would be better to not let apt-get get it\u0027s mongo package from ubuntu official package repo by default. Mongo\u0027s own package servers have the most latest stable releases. So it would be good to add mongo repos by adding the following lines\n\n apt-key adv --keyserver hkp://keyserver.ubuntu.com:80 --recv 7F0CEB10\n echo \u0027deb http://downloads-distro.mongodb.org/repo/ubuntu-upstart dist 10gen\u0027 | sudo tee /etc/apt/sources.list.d/mongodb.list\n apt-get update\n\nReference: http://docs.mongodb.org/manual/tutorial/install-mongodb-on-ubuntu/","commit_id":"f7a3485a7cfc724707b2cc3fb1541b2c99fbdf92"},{"author":{"_account_id":8136,"name":"Viswa Vutharkar","email":"vpvutharkar@ebaysf.com","username":"vvutharkar"},"change_message_id":"1841732951000c441f6a1040eca2bb21bbb9a181","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"export DEBIAN_FRONTEND\u003dnoninteractive"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"apt-get -y install mongodb"},{"line_number":12,"context_line":"rm -rf /var/lib/mongodb/"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"AAAAUH%2F9nQU%3D","line":11,"updated":"2014-02-05 17:01:17.000000000","message":"use the below  instead.\n\n apt-get -y install mongodb-10gen","commit_id":"f7a3485a7cfc724707b2cc3fb1541b2c99fbdf92"},{"author":{"_account_id":8136,"name":"Viswa Vutharkar","email":"vpvutharkar@ebaysf.com","username":"vvutharkar"},"change_message_id":"70a5be799cd5c80baf9c2b539fb9f47dfaa05b77","unresolved":false,"context_lines":[{"line_number":9,"context_line":"export DEBIAN_FRONTEND\u003dnoninteractive"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"apt-get -y install mongodb"},{"line_number":12,"context_line":"rm -rf /var/lib/mongodb/"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"AAAAUX%2F%2F%2BBg%3D","line":12,"updated":"2014-02-08 05:53:43.000000000","message":"I have done some reading around this \nhttps://github.com/openstack/diskimage-builder\n\ninstall.d elements run in \u0027chroot\u0027 mode on the Host machine itself where the image is being built (the redstack machine). It makes no sense to delete this dir at this stage because I have observed  one of the two things happen based on version of mongo\n\nmongo 2.0.4 \n\n------------------\n\nBy default the apt-get install step above installs mongo version 2.0.4\n\nThe install process also configures \u0027upstart\u0027/init.d scripts to startup mongod process automatically at boot time.\n\nGiven the above, when the image is provisioned and VM comes up, at boot time the mongodb process starts up, and not finding the /var/lib/mongodb/  dir,  it goes ahead and creates one again and populates it with sparse files (about 3GB total size)\n\nThe trove guest agent install (rsync) etc comes later, as part of the execution of first-boot.d  element. So when the manager comes up, it detects the presence of /var/lib/mongodb/ dir and triggers the \u0027migration\u0027 process anyway (mount the volume, move the files via rsync, remount /var/lib/mongodb on the volume etc). \n\nSo, not sure what exactly is accomplished by removing the directory at install.d  element stage \n\nmongo 2.4.9\n\n------------------\n\nI forced the installation of mongo 2.4.9 by adding couple more steps before the apt-get install  and including mongodb.org debian repos in the etc/apt/sources.list.d/\n\nThis install (of version 2.4.9) via the apt-get install also configures the  \u0027upstart\u0027/init.d scripts to startup mongod process automatically at boot time.\n\nGiven the above, when the image is provisioned and VM comes up, at boot time the mongodb process starts up. But possibly due to non resilient upstart scripts bundled with this version, the mongo version 2.4.9 fails to startup if the /var/lib/mongodb/ dir is not present.  So I tweaked the rm statement instead to \"rm -rf /var/lib/mongodb/* \" .  But that doesn\u0027t help either due to the remaining logic described in the 2.0.4 case (mongodb starts up and creates files in the dir, 3.5GB worth of data, and first-boot.d only comes later on, when guest agent starts and detects the dir presence and triggers migration).  \n\nWhat I also noticed is that the rsync triggered to migrate the data into the mounted volume took about 10 mins, but this might be environmental (cinder network speed) at our company.\n\nAnyway, So, not sure what exactly is accomplished by removing the directory at install.d  element stage \n\n\n\nProper solution\n\n----------------------\n\n\nThe proper solution is to tackle this removal of /var/lib/mongodb/*  contents in the guestagent manager::prepare() method.  Even there what is the need to do rsync at all, If that data is discardable (which is why you would consider rm -rf in the first place). Just delete the content, don\u0027t do rsync, and just mount the /var/lib/mongodb on the empty formatted volume. \n\nBut there could be a sensitive datastore that may put some critical data there without which it cannot start up. In that case you may want to migrate the data rather than delete it. That is one more reason why you want to tackle this in a datastore specific manager, at one time prepare() phase.\n\nMy assumption is that the prepare() method is ONLY called ONCE by the api to setup the datastore during creation. If that is not the case, then alternatively we should consider adding an element to tackle this in first-boot.d, right before starting trove-guest, and not in an install.d element.","commit_id":"15ed84ec3e0823bf8f7cff68afc07e385ce7299c"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"7fe3d18eaa5b09981844a8274342d54b2e9ab3c1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"export DEBIAN_FRONTEND\u003dnoninteractive"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"apt-get -y install mongodb"},{"line_number":12,"context_line":"rm -rf /var/lib/mongodb/"}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"AAAAVX%2F%2F9Lg%3D","line":12,"updated":"2014-02-27 06:20:11.000000000","message":"the \"rm -rf\" logic has been moved to the guest (see https://review.openstack.org/#/c/50597/61/trove/guestagent/datastore/mongodb/manager.py), please remove this line.","commit_id":"5760a8e4d806f10c507634e4a3682c6195599a9f"}],"scripts/redstack":[{"author":{"_account_id":8136,"name":"Viswa Vutharkar","email":"vpvutharkar@ebaysf.com","username":"vvutharkar"},"change_message_id":"9b1f11a6e242625ff223c0c4bc973c68ea1e26a4","unresolved":false,"context_lines":[{"line_number":367,"context_line":""},{"line_number":368,"context_line":"function cmd_set_datastore() {"},{"line_number":369,"context_line":"    IMAGEID\u003d$1"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    rd_manage datastore_update Test_Mysql mysql \"\""},{"line_number":372,"context_line":"    rd_manage datastore_version_update Test_Mysql \"mysql_test_version\" $IMAGEID \"mysql-server-5.5\" 1"},{"line_number":373,"context_line":"    rd_manage datastore_version_update Test_Mysql \"mysql_inactive_version\" $IMAGEID \"\" 0"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"AAAAUH%2F%2Fl%2Fw%3D","line":370,"updated":"2014-01-10 17:23:30.000000000","message":"You are passing only one IMAGE id to this function, but in the subsequent code below you are using rd_manage cmd to set this same  imageid value for mysql datastore type as well mongodb type !  So depending on what \"redstack kick-start \u003cmysql|mongodb\u003e ..\"  command was last run, that image will be set as the image-id for ALL the datastores ! Now that we are adding more datastore types, this function has to take an additional parameter to map image--\u003ecorrect datastore.","commit_id":"34fd727dd9e0623fb015ad1dddd944bca0061207"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"2e379521a5f339b6659d07b9ba7f711a45ed9477","unresolved":false,"context_lines":[{"line_number":367,"context_line":""},{"line_number":368,"context_line":"function cmd_set_datastore() {"},{"line_number":369,"context_line":"    IMAGEID\u003d$1"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    rd_manage datastore_update Test_Mysql mysql \"\""},{"line_number":372,"context_line":"    rd_manage datastore_version_update Test_Mysql \"mysql_test_version\" $IMAGEID \"mysql-server-5.5\" 1"},{"line_number":373,"context_line":"    rd_manage datastore_version_update Test_Mysql \"mysql_inactive_version\" $IMAGEID \"\" 0"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"AAAAUH%2F%2Fl44%3D","line":370,"in_reply_to":"AAAAUH%2F%2Fl%2Fw%3D","updated":"2014-01-10 17:41:00.000000000","message":"There\u0027s no need to pass more than one image id. Integration tests are working with ubuntu-cloudinit image and it fits to all possible datastore type/versions.\nThere\u0027s no need to build more than one image for testing. All possible datastore works fine with ubuntu. And mapping \"image --\u003e datastore\" sounds like time-killer idea. Please read documentation about how kick-start works.\nWith building only one image tests took 1h or above.","commit_id":"34fd727dd9e0623fb015ad1dddd944bca0061207"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"21ace520e399d7c4051a96712c6cafc1f48a2eaf","unresolved":false,"context_lines":[{"line_number":373,"context_line":"    rd_manage datastore_version_update Test_Mysql \"mysql_inactive_version\" $IMAGEID \"\" 0"},{"line_number":374,"context_line":"    rd_manage datastore_update Test_Mysql mysql \"mysql_test_version\""},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"    rd_manage datastore_update Test_Mongodb mongodb \"\""},{"line_number":377,"context_line":"    rd_manage datastore_version_update Test_Mongodb \"mongodb\" $IMAGEID \"mongodb\" 1"},{"line_number":378,"context_line":"    rd_manage datastore_version_update Test_Mongodb \"mongodb_inactive_version\" $IMAGEID \"\" 0"},{"line_number":379,"context_line":"    rd_manage datastore_update Test_Mongodb mongodb \"mongodb\""}],"source_content_type":"application/octet-stream","patch_set":9,"id":"AAAATn%2F9TE0%3D","line":376,"updated":"2013-12-12 22:09:05.000000000","message":"See my comment at https://review.openstack.org/#/c/57780/4/scripts/redstack (pertaining to the use of \"test\")","commit_id":"34fd727dd9e0623fb015ad1dddd944bca0061207"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"115318141cdf535553e1e173332b7bc26186dced","unresolved":false,"context_lines":[{"line_number":373,"context_line":"    rd_manage datastore_version_update Test_Mysql \"mysql_inactive_version\" $IMAGEID \"\" 0"},{"line_number":374,"context_line":"    rd_manage datastore_update Test_Mysql mysql \"mysql_test_version\""},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"    rd_manage datastore_update Test_Mongodb mongodb \"\""},{"line_number":377,"context_line":"    rd_manage datastore_version_update Test_Mongodb \"mongodb\" $IMAGEID \"mongodb\" 1"},{"line_number":378,"context_line":"    rd_manage datastore_version_update Test_Mongodb \"mongodb_inactive_version\" $IMAGEID \"\" 0"},{"line_number":379,"context_line":"    rd_manage datastore_update Test_Mongodb mongodb \"mongodb\""}],"source_content_type":"application/octet-stream","patch_set":9,"id":"AAAATn%2F9TCE%3D","line":376,"in_reply_to":"AAAATn%2F9TE0%3D","updated":"2013-12-12 22:15:48.000000000","message":"I agreed. This review is temporary suggestion, same with cassandra. It would be better to wait until Kevin\u0027s final review land.","commit_id":"34fd727dd9e0623fb015ad1dddd944bca0061207"},{"author":{"_account_id":8136,"name":"Viswa Vutharkar","email":"vpvutharkar@ebaysf.com","username":"vvutharkar"},"change_message_id":"88bdecbf75db4f66eff4e22cdb0cd014bf0ac15f","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        VERSION\u003d\"-5.5\""},{"line_number":291,"context_line":"    elif [ \"$DATASTORE_TYPE\" \u003d\u003d \"mongodb\" ]; then"},{"line_number":292,"context_line":"        PACKAGES\u003d${PACKAGES:-\"mongodb\"}"},{"line_number":293,"context_line":"        VERSION\u003d\"-mongo\""},{"line_number":294,"context_line":"    elif [ \"$DATASTORE_TYPE\" \u003d\u003d \"redis\" ]; then"},{"line_number":295,"context_line":"        PACKAGES\u003d${PACKAGES:-\"redis-server\"}"},{"line_number":296,"context_line":"        VERSION\u003d\"-2.8\""}],"source_content_type":"application/octet-stream","patch_set":14,"id":"AAAAUX%2F%2FnIQ%3D","line":293,"updated":"2014-02-12 01:09:31.000000000","message":"Can you please change this line to\n \nVERSION\u003d${VERSION:-\"-mongo\"}\n\nso that VERSION string can be provided/overridden by the environment if needed (eg: export VERSION\u003d\"-2.4.9\"; redstack kick-start mongodb)\n\nI have submitted a patch to fix this in the 3 other places where VERSION string appears within this function.  (See https://review.openstack.org/#/c/72804/ )","commit_id":"b0393696d453327eb0b6dad7944eadb12d3445c5"},{"author":{"_account_id":8136,"name":"Viswa Vutharkar","email":"vpvutharkar@ebaysf.com","username":"vvutharkar"},"change_message_id":"07642d1ebbafd95a10c746d12301504220c4fee3","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        VERSION\u003d\"-5.5\""},{"line_number":291,"context_line":"    elif [ \"$DATASTORE_TYPE\" \u003d\u003d \"mongodb\" ]; then"},{"line_number":292,"context_line":"        PACKAGES\u003d${PACKAGES:-\"mongodb\"}"},{"line_number":293,"context_line":"        VERSION\u003d\"-mongo\""},{"line_number":294,"context_line":"    elif [ \"$DATASTORE_TYPE\" \u003d\u003d \"redis\" ]; then"},{"line_number":295,"context_line":"        PACKAGES\u003d${PACKAGES:-\"redis-server\"}"},{"line_number":296,"context_line":"        VERSION\u003d\"-2.8\""}],"source_content_type":"application/octet-stream","patch_set":14,"id":"AAAAUX%2F%2FgpQ%3D","line":293,"in_reply_to":"AAAAUX%2F%2Fkpk%3D","updated":"2014-02-12 17:23:12.000000000","message":"Sounds good. I will take my -1 back.","commit_id":"b0393696d453327eb0b6dad7944eadb12d3445c5"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"a905b667fd734c683f26986524351029012e9a5c","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        VERSION\u003d\"-5.5\""},{"line_number":291,"context_line":"    elif [ \"$DATASTORE_TYPE\" \u003d\u003d \"mongodb\" ]; then"},{"line_number":292,"context_line":"        PACKAGES\u003d${PACKAGES:-\"mongodb\"}"},{"line_number":293,"context_line":"        VERSION\u003d\"-mongo\""},{"line_number":294,"context_line":"    elif [ \"$DATASTORE_TYPE\" \u003d\u003d \"redis\" ]; then"},{"line_number":295,"context_line":"        PACKAGES\u003d${PACKAGES:-\"redis-server\"}"},{"line_number":296,"context_line":"        VERSION\u003d\"-2.8\""}],"source_content_type":"application/octet-stream","patch_set":14,"id":"AAAAUX%2F%2Fkpk%3D","line":293,"in_reply_to":"AAAAUX%2F%2FnIQ%3D","updated":"2014-02-12 09:11:06.000000000","message":"viswa: this shouldn\u0027t be handled in this particular patch-set, because as you mentioned, if it should be done at all it should be done for all of them. after this merges, your add-on will be considered.","commit_id":"b0393696d453327eb0b6dad7944eadb12d3445c5"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"3d228c5f1690080a82205653243d7a8dc6eacb3c","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        VERSION\u003d\"-5.5\""},{"line_number":291,"context_line":"    elif [ \"$DATASTORE_TYPE\" \u003d\u003d \"mongodb\" ]; then"},{"line_number":292,"context_line":"        PACKAGES\u003d${PACKAGES:-\"mongodb\"}"},{"line_number":293,"context_line":"        VERSION\u003d\"-2.0.6\""},{"line_number":294,"context_line":"    elif [ \"$DATASTORE_TYPE\" \u003d\u003d \"redis\" ]; then"},{"line_number":295,"context_line":"        PACKAGES\u003d${PACKAGES:-\"redis-server\"}"},{"line_number":296,"context_line":"        VERSION\u003d\"-2.8\""}],"source_content_type":"application/octet-stream","patch_set":15,"id":"AAAAUX%2F%2FMYI%3D","line":293,"updated":"2014-02-15 00:20:54.000000000","message":"the latest distro package is 2.0.4, not 2.0.6","commit_id":"deb31846fdc16a2923c92ad2811cac123ad959bd"}]}