)]}'
{"scripts/redstack":[{"author":{"_account_id":6162,"name":"Dan Nguyen","email":"dan.nguyens.mail@gmail.com","username":"daniel-a-nguyen"},"change_message_id":"28e3fe3fa0e01572b43cc6b84ce35b4ced20b3f9","unresolved":false,"context_lines":[{"line_number":51,"context_line":"ESCAPED_PATH_TROVE\u003d`echo $PATH_TROVE | sed \u0027s/\\//\\\\\\\\\\//g\u0027`"},{"line_number":52,"context_line":"ESCAPED_REDSTACK_SCRIPTS\u003d`echo $REDSTACK_SCRIPTS | sed \u0027s/\\//\\\\\\\\\\//g\u0027`"},{"line_number":53,"context_line":"TROVE_AUTH_CACHE_DIR\u003d${TROVE_AUTH_CACHE_DIR:-/var/cache/trove}"},{"line_number":54,"context_line":"TROVE_LOGDIR\u003d${TROVE_LOGDIR:-$REDSTACK_SCRIPTS/../report/logs}"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"# Creates TROVE_LOGDIR if it does not exists"},{"line_number":57,"context_line":"if [ -d $TROVE_LOGDIR ]; then"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAUH%2F%2F6WI%3D","line":54,"updated":"2014-01-06 21:39:23.000000000","message":"Isn\u0027t this already creating a default here?","commit_id":"a150545831429b102fe2fd5b2ba41939a7392dee"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"f8aec920173cdf6dbacee1d471688f0e0d2b6d6c","unresolved":false,"context_lines":[{"line_number":51,"context_line":"ESCAPED_PATH_TROVE\u003d`echo $PATH_TROVE | sed \u0027s/\\//\\\\\\\\\\//g\u0027`"},{"line_number":52,"context_line":"ESCAPED_REDSTACK_SCRIPTS\u003d`echo $REDSTACK_SCRIPTS | sed \u0027s/\\//\\\\\\\\\\//g\u0027`"},{"line_number":53,"context_line":"TROVE_AUTH_CACHE_DIR\u003d${TROVE_AUTH_CACHE_DIR:-/var/cache/trove}"},{"line_number":54,"context_line":"TROVE_LOGDIR\u003d${TROVE_LOGDIR:-$REDSTACK_SCRIPTS/../report/logs}"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"# Creates TROVE_LOGDIR if it does not exists"},{"line_number":57,"context_line":"if [ -d $TROVE_LOGDIR ]; then"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAUH%2F%2F4T4%3D","line":54,"in_reply_to":"AAAAUH%2F%2F6WI%3D","updated":"2014-01-07 09:48:40.000000000","message":"it is not creating, it is just assigning the value to export variable.","commit_id":"a150545831429b102fe2fd5b2ba41939a7392dee"},{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"change_message_id":"c7f42615ebe76fbe58b9cf32bfef4a9e6bf71cdb","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"# Creates TROVE_LOGDIR if it does not exists"},{"line_number":57,"context_line":"if [ -d $TROVE_LOGDIR ]; then"},{"line_number":58,"context_line":"    mkdir -p $TROVE_LOGDIR"},{"line_number":59,"context_line":"fi"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"# Load functions devstack style"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAUH%2F%2FqhE%3D","line":58,"updated":"2014-01-09 22:26:38.000000000","message":"This should be done below the override config values in env.rc line 66-68","commit_id":"a150545831429b102fe2fd5b2ba41939a7392dee"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"2f2f29cc232643d75efd686d3eac28fbffda29ba","unresolved":false,"context_lines":[{"line_number":63,"context_line":"fi"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"# Creates TROVE_LOGDIR if it does not exists"},{"line_number":66,"context_line":"if [ -d $TROVE_LOGDIR ]; then"},{"line_number":67,"context_line":"    mkdir -p $TROVE_LOGDIR"},{"line_number":68,"context_line":"fi"},{"line_number":69,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAUH%2F%2FoiA%3D","line":66,"updated":"2014-01-10 09:25:47.000000000","message":"should be \"! -d\", not \"-d\"; you\u0027re wanting to check if it does *not* exist.","commit_id":"9025a1fe4327ed36fb8eaf057916094b12be7167"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"b2ff5681ed193f429c1686f38c660ff30b33a172","unresolved":false,"context_lines":[{"line_number":63,"context_line":"fi"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"# Creates TROVE_LOGDIR if it does not exist"},{"line_number":66,"context_line":"if [ ! -d $TROVE_LOGDIR ]; then"},{"line_number":67,"context_line":"    mkdir -p $TROVE_LOGDIR"},{"line_number":68,"context_line":"fi"},{"line_number":69,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":6,"id":"AAAAUH%2F%2Ff3w%3D","line":66,"updated":"2014-01-13 10:03:10.000000000","message":"You don\u0027t need the check here.\n\nSince you\u0027re using -p,  \"mkdir -p $TROVE_LOGDIR\" will suffice.","commit_id":"bdd7c3bc51938d69f6b2669f79ba61cc80839825"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"9b913f18561d811f86b411bb4e7f9b60665a9daa","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"# Creates TROVE_LOGDIR if it does not exist"},{"line_number":66,"context_line":"mkdir -p $TROVE_LOGDIR"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"###############################################################################"},{"line_number":70,"context_line":"# Utility functions"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"AAAAUH%2F%2FHRU%3D","line":67,"updated":"2014-01-17 10:14:08.000000000","message":"We probably don\u0027t need to run this every time the redstack script is called (say for example on ./redstack rd-client).\n\nCan we move this to a more appropriate location? (Perhaps some time during ./redstack install)?","commit_id":"c97260b7bf72b5169f2bb0cc4800c3d7d044bbc4"}]}