)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"7ccef6f810c0a641f48a634556798b5ce15eed39","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Changes: Included a new group GROUP_HEAT"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib0ee3d29be69478f0a29765eb4cf688d14c309c3"},{"line_number":13,"context_line":"Implements: https://blueprints.launchpad.net/trove/+spec/test-heat-based-instance-workflow"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2FY2c%3D","line":13,"updated":"2014-01-14 10:25:57.000000000","message":"You don\u0027t need the full bp url; just the name is sufficient.\n(i.e. Implements bp: test-heat-based-instance-workflow)","commit_id":"5dec464dec22af409fadd96e2bb44bf4bfb177b1"},{"author":{"_account_id":9122,"name":"Shalini khandelwal","email":"shalini.khandelwal@globallogic.com","username":"shalini"},"change_message_id":"07b4fbdceee625deaad096cddafec5f19082dcfc","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Changes: Included a new group GROUP_HEAT"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib0ee3d29be69478f0a29765eb4cf688d14c309c3"},{"line_number":13,"context_line":"Implements: https://blueprints.launchpad.net/trove/+spec/test-heat-based-instance-workflow"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2FUWw%3D","line":13,"in_reply_to":"AAAAUH%2F%2FY2c%3D","updated":"2014-01-15 04:27:36.000000000","message":"Okay, point taken","commit_id":"5dec464dec22af409fadd96e2bb44bf4bfb177b1"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"66d2414de1d9cf52253147e0f2def25241f3544a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Changes: Included a new group GROUP_HEAT"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib0ee3d29be69478f0a29765eb4cf688d14c309c3"},{"line_number":13,"context_line":"Implements bp: test-heat-based-instance-workflow"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAAUH%2F%2FGw8%3D","line":13,"updated":"2014-01-17 11:44:53.000000000","message":"Implements: blueprint test-heat-based-instance-workflow","commit_id":"ff088048438a7f6277cb4b5addb13aefe88b17d1"}],"scripts/conf/test_begin.conf":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"ac210629d163a737a62719fc2721dd42ed0142d6","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    \"trove_code_root\":\"%trove_path%\","},{"line_number":40,"context_line":"    \"trove_conf\":\"/tmp/trove.conf\","},{"line_number":41,"context_line":"    \"trove_conf_dir\":\"/etc/trove/\","},{"line_number":42,"context_line":"    \"trove_version\":\"v1.0\","},{"line_number":43,"context_line":"    \"trove_api_updated\":\"2012-08-01T00:00:00Z\","},{"line_number":44,"context_line":"    \"trove_volume_support\":true,"},{"line_number":45,"context_line":"    \"trove_max_accepted_volume_size\": 1000,"}],"source_content_type":"text/plain","patch_set":4,"id":"AAAAUH%2F%2FNg4%3D","line":42,"updated":"2014-01-16 10:39:01.000000000","message":"should be retrived from operation system env","commit_id":"2d7368daa6334d524273314517f05bd66a779aaf"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"6cddf24287a868c5073df87d268de47eedf9e883","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    \"trove_code_root\":\"%trove_path%\","},{"line_number":40,"context_line":"    \"trove_conf\":\"/tmp/trove.conf\","},{"line_number":41,"context_line":"    \"trove_conf_dir\":\"/etc/trove/\","},{"line_number":42,"context_line":"    \"trove_version\":\"v1.0\","},{"line_number":43,"context_line":"    \"trove_api_updated\":\"2012-08-01T00:00:00Z\","},{"line_number":44,"context_line":"    \"trove_volume_support\":true,"},{"line_number":45,"context_line":"    \"trove_max_accepted_volume_size\": 1000,"}],"source_content_type":"text/plain","patch_set":4,"id":"AAAAUH%2F%2FNNo%3D","line":42,"in_reply_to":"AAAAUH%2F%2FNYI%3D","updated":"2014-01-16 11:51:15.000000000","message":"it is a constant, but it should be retrieved from OS ENV, please take a look how TROVE_CONF_DIR var is initialized in trove integration.","commit_id":"2d7368daa6334d524273314517f05bd66a779aaf"},{"author":{"_account_id":9122,"name":"Shalini khandelwal","email":"shalini.khandelwal@globallogic.com","username":"shalini"},"change_message_id":"0351f66abf649b3efd3b6e233eb6bf504fb2913d","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    \"trove_code_root\":\"%trove_path%\","},{"line_number":40,"context_line":"    \"trove_conf\":\"/tmp/trove.conf\","},{"line_number":41,"context_line":"    \"trove_conf_dir\":\"/etc/trove/\","},{"line_number":42,"context_line":"    \"trove_version\":\"v1.0\","},{"line_number":43,"context_line":"    \"trove_api_updated\":\"2012-08-01T00:00:00Z\","},{"line_number":44,"context_line":"    \"trove_volume_support\":true,"},{"line_number":45,"context_line":"    \"trove_max_accepted_volume_size\": 1000,"}],"source_content_type":"text/plain","patch_set":4,"id":"AAAAUH%2F%2FNYI%3D","line":42,"in_reply_to":"AAAAUH%2F%2FNg4%3D","updated":"2014-01-16 11:04:59.000000000","message":"Trove Conf Dir is a constant, to use it in int-tests it can be written here, so that it can be used anywhere. To get it from env we need to export it.","commit_id":"2d7368daa6334d524273314517f05bd66a779aaf"}],"scripts/redstack":[{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"7ccef6f810c0a641f48a634556798b5ce15eed39","unresolved":false,"context_lines":[{"line_number":612,"context_line":"    heat_url\u003d`keystone --os-auth-url\u003d$TROVE_AUTH_ENDPOINT --os-username\u003dradmin --os-password\u003dradmin\\"},{"line_number":613,"context_line":"              --os-tenant-name\u003dtrove endpoint-get --service orchestration |\\"},{"line_number":614,"context_line":"              grep \u0027http\u0027 | cut -d\u0027|\u0027 -f3 | cut -d/ -f1-4`"},{"line_number":615,"context_line":"    export HEAT_URL\u003d$heat_url"},{"line_number":616,"context_line":"    if [ $# -lt 1 ]; then"},{"line_number":617,"context_line":"        args\u003d\"--group\u003dblackbox\""},{"line_number":618,"context_line":"    else"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAUH%2F%2FY1M%3D","line":615,"updated":"2014-01-14 10:25:57.000000000","message":"Let\u0027s not have redstack communicate to the tests through ENV variables. If you absolutely must pass information to the tests, please use the test.conf.","commit_id":"5dec464dec22af409fadd96e2bb44bf4bfb177b1"},{"author":{"_account_id":9122,"name":"Shalini khandelwal","email":"shalini.khandelwal@globallogic.com","username":"shalini"},"change_message_id":"07b4fbdceee625deaad096cddafec5f19082dcfc","unresolved":false,"context_lines":[{"line_number":612,"context_line":"    heat_url\u003d`keystone --os-auth-url\u003d$TROVE_AUTH_ENDPOINT --os-username\u003dradmin --os-password\u003dradmin\\"},{"line_number":613,"context_line":"              --os-tenant-name\u003dtrove endpoint-get --service orchestration |\\"},{"line_number":614,"context_line":"              grep \u0027http\u0027 | cut -d\u0027|\u0027 -f3 | cut -d/ -f1-4`"},{"line_number":615,"context_line":"    export HEAT_URL\u003d$heat_url"},{"line_number":616,"context_line":"    if [ $# -lt 1 ]; then"},{"line_number":617,"context_line":"        args\u003d\"--group\u003dblackbox\""},{"line_number":618,"context_line":"    else"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAUH%2F%2FUWo%3D","line":615,"in_reply_to":"AAAAUH%2F%2FY1M%3D","updated":"2014-01-15 04:27:36.000000000","message":"Using test.conf or ENV variable, modifications will be done in redstack only.\nThen, why cant we use ENV variable ?","commit_id":"5dec464dec22af409fadd96e2bb44bf4bfb177b1"}],"tests/integration/int_tests.py":[{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"7ccef6f810c0a641f48a634556798b5ce15eed39","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            instances.GROUP_STOP,"},{"line_number":180,"context_line":"            versions.GROUP,"},{"line_number":181,"context_line":"            \"dbaas.guest.start.test\","},{"line_number":182,"context_line":"            instances.GROUP_HEAT"},{"line_number":183,"context_line":"            ]"},{"line_number":184,"context_line":"        proboscis.register(groups\u003d[\"blackbox\"],"},{"line_number":185,"context_line":"                           depends_on_groups\u003dblack_box_groups)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FY08%3D","line":182,"updated":"2014-01-14 10:25:57.000000000","message":"This is not defined.","commit_id":"5dec464dec22af409fadd96e2bb44bf4bfb177b1"},{"author":{"_account_id":9122,"name":"Shalini khandelwal","email":"shalini.khandelwal@globallogic.com","username":"shalini"},"change_message_id":"f4c776017dc7b9fb07e60e4c8bf6caaeb3577c8c","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            instances.GROUP_STOP,"},{"line_number":180,"context_line":"            versions.GROUP,"},{"line_number":181,"context_line":"            \"dbaas.guest.start.test\","},{"line_number":182,"context_line":"            instances.GROUP_HEAT"},{"line_number":183,"context_line":"            ]"},{"line_number":184,"context_line":"        proboscis.register(groups\u003d[\"blackbox\"],"},{"line_number":185,"context_line":"                           depends_on_groups\u003dblack_box_groups)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FYns%3D","line":182,"in_reply_to":"AAAAUH%2F%2FY08%3D","updated":"2014-01-14 11:53:36.000000000","message":"GROUP_HEAT is defined in the following check-in :\nhttps://review.openstack.org/#/c/66499/","commit_id":"5dec464dec22af409fadd96e2bb44bf4bfb177b1"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"d5c24da788277b94af0e31f60ad03bf4b9b4d107","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            instances.GROUP_STOP,"},{"line_number":180,"context_line":"            versions.GROUP,"},{"line_number":181,"context_line":"            \"dbaas.guest.start.test\","},{"line_number":182,"context_line":"            instances.GROUP_HEAT"},{"line_number":183,"context_line":"            ]"},{"line_number":184,"context_line":"        proboscis.register(groups\u003d[\"blackbox\"],"},{"line_number":185,"context_line":"                           depends_on_groups\u003dblack_box_groups)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FXBk%3D","line":182,"in_reply_to":"AAAAUH%2F%2FYns%3D","updated":"2014-01-14 17:04:43.000000000","message":"Okay, thanks for response. Can you address the other two comments as well?","commit_id":"5dec464dec22af409fadd96e2bb44bf4bfb177b1"}]}