)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"a296c59ea2c70ecabbd8812c2639e7fec5e492ea","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- Cleaned up client wrappers to OS services which were also using"},{"line_number":13,"context_line":"  hardcoded paths in their connection URLs"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I2a284a476dc325c704d2517616b723ac964420d3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAUX%2F%2Fvcg%3D","line":14,"updated":"2014-02-11 06:02:39.000000000","message":"no blueprint, no bug.","commit_id":"84b0ffc69aa52bbd36776277ee9f49c360a45359"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"fba3675a95fe81c072269563f014cc81d8554eb1","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- Cleaned up client wrappers to OS services which were also using"},{"line_number":13,"context_line":"  hardcoded paths in their connection URLs"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I2a284a476dc325c704d2517616b723ac964420d3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAUX%2F%2FoPk%3D","line":14,"in_reply_to":"AAAAUX%2F%2Fvcg%3D","updated":"2014-02-11 21:47:42.000000000","message":"I don\u0027t think we have a requirement to have a bp / bugs for every trove-integration change, although I could be wrong.","commit_id":"84b0ffc69aa52bbd36776277ee9f49c360a45359"}],"scripts/redstack":[{"author":{"_account_id":9749,"name":"Greg Lucas","email":"greg@glucas.net","username":"glucas"},"change_message_id":"ceecb24cdc598ac74db1c359b08f93dbb2b9df88","unresolved":false,"context_lines":[{"line_number":38,"context_line":"# Public facing bits"},{"line_number":39,"context_line":"SERVICE_PROTOCOL\u003d${SERVICE_PROTOCOL:-http}"},{"line_number":40,"context_line":"SERVICE_TENANT\u003d${SERVICE_TENANT:-service}"},{"line_number":41,"context_line":"NETWORK_GATEWAY\u003d${NETWORK_GATEWAY:-$SERVICE_HOST}"},{"line_number":42,"context_line":"NETWORK_INTERFACE\u003d${NETWORK_INTERFACE:-eth0}"},{"line_number":43,"context_line":"NETWORK_SUBNET\u003d${NETWORK_SUBNET:-10.0.0.0/24}"},{"line_number":44,"context_line":"KEYSTONE_AUTH_HOST\u003d${KEYSTONE_AUTH_HOST:-$SERVICE_HOST}"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"AAAAWH%2F%2Fy2M%3D","line":41,"updated":"2014-03-13 19:23:56.000000000","message":"NETWORK_GATEWAY is independent of SERVICE_HOST?","commit_id":"d111d30ac0d9bce3cdd98ee6a93a9d8147df166d"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"07622e4011d86c9d4a5ff93feda405fbbc7a9284","unresolved":false,"context_lines":[{"line_number":38,"context_line":"# Public facing bits"},{"line_number":39,"context_line":"SERVICE_PROTOCOL\u003d${SERVICE_PROTOCOL:-http}"},{"line_number":40,"context_line":"SERVICE_TENANT\u003d${SERVICE_TENANT:-service}"},{"line_number":41,"context_line":"NETWORK_GATEWAY\u003d${NETWORK_GATEWAY:-$SERVICE_HOST}"},{"line_number":42,"context_line":"NETWORK_INTERFACE\u003d${NETWORK_INTERFACE:-eth0}"},{"line_number":43,"context_line":"NETWORK_SUBNET\u003d${NETWORK_SUBNET:-10.0.0.0/24}"},{"line_number":44,"context_line":"KEYSTONE_AUTH_HOST\u003d${KEYSTONE_AUTH_HOST:-$SERVICE_HOST}"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"AAAAXH%2F%2F2oo%3D","line":41,"in_reply_to":"AAAAWH%2F%2Fy2M%3D","updated":"2014-04-16 23:15:01.000000000","message":"Thanks for your comment, Greg.\n\nYes, you can have a NETWORK_GATEWAY that\u0027s different from SERVICE_HOST if you have a multi-host devstack install. In that case you need to explicitly ensure that the NETWORK_GATEWAY environment variable is set, and it will not be overidden.\n\nThis line here only changes the default in the case that NETWORK_GATEWAY hasn\u0027t been explicitly set. In that case, (since it is likely that it\u0027s a single host devstack install) we want to use the actual IP of the SERVICE_HOST, instead of the hardcoded 10.0.0.1 IP that we were using earlier.\n\nHope that clarifies things.","commit_id":"d111d30ac0d9bce3cdd98ee6a93a9d8147df166d"}],"scripts/redstack.rc":[{"author":{"_account_id":9749,"name":"Greg Lucas","email":"greg@glucas.net","username":"glucas"},"change_message_id":"ceecb24cdc598ac74db1c359b08f93dbb2b9df88","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Paths inside the VM."},{"line_number":2,"context_line":"[ -z $SERVICE_HOST ] \u0026\u0026 SERVICE_HOST\u003d`get_default_host_ip`"},{"line_number":3,"context_line":"[ -z $DEST ] \u0026\u0026 DEST\u003d/opt/stack"},{"line_number":4,"context_line":"[ -z $NETWORK_GATEWAY ] \u0026\u0026 NETWORK_GATEWAY\u003d$SERVICE_HOST"},{"line_number":5,"context_line":"[ -z $PATH_DEVSTACK_SRC ] \u0026\u0026 PATH_DEVSTACK_SRC\u003d~/devstack"},{"line_number":6,"context_line":"[ -z $TROVE_CONF_DIR ] \u0026\u0026 TROVE_CONF_DIR\u003d/etc/trove"},{"line_number":7,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":8,"id":"AAAAWH%2F%2Fy14%3D","line":4,"updated":"2014-03-13 19:23:56.000000000","message":"NETWORK_GATEWAY is independent of SERVICE_HOST?","commit_id":"d111d30ac0d9bce3cdd98ee6a93a9d8147df166d"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"07622e4011d86c9d4a5ff93feda405fbbc7a9284","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Paths inside the VM."},{"line_number":2,"context_line":"[ -z $SERVICE_HOST ] \u0026\u0026 SERVICE_HOST\u003d`get_default_host_ip`"},{"line_number":3,"context_line":"[ -z $DEST ] \u0026\u0026 DEST\u003d/opt/stack"},{"line_number":4,"context_line":"[ -z $NETWORK_GATEWAY ] \u0026\u0026 NETWORK_GATEWAY\u003d$SERVICE_HOST"},{"line_number":5,"context_line":"[ -z $PATH_DEVSTACK_SRC ] \u0026\u0026 PATH_DEVSTACK_SRC\u003d~/devstack"},{"line_number":6,"context_line":"[ -z $TROVE_CONF_DIR ] \u0026\u0026 TROVE_CONF_DIR\u003d/etc/trove"},{"line_number":7,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":8,"id":"AAAAXH%2F%2F2ok%3D","line":4,"in_reply_to":"AAAAWH%2F%2Fy14%3D","updated":"2014-04-16 23:15:01.000000000","message":"Thanks for your comment, Greg.\n\nYes, you can have a NETWORK_GATEWAY that\u0027s different from SERVICE_HOST if you have a multi-host devstack install. In that case you need to explicitly ensure that the NETWORK_GATEWAY environment variable is set, and it will not be overidden.\n\nThis line here only changes the default in the case that NETWORK_GATEWAY hasn\u0027t been explicitly set. In that case, (since it is likely that it\u0027s a single host devstack install) we want to use the actual IP of the SERVICE_HOST, instead of the hardcoded 10.0.0.1 IP that we were using earlier.\n\nHope that clarifies things.","commit_id":"d111d30ac0d9bce3cdd98ee6a93a9d8147df166d"},{"author":{"_account_id":9749,"name":"Greg Lucas","email":"greg@glucas.net","username":"glucas"},"change_message_id":"65bbdfedf2d735c3f8da078d3cc53e916556a57c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Paths inside the VM."},{"line_number":2,"context_line":"[ -z $SERVICE_HOST ] \u0026\u0026 SERVICE_HOST\u003d`get_default_host_ip`"},{"line_number":3,"context_line":"[ -z $DEST ] \u0026\u0026 DEST\u003d/opt/stack"},{"line_number":4,"context_line":"[ -z $NETWORK_GATEWAY ] \u0026\u0026 NETWORK_GATEWAY\u003d$SERVICE_HOST"},{"line_number":5,"context_line":"[ -z $PATH_DEVSTACK_SRC ] \u0026\u0026 PATH_DEVSTACK_SRC\u003d~/devstack"},{"line_number":6,"context_line":"[ -z $TROVE_CONF_DIR ] \u0026\u0026 TROVE_CONF_DIR\u003d/etc/trove"},{"line_number":7,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":8,"id":"AAAAXH%2F%2Fx0s%3D","line":4,"in_reply_to":"AAAAXH%2F%2F2ok%3D","updated":"2014-04-17 14:27:23.000000000","message":"Thanks Nikhil. I still have a question though: I was thinking the NETWORK_GATEWAY for a guest VM would be derived based on the network configuration -- specifically, the reason that 10.0.0.1 was being used here is that the default FIXED_RANGE is 10.0.0.0/24. That would be independent of the SERVICE_HOST.","commit_id":"d111d30ac0d9bce3cdd98ee6a93a9d8147df166d"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"01bce5df2b661ae2187c419a264c7eb5b888c59c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Paths inside the VM."},{"line_number":2,"context_line":"[ -z $SERVICE_HOST ] \u0026\u0026 SERVICE_HOST\u003d`get_default_host_ip`"},{"line_number":3,"context_line":"[ -z $DEST ] \u0026\u0026 DEST\u003d/opt/stack"},{"line_number":4,"context_line":"[ -z $NETWORK_GATEWAY ] \u0026\u0026 NETWORK_GATEWAY\u003d$SERVICE_HOST"},{"line_number":5,"context_line":"[ -z $PATH_DEVSTACK_SRC ] \u0026\u0026 PATH_DEVSTACK_SRC\u003d~/devstack"},{"line_number":6,"context_line":"[ -z $TROVE_CONF_DIR ] \u0026\u0026 TROVE_CONF_DIR\u003d/etc/trove"},{"line_number":7,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":8,"id":"AAAAXH%2F%2FuG8%3D","line":4,"in_reply_to":"AAAAXH%2F%2Fx0s%3D","updated":"2014-04-17 22:54:52.000000000","message":"The problem is that when the FIXED_RANGE isn\u0027t 10.0.0.0/24, we still end up using the 10.0.0.1 here which ends up making the trove host non-routable from the guest. \n\nTo clarify, the NETWORK_GATEWAY param (which is somewhat badly named and is probably causing confusion) is a trove-integration construct that describes what hostname / IP the trove-guest should use to reach the host from which to rsync the guestagent code. A more appropriate name for it would probably have been TROVE_HOST or something similar. It\u0027s not really a network gateway in the true sense of the word.","commit_id":"d111d30ac0d9bce3cdd98ee6a93a9d8147df166d"}]}