)]}'
{"scripts/localrc.rc":[{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"2f71865d8c3d92769a20be9ffbd6252e36d9afbb","unresolved":false,"context_lines":[{"line_number":16,"context_line":"ENABLED_SERVICES+\u003d,-n-novnc,-n-xvnc"},{"line_number":17,"context_line":"if [[ $ENABLE_NEUTRON \u003d true ]]; then"},{"line_number":18,"context_line":"    echo ENABLED_SERVICES+\u003d,neutron,q-svc,q-agt,q-dhcp,q-l3,q-meta"},{"line_number":19,"context_line":"    echo disable_service n-net"},{"line_number":20,"context_line":"fi"},{"line_number":21,"context_line":"NOVNC_FROM_PACKAGE\u003dfalse"},{"line_number":22,"context_line":"SWIFT_HASH\u003d$SWIFT_HASH"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"AAAAVn%2F%2FbBw%3D","line":19,"updated":"2014-03-06 06:30:05.000000000","message":"The echo should be removed","commit_id":"6fd8f66589cf46dc7a0271ad0243e4ee628f95b0"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"cd017e572f2e39bbb57915b79b28e3ad701bf8c4","unresolved":false,"context_lines":[{"line_number":16,"context_line":"ENABLED_SERVICES+\u003d,-n-novnc,-n-xvnc"},{"line_number":17,"context_line":"if [[ $ENABLE_NEUTRON \u003d true ]]; then"},{"line_number":18,"context_line":"    echo ENABLED_SERVICES+\u003d,neutron,q-svc,q-agt,q-dhcp,q-l3,q-meta"},{"line_number":19,"context_line":"    echo disable_service n-net"},{"line_number":20,"context_line":"fi"},{"line_number":21,"context_line":"NOVNC_FROM_PACKAGE\u003dfalse"},{"line_number":22,"context_line":"SWIFT_HASH\u003d$SWIFT_HASH"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"AAAAVn%2F%2FaUk%3D","line":19,"in_reply_to":"AAAAVn%2F%2FbBw%3D","updated":"2014-03-06 08:46:16.000000000","message":"Done. \nYeah, blame it on the copy pasta. :)","commit_id":"6fd8f66589cf46dc7a0271ad0243e4ee628f95b0"}],"scripts/redstack":[{"author":{"_account_id":6156,"name":"Justin Hopper","email":"justin.hopper@hp.com","username":"justin-hopper"},"change_message_id":"5943b8a11e97e2dcdf5353a0c2689e84a8f6c527","unresolved":false,"context_lines":[{"line_number":390,"context_line":""},{"line_number":391,"context_line":"function mod_confs() {"},{"line_number":392,"context_line":"    cp $REDSTACK_SCRIPTS/conf/test_begin.conf $TROVE_CONF_DIR/test.conf"},{"line_number":393,"context_line":"    Trove_REPORT_DIR\u003d$REDSTACK_SCRIPTS/../report/"},{"line_number":394,"context_line":"    EXTRA_CONF\u003d$REDSTACK_SCRIPTS/conf/test.extra.conf"},{"line_number":395,"context_line":"    if [ -e $EXTRA_CONF ]; then"},{"line_number":396,"context_line":"        cat $EXTRA_CONF \u003e\u003e $TROVE_CONF_DIR/test.conf"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAVn%2F%2FfJU%3D","line":393,"updated":"2014-03-05 19:58:32.000000000","message":"Was this intentional?  Seems like the error in the gate is surrounding the report directory.","commit_id":"dfdcebeb3c3aab8864c0e28e3fde2f4462c9b700"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"42a322294a7a8a2596ab6188147b281d64bf3f24","unresolved":false,"context_lines":[{"line_number":390,"context_line":""},{"line_number":391,"context_line":"function mod_confs() {"},{"line_number":392,"context_line":"    cp $REDSTACK_SCRIPTS/conf/test_begin.conf $TROVE_CONF_DIR/test.conf"},{"line_number":393,"context_line":"    Trove_REPORT_DIR\u003d$REDSTACK_SCRIPTS/../report/"},{"line_number":394,"context_line":"    EXTRA_CONF\u003d$REDSTACK_SCRIPTS/conf/test.extra.conf"},{"line_number":395,"context_line":"    if [ -e $EXTRA_CONF ]; then"},{"line_number":396,"context_line":"        cat $EXTRA_CONF \u003e\u003e $TROVE_CONF_DIR/test.conf"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAVn%2F%2FaVE%3D","line":393,"in_reply_to":"AAAAVn%2F%2FfJU%3D","updated":"2014-03-06 08:44:16.000000000","message":"Nah, it was inadvertent.\nFixed now.","commit_id":"dfdcebeb3c3aab8864c0e28e3fde2f4462c9b700"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"9473a69342c1d2194da0bc17fec0f0376758a7b0","unresolved":false,"context_lines":[{"line_number":450,"context_line":""},{"line_number":451,"context_line":"function fix_network_connectivity(){"},{"line_number":452,"context_line":"    exclaim \"Configuring IPTables for PostRouting through $NETWORK_INTERFACE.\""},{"line_number":453,"context_line":"    sudo iptables -t nat -A POSTROUTING -o $NETWORK_INTERFACE -j MASQUERADE"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"    if [[ $ENABLE_NEUTRON \u003d true ]]; then"},{"line_number":456,"context_line":"        source $PATH_DEVSTACK_SRC/openrc admin admin"}],"source_content_type":"application/octet-stream","patch_set":16,"id":"AAAAXX%2F%2F1lU%3D","line":453,"updated":"2014-04-25 21:27:12.000000000","message":"hmm if we are doing this here then we can remove it from the list of commands.","commit_id":"8d7a4ed1c17f36f1985bdc285b8fb344365de9a0"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"6003a6f98b8cdd14f1ad0d358f53bc3137c3e125","unresolved":false,"context_lines":[{"line_number":450,"context_line":""},{"line_number":451,"context_line":"function fix_network_connectivity(){"},{"line_number":452,"context_line":"    exclaim \"Configuring IPTables for PostRouting through $NETWORK_INTERFACE.\""},{"line_number":453,"context_line":"    sudo iptables -t nat -A POSTROUTING -o $NETWORK_INTERFACE -j MASQUERADE"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"    if [[ $ENABLE_NEUTRON \u003d true ]]; then"},{"line_number":456,"context_line":"        source $PATH_DEVSTACK_SRC/openrc admin admin"}],"source_content_type":"application/octet-stream","patch_set":16,"id":"9ad9bd40_c1d02256","line":453,"in_reply_to":"AAAAXX%2F%2F1lU%3D","updated":"2014-05-01 09:47:09.000000000","message":"This might not be needed after juice\u0027s latest change; will update the patchset.","commit_id":"8d7a4ed1c17f36f1985bdc285b8fb344365de9a0"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"db978147976d3ab01cbbed8021514fe80f06dd6c","unresolved":false,"context_lines":[{"line_number":418,"context_line":"    # If neutron is enabled, we create a shared network and write this info to the"},{"line_number":419,"context_line":"    # confs so that the integration tests can use it."},{"line_number":420,"context_line":"    if [[ $ENABLE_NEUTRON \u003d true ]]; then"},{"line_number":421,"context_line":"        customer_network_id\u003d$(neutron net-list | grep customer | awk {\u0027print $2\u0027})"},{"line_number":422,"context_line":"        if [[ -z \"$customer_network_id\" ]]; then"},{"line_number":423,"context_line":"            customer_network_id\u003d$(neutron net-create customer | grep \u0027 id \u0027| awk {\u0027print $4\u0027})"},{"line_number":424,"context_line":"            customer_subnet_id\u003d$(neutron subnet-create customer 10.0.1.0/24 | grep \u0027 id \u0027| awk {\u0027print $4\u0027})"}],"source_content_type":"application/octet-stream","patch_set":20,"id":"7adec928_6f9aebc6","line":421,"updated":"2014-05-21 04:10:39.000000000","message":"`input | grep | awk` is kind of redundant. (awk is a powerful command)\n\ntry this:\n\n    customer_network_id\u003d$(neutron net-list | awk \u0027/customer/ {print $2}/\u0027)\n\nnet same results and likewise for the lines below.","commit_id":"287258b5939cb8b05a096b254eeff8b92e88e4eb"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"a6371c09fd9af705e5ae021fd6f1f88cc764ad08","unresolved":false,"context_lines":[{"line_number":418,"context_line":"    # If neutron is enabled, we create a shared network and write this info to the"},{"line_number":419,"context_line":"    # confs so that the integration tests can use it."},{"line_number":420,"context_line":"    if [[ $ENABLE_NEUTRON \u003d true ]]; then"},{"line_number":421,"context_line":"        customer_network_id\u003d$(neutron net-list | grep customer | awk {\u0027print $2\u0027})"},{"line_number":422,"context_line":"        if [[ -z \"$customer_network_id\" ]]; then"},{"line_number":423,"context_line":"            customer_network_id\u003d$(neutron net-create customer | grep \u0027 id \u0027| awk {\u0027print $4\u0027})"},{"line_number":424,"context_line":"            customer_subnet_id\u003d$(neutron subnet-create customer 10.0.1.0/24 | grep \u0027 id \u0027| awk {\u0027print $4\u0027})"}],"source_content_type":"application/octet-stream","patch_set":20,"id":"7adec928_93a9077e","line":421,"in_reply_to":"7adec928_6f9aebc6","updated":"2014-05-21 21:56:12.000000000","message":"Good point, will fix. Thanks!","commit_id":"287258b5939cb8b05a096b254eeff8b92e88e4eb"},{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"0a175c64e0402b5cdb6f58555e46c398fbbfd30a","unresolved":false,"context_lines":[{"line_number":460,"context_line":"    add_test_flavors"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"    #exclaim \"Fixing network for guestagent connectivity\""},{"line_number":463,"context_line":"    #fix_network_connectivity"},{"line_number":464,"context_line":""},{"line_number":465,"context_line":"    if [[ -n $KEY_DIR ]]; then"},{"line_number":466,"context_line":"        exclaim \"Installing the SSH key from $KEY_DIR to the test environment.\""}],"source_content_type":"application/octet-stream","patch_set":36,"id":"baada198_2310a6a7","line":463,"updated":"2014-07-11 00:37:56.000000000","message":"Should this be uncommented?  If not, is there a reason for keeping the fix_network_connectivity function above?","commit_id":"2f593bdff3326ac24dc65b766ce3e387d471f6d6"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"f7c3cd899b8c6074cce857a28d66818c19a9390b","unresolved":false,"context_lines":[{"line_number":460,"context_line":"    add_test_flavors"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"    #exclaim \"Fixing network for guestagent connectivity\""},{"line_number":463,"context_line":"    #fix_network_connectivity"},{"line_number":464,"context_line":""},{"line_number":465,"context_line":"    if [[ -n $KEY_DIR ]]; then"},{"line_number":466,"context_line":"        exclaim \"Installing the SSH key from $KEY_DIR to the test environment.\""}],"source_content_type":"application/octet-stream","patch_set":36,"id":"baada198_f6ac67ef","line":463,"in_reply_to":"baada198_2310a6a7","updated":"2014-07-14 06:28:00.000000000","message":"The fix network connectivity sets up the correct DNS server for the neutron network. It\u0027s needed for convenience, if we want to be able to resolve DNS on the guest agent, and isn\u0027t required for the tests to complete successfully. Will update this so it\u0027s turned on.","commit_id":"2f593bdff3326ac24dc65b766ce3e387d471f6d6"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"ef8346714c3fe5f8f42b595f2452e29ea3c67293","unresolved":false,"context_lines":[{"line_number":460,"context_line":"    add_test_flavors"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"    #exclaim \"Fixing network for guestagent connectivity\""},{"line_number":463,"context_line":"    #fix_network_connectivity"},{"line_number":464,"context_line":""},{"line_number":465,"context_line":"    if [[ -n $KEY_DIR ]]; then"},{"line_number":466,"context_line":"        exclaim \"Installing the SSH key from $KEY_DIR to the test environment.\""}],"source_content_type":"application/octet-stream","patch_set":36,"id":"baada198_a20b8922","line":463,"in_reply_to":"baada198_f6ac67ef","updated":"2014-07-14 08:54:08.000000000","message":"On second thought, it might be better to have this off by default. If it\u0027s needed for convenience, it can be turned on manually/later.","commit_id":"2f593bdff3326ac24dc65b766ce3e387d471f6d6"}],"tests/integration/tests/initialize.py":[{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"db978147976d3ab01cbbed8021514fe80f06dd6c","unresolved":false,"context_lines":[{"line_number":121,"context_line":"           service_path\u003d\"%s/nova-network\","},{"line_number":122,"context_line":"           extra_cmds\u003d[\u0027--config-file\u003d\u0027],"},{"line_number":123,"context_line":"           conf_file_name\u003d\"nova_conf\").run()"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"@test(groups\u003d[\"services.initialize\"], enabled\u003dSTART_SERVICES)"},{"line_number":127,"context_line":"def start_scheduler():"}],"source_content_type":"text/x-python","patch_set":20,"id":"7adec928_0f6ec796","line":124,"updated":"2014-05-21 04:10:39.000000000","message":"I think we should add a method for \n\n    def start_neutron():","commit_id":"287258b5939cb8b05a096b254eeff8b92e88e4eb"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"a6371c09fd9af705e5ae021fd6f1f88cc764ad08","unresolved":false,"context_lines":[{"line_number":121,"context_line":"           service_path\u003d\"%s/nova-network\","},{"line_number":122,"context_line":"           extra_cmds\u003d[\u0027--config-file\u003d\u0027],"},{"line_number":123,"context_line":"           conf_file_name\u003d\"nova_conf\").run()"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"@test(groups\u003d[\"services.initialize\"], enabled\u003dSTART_SERVICES)"},{"line_number":127,"context_line":"def start_scheduler():"}],"source_content_type":"text/x-python","patch_set":20,"id":"7adec928_73755b31","line":124,"in_reply_to":"7adec928_0f6ec796","updated":"2014-05-21 21:56:12.000000000","message":"Problem is that a lot of this \"start-service\" code doesn\u0027t work correctly with devstack anyway, so I\u0027d question adding to it. \n\nFrom looking at the code, these functions were written to use with a very specific vagrant configuration. Do any rackers rely on these start-services pieces running with vagrant? If so, can we get them to fix it since it\u0027s not part of the standard devstack config? If not, I\u0027d recommend cleaning this out so that we don\u0027t need to deal with this. What do you think?","commit_id":"287258b5939cb8b05a096b254eeff8b92e88e4eb"}]}