)]}'
{"scripts/files/elements/ubuntu-mysql-5.6/install.d/10-mysql":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"69a55532e1eccf67cb099407144598880e8d1f0a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"set -o xtrace"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"tmpdir\u003d`mktemp -d`"},{"line_number":11,"context_line":"cd $tmpdir"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# get Debian package from mysql.com"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"1ae5cdf2_9cda0f4a","line":10,"updated":"2014-06-23 15:49:05.000000000","message":"as a matter of style, I\u0027d recommend upper-casing tmpdir to TMPDIR","commit_id":"efd59aaae20ba9a59a75bdf73d228c4c35ce1b89"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"69a55532e1eccf67cb099407144598880e8d1f0a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"tmpdir\u003d`mktemp -d`"},{"line_number":11,"context_line":"cd $tmpdir"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# get Debian package from mysql.com"},{"line_number":14,"context_line":"wget http://cdn.mysql.com/Downloads/MySQL-5.6/mysql-5.6.17-debian6.0-x86_64.deb"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"1ae5cdf2_3cc2db53","line":11,"updated":"2014-06-23 15:49:05.000000000","message":"since you intend to delete the dir later, it would be preferable to use pushd ${TMPDIR} instead of cd. see comment later about \"cd -\"","commit_id":"efd59aaae20ba9a59a75bdf73d228c4c35ce1b89"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"3978ed61dfa237a9561d3c0ac0e8828ba04e89df","unresolved":false,"context_lines":[{"line_number":11,"context_line":"cd $tmpdir"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# get Debian package from mysql.com"},{"line_number":14,"context_line":"wget http://cdn.mysql.com/Downloads/MySQL-5.6/mysql-5.6.17-debian6.0-x86_64.deb"},{"line_number":15,"context_line":"export DEBIAN_FRONTEND\u003dnoninteractive"},{"line_number":16,"context_line":"apt-get -y install libaio1"},{"line_number":17,"context_line":"dpkg -i mysql-5.6.17-debian6.0-x86_64.deb"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"1ae5cdf2_eb42340e","line":14,"updated":"2014-06-24 19:17:21.000000000","message":"Andrew (abramley) mentioned this to me and it occurred to me that it was a very obvious question \u003cDOH\u003e\n\nWhy are we doing all this for 5.6 when in 5.5 we just did an apt-get install?\n\nI\u0027m sure there\u0027s a good reason for it but I figure I may as well ask and get it cleared up.","commit_id":"efd59aaae20ba9a59a75bdf73d228c4c35ce1b89"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"69a55532e1eccf67cb099407144598880e8d1f0a","unresolved":false,"context_lines":[{"line_number":32,"context_line":"cp /opt/mysql/server-5.6/support-files/mysql.server /etc/init.d/mysql-server"},{"line_number":33,"context_line":"sed -i \u0027s/datadir\u003d$/datadir\u003d\\/var\\/lib\\/mysql/\u0027 /etc/init.d/mysql-server"},{"line_number":34,"context_line":"sudo chmod 755 /etc/init.d/mysql-server"},{"line_number":35,"context_line":"#sudo update-rc.d mysql-server defaults"},{"line_number":36,"context_line":"# create conf dir"},{"line_number":37,"context_line":"mkdir -p /etc/mysql/conf.d"},{"line_number":38,"context_line":"# copy sample conf"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"1ae5cdf2_fc9cf35d","line":35,"updated":"2014-06-23 15:49:05.000000000","message":"why have this line commented out? Why not just eliminate it?","commit_id":"efd59aaae20ba9a59a75bdf73d228c4c35ce1b89"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"69a55532e1eccf67cb099407144598880e8d1f0a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"cp /opt/mysql/server-5.6/support-files/my-default.cnf /etc/mysql/my.cnf"},{"line_number":40,"context_line":"# copy logrotate conf"},{"line_number":41,"context_line":"cp /opt/mysql/server-5.6/support-files/mysql-log-rotate /etc/logrotate.d/mysql-server"},{"line_number":42,"context_line":"sed -i -r \u0027s@/opt/mysql/server-5.6/data/mysqld.log \\{@/var/log/mysql/error.log \\{@\u0027 /etc/logrotate.d/mysql-server"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# install python-mysqldb; this will install libmysqlclient18 too;"},{"line_number":45,"context_line":"# libmysqlclient18\u0027s files will be removed below; we don\u0027t uninstall"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"1ae5cdf2_7cb8e3c7","line":42,"updated":"2014-06-23 15:49:05.000000000","message":"could you wrap this long line?","commit_id":"efd59aaae20ba9a59a75bdf73d228c4c35ce1b89"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"69a55532e1eccf67cb099407144598880e8d1f0a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"apt-get -y install percona-xtrabackup python-mysqldb"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"# symlink some files to where guestagent will look for them"},{"line_number":50,"context_line":"for f in /opt/mysql/server-5.6/bin/*; do sudo ln -s $f /usr/bin; done"},{"line_number":51,"context_line":"# remove libs from libmysqlclient18"},{"line_number":52,"context_line":"rm -rf /usr/lib/*mysql*"},{"line_number":53,"context_line":"for f in /opt/mysql/server-5.6/lib/*; do sudo ln -s $f /usr/lib; done"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"1ae5cdf2_dccd7760","line":50,"updated":"2014-06-23 15:49:05.000000000","message":"would be good to quote f just in case some path has spaces.","commit_id":"efd59aaae20ba9a59a75bdf73d228c4c35ce1b89"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"69a55532e1eccf67cb099407144598880e8d1f0a","unresolved":false,"context_lines":[{"line_number":50,"context_line":"for f in /opt/mysql/server-5.6/bin/*; do sudo ln -s $f /usr/bin; done"},{"line_number":51,"context_line":"# remove libs from libmysqlclient18"},{"line_number":52,"context_line":"rm -rf /usr/lib/*mysql*"},{"line_number":53,"context_line":"for f in /opt/mysql/server-5.6/lib/*; do sudo ln -s $f /usr/lib; done"},{"line_number":54,"context_line":"set +e"},{"line_number":55,"context_line":"# ignore existing file errors"},{"line_number":56,"context_line":"for f in /opt/mysql/server-5.6/share/*; do sudo ln -s $f /usr/share; done"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"1ae5cdf2_1cd8bf1d","line":53,"updated":"2014-06-23 15:49:05.000000000","message":"same comment on quoting","commit_id":"efd59aaae20ba9a59a75bdf73d228c4c35ce1b89"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"69a55532e1eccf67cb099407144598880e8d1f0a","unresolved":false,"context_lines":[{"line_number":74,"context_line":"sed -i -r \u0027s@\\s*err_log\u003d\\$DATADIR/`hostname`.err@  err_log\u003d/var/log/mysql/error.log@\u0027 /opt/mysql/server-5.6/bin/mysqld_safe"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"cd -"},{"line_number":77,"context_line":"rm -rf $tmpdir"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"1ae5cdf2_5c2887ee","line":77,"updated":"2014-06-23 15:49:05.000000000","message":"${TMPDIR}","commit_id":"efd59aaae20ba9a59a75bdf73d228c4c35ce1b89"}]}