)]}'
{"scripts/files/elements/ubuntu-redis/install.d/10-redis":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"3b1a4ec6d079b477c88ee5fb0f9ca7d9fffa2a41","unresolved":false,"context_lines":[{"line_number":8,"context_line":"export DEBIAN_FRONTEND\u003dnoninteractive"},{"line_number":9,"context_line":"add-apt-repository ppa:rwky/redis -y"},{"line_number":10,"context_line":"apt-get update"},{"line_number":11,"context_line":"apt-get install -y redis-server"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"bad4c104_fc1154ad","side":"PARENT","line":11,"updated":"2014-04-29 18:42:33.000000000","message":"I think there needs to be an apt-get update before calling install.\n\nI shared http://pastebin.com/5wkeiMwf with mat-lowery. marking +0 for now.\n\nWill +1 once we understand this better.","commit_id":"db4aa87f400c2b636f0683750e3a6c30aacf83bf"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"3875e80c2810e407d9fff1b6ef180a29c2d0aa73","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# never install trusty packages..."},{"line_number":13,"context_line":"$(which echo) -e \"\\nPackage: *\\nPin: release n\u003dtrusty\\nPin-Priority: -10\" \u003e\u003e /etc/apt/preferences.d/redis-trusty"},{"line_number":14,"context_line":"# ...except for redis-server and redis-tools (501 is higher than default priority)"},{"line_number":15,"context_line":"$(which echo) -e \"\\nPackage: redis-server redis-tools\\nPin: release n\u003dtrusty\\nPin-Priority: 501\" \u003e\u003e /etc/apt/preferences.d/redis-trusty"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"apt-get install -y redis-server"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9ad9bd40_8418ed85","line":15,"updated":"2014-04-30 20:33:23.000000000","message":"I see \u0027echo\u0027 used earlier, and $(which echo) used here. Any reason for the difference? If possible, let\u0027s be consistent with the usage.","commit_id":"56f1e69fb156602c43a3183ebb071942b2514ec5"},{"author":{"_account_id":9683,"name":"Mat Lowery","email":"mlowery@ebaysf.com","username":"mat-lowery"},"change_message_id":"d6dc4c83f41ab4826d962edbf32e8146984235e9","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# never install trusty packages..."},{"line_number":13,"context_line":"$(which echo) -e \"\\nPackage: *\\nPin: release n\u003dtrusty\\nPin-Priority: -10\" \u003e\u003e /etc/apt/preferences.d/redis-trusty"},{"line_number":14,"context_line":"# ...except for redis-server and redis-tools (501 is higher than default priority)"},{"line_number":15,"context_line":"$(which echo) -e \"\\nPackage: redis-server redis-tools\\nPin: release n\u003dtrusty\\nPin-Priority: 501\" \u003e\u003e /etc/apt/preferences.d/redis-trusty"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"apt-get install -y redis-server"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9ad9bd40_ff406037","line":15,"in_reply_to":"9ad9bd40_8418ed85","updated":"2014-04-30 20:39:41.000000000","message":"sh\u0027s builtin echo doesn\u0027t understand the -e. $(which echo) forces it to use the command echo instead of the builtin.\n\nWould you prefer a comment to that effect?","commit_id":"56f1e69fb156602c43a3183ebb071942b2514ec5"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"5527f0f769cfd9e37a6c942f9f9c36a3cc011cb7","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# never install trusty packages..."},{"line_number":13,"context_line":"$(which echo) -e \"\\nPackage: *\\nPin: release n\u003dtrusty\\nPin-Priority: -10\" \u003e\u003e /etc/apt/preferences.d/redis-trusty"},{"line_number":14,"context_line":"# ...except for redis-server and redis-tools (501 is higher than default priority)"},{"line_number":15,"context_line":"$(which echo) -e \"\\nPackage: redis-server redis-tools\\nPin: release n\u003dtrusty\\nPin-Priority: 501\" \u003e\u003e /etc/apt/preferences.d/redis-trusty"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"apt-get install -y redis-server"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9ad9bd40_1a7c2820","line":15,"in_reply_to":"9ad9bd40_ff406037","updated":"2014-05-01 09:34:39.000000000","message":"Ah, I see. It might make it clearer if we use a heredoc here instead. Something like:\n\n  cat \u003c\u003c EOF \u003e\u003e /etc/apt/preferences.d/redis-trusty \n  Package: redis-server redis-tools\n  Pin: release n\u003dtrusty\n  Pin-Priority: 501\n  EOF\n\nWhat say?","commit_id":"56f1e69fb156602c43a3183ebb071942b2514ec5"}]}
