)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"4ecc15d76e26d19c50004efe4418c4d355e4445e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Fixed the trove guestagent to use the config file from"},{"line_number":10,"context_line":"/etc/trove/trove-guestagent.conf instead of using the sample"},{"line_number":11,"context_line":"conf from the trove/etc directory."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I7c55198d6d93f5e909c3b3d9085c08d88561f376"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9ad9bd40_d491da53","line":12,"updated":"2014-04-30 06:01:57.000000000","message":"no buggy #?","commit_id":"4b625cc09e904ac5c729802e06c9d99209df4199"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"254a1376cbc1b74490617f3e090e363b1fdb8c6f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Fixed the trove guestagent to use the config file from"},{"line_number":10,"context_line":"/etc/trove/trove-guestagent.conf instead of using the sample"},{"line_number":11,"context_line":"conf from the trove/etc directory."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I7c55198d6d93f5e909c3b3d9085c08d88561f376"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9ad9bd40_c944ce76","line":12,"in_reply_to":"9ad9bd40_d491da53","updated":"2014-04-30 19:29:06.000000000","message":"Yes, needs buggy #. :)","commit_id":"4b625cc09e904ac5c729802e06c9d99209df4199"},{"author":{"_account_id":6162,"name":"Dan Nguyen","email":"dan.nguyens.mail@gmail.com","username":"daniel-a-nguyen"},"change_message_id":"78930df7f35e364ae1bb3cfb16aa5c5bcef7d41a","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2014-05-05 11:42:56 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Trove guestagent should not use sample conf"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixed the trove guestagent to use the config file from"},{"line_number":10,"context_line":"/etc/trove/trove-guestagent.conf instead of using the sample"},{"line_number":11,"context_line":"conf from the trove/etc directory."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9ad9bd40_5438ceee","line":8,"updated":"2014-05-06 16:23:58.000000000","message":"Slick can you please provide a bit more detail as to why this caused a problem or link it to a bug?","commit_id":"9fae5d1e7d09bca302aace8438e4438969946cc3"},{"author":{"_account_id":6162,"name":"Dan Nguyen","email":"dan.nguyens.mail@gmail.com","username":"daniel-a-nguyen"},"change_message_id":"31bc947d1377f2051f5c34df51eed6c1bd59f260","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2014-05-05 11:42:56 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Trove guestagent should not use sample conf"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixed the trove guestagent to use the config file from"},{"line_number":10,"context_line":"/etc/trove/trove-guestagent.conf instead of using the sample"},{"line_number":11,"context_line":"conf from the trove/etc directory."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9ad9bd40_e8ef3eaf","line":8,"in_reply_to":"9ad9bd40_0556122a","updated":"2014-05-06 21:33:30.000000000","message":"k, I\u0027ll dig for the bug to get some context.","commit_id":"9fae5d1e7d09bca302aace8438e4438969946cc3"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"6f6063fe04a528ce25bec29485ea0268056c0188","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2014-05-05 11:42:56 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Trove guestagent should not use sample conf"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixed the trove guestagent to use the config file from"},{"line_number":10,"context_line":"/etc/trove/trove-guestagent.conf instead of using the sample"},{"line_number":11,"context_line":"conf from the trove/etc directory."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9ad9bd40_0556122a","line":8,"in_reply_to":"9ad9bd40_5438ceee","updated":"2014-05-06 18:24:34.000000000","message":"I did link to a bug (look at patch set 3) but annashen overwrote my latest patchset with an older one. \n\nGonna re-up the latest patchset with the bug info in it once again.","commit_id":"9fae5d1e7d09bca302aace8438e4438969946cc3"}],"scripts/files/bootstrap_init-mysql.sh":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"440ea035bfcbc260a12945eaebe63cfdd6fe55e0","unresolved":false,"context_lines":[{"line_number":22,"context_line":"sudo -u GUEST_USERNAME rsync -e \u0027ssh -o UserKnownHostsFile\u003d/dev/null -o StrictHostKeyChecking\u003dno\u0027 -avz --exclude\u003d\u0027.*\u0027 HOST_USERNAME@NETWORK_GATEWAY:/etc/trove/trove-guestagent.conf ~GUEST_USERNAME/"},{"line_number":23,"context_line":"mkdir /etc/trove"},{"line_number":24,"context_line":"mv ~GUEST_USERNAME/trove-guestagent.conf /etc/trove/trove-guestagent.conf"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Do an apt-get update since its SUPER slow first time"},{"line_number":27,"context_line":"if [ -f /etc/debian_version ] ; then"},{"line_number":28,"context_line":"    apt-get update"}],"source_content_type":"text/x-sh","patch_set":2,"id":"AAAAXX%2F%2F4%2Bs%3D","line":25,"updated":"2014-04-25 14:24:59.000000000","message":"An in-flight review has refactored this file, and it will no longer exist.  Should we wait until that review clears first? (https://review.openstack.org/#/c/69965/2 ) In that case, this change would need to be put in scripts/files/trove-guest.systemd.conf and scripts/files/trove-guest.upstart.conf","commit_id":"4b625cc09e904ac5c729802e06c9d99209df4199"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"104df7127083b3ba7d2b73af7fb0e7b4963fced2","unresolved":false,"context_lines":[{"line_number":22,"context_line":"sudo -u GUEST_USERNAME rsync -e \u0027ssh -o UserKnownHostsFile\u003d/dev/null -o StrictHostKeyChecking\u003dno\u0027 -avz --exclude\u003d\u0027.*\u0027 HOST_USERNAME@NETWORK_GATEWAY:/etc/trove/trove-guestagent.conf ~GUEST_USERNAME/"},{"line_number":23,"context_line":"mkdir /etc/trove"},{"line_number":24,"context_line":"mv ~GUEST_USERNAME/trove-guestagent.conf /etc/trove/trove-guestagent.conf"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Do an apt-get update since its SUPER slow first time"},{"line_number":27,"context_line":"if [ -f /etc/debian_version ] ; then"},{"line_number":28,"context_line":"    apt-get update"}],"source_content_type":"text/x-sh","patch_set":2,"id":"bad4c104_558dc630","line":25,"in_reply_to":"AAAAXX%2F%2F4%2Bs%3D","updated":"2014-04-29 08:38:53.000000000","message":"That review hasn\u0027t merged yet. The review that merges second (likely this one) will have to rebase due to a conflict, and I\u0027m aware of it.","commit_id":"4b625cc09e904ac5c729802e06c9d99209df4199"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"7ed3208e53af1b9b81845c023b61661dc841535f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"sudo -u GUEST_USERNAME rsync -e \u0027ssh -o UserKnownHostsFile\u003d/dev/null -o StrictHostKeyChecking\u003dno\u0027 -avz --exclude\u003d\u0027.*\u0027 HOST_USERNAME@NETWORK_GATEWAY:/etc/trove/trove-guestagent.conf ~GUEST_USERNAME/"},{"line_number":23,"context_line":"mkdir /etc/trove"},{"line_number":24,"context_line":"mv ~GUEST_USERNAME/trove-guestagent.conf /etc/trove/trove-guestagent.conf"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Do an apt-get update since its SUPER slow first time"},{"line_number":27,"context_line":"if [ -f /etc/debian_version ] ; then"},{"line_number":28,"context_line":"    apt-get update"}],"source_content_type":"text/x-sh","patch_set":2,"id":"bad4c104_1c96f894","line":25,"in_reply_to":"bad4c104_558dc630","updated":"2014-04-29 18:23:34.000000000","message":"Ok, I\u0027m good then ;)","commit_id":"4b625cc09e904ac5c729802e06c9d99209df4199"},{"author":{"_account_id":6162,"name":"Dan Nguyen","email":"dan.nguyens.mail@gmail.com","username":"daniel-a-nguyen"},"change_message_id":"23683464ef8d86be21739337ca63c0e9095ae929","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# Copies over the guestagent.conf file from the devstack host to /etc/trove on the guest"},{"line_number":22,"context_line":"sudo -u GUEST_USERNAME rsync -e \u0027ssh -o UserKnownHostsFile\u003d/dev/null -o StrictHostKeyChecking\u003dno\u0027 -avz --exclude\u003d\u0027.*\u0027 HOST_USERNAME@NETWORK_GATEWAY:/etc/trove/trove-guestagent.conf ~GUEST_USERNAME/"},{"line_number":23,"context_line":"mkdir /etc/trove"},{"line_number":24,"context_line":"mv ~GUEST_USERNAME/trove-guestagent.conf /etc/trove/trove-guestagent.conf"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Do an apt-get update since its SUPER slow first time"},{"line_number":27,"context_line":"if [ -f /etc/debian_version ] ; then"}],"source_content_type":"text/x-sh","patch_set":4,"id":"9ad9bd40_68b40e82","line":24,"updated":"2014-05-06 21:45:28.000000000","message":"I\u0027m not 100% sure but I wonder if cp would make more sense that mv for this.","commit_id":"9fae5d1e7d09bca302aace8438e4438969946cc3"}],"scripts/redstack":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"440ea035bfcbc260a12945eaebe63cfdd6fe55e0","unresolved":false,"context_lines":[{"line_number":438,"context_line":"    add_test_flavors"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"    exclaim \"Configuring IPTables for PostRouting through $NETWORK_INTERFACE.\""},{"line_number":441,"context_line":"    sudo iptables -t nat -A POSTROUTING -o $NETWORK_INTERFACE -j MASQUERADE"},{"line_number":442,"context_line":"}"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"function cmd_initialize() {"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAXX%2F%2F48g%3D","line":441,"updated":"2014-04-25 14:24:59.000000000","message":"This seems out of scope of this bug (plus it\u0027s been moved/changed in an in-flight review https://review.openstack.org/#/c/78123 )","commit_id":"4b625cc09e904ac5c729802e06c9d99209df4199"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"104df7127083b3ba7d2b73af7fb0e7b4963fced2","unresolved":false,"context_lines":[{"line_number":438,"context_line":"    add_test_flavors"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"    exclaim \"Configuring IPTables for PostRouting through $NETWORK_INTERFACE.\""},{"line_number":441,"context_line":"    sudo iptables -t nat -A POSTROUTING -o $NETWORK_INTERFACE -j MASQUERADE"},{"line_number":442,"context_line":"}"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"function cmd_initialize() {"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"bad4c104_35dda215","line":441,"in_reply_to":"AAAAXX%2F%2F48g%3D","updated":"2014-04-29 08:38:53.000000000","message":"Yes, It\u0027ll  disappear when I rebase.","commit_id":"4b625cc09e904ac5c729802e06c9d99209df4199"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"7ed3208e53af1b9b81845c023b61661dc841535f","unresolved":false,"context_lines":[{"line_number":438,"context_line":"    add_test_flavors"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"    exclaim \"Configuring IPTables for PostRouting through $NETWORK_INTERFACE.\""},{"line_number":441,"context_line":"    sudo iptables -t nat -A POSTROUTING -o $NETWORK_INTERFACE -j MASQUERADE"},{"line_number":442,"context_line":"}"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"function cmd_initialize() {"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"bad4c104_fcf874e7","line":441,"in_reply_to":"bad4c104_35dda215","updated":"2014-04-29 18:23:34.000000000","message":"Sounds good.","commit_id":"4b625cc09e904ac5c729802e06c9d99209df4199"},{"author":{"_account_id":9683,"name":"Mat Lowery","email":"mlowery@ebaysf.com","username":"mat-lowery"},"change_message_id":"af289ac1678c5ece3dc5b308828416f5d21abb56","unresolved":false,"context_lines":[{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    # Create a conf for the guestagent based on the sample"},{"line_number":415,"context_line":"    cp $PATH_TROVE/etc/trove/trove-guestagent.conf.sample $TROVE_CONF_DIR/trove-guestagent.conf"},{"line_number":416,"context_line":"    sed -i \"s/10.0.0.1/$NETWORK_GATEWAY/g\" $TROVE_CONF_DIR/trove-guestagent.conf"},{"line_number":417,"context_line":"}"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"9ad9bd40_63c61a6a","line":416,"updated":"2014-05-05 17:30:31.000000000","message":"How does this line play with this line:\n\nhttp://git.io/p304QA\n\nShould this cp and sed go in devstack/lib/trove?","commit_id":"9fc40771b1c500ec675fae28a819c4962d1cc3db"},{"author":{"_account_id":9683,"name":"Mat Lowery","email":"mlowery@ebaysf.com","username":"mat-lowery"},"change_message_id":"0365ca1c0eeafdc221bf77d167d301a9d66f45a4","unresolved":false,"context_lines":[{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    # Create a conf for the guestagent based on the sample"},{"line_number":415,"context_line":"    cp $PATH_TROVE/etc/trove/trove-guestagent.conf.sample $TROVE_CONF_DIR/trove-guestagent.conf"},{"line_number":416,"context_line":"    sed -i \"s/10.0.0.1/$NETWORK_GATEWAY/g\" $TROVE_CONF_DIR/trove-guestagent.conf"},{"line_number":417,"context_line":"}"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"9ad9bd40_34f0aa66","line":416,"updated":"2014-05-06 16:18:03.000000000","message":"How does line 416 play with the line highlighted in the following link:\n\nhttp://git.io/p304QA\n\nShould this cp and sed go in devstack/lib/trove?","commit_id":"9fae5d1e7d09bca302aace8438e4438969946cc3"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"d97e5dc6326f395a597a2e106acdd8d0969a269b","unresolved":false,"context_lines":[{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    # Create a conf for the guestagent based on the sample"},{"line_number":415,"context_line":"    cp $PATH_TROVE/etc/trove/trove-guestagent.conf.sample $TROVE_CONF_DIR/trove-guestagent.conf"},{"line_number":416,"context_line":"    sed -i \"s/10.0.0.1/$NETWORK_GATEWAY/g\" $TROVE_CONF_DIR/trove-guestagent.conf"},{"line_number":417,"context_line":"}"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"7adec928_35dbd41c","line":416,"in_reply_to":"9ad9bd40_34f0aa66","updated":"2014-05-08 02:05:54.000000000","message":"Yes, it eventually will. \n\nI\u0027m tackling this issue in two phases though:\n\n1. I want to get the guest-images built, and cached as part of a infra job. The CI system can then use these cached images.\n\n2. We need to move pretty much all of the setup and integration test code from trove-integration into either devstack or trove so that we can deprecate running CI from trove-integration. \nAs part of this, I\u0027ll be mass-moving a lot of this to devstack, so I plan on moving this there as well.\n\nHowever, it looks like devstack is already doing the sed replace, so I don\u0027t need to do it here for now (will have to revisit it for neutron since the host in that case can no longer be reached using 10.0.0.1).","commit_id":"9fae5d1e7d09bca302aace8438e4438969946cc3"},{"author":{"_account_id":9683,"name":"Mat Lowery","email":"mlowery@ebaysf.com","username":"mat-lowery"},"change_message_id":"3153c67e32d1f17a80047f734cbbb606a051c215","unresolved":false,"context_lines":[{"line_number":412,"context_line":"    sed -i \"s/%admin_password%/$ADMIN_PASSWORD/g\" $TROVE_CONF_DIR/test.conf"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    # Create a conf for the guestagent based on the sample"},{"line_number":415,"context_line":"    cp $PATH_TROVE/etc/trove/trove-guestagent.conf.sample $TROVE_CONF_DIR/trove-guestagent.conf"},{"line_number":416,"context_line":"}"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"7adec928_c02bcc2e","line":415,"updated":"2014-05-08 00:49:58.000000000","message":"I\u0027m still trying to understand why this cp is here when all of the other copying to /etc/trove (via iniset) are here:\n\nhttp://git.io/xnNV_g","commit_id":"ed7628e4f2cb46dedb2b69c9dec527fadb56cd0a"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"10f2f688007edfea7a09e77b064d266bf3fe0eee","unresolved":false,"context_lines":[{"line_number":412,"context_line":"    sed -i \"s/%admin_password%/$ADMIN_PASSWORD/g\" $TROVE_CONF_DIR/test.conf"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    # Create a conf for the guestagent based on the sample"},{"line_number":415,"context_line":"    cp $PATH_TROVE/etc/trove/trove-guestagent.conf.sample $TROVE_CONF_DIR/trove-guestagent.conf"},{"line_number":416,"context_line":"}"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"7adec928_7b30ed56","line":415,"in_reply_to":"7adec928_c02bcc2e","updated":"2014-05-08 02:10:02.000000000","message":"Apologies, I responded to your comment in patchset 4, but failed to publish the draft of my response (still getting used to the new gerrit screen). It\u0027s published now. Thanks!","commit_id":"ed7628e4f2cb46dedb2b69c9dec527fadb56cd0a"}]}
