)]}'
{"scripts/redstack":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"68c3a3fb7521d1cbfdcd276c5c156f1a26a05909","unresolved":false,"context_lines":[{"line_number":765,"context_line":"    Commands :"},{"line_number":766,"context_line":"        --setup environment--"},{"line_number":767,"context_line":"          install         - Install all the required dependencies and bring up tr-api and tr-tmgr"},{"line_number":768,"context_line":"          test-init       - Configure the test configuration files and add keystone test users"},{"line_number":769,"context_line":"          build-image     - Builds the vm image and adds it to glance"},{"line_number":770,"context_line":"          initialize      - Reinitialize the trove database, users, services, and test config"},{"line_number":771,"context_line":"          post-devstack   - Configures testing environment, builds image and uploads to glance"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"7adec928_771d4e0f","line":768,"updated":"2014-05-08 16:50:09.000000000","message":"I believe \u0027and adds it to glance\u0027 needs to be removed from the build-image help.  And maybe a \u0027build-and-upload-image\u0027 needs to be added that still does both?","commit_id":"a5308fd59fad10041fb0cf60f80b3b93c23e1520"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"2896ca0e6739ec07d3856b870fb0fca1e90d16bb","unresolved":false,"context_lines":[{"line_number":765,"context_line":"    Commands :"},{"line_number":766,"context_line":"        --setup environment--"},{"line_number":767,"context_line":"          install         - Install all the required dependencies and bring up tr-api and tr-tmgr"},{"line_number":768,"context_line":"          test-init       - Configure the test configuration files and add keystone test users"},{"line_number":769,"context_line":"          build-image     - Builds the vm image and adds it to glance"},{"line_number":770,"context_line":"          initialize      - Reinitialize the trove database, users, services, and test config"},{"line_number":771,"context_line":"          post-devstack   - Configures testing environment, builds image and uploads to glance"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"7adec928_337f50e2","line":768,"in_reply_to":"7adec928_771d4e0f","updated":"2014-05-21 21:57:14.000000000","message":"Good catch; I\u0027ll change the help text to better reflect what\u0027s actually going on.\n\nAs for a new command to build-and-upload image, I don\u0027t think that there\u0027s a real need for it. At that point I think you\u0027re probably better off running \"kick-start\" itself. If you have a glance to upload the image to, you\u0027re probably using a devstack environment, and really want to kick-start.","commit_id":"a5308fd59fad10041fb0cf60f80b3b93c23e1520"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"68c3a3fb7521d1cbfdcd276c5c156f1a26a05909","unresolved":false,"context_lines":[{"line_number":771,"context_line":"          post-devstack   - Configures testing environment, builds image and uploads to glance"},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"        --helper for environment--"},{"line_number":774,"context_line":"          kick-start      - kick start the setup of trove."},{"line_number":775,"context_line":"                            (redstack test-init/build-image in one step)"},{"line_number":776,"context_line":"                            [mysql no-clean] no clean avoids rebuilding pacakges from scratch"},{"line_number":777,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":10,"id":"7adec928_17ac0aa0","line":774,"updated":"2014-05-08 16:50:09.000000000","message":"If a \u0027build-and-upload-image\u0027 is added, it should be referenced here.  If not, not sure what this should say ...","commit_id":"a5308fd59fad10041fb0cf60f80b3b93c23e1520"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"2896ca0e6739ec07d3856b870fb0fca1e90d16bb","unresolved":false,"context_lines":[{"line_number":771,"context_line":"          post-devstack   - Configures testing environment, builds image and uploads to glance"},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"        --helper for environment--"},{"line_number":774,"context_line":"          kick-start      - kick start the setup of trove."},{"line_number":775,"context_line":"                            (redstack test-init/build-image in one step)"},{"line_number":776,"context_line":"                            [mysql no-clean] no clean avoids rebuilding pacakges from scratch"},{"line_number":777,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":10,"id":"7adec928_137a54f1","line":774,"in_reply_to":"7adec928_17ac0aa0","updated":"2014-05-21 21:57:14.000000000","message":"I don\u0027t think we need to add a build-and-upload command (see above), since I\u0027m not sure what scenario it would actually be used in.","commit_id":"a5308fd59fad10041fb0cf60f80b3b93c23e1520"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"68c3a3fb7521d1cbfdcd276c5c156f1a26a05909","unresolved":false,"context_lines":[{"line_number":772,"context_line":""},{"line_number":773,"context_line":"        --helper for environment--"},{"line_number":774,"context_line":"          kick-start      - kick start the setup of trove."},{"line_number":775,"context_line":"                            (redstack test-init/build-image in one step)"},{"line_number":776,"context_line":"                            [mysql no-clean] no clean avoids rebuilding pacakges from scratch"},{"line_number":777,"context_line":""},{"line_number":778,"context_line":"        --trove dependency services--"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"7adec928_b7aa766e","line":775,"updated":"2014-05-08 16:50:09.000000000","message":"No sure if you can fix the typo here (pacakges) or if it\u0027s out of scope :)","commit_id":"a5308fd59fad10041fb0cf60f80b3b93c23e1520"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"2896ca0e6739ec07d3856b870fb0fca1e90d16bb","unresolved":false,"context_lines":[{"line_number":772,"context_line":""},{"line_number":773,"context_line":"        --helper for environment--"},{"line_number":774,"context_line":"          kick-start      - kick start the setup of trove."},{"line_number":775,"context_line":"                            (redstack test-init/build-image in one step)"},{"line_number":776,"context_line":"                            [mysql no-clean] no clean avoids rebuilding pacakges from scratch"},{"line_number":777,"context_line":""},{"line_number":778,"context_line":"        --trove dependency services--"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"7adec928_f31de8be","line":775,"in_reply_to":"7adec928_b7aa766e","updated":"2014-05-21 21:57:14.000000000","message":"Good catch. Let me fix the typo. :)","commit_id":"a5308fd59fad10041fb0cf60f80b3b93c23e1520"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"1b2e1119eb3f6bf7ed946836ea49b452f7e8dff6","unresolved":false,"context_lines":[{"line_number":433,"context_line":"    exclaim \"Creating Test Flavors.\""},{"line_number":434,"context_line":"    add_test_flavors"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    if [[ -n $KEY_DIR ]]; then"},{"line_number":437,"context_line":"        exclaim \"Installing the SSH key from $KEY_DIR to the test environment.\""},{"line_number":438,"context_line":"        mkdir -p $USERHOME/.ssh"},{"line_number":439,"context_line":"        install -b --mode 0400 $KEY_DIR/id_rsa $USERHOME/.ssh"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"1ae5cdf2_96a13efa","line":436,"updated":"2014-06-05 19:12:03.000000000","message":"wouldn\u0027t\n    if [ -n \"$KEY_DIR\" ]; then\nbe more in keeping with the style of the script?","commit_id":"e63310d57239dc02f4d2ae741423c3b507f5207d"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"69b94f7ecfa109c849d022badf2b31dee79f2e8d","unresolved":false,"context_lines":[{"line_number":433,"context_line":"    exclaim \"Creating Test Flavors.\""},{"line_number":434,"context_line":"    add_test_flavors"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    if [[ -n $KEY_DIR ]]; then"},{"line_number":437,"context_line":"        exclaim \"Installing the SSH key from $KEY_DIR to the test environment.\""},{"line_number":438,"context_line":"        mkdir -p $USERHOME/.ssh"},{"line_number":439,"context_line":"        install -b --mode 0400 $KEY_DIR/id_rsa $USERHOME/.ssh"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"1ae5cdf2_b979c1c9","line":436,"in_reply_to":"1ae5cdf2_96a13efa","updated":"2014-06-06 06:14:03.000000000","message":"[ ] is the older POSIX style of testing that is just an alias for test, and can trip you up when it comes to things like word splitting, and expanding filenames [1]. \n\nSince we\u0027re using bash for this script, portability to POSIX shells is much less of an issue. The [[ ]] syntax works in other newer shells like zsh, and tcsh as well, and also enables some other cool nifty syntax and features like combining operators, shell globbing, and regexp matching. [2]\n\nLooking at the script, it looks like we\u0027ve been using [[ ]] at least in a couple of other places as well, so we\u0027re already not very consistent. I\u0027d recommend using the [[ ]] syntax going forward as well.\n\n[1] http://mywiki.wooledge.org/BashFAQ/031\n\n[2] https://linuxacademy.com/blog/linux/conditions-in-bash-scripting-if-statements/","commit_id":"e63310d57239dc02f4d2ae741423c3b507f5207d"}]}