)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"4a603bf6cc31321fee7ead1759770b6533bb313c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"   such as cassandra."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Changes:"},{"line_number":14,"context_line":" - parametrizing test_begin.conf to expect flavor refs;"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I3d068718a935132ea1637e99468a686ee85422f5"},{"line_number":17,"context_line":"Closes-Bug: #1329310"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1ae5cdf2_08fedd05","line":14,"updated":"2014-06-21 23:18:34.000000000","message":"parameterizing (spelling)","commit_id":"b9daf318e46edf427afb6a7cf9759e3dd8eea3e3"}],"scripts/redstack":[{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"a3b49b31e5a3e8d5433fef4dcc4f3b649a02fe82","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        VERSION\u003d\"2.0.6\""},{"line_number":306,"context_line":"        FLAVOR\u003d\"m1.small\""},{"line_number":307,"context_line":"        BIGGER_FLAVOR\u003d\"m1.medium\""},{"line_number":308,"context_line":"        EPH_FLAVOR\u003d$FLAVOR"},{"line_number":309,"context_line":"        BIGGER_EPH_FLAVOR\u003d$BIGGER_FLAVOR"},{"line_number":310,"context_line":"    elif [ \"$DATASTORE_TYPE\" \u003d\u003d \"couchbase\" ]; then"},{"line_number":311,"context_line":"        PACKAGES\u003d${PACKAGES:-\"couchbase-server\"}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1ae5cdf2_d876b1a3","line":308,"updated":"2014-06-12 20:33:43.000000000","message":"Was it deliberate that you aren\u0027t using an ephemeral flavor here?","commit_id":"8fbe316c999977b7060f1e7aa0fc9e5a13e696be"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"9a4ad924d70fda43cefaf2f762b06b2f537b48f3","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        VERSION\u003d\"2.0.6\""},{"line_number":306,"context_line":"        FLAVOR\u003d\"m1.small\""},{"line_number":307,"context_line":"        BIGGER_FLAVOR\u003d\"m1.medium\""},{"line_number":308,"context_line":"        EPH_FLAVOR\u003d$FLAVOR"},{"line_number":309,"context_line":"        BIGGER_EPH_FLAVOR\u003d$BIGGER_FLAVOR"},{"line_number":310,"context_line":"    elif [ \"$DATASTORE_TYPE\" \u003d\u003d \"couchbase\" ]; then"},{"line_number":311,"context_line":"        PACKAGES\u003d${PACKAGES:-\"couchbase-server\"}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1ae5cdf2_55a8a21f","line":308,"in_reply_to":"1ae5cdf2_d876b1a3","updated":"2014-06-13 03:20:51.000000000","message":"Let\u0027s not skip tests on ephemeral flavors.","commit_id":"8fbe316c999977b7060f1e7aa0fc9e5a13e696be"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"9a4ad924d70fda43cefaf2f762b06b2f537b48f3","unresolved":false,"context_lines":[{"line_number":321,"context_line":"    #Setting specific flavor for datastore since each datastore requires its own flavor"},{"line_number":322,"context_line":"    sed -i \"s/%flavor%/$FLAVOR/g\" $TROVE_CONF_DIR/test.conf"},{"line_number":323,"context_line":"    sed -i \"s/%bigger_flavor%/$BIGGER_FLAVOR/g\" $TROVE_CONF_DIR/test.conf"},{"line_number":324,"context_line":"    sed -i \"s/%eph_flavor%/$EPH_FLAVOR/g\" $TROVE_CONF_DIR/test.conf"},{"line_number":325,"context_line":"    sed -i \"s/%bigger_eph_flavor%/$BIGGER_EPH_FLAVOR/g\" $TROVE_CONF_DIR/test.conf"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    #rd_manage datastore_version_update \u003cdatastore_name\u003e \u003cversion_name\u003e \u003cdatastore_manager\u003e \u003cimage_id\u003e \u003cpackages\u003e \u003cactive\u003e"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1ae5cdf2_95330a13","line":325,"range":{"start_line":324,"start_character":0,"end_line":325,"end_character":0},"updated":"2014-06-13 03:20:51.000000000","message":"This should be moved to the mod_confs section.","commit_id":"8fbe316c999977b7060f1e7aa0fc9e5a13e696be"},{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"0cb146f1db80d33bda6bddf1d283d36378e60c15","unresolved":false,"context_lines":[{"line_number":420,"context_line":"    cp $PATH_TROVE/etc/trove/trove-guestagent.conf.sample $TROVE_CONF_DIR/trove-guestagent.conf"},{"line_number":421,"context_line":"    sed -i \"s/10.0.0.1/$NETWORK_GATEWAY/g\" $TROVE_CONF_DIR/trove-guestagent.conf"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    if [ \"$DATASTORE_TYPE\" \u003d\u003d \"cassandra\" ]; then"},{"line_number":424,"context_line":"        FLAVOR\u003d\"m1.small\""},{"line_number":425,"context_line":"        BIGGER_FLAVOR\u003d\"m1.medium\""},{"line_number":426,"context_line":"        EPH_FLAVOR\u003d\"eph.rd-small\""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"1ae5cdf2_99bccf08","line":423,"updated":"2014-06-16 17:56:33.000000000","message":"One thought which I realize will expand the scope of this change.\n\nWe already have some code that is hardcoding the datastore types. It is in function cmd_set_datastore. I realize this is for setting things up for uploading an image to Glance, however, it seems like maybe we could abstract out setting datastore specific variables to one function and just call it as appropriate? i.e. try to isolate all the DATASTORE_TYPE specific code to one function?","commit_id":"b9daf318e46edf427afb6a7cf9759e3dd8eea3e3"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"81d62c61e995ed730bbaf02a69587f2fd0ebfc4a","unresolved":false,"context_lines":[{"line_number":437,"context_line":"    sed -i \"s/%flavor%/$FLAVOR/g\" $TROVE_CONF_DIR/test.conf"},{"line_number":438,"context_line":"    sed -i \"s/%bigger_flavor%/$BIGGER_FLAVOR/g\" $TROVE_CONF_DIR/test.conf"},{"line_number":439,"context_line":"    sed -i \"s/%eph_flavor%/$EPH_FLAVOR/g\" $TROVE_CONF_DIR/test.conf"},{"line_number":440,"context_line":"    sed -i \"s/%bigger_eph_flavor%/$BIGGER_EPH_FLAVOR/g\" $TROVE_CONF_DIR/test.conf"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"}"},{"line_number":443,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"1ae5cdf2_f73d85de","line":440,"updated":"2014-06-18 11:30:43.000000000","message":"since you are really executing the commands on the same file, why not make your code more readable and execute it in one command?\n\nsed -i -e \u003ccmd1\u003e -e \u003ccmd2\u003e -e \u003ccmd3\u003e -e \u003ccmd4\u003e test.conf","commit_id":"b9daf318e46edf427afb6a7cf9759e3dd8eea3e3"}]}
