)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"ece76a558b6d33450391563ec73b619d19fe6157","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use oslo-versioned-objects to help with dealing with upgrades"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Idcbc052b28395ad6d3a8ca4b9c9b5bad97e1e71e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9aa53dc9_a0f2b3d0","line":9,"updated":"2015-04-07 20:54:27.000000000","message":"Need to include the blueprint here as well.","commit_id":"fb968640652bc4c1bf9fdd68df8f5a683e5df065"}],"specs/liberty/versioned-object.rst":[{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"4e7b45cb2a380a2104bacf35e302cda53ded1c49","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/trove/+spec/versioned-objects"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The goal of this spec is to introduce objects into Trove.  An object is used"},{"line_number":14,"context_line":"to bundle data with methods that can operate on them.  By implementing this"},{"line_number":15,"context_line":"spec, we would be able to pass rich objects over RPC and decouple the"},{"line_number":16,"context_line":"database schema implementation from SQLAlchemy."}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa041b7_4e7571c9","line":13,"updated":"2015-04-02 14:58:47.000000000","message":"I believe Trove already has objects.","commit_id":"fb968640652bc4c1bf9fdd68df8f5a683e5df065"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"7a0a046c03f9da65f2619e4f4a6454c23dbb7ff9","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/trove/+spec/versioned-objects"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The goal of this spec is to introduce objects into Trove.  An object is used"},{"line_number":14,"context_line":"to bundle data with methods that can operate on them.  By implementing this"},{"line_number":15,"context_line":"spec, we would be able to pass rich objects over RPC and decouple the"},{"line_number":16,"context_line":"database schema implementation from SQLAlchemy."}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa041b7_71dc94e4","line":13,"in_reply_to":"baa041b7_4e7571c9","updated":"2015-04-02 15:21:12.000000000","message":"Maybe the term \u0027versioned objects\u0027 should be used here (and the description removed as it is explained below).","commit_id":"fb968640652bc4c1bf9fdd68df8f5a683e5df065"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"ece76a558b6d33450391563ec73b619d19fe6157","unresolved":false,"context_lines":[{"line_number":22,"context_line":"We are looking to improve the way we deal with versioning"},{"line_number":23,"context_line":"(of all sorts db/rpc/rest/templates/plugins). Nova has come up with the idea"},{"line_number":24,"context_line":"of versioned objects, that Ironic has also now used. This has now been"},{"line_number":25,"context_line":"proposed as an oslo library: https://review.openstack.org/#/c/127532/"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Versioned-objects will help us deal with DB schema being at a different"},{"line_number":28,"context_line":"version than the code expects. This will allow Trove to be operated safely"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9aa53dc9_ac5aaf4e","line":25,"updated":"2015-04-07 20:54:27.000000000","message":"This link has already been specified in the reference section. We could just reference it from the reference section directly instead of defining it twice. For example, you could say: \"This has now been proposed as an oslo library as mentioned in Reference Section [1]\" and then in the Reference Section, number it accordingly.","commit_id":"fb968640652bc4c1bf9fdd68df8f5a683e5df065"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"ece76a558b6d33450391563ec73b619d19fe6157","unresolved":false,"context_lines":[{"line_number":25,"context_line":"proposed as an oslo library: https://review.openstack.org/#/c/127532/"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Versioned-objects will help us deal with DB schema being at a different"},{"line_number":28,"context_line":"version than the code expects. This will allow Trove to be operated safely"},{"line_number":29,"context_line":"during upgrades."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9aa53dc9_60270bb7","line":28,"updated":"2015-04-07 20:54:27.000000000","message":"how about rephrasing this as \"This will allow Trove to function/work safely during upgrades\"","commit_id":"fb968640652bc4c1bf9fdd68df8f5a683e5df065"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"ece76a558b6d33450391563ec73b619d19fe6157","unresolved":false,"context_lines":[{"line_number":32,"context_line":"Proposed change"},{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"There is an approved proposal to put nova.objects into oslo as"},{"line_number":36,"context_line":"oslo.versionedobjects - https://review.openstack.org/#/c/127532/ - which would"},{"line_number":37,"context_line":"abstract versionable internal objects for use with RPC.  The plan is to adopt"},{"line_number":38,"context_line":"oslo.versionedobjects and abstract Trove db models."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9aa53dc9_0024bfac","line":35,"updated":"2015-04-07 20:54:27.000000000","message":"Nova instead of nova","commit_id":"fb968640652bc4c1bf9fdd68df8f5a683e5df065"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"ece76a558b6d33450391563ec73b619d19fe6157","unresolved":false,"context_lines":[{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"There is an approved proposal to put nova.objects into oslo as"},{"line_number":36,"context_line":"oslo.versionedobjects - https://review.openstack.org/#/c/127532/ - which would"},{"line_number":37,"context_line":"abstract versionable internal objects for use with RPC.  The plan is to adopt"},{"line_number":38,"context_line":"oslo.versionedobjects and abstract Trove db models."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9aa53dc9_4051a70d","line":36,"updated":"2015-04-07 20:54:27.000000000","message":"Again reference this directly from the reference section instead of specifying the link again","commit_id":"fb968640652bc4c1bf9fdd68df8f5a683e5df065"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"ece76a558b6d33450391563ec73b619d19fe6157","unresolved":false,"context_lines":[{"line_number":36,"context_line":"oslo.versionedobjects - https://review.openstack.org/#/c/127532/ - which would"},{"line_number":37,"context_line":"abstract versionable internal objects for use with RPC.  The plan is to adopt"},{"line_number":38,"context_line":"oslo.versionedobjects and abstract Trove db models."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"The proposed changes are:"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"* Create a directory trove/objects/ that will contain wrapper objects "}],"source_content_type":"text/x-rst","patch_set":1,"id":"9aa53dc9_a04cf370","line":39,"updated":"2015-04-07 20:54:27.000000000","message":"should this be \u0027database\u0027 instead of \u0027db\u0027 models","commit_id":"fb968640652bc4c1bf9fdd68df8f5a683e5df065"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"7a0a046c03f9da65f2619e4f4a6454c23dbb7ff9","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"The proposed changes are:"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"* Create a directory trove/objects/ that will contain wrapper objects "},{"line_number":43,"context_line":"  that are a layer above the db objects."},{"line_number":44,"context_line":"* Objects will be database schema independent."},{"line_number":45,"context_line":"* Objects will be sent over RPC instead of ids, reducing the additional"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa041b7_141bf673","line":42,"updated":"2015-04-02 15:21:12.000000000","message":"extraneous space at end of line","commit_id":"fb968640652bc4c1bf9fdd68df8f5a683e5df065"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"4e7b45cb2a380a2104bacf35e302cda53ded1c49","unresolved":false,"context_lines":[{"line_number":42,"context_line":"* Create a directory trove/objects/ that will contain wrapper objects "},{"line_number":43,"context_line":"  that are a layer above the db objects."},{"line_number":44,"context_line":"* Objects will be database schema independent."},{"line_number":45,"context_line":"* Objects will be sent over RPC instead of ids, reducing the additional"},{"line_number":46,"context_line":"  database hits to query the SQLAlchemy objects."},{"line_number":47,"context_line":"* Objects will be versioned, allowing older objects to be detected and taking"},{"line_number":48,"context_line":"  appropriate actions when the objects are incompatible, i.e. fail gracefully"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa041b7_5194f089","line":45,"updated":"2015-04-02 14:58:47.000000000","message":"Specify which RPC APIs will be affected by this change.  I assume you mean the RPC connection between the Trove API and the Trove Taskmanager.  Anywhere else?","commit_id":"fb968640652bc4c1bf9fdd68df8f5a683e5df065"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"4e7b45cb2a380a2104bacf35e302cda53ded1c49","unresolved":false,"context_lines":[{"line_number":47,"context_line":"* Objects will be versioned, allowing older objects to be detected and taking"},{"line_number":48,"context_line":"  appropriate actions when the objects are incompatible, i.e. fail gracefully"},{"line_number":49,"context_line":"  or emulate older behavior."},{"line_number":50,"context_line":"* To handle cases where the underlying cluster, db, could"},{"line_number":51,"context_line":"  have been changed when the object is in flight, additional arguments"},{"line_number":52,"context_line":"  (e.g. expected_cluster_state and expected_db_state) would be included in"},{"line_number":53,"context_line":"  the object save method, which would check against the in-database copy of"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa041b7_4e0a1128","line":50,"updated":"2015-04-02 14:58:47.000000000","message":"do you mean a cluster called \"db\"?","commit_id":"fb968640652bc4c1bf9fdd68df8f5a683e5df065"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"7a0a046c03f9da65f2619e4f4a6454c23dbb7ff9","unresolved":false,"context_lines":[{"line_number":86,"context_line":"Guest Agent"},{"line_number":87,"context_line":"-----------"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Does this change behavior on the Guest Agent? If so, is it backwards compatible with API and Task Manager?"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa041b7_f45e52e8","line":89,"updated":"2015-04-02 15:21:12.000000000","message":"Please fill out this section","commit_id":"fb968640652bc4c1bf9fdd68df8f5a683e5df065"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"4e7b45cb2a380a2104bacf35e302cda53ded1c49","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Developer impact"},{"line_number":101,"context_line":"----------------"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Today, database APIs are called directly to create, read, update, and delete"},{"line_number":104,"context_line":"cluster, db and others.  With the switch to an object model,"},{"line_number":105,"context_line":"these calls will be made against the appropriate object methods. It will take"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa041b7_513f50b4","line":102,"updated":"2015-04-02 14:58:47.000000000","message":"Please provide code examples of how db objects will be represented, loaded, saved, and accessed.","commit_id":"fb968640652bc4c1bf9fdd68df8f5a683e5df065"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"ece76a558b6d33450391563ec73b619d19fe6157","unresolved":false,"context_lines":[{"line_number":143,"context_line":"* Implement the objects for each DB object type we have."},{"line_number":144,"context_line":"* Update code that uses the DB to use versioned-objects instead."},{"line_number":145,"context_line":"* Write some developer docs on how to deal with older schema."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Dependencies"},{"line_number":149,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9aa53dc9_2027c365","line":146,"updated":"2015-04-07 20:54:27.000000000","message":"Can you also include a work item for adding unit tests. Thank you.","commit_id":"fb968640652bc4c1bf9fdd68df8f5a683e5df065"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"ece76a558b6d33450391563ec73b619d19fe6157","unresolved":false,"context_lines":[{"line_number":154,"context_line":"Upgrade Implications"},{"line_number":155,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"With decouple the database schema implementation from SQLAlchemy,"},{"line_number":158,"context_line":"trove rolling upgrade will be more smoothly and increase the odds of success,"},{"line_number":159,"context_line":"when the version of DB schema and trove service are not same or compatible,"},{"line_number":160,"context_line":"versioned object will bridge them and translate db object to "}],"source_content_type":"text/x-rst","patch_set":1,"id":"9aa53dc9_c0c0177f","line":157,"updated":"2015-04-07 20:54:27.000000000","message":"I think this sentence needs to be rephrased a bit. For example, \u0027By decoupling .........\" instead of \u0027With decouple\u0027","commit_id":"fb968640652bc4c1bf9fdd68df8f5a683e5df065"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"ece76a558b6d33450391563ec73b619d19fe6157","unresolved":false,"context_lines":[{"line_number":155,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"With decouple the database schema implementation from SQLAlchemy,"},{"line_number":158,"context_line":"trove rolling upgrade will be more smoothly and increase the odds of success,"},{"line_number":159,"context_line":"when the version of DB schema and trove service are not same or compatible,"},{"line_number":160,"context_line":"versioned object will bridge them and translate db object to "},{"line_number":161,"context_line":"same/compatible one for each of other."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9aa53dc9_605f0be6","line":158,"updated":"2015-04-07 20:54:27.000000000","message":"Needs to be Trove instead of trove. Also need to rephrase it to something like \" Trove rolling upgrade will run more smoothly\u0027 or \u0027Trove rolling upgrades will be more smooth\u0027","commit_id":"fb968640652bc4c1bf9fdd68df8f5a683e5df065"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"ece76a558b6d33450391563ec73b619d19fe6157","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"With decouple the database schema implementation from SQLAlchemy,"},{"line_number":158,"context_line":"trove rolling upgrade will be more smoothly and increase the odds of success,"},{"line_number":159,"context_line":"when the version of DB schema and trove service are not same or compatible,"},{"line_number":160,"context_line":"versioned object will bridge them and translate db object to "},{"line_number":161,"context_line":"same/compatible one for each of other."},{"line_number":162,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9aa53dc9_00139f0e","line":159,"updated":"2015-04-07 20:54:27.000000000","message":"I think this should be a seperate sentence. \"When the version of DB schema and Trove service are not same or compatible, .....\"","commit_id":"fb968640652bc4c1bf9fdd68df8f5a683e5df065"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"7a0a046c03f9da65f2619e4f4a6454c23dbb7ff9","unresolved":false,"context_lines":[{"line_number":157,"context_line":"With decouple the database schema implementation from SQLAlchemy,"},{"line_number":158,"context_line":"trove rolling upgrade will be more smoothly and increase the odds of success,"},{"line_number":159,"context_line":"when the version of DB schema and trove service are not same or compatible,"},{"line_number":160,"context_line":"versioned object will bridge them and translate db object to "},{"line_number":161,"context_line":"same/compatible one for each of other."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baa041b7_341efa63","line":160,"updated":"2015-04-02 15:21:12.000000000","message":"extraneous space at end of line","commit_id":"fb968640652bc4c1bf9fdd68df8f5a683e5df065"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"ece76a558b6d33450391563ec73b619d19fe6157","unresolved":false,"context_lines":[{"line_number":163,"context_line":"Testing"},{"line_number":164,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"By introducing objects, we are not changing the end user facing API or"},{"line_number":167,"context_line":"functionality of Trove.  We are passing objects over RPC instead of ids."},{"line_number":168,"context_line":"Given this, no new tempest tests will be created.  However, relevant unit"},{"line_number":169,"context_line":"tests will be created to test the new object code base."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9aa53dc9_a004f3bf","line":166,"updated":"2015-04-07 20:54:27.000000000","message":"versioned objects instead of just objects","commit_id":"fb968640652bc4c1bf9fdd68df8f5a683e5df065"}]}
