)]}'
{"doc/source/index.rst":[{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"1c1a43f54e55834a58243c2a407219e3b1683987","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"   specs/kilo/*"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Liberty approved specs:"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":".. toctree::"},{"line_number":26,"context_line":"   :glob:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5afe65bd_f239c342","line":23,"updated":"2015-06-02 06:30:17.000000000","message":"(+0) This change has already been merged, do we still need this, not sure","commit_id":"f8b325a2004f47c5aec2cfaf0072c2f516b235c4"}],"specs/liberty/mongodb-database.rst":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"a363939207feaaf1a7d40a18f2a126fd3499d3a1","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Problem description"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"The MongoDB datastore does not support database management features. Allowing"},{"line_number":25,"context_line":"the user to create, list, and delete databases through the API is essential."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a016987_3b48412d","line":24,"updated":"2015-05-26 23:48:59.000000000","message":"What about the features for user management (create, delete, update, retrieve) and access control? I\u0027m precisely thinking about this set https://github.com/openstack/trove/blob/master/trove/guestagent/datastore/experimental/mongodb/manager.py#L147-L207.\n\nThose are also considered management and would be appropriate to do so as part of this feature.","commit_id":"75c2d63bbea4f1d12b0a15e354970a8ee7601fbb"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"d650cda27600e0d2fe59d5700697242a0517bad8","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Problem description"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"The MongoDB datastore does not support database management features. Allowing"},{"line_number":25,"context_line":"the user to create, list, and delete databases through the API is essential."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a016987_51a50e45","line":24,"in_reply_to":"7a016987_3b48412d","updated":"2015-05-27 10:40:24.000000000","message":"I agree, as we are implementing the BP, why not put more stuff into it, instead of bits by bits","commit_id":"75c2d63bbea4f1d12b0a15e354970a8ee7601fbb"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"dcd7b9830beed4b396106820f855933a57fbc404","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Problem description"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"The MongoDB datastore does not support database management features. Allowing"},{"line_number":25,"context_line":"the user to create, list, and delete databases through the API is essential."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a016987_56abae1e","line":24,"in_reply_to":"7a016987_3b48412d","updated":"2015-05-27 18:31:03.000000000","message":"There is a separate BP for the user feature work - https://review.openstack.org/#/c/184826/","commit_id":"75c2d63bbea4f1d12b0a15e354970a8ee7601fbb"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"f7fd2e29b3aaa099280a62c26c1359a54925ce97","unresolved":false,"context_lines":[{"line_number":34,"context_line":"2. database-list"},{"line_number":35,"context_line":"3. database-delete"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"The changes will be confined to the guestagent code. The DBaaS controller"},{"line_number":38,"context_line":"does not require any code changes. The code changes will be to implement a"},{"line_number":39,"context_line":"new class service.MongoDBAdmin and the corresponding methods as members of the"},{"line_number":40,"context_line":"class. The methods of manager.Manager will be updated to call the admin"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a016987_255b8130","line":37,"updated":"2015-05-26 20:35:58.000000000","message":"DBaaS controller?  Do you mean the task manager?","commit_id":"75c2d63bbea4f1d12b0a15e354970a8ee7601fbb"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"a363939207feaaf1a7d40a18f2a126fd3499d3a1","unresolved":false,"context_lines":[{"line_number":34,"context_line":"2. database-list"},{"line_number":35,"context_line":"3. database-delete"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"The changes will be confined to the guestagent code. The DBaaS controller"},{"line_number":38,"context_line":"does not require any code changes. The code changes will be to implement a"},{"line_number":39,"context_line":"new class service.MongoDBAdmin and the corresponding methods as members of the"},{"line_number":40,"context_line":"class. The methods of manager.Manager will be updated to call the admin"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a016987_bb09d1df","line":37,"in_reply_to":"7a016987_255b8130","updated":"2015-05-26 23:48:59.000000000","message":"I\u0027d assume its the API, since it doesn\u0027t require changes. The Task Manager and Conductor shouldn\u0027t care about the database.","commit_id":"75c2d63bbea4f1d12b0a15e354970a8ee7601fbb"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"dcd7b9830beed4b396106820f855933a57fbc404","unresolved":false,"context_lines":[{"line_number":34,"context_line":"2. database-list"},{"line_number":35,"context_line":"3. database-delete"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"The changes will be confined to the guestagent code. The DBaaS controller"},{"line_number":38,"context_line":"does not require any code changes. The code changes will be to implement a"},{"line_number":39,"context_line":"new class service.MongoDBAdmin and the corresponding methods as members of the"},{"line_number":40,"context_line":"class. The methods of manager.Manager will be updated to call the admin"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a016987_716d9431","line":37,"in_reply_to":"7a016987_bb09d1df","updated":"2015-05-27 18:31:03.000000000","message":"The changes will probably be transparent outside the guest.","commit_id":"75c2d63bbea4f1d12b0a15e354970a8ee7601fbb"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"a363939207feaaf1a7d40a18f2a126fd3499d3a1","unresolved":false,"context_lines":[{"line_number":35,"context_line":"3. database-delete"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"The changes will be confined to the guestagent code. The DBaaS controller"},{"line_number":38,"context_line":"does not require any code changes. The code changes will be to implement a"},{"line_number":39,"context_line":"new class service.MongoDBAdmin and the corresponding methods as members of the"},{"line_number":40,"context_line":"class. The methods of manager.Manager will be updated to call the admin"},{"line_number":41,"context_line":"functions."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a016987_3bf601d8","line":38,"updated":"2015-05-26 23:48:59.000000000","message":"Why are you going to create a class for this instead of implementing those in Manager directly?","commit_id":"75c2d63bbea4f1d12b0a15e354970a8ee7601fbb"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"d650cda27600e0d2fe59d5700697242a0517bad8","unresolved":false,"context_lines":[{"line_number":35,"context_line":"3. database-delete"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"The changes will be confined to the guestagent code. The DBaaS controller"},{"line_number":38,"context_line":"does not require any code changes. The code changes will be to implement a"},{"line_number":39,"context_line":"new class service.MongoDBAdmin and the corresponding methods as members of the"},{"line_number":40,"context_line":"class. The methods of manager.Manager will be updated to call the admin"},{"line_number":41,"context_line":"functions."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a016987_9184a6b1","line":38,"in_reply_to":"7a016987_3bf601d8","updated":"2015-05-27 10:40:24.000000000","message":"+1, any specific needs to get the help of a new class","commit_id":"75c2d63bbea4f1d12b0a15e354970a8ee7601fbb"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"dcd7b9830beed4b396106820f855933a57fbc404","unresolved":false,"context_lines":[{"line_number":35,"context_line":"3. database-delete"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"The changes will be confined to the guestagent code. The DBaaS controller"},{"line_number":38,"context_line":"does not require any code changes. The code changes will be to implement a"},{"line_number":39,"context_line":"new class service.MongoDBAdmin and the corresponding methods as members of the"},{"line_number":40,"context_line":"class. The methods of manager.Manager will be updated to call the admin"},{"line_number":41,"context_line":"functions."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a016987_d101e805","line":38,"in_reply_to":"7a016987_9184a6b1","updated":"2015-05-27 18:31:03.000000000","message":"The guestagent Managers are a controller level that then calls the service classes - in this case service.MongoDBAdmin.","commit_id":"75c2d63bbea4f1d12b0a15e354970a8ee7601fbb"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"d650cda27600e0d2fe59d5700697242a0517bad8","unresolved":false,"context_lines":[{"line_number":40,"context_line":"class. The methods of manager.Manager will be updated to call the admin"},{"line_number":41,"context_line":"functions."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Calls to MongoDB will be done in Python via the PyMongo library, which is already being installed on the guest."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Configuration"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a016987_1198b61a","line":43,"updated":"2015-05-27 10:40:24.000000000","message":"\"which is already installed on\"","commit_id":"75c2d63bbea4f1d12b0a15e354970a8ee7601fbb"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"dcd7b9830beed4b396106820f855933a57fbc404","unresolved":false,"context_lines":[{"line_number":40,"context_line":"class. The methods of manager.Manager will be updated to call the admin"},{"line_number":41,"context_line":"functions."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Calls to MongoDB will be done in Python via the PyMongo library, which is already being installed on the guest."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Configuration"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a016987_f6173a52","line":43,"in_reply_to":"7a016987_1198b61a","updated":"2015-05-27 18:31:03.000000000","message":"I should reword this to make it a requirement of the guest image being used. redstack kick-start currently installs PyMongo during creation, but that this doc should not care about that.","commit_id":"75c2d63bbea4f1d12b0a15e354970a8ee7601fbb"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"a363939207feaaf1a7d40a18f2a126fd3499d3a1","unresolved":false,"context_lines":[{"line_number":90,"context_line":"   database. The database to use is specified via \u0027use \u003cdbname\u003e\u0027, but this does"},{"line_number":91,"context_line":"   not create the database. Databases are created when a \u0027document\u0027 is first"},{"line_number":92,"context_line":"   inserted into them. To ensure a database is created, a dummy document will"},{"line_number":93,"context_line":"   be inserted but then deleted."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"2. list_databases - Run \u0027pymongo.MongoClient.database_names()\u0027 and return the resulting list."},{"line_number":96,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a016987_1bf105ce","line":93,"updated":"2015-05-26 23:48:59.000000000","message":"I don\u0027t like this much, but I don\u0027t think there is a better way to do it. Hmm.","commit_id":"75c2d63bbea4f1d12b0a15e354970a8ee7601fbb"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"a363939207feaaf1a7d40a18f2a126fd3499d3a1","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"2. list_databases - Run \u0027pymongo.MongoClient.database_names()\u0027 and return the resulting list."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"3. delete_database - Drop the database. Optional - drop all users first - get all the users for the database from the admin db’s ‘system.users’ collection, then remove each user."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"   ::"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a016987_3b796130","line":97,"updated":"2015-05-26 23:48:59.000000000","message":"I don\u0027t think users should be deleted as part of the database deletion. There should be a different command for that.","commit_id":"75c2d63bbea4f1d12b0a15e354970a8ee7601fbb"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"d650cda27600e0d2fe59d5700697242a0517bad8","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"2. list_databases - Run \u0027pymongo.MongoClient.database_names()\u0027 and return the resulting list."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"3. delete_database - Drop the database. Optional - drop all users first - get all the users for the database from the admin db’s ‘system.users’ collection, then remove each user."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"   ::"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a016987_b12562c3","line":97,"in_reply_to":"7a016987_3b796130","updated":"2015-05-27 10:40:24.000000000","message":"1. I do agree why should we delete all users, is it the case that one user accesses only one db.\n\n2. Now, here is the trick, you do not have any user management and you want to delete the users, this also emphasizes on need to add more APIs as part of this BP.","commit_id":"75c2d63bbea4f1d12b0a15e354970a8ee7601fbb"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"dcd7b9830beed4b396106820f855933a57fbc404","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"2. list_databases - Run \u0027pymongo.MongoClient.database_names()\u0027 and return the resulting list."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"3. delete_database - Drop the database. Optional - drop all users first - get all the users for the database from the admin db’s ‘system.users’ collection, then remove each user."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"   ::"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a016987_7168f4ba","line":97,"in_reply_to":"7a016987_b12562c3","updated":"2015-05-27 18:31:03.000000000","message":"MongoDB users are identified by their name AND authenticating database. You can have 2 users with the same name but with different databases. If you delete a database but do not clear its users first then you have useless users whose only record is in the admin.system.users collection. Please see http://docs.mongodb.org/manual/reference/command/dropDatabase/ for details.","commit_id":"75c2d63bbea4f1d12b0a15e354970a8ee7601fbb"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"a363939207feaaf1a7d40a18f2a126fd3499d3a1","unresolved":false,"context_lines":[{"line_number":106,"context_line":"Alternatives"},{"line_number":107,"context_line":"------------"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"create_database could not create a dummy object in the database."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"A new option could be added to delete_database to specify whether to delete"},{"line_number":112,"context_line":"users or not."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a016987_9bb3b50a","line":109,"updated":"2015-05-26 23:48:59.000000000","message":"In that case, create_database would be a noop?","commit_id":"75c2d63bbea4f1d12b0a15e354970a8ee7601fbb"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"d650cda27600e0d2fe59d5700697242a0517bad8","unresolved":false,"context_lines":[{"line_number":106,"context_line":"Alternatives"},{"line_number":107,"context_line":"------------"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"create_database could not create a dummy object in the database."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"A new option could be added to delete_database to specify whether to delete"},{"line_number":112,"context_line":"users or not."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a016987_d470cca6","line":109,"in_reply_to":"7a016987_9bb3b50a","updated":"2015-05-27 10:40:24.000000000","message":"If thats the case, would that be listed in list_databases","commit_id":"75c2d63bbea4f1d12b0a15e354970a8ee7601fbb"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"dcd7b9830beed4b396106820f855933a57fbc404","unresolved":false,"context_lines":[{"line_number":106,"context_line":"Alternatives"},{"line_number":107,"context_line":"------------"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"create_database could not create a dummy object in the database."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"A new option could be added to delete_database to specify whether to delete"},{"line_number":112,"context_line":"users or not."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a016987_b1a42c08","line":109,"in_reply_to":"7a016987_d470cca6","updated":"2015-05-27 18:31:03.000000000","message":"Noop, would not appear in list-databases","commit_id":"75c2d63bbea4f1d12b0a15e354970a8ee7601fbb"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"d650cda27600e0d2fe59d5700697242a0517bad8","unresolved":false,"context_lines":[{"line_number":124,"context_line":"Milestones"},{"line_number":125,"context_line":"----------"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Liberty"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Work Items"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a016987_14854458","line":127,"updated":"2015-05-27 10:40:24.000000000","message":"(+0) can we be specific about Liberty-1, Liberty-2","commit_id":"75c2d63bbea4f1d12b0a15e354970a8ee7601fbb"},{"author":{"_account_id":14912,"name":"Ashleigh Farnham","email":"ashleighfarnham@gmail.com"},"change_message_id":"09778ca87fdab181f811c09ea5b7b9b5b5eff34a","unresolved":false,"context_lines":[{"line_number":131,"context_line":"----------"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"The changes will be implemented in a single commit. The scope is small and the"},{"line_number":134,"context_line":"functionality is linked."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Upgrade Implications"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a016987_36aa9986","line":134,"updated":"2015-05-26 22:28:01.000000000","message":"Is there a work item covering the documentation side of things?","commit_id":"75c2d63bbea4f1d12b0a15e354970a8ee7601fbb"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"a363939207feaaf1a7d40a18f2a126fd3499d3a1","unresolved":false,"context_lines":[{"line_number":131,"context_line":"----------"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"The changes will be implemented in a single commit. The scope is small and the"},{"line_number":134,"context_line":"functionality is linked."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Upgrade Implications"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a016987_7b9d9958","line":134,"in_reply_to":"7a016987_36aa9986","updated":"2015-05-26 23:48:59.000000000","message":"+1. There should be, we need to document how MongoDB executes things (e.g. the database creation thing) so we avoid misunderstandings.\n\n(I see that it has been added to the docs section)","commit_id":"75c2d63bbea4f1d12b0a15e354970a8ee7601fbb"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"f7fd2e29b3aaa099280a62c26c1359a54925ce97","unresolved":false,"context_lines":[{"line_number":150,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"Unit tests will be added to validate non-trivial code paths."},{"line_number":153,"context_line":"Integration tests will be added."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"Documentation Impact"},{"line_number":156,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a016987_25802146","line":153,"updated":"2015-05-26 20:35:58.000000000","message":"Could you elucidate the integration tests you foresee, please?  Give an idea of what sort of functionality you intend to test","commit_id":"75c2d63bbea4f1d12b0a15e354970a8ee7601fbb"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"dcd7b9830beed4b396106820f855933a57fbc404","unresolved":false,"context_lines":[{"line_number":150,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"Unit tests will be added to validate non-trivial code paths."},{"line_number":153,"context_line":"Integration tests will be added."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"Documentation Impact"},{"line_number":156,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a016987_234d8f72","line":153,"in_reply_to":"7a016987_25802146","updated":"2015-05-27 18:31:03.000000000","message":"Not sure at this point.","commit_id":"75c2d63bbea4f1d12b0a15e354970a8ee7601fbb"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"506f54bc9691e04dc6233a0e2a79450645a1c0a7","unresolved":false,"context_lines":[{"line_number":35,"context_line":"3. database-delete"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"The changes will be confined to the guestagent code. The taskmanager, API, and"},{"line_number":38,"context_line":"conductor do not require require any code changes. The code changes will be to"},{"line_number":39,"context_line":"implement a new class service.MongoDBAdmin and the corresponding methods as"},{"line_number":40,"context_line":"members of the class. The methods of manager.Manager will be updated to call"},{"line_number":41,"context_line":"the admin functions."}],"source_content_type":"text/x-rst","patch_set":3,"id":"5afe65bd_3fbba4c6","line":38,"updated":"2015-06-02 05:36:37.000000000","message":"require mentioned twice. Not a big deal.","commit_id":"f8b325a2004f47c5aec2cfaf0072c2f516b235c4"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"1c1a43f54e55834a58243c2a407219e3b1683987","unresolved":false,"context_lines":[{"line_number":35,"context_line":"3. database-delete"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"The changes will be confined to the guestagent code. The taskmanager, API, and"},{"line_number":38,"context_line":"conductor do not require require any code changes. The code changes will be to"},{"line_number":39,"context_line":"implement a new class service.MongoDBAdmin and the corresponding methods as"},{"line_number":40,"context_line":"members of the class. The methods of manager.Manager will be updated to call"},{"line_number":41,"context_line":"the admin functions."}],"source_content_type":"text/x-rst","patch_set":3,"id":"5afe65bd_d26da733","line":38,"in_reply_to":"5afe65bd_3fbba4c6","updated":"2015-06-02 06:30:17.000000000","message":"+1, require mistakenly written twice, we should edit this one.","commit_id":"f8b325a2004f47c5aec2cfaf0072c2f516b235c4"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"92176ac5c8d312019d7f5c337a29e4df1a762b01","unresolved":false,"context_lines":[{"line_number":35,"context_line":"3. database-delete"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"The changes will be confined to the guestagent code. The taskmanager, API, and"},{"line_number":38,"context_line":"conductor do not require require any code changes. The code changes will be to"},{"line_number":39,"context_line":"implement a new class service.MongoDBAdmin and the corresponding methods as"},{"line_number":40,"context_line":"members of the class. The methods of manager.Manager will be updated to call"},{"line_number":41,"context_line":"the admin functions."}],"source_content_type":"text/x-rst","patch_set":3,"id":"5afe65bd_013bd9d2","line":38,"in_reply_to":"5afe65bd_d26da733","updated":"2015-06-02 15:00:19.000000000","message":"done","commit_id":"f8b325a2004f47c5aec2cfaf0072c2f516b235c4"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"506f54bc9691e04dc6233a0e2a79450645a1c0a7","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"::"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    trove/guestagent/db/models.py - add a MongoDBSchema class."},{"line_number":85,"context_line":"    trove/guestagent/datastore/experimental/mongodb/manager.py - enable functions."},{"line_number":86,"context_line":"    trove/guestagent/datastore/experimental/mongodb/service.py - add functions."},{"line_number":87,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5afe65bd_1f26a868","line":84,"updated":"2015-06-02 05:36:37.000000000","message":"Matt, could you elaborate a little on this new schema class for MongoDB. What additional/different functions is it going to support, etc? Thanks.","commit_id":"f8b325a2004f47c5aec2cfaf0072c2f516b235c4"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"92176ac5c8d312019d7f5c337a29e4df1a762b01","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"::"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    trove/guestagent/db/models.py - add a MongoDBSchema class."},{"line_number":85,"context_line":"    trove/guestagent/datastore/experimental/mongodb/manager.py - enable functions."},{"line_number":86,"context_line":"    trove/guestagent/datastore/experimental/mongodb/service.py - add functions."},{"line_number":87,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5afe65bd_8660ff36","line":84,"in_reply_to":"5afe65bd_1f26a868","updated":"2015-06-02 15:00:19.000000000","message":"This will be similar to the MySQL schema class. Nothing external. Just verification of the schema properties as seen by Trove.","commit_id":"f8b325a2004f47c5aec2cfaf0072c2f516b235c4"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"506f54bc9691e04dc6233a0e2a79450645a1c0a7","unresolved":false,"context_lines":[{"line_number":96,"context_line":"2. list_databases - Run \u0027pymongo.MongoClient.database_names()\u0027 and return the resulting list."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"3. delete_database - Drop the database. Optional - drop all users first - get all the users for the database from the admin db’s ‘system.users’ collection, then remove each user."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"   ::"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"      for user in pymongo.MongoClient[‘admin’][‘system.users’].find({‘db’: ‘\u003cdbname\u003e’}):"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5afe65bd_bf92f455","line":99,"updated":"2015-06-02 05:36:37.000000000","message":"Is this how mongodb deletes databases as well (by dropping the users). The reason I ask is to see if there is another alternative of removing user access to a database before deleting the database, instead of actually deleting the user. This way we wouldnt have to change the delete_database method to accept  a new option for deleting users. If users really wanted to delete users, they could use the delete_user api.","commit_id":"f8b325a2004f47c5aec2cfaf0072c2f516b235c4"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"92176ac5c8d312019d7f5c337a29e4df1a762b01","unresolved":false,"context_lines":[{"line_number":96,"context_line":"2. list_databases - Run \u0027pymongo.MongoClient.database_names()\u0027 and return the resulting list."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"3. delete_database - Drop the database. Optional - drop all users first - get all the users for the database from the admin db’s ‘system.users’ collection, then remove each user."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"   ::"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"      for user in pymongo.MongoClient[‘admin’][‘system.users’].find({‘db’: ‘\u003cdbname\u003e’}):"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5afe65bd_a11ac56c","line":99,"in_reply_to":"5afe65bd_bf92f455","updated":"2015-06-02 15:00:19.000000000","message":"Ok the consensus seems to be to not drop all the users when dropping the database. I will remove this.","commit_id":"f8b325a2004f47c5aec2cfaf0072c2f516b235c4"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"506f54bc9691e04dc6233a0e2a79450645a1c0a7","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"A new option could be added to delete_database to specify whether to delete"},{"line_number":113,"context_line":"users or not."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Implementation"},{"line_number":117,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5afe65bd_bfa0b491","line":114,"updated":"2015-06-02 05:36:37.000000000","message":"wouldnt this require an api change as well. I am assuming this is an option the user can specify while deleting a database.","commit_id":"f8b325a2004f47c5aec2cfaf0072c2f516b235c4"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"92176ac5c8d312019d7f5c337a29e4df1a762b01","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"A new option could be added to delete_database to specify whether to delete"},{"line_number":113,"context_line":"users or not."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Implementation"},{"line_number":117,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5afe65bd_612bad83","line":114,"in_reply_to":"5afe65bd_bfa0b491","updated":"2015-06-02 15:00:19.000000000","message":"This will be removed.","commit_id":"f8b325a2004f47c5aec2cfaf0072c2f516b235c4"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"457bb41707c6d4b33ee4d310e4ed9e78cdd83d4f","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"::"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    trove/guestagent/db/models.py - add a MongoDBSchema class."},{"line_number":85,"context_line":"    trove/guestagent/datastore/experimental/mongodb/manager.py - enable functions."},{"line_number":86,"context_line":"    trove/guestagent/datastore/experimental/mongodb/service.py - add functions."},{"line_number":87,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5afe65bd_575f5241","line":84,"updated":"2015-06-02 16:07:22.000000000","message":"When you say MySQL schema do you mean the MySQLDatabase class? If they are similar then why create a new class for MongoDB?","commit_id":"bccf801f3242eaa91242ba1363529579d04bfc37"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"b17b14bc51f76621a30f3c19ebac7fbfcb3221a3","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"::"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    trove/guestagent/db/models.py - add a MongoDBSchema class."},{"line_number":85,"context_line":"    trove/guestagent/datastore/experimental/mongodb/manager.py - enable functions."},{"line_number":86,"context_line":"    trove/guestagent/datastore/experimental/mongodb/service.py - add functions."},{"line_number":87,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5afe65bd_60fa82bf","line":84,"in_reply_to":"5afe65bd_575f5241","updated":"2015-06-02 17:40:49.000000000","message":"MySQL has collation,etc that are MySQL specific. Again, internal, not needed here.","commit_id":"bccf801f3242eaa91242ba1363529579d04bfc37"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"a6e1279504aee8a043a46f22377d7d1679f70175","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"The Guest Agent will be changed to support the following manager functions:"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"1. create_database - MongoDB does not have a method to explicitly create a"},{"line_number":91,"context_line":"   database. The database to use is specified via \u0027use \u003cdbname\u003e\u0027, but this does"},{"line_number":92,"context_line":"   not create the database. Databases are created when a \u0027document\u0027 is first"},{"line_number":93,"context_line":"   inserted into them. To ensure a database is created, a dummy document will"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5afe65bd_cc95ede4","line":90,"updated":"2015-06-02 18:25:09.000000000","message":"What is this operation is a noop? I don\u0027t see the point of creating a dummy document just to \"simulate\" creation. It adds an unnecessary, minimal but still..., overhead. It makes sense, though, to have this feature \"implemented\" so we have are consistent with the rest of the databases.","commit_id":"bccf801f3242eaa91242ba1363529579d04bfc37"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"721a68ec54f303325d157224543c5fb75cc64564","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"The Guest Agent will be changed to support the following manager functions:"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"1. create_database - MongoDB does not have a method to explicitly create a"},{"line_number":91,"context_line":"   database. The database to use is specified via \u0027use \u003cdbname\u003e\u0027, but this does"},{"line_number":92,"context_line":"   not create the database. Databases are created when a \u0027document\u0027 is first"},{"line_number":93,"context_line":"   inserted into them. To ensure a database is created, a dummy document will"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5afe65bd_60eddd8a","line":90,"in_reply_to":"5afe65bd_40cb0154","updated":"2015-06-02 18:36:58.000000000","message":"That\u0027s a good point. Thanks.","commit_id":"bccf801f3242eaa91242ba1363529579d04bfc37"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"3aa2281cf658111c9cb86c1c5f91964d9344783a","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"The Guest Agent will be changed to support the following manager functions:"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"1. create_database - MongoDB does not have a method to explicitly create a"},{"line_number":91,"context_line":"   database. The database to use is specified via \u0027use \u003cdbname\u003e\u0027, but this does"},{"line_number":92,"context_line":"   not create the database. Databases are created when a \u0027document\u0027 is first"},{"line_number":93,"context_line":"   inserted into them. To ensure a database is created, a dummy document will"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5afe65bd_40cb0154","line":90,"in_reply_to":"5afe65bd_cc95ede4","updated":"2015-06-02 18:31:51.000000000","message":"So that it shows up in database-list\nIf it was just a noop then it would not appear when listing the dbs.","commit_id":"bccf801f3242eaa91242ba1363529579d04bfc37"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"457bb41707c6d4b33ee4d310e4ed9e78cdd83d4f","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"3. delete_database - Drop the database with"},{"line_number":99,"context_line":"   \u0027pymongo.MongoClient.drop_database(\"\u003cdbname\u003e\")\u0027. Users associated with the"},{"line_number":100,"context_line":"   database will have to be removed manually."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5afe65bd_1a91ff99","line":100,"updated":"2015-06-02 16:07:22.000000000","message":"How about user access to the database? When a database gets deleted, does the user access get deleted automatically or should this be done by the user? I am thinking that its probably not a good thing if we delete a database and have these user access to a deleted database still hanging around.  I think user access deletion and user delete are 2 different things.","commit_id":"bccf801f3242eaa91242ba1363529579d04bfc37"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"b17b14bc51f76621a30f3c19ebac7fbfcb3221a3","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"3. delete_database - Drop the database with"},{"line_number":99,"context_line":"   \u0027pymongo.MongoClient.drop_database(\"\u003cdbname\u003e\")\u0027. Users associated with the"},{"line_number":100,"context_line":"   database will have to be removed manually."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5afe65bd_b1a0cef5","line":100,"in_reply_to":"5afe65bd_1a91ff99","updated":"2015-06-02 17:40:49.000000000","message":"Check the MongoDB docs. A users account name is based on username and database. However, user information is actually stored in the admin db\u0027s system.users collection, so deleting the database will keep the user around.","commit_id":"bccf801f3242eaa91242ba1363529579d04bfc37"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"a6e1279504aee8a043a46f22377d7d1679f70175","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"3. delete_database - Drop the database with"},{"line_number":99,"context_line":"   \u0027pymongo.MongoClient.drop_database(\"\u003cdbname\u003e\")\u0027. Users associated with the"},{"line_number":100,"context_line":"   database will have to be removed manually."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5afe65bd_cc63ad19","line":100,"in_reply_to":"5afe65bd_b1a0cef5","updated":"2015-06-02 18:25:09.000000000","message":"What is a user belongs to more than one database? We shouldn\u0027t drop the user in that case. IMO the user deletion should be responsibility of the user.","commit_id":"bccf801f3242eaa91242ba1363529579d04bfc37"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"721a68ec54f303325d157224543c5fb75cc64564","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"3. delete_database - Drop the database with"},{"line_number":99,"context_line":"   \u0027pymongo.MongoClient.drop_database(\"\u003cdbname\u003e\")\u0027. Users associated with the"},{"line_number":100,"context_line":"   database will have to be removed manually."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5afe65bd_e0f9cd4e","line":100,"in_reply_to":"5afe65bd_c08ff121","updated":"2015-06-02 18:36:58.000000000","message":"Cool!","commit_id":"bccf801f3242eaa91242ba1363529579d04bfc37"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"3aa2281cf658111c9cb86c1c5f91964d9344783a","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"3. delete_database - Drop the database with"},{"line_number":99,"context_line":"   \u0027pymongo.MongoClient.drop_database(\"\u003cdbname\u003e\")\u0027. Users associated with the"},{"line_number":100,"context_line":"   database will have to be removed manually."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5afe65bd_c08ff121","line":100,"in_reply_to":"5afe65bd_cc63ad19","updated":"2015-06-02 18:31:51.000000000","message":"I have changed it to state that user deletion needs to be done manually.","commit_id":"bccf801f3242eaa91242ba1363529579d04bfc37"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"3894abee61f080df6763eaa9e7aea547b38fd08c","unresolved":false,"context_lines":[{"line_number":156,"context_line":"References"},{"line_number":157,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"There are no external references in this document."}],"source_content_type":"text/x-rst","patch_set":4,"id":"5afe65bd_405f8141","line":159,"updated":"2015-06-02 18:40:25.000000000","message":"I think pymongo could make an entry here","commit_id":"bccf801f3242eaa91242ba1363529579d04bfc37"}]}
