)]}'
{"specs/liberty/mongodb-configuration-groups.rst":[{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"b54009ec8da716418289c92325101ec4b942cd11","unresolved":false,"context_lines":[{"line_number":29,"context_line":"file."},{"line_number":30,"context_line":"The database service has to be restarted for any changes to the"},{"line_number":31,"context_line":"configuration file to take effect. All configuration changes will therefore be"},{"line_number":32,"context_line":"requiring database restart and \u0027apply_overrides\u0027 will be implemented as no-op."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Overrides will be implemented by replacing the current file with an"},{"line_number":35,"context_line":"updated one."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5afe65bd_46979e90","line":32,"updated":"2015-06-02 17:28:15.000000000","message":"If `apply_overrides` is a no-op then when a user makes the call it would look like something happened but thats not the case because nothing was applied. \n\nI\u0027d suggest that this be either raise an exception with a message that this call is not available for mongo (maybe this is what you intended) OR make it call the `update_overrides` and act the same as updating the properties sent in the call.\n\nI\u0027m leaning toward raise an exception only because then we should keep the apply term as something that does not overwrite the config file.","commit_id":"7c79622a1be80f887b3139f1b63915dfbf48e177"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"2b384514c06fc5ccae5689d1e3fab26c7ae67cfd","unresolved":false,"context_lines":[{"line_number":29,"context_line":"file."},{"line_number":30,"context_line":"The database service has to be restarted for any changes to the"},{"line_number":31,"context_line":"configuration file to take effect. All configuration changes will therefore be"},{"line_number":32,"context_line":"requiring database restart and \u0027apply_overrides\u0027 will be implemented as no-op."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Overrides will be implemented by replacing the current file with an"},{"line_number":35,"context_line":"updated one."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3afb71cf_62e736e5","line":32,"in_reply_to":"3afb71cf_ed81fd4e","updated":"2015-06-05 16:11:44.000000000","message":"ah yeah ok. I retract my comment as this change only applies to the method in the guest for `apply_overrides`","commit_id":"7c79622a1be80f887b3139f1b63915dfbf48e177"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"3b5b39e19c2d30f22d8e3d4b2d16c380ea6e7b64","unresolved":false,"context_lines":[{"line_number":29,"context_line":"file."},{"line_number":30,"context_line":"The database service has to be restarted for any changes to the"},{"line_number":31,"context_line":"configuration file to take effect. All configuration changes will therefore be"},{"line_number":32,"context_line":"requiring database restart and \u0027apply_overrides\u0027 will be implemented as no-op."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Overrides will be implemented by replacing the current file with an"},{"line_number":35,"context_line":"updated one."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3afb71cf_ed81fd4e","line":32,"in_reply_to":"5afe65bd_46979e90","updated":"2015-06-04 20:23:20.000000000","message":"Maybe the sentence should really say that \u0027...because there is no way to apply configuration changes...\u0027","commit_id":"7c79622a1be80f887b3139f1b63915dfbf48e177"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"bdd458b80bf98f536bb43e94b5eb9e65fcb45ca6","unresolved":false,"context_lines":[{"line_number":29,"context_line":"file."},{"line_number":30,"context_line":"The database service has to be restarted for any changes to the"},{"line_number":31,"context_line":"configuration file to take effect. All configuration changes will therefore be"},{"line_number":32,"context_line":"requiring database restart and \u0027apply_overrides\u0027 will be implemented as no-op."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Overrides will be implemented by replacing the current file with an"},{"line_number":35,"context_line":"updated one."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3afb71cf_6a0cd342","line":32,"in_reply_to":"5afe65bd_46979e90","updated":"2015-06-04 20:19:09.000000000","message":"That would make sense, but looking at BuiltInstanceTasks.update_overrides(...) in taskmanager/models the two calls get executed in sequence.\nMaybe the original implementation assumed that all configuration changes can be always applied.","commit_id":"7c79622a1be80f887b3139f1b63915dfbf48e177"}]}
