)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"f9b8d2c16e12ad01f40fbb090f2a2eb99cbfd1df","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Mayuri Ganguly \u003cmayuri.ganguly@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-17 14:41:25 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Vertica cluster user management"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I214aa314b4f9bc5abd059d121bab7f7975fa776c"},{"line_number":10,"context_line":"blueprint: cluster-user-management"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa32b979_2b9bfe67","line":7,"updated":"2015-06-28 07:18:36.000000000","message":"There is a big difference between commit title and proposed change, needs to be corrected, title refers only one datastore, bp refers general functionlality for all clusters.","commit_id":"ec020f3e0c9cba68bd1a860851dc9ddf0089062b"}],"specs/liberty/cluster-user-management.rst":[{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"2b544aeb6b499d2d0ff6af94b8b26b1085908bf1","unresolved":false,"context_lines":[{"line_number":29,"context_line":"the  DB admin to perform the CRUD operations on the users. A DB admin can"},{"line_number":30,"context_line":"create an user for the cluster, get a list of all the users for a particular"},{"line_number":31,"context_line":"cluster. An user added/updated/deleted to a cluster, gets"},{"line_number":32,"context_line":"added/updated/deleted to all the instances of that cluster."},{"line_number":33,"context_line":"We can also update and delete any user associated with the cluster."},{"line_number":34,"context_line":"Currently it will be implemented only for the Vertica clusters, with the"},{"line_number":35,"context_line":"scope for possible extension in future for other clusters as well."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_634ff8bd","line":32,"updated":"2015-06-15 19:32:05.000000000","message":"If the user gets added to all the instances, or just one, is datastore specific implementation detail.","commit_id":"9b77579709ce1b8319a4e3bdeac9286b88f4dd1b"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"2b544aeb6b499d2d0ff6af94b8b26b1085908bf1","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Request::"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    POST /v1.0/​{tenantId}​/clusters{clusterID}/users"},{"line_number":78,"context_line":"    {"},{"line_number":79,"context_line":"        \"users\": ["},{"line_number":80,"context_line":"            {"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_8e5ee310","line":77,"updated":"2015-06-15 19:32:05.000000000","message":"this URI doesn\u0027t look right to me","commit_id":"9b77579709ce1b8319a4e3bdeac9286b88f4dd1b"},{"author":{"_account_id":14991,"name":"Mayuri Ganguly","email":"mayuri.ganguly@hpe.com","username":"gangulma"},"change_message_id":"43a99b1537e89cf339f881d929acabd82f58baac","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Request::"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    POST /v1.0/​{tenantId}​/clusters{clusterID}/users"},{"line_number":78,"context_line":"    {"},{"line_number":79,"context_line":"        \"users\": ["},{"line_number":80,"context_line":"            {"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_81d7544a","line":77,"in_reply_to":"fa32b979_8e5ee310","updated":"2015-06-16 23:34:13.000000000","message":"do you mean this: POST /v1.0/​{tenantId}​/clusters/{clusterID}/users\nor something else?","commit_id":"9b77579709ce1b8319a4e3bdeac9286b88f4dd1b"},{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"71147cf67eba31044312435991959ddb1fddd55c","unresolved":false,"context_lines":[{"line_number":245,"context_line":"We need to modify the python-troveclient in order to get the user list,"},{"line_number":246,"context_line":"create user, delete user, etc. Currently, the positional argument: ID or"},{"line_number":247,"context_line":"name of the instance needs to be modified to ID or name"},{"line_number":248,"context_line":"of the instance or cluster."},{"line_number":249,"context_line":"- user-create                   Creates a user on an instance or a cluster."},{"line_number":250,"context_line":"- user-delete                   Deletes a user from an instance or a cluster."},{"line_number":251,"context_line":"- user-list                     Lists the users for an instance or a cluster."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_a9140144","line":248,"range":{"start_line":248,"start_character":6,"end_line":248,"end_character":7},"updated":"2015-06-15 19:48:59.000000000","message":"Are you proposing that we will have some CLI commands that take instance ID or instance name but others that will take instance or cluster id or name? Given this design, there shouldn\u0027t be any commands starting with \"cluster-*\" i.e. we should have just overloaded all relevant apis (i.e. create, delete, list, etc).\nI think we should either stick with the \"cluster-*\" paradigm or we don\u0027t. Anything else will be confusing.","commit_id":"9b77579709ce1b8319a4e3bdeac9286b88f4dd1b"},{"author":{"_account_id":1976,"name":"Jonathan Halterman","email":"jhalterman@hp.com","username":"jhalterman"},"change_message_id":"397084d251e67da48f29d11343d2e17c10acf803","unresolved":false,"context_lines":[{"line_number":245,"context_line":"We need to modify the python-troveclient in order to get the user list,"},{"line_number":246,"context_line":"create user, delete user, etc. Currently, the positional argument: ID or"},{"line_number":247,"context_line":"name of the instance needs to be modified to ID or name"},{"line_number":248,"context_line":"of the instance or cluster."},{"line_number":249,"context_line":"- user-create                   Creates a user on an instance or a cluster."},{"line_number":250,"context_line":"- user-delete                   Deletes a user from an instance or a cluster."},{"line_number":251,"context_line":"- user-list                     Lists the users for an instance or a cluster."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_ec6ad7b2","line":248,"range":{"start_line":248,"start_character":6,"end_line":248,"end_character":7},"in_reply_to":"fa32b979_a9140144","updated":"2015-06-17 00:07:15.000000000","message":"@Doug I\u0027m a fan of re-using the existing user-... commands for instances and clusters. Having two sets of commands for everything could get to be a bit much.","commit_id":"9b77579709ce1b8319a4e3bdeac9286b88f4dd1b"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"f9b8d2c16e12ad01f40fbb090f2a2eb99cbfd1df","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"We would like to introduce user management for clusters. This would allow"},{"line_number":29,"context_line":"the  DB admin to perform the CRUD operations on the users. A DB admin can"},{"line_number":30,"context_line":"create an user for the cluster, get a list of all the users for a particular"},{"line_number":31,"context_line":"cluster. We can also update and delete any user associated with the cluster."},{"line_number":32,"context_line":"Currently it will be implemented only for the Vertica clusters, with the"},{"line_number":33,"context_line":"scope for possible extension in future for other clusters as well. For"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa32b979_eb9d1658","line":30,"updated":"2015-06-28 07:18:36.000000000","message":"s/an/a","commit_id":"ec020f3e0c9cba68bd1a860851dc9ddf0089062b"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"f9b8d2c16e12ad01f40fbb090f2a2eb99cbfd1df","unresolved":false,"context_lines":[{"line_number":31,"context_line":"cluster. We can also update and delete any user associated with the cluster."},{"line_number":32,"context_line":"Currently it will be implemented only for the Vertica clusters, with the"},{"line_number":33,"context_line":"scope for possible extension in future for other clusters as well. For"},{"line_number":34,"context_line":"Vertica, an user added/updated/deleted to a cluster, gets"},{"line_number":35,"context_line":"added/updated/deleted to all the instances of that cluster. May/maynot apply"},{"line_number":36,"context_line":"to other datastores."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa32b979_4bb522ce","line":34,"updated":"2015-06-28 07:18:36.000000000","message":"s/an/a","commit_id":"ec020f3e0c9cba68bd1a860851dc9ddf0089062b"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"f9b8d2c16e12ad01f40fbb090f2a2eb99cbfd1df","unresolved":false,"context_lines":[{"line_number":32,"context_line":"Currently it will be implemented only for the Vertica clusters, with the"},{"line_number":33,"context_line":"scope for possible extension in future for other clusters as well. For"},{"line_number":34,"context_line":"Vertica, an user added/updated/deleted to a cluster, gets"},{"line_number":35,"context_line":"added/updated/deleted to all the instances of that cluster. May/maynot apply"},{"line_number":36,"context_line":"to other datastores."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Launchpad Blueprint:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa32b979_cbc9325c","line":35,"updated":"2015-06-28 07:18:36.000000000","message":"it should be member of cluster instead of instances of cluster.","commit_id":"ec020f3e0c9cba68bd1a860851dc9ddf0089062b"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"1c82f94c782e2f1787b1e11536cdde105f8c9bff","unresolved":false,"context_lines":[{"line_number":32,"context_line":"Currently it will be implemented only for the Vertica clusters, with the"},{"line_number":33,"context_line":"scope for possible extension in future for other clusters as well. For"},{"line_number":34,"context_line":"Vertica, an user added/updated/deleted to a cluster, gets"},{"line_number":35,"context_line":"added/updated/deleted to all the instances of that cluster. May/maynot apply"},{"line_number":36,"context_line":"to other datastores."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Launchpad Blueprint:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a50d1a3_21064152","line":35,"in_reply_to":"fa32b979_cbc9325c","updated":"2015-07-23 03:15:04.000000000","message":"may not; add [space]","commit_id":"ec020f3e0c9cba68bd1a860851dc9ddf0089062b"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"f9b8d2c16e12ad01f40fbb090f2a2eb99cbfd1df","unresolved":false,"context_lines":[{"line_number":51,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"To implement the changes needed we to incorporate user management to the"},{"line_number":54,"context_line":"clusters."},{"line_number":55,"context_line":"This should allow the DB admin to perform the following tasks:"},{"line_number":56,"context_line":"1. create user: user name, password and list of databases(optional) should"},{"line_number":57,"context_line":"be passed to create an user."}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa32b979_6bdfc60c","line":54,"updated":"2015-06-28 07:18:36.000000000","message":"we have to incorporate","commit_id":"ec020f3e0c9cba68bd1a860851dc9ddf0089062b"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"1c82f94c782e2f1787b1e11536cdde105f8c9bff","unresolved":false,"context_lines":[{"line_number":54,"context_line":"clusters."},{"line_number":55,"context_line":"This should allow the DB admin to perform the following tasks:"},{"line_number":56,"context_line":"1. create user: user name, password and list of databases(optional) should"},{"line_number":57,"context_line":"be passed to create an user."},{"line_number":58,"context_line":"2. list user: list all users for a specified cluster ID"},{"line_number":59,"context_line":"3. update user: updates a specific user for a cluster"},{"line_number":60,"context_line":"4. delete user: deletes a specific user"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a50d1a3_018ea5cf","line":57,"updated":"2015-07-23 03:15:04.000000000","message":"a user; s/an/a/","commit_id":"ec020f3e0c9cba68bd1a860851dc9ddf0089062b"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"1c82f94c782e2f1787b1e11536cdde105f8c9bff","unresolved":false,"context_lines":[{"line_number":57,"context_line":"be passed to create an user."},{"line_number":58,"context_line":"2. list user: list all users for a specified cluster ID"},{"line_number":59,"context_line":"3. update user: updates a specific user for a cluster"},{"line_number":60,"context_line":"4. delete user: deletes a specific user"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Configuration"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a50d1a3_e1a93925","line":60,"updated":"2015-07-23 03:15:04.000000000","message":"please clarify whether you will also support the ignored_users configuration construct.","commit_id":"ec020f3e0c9cba68bd1a860851dc9ddf0089062b"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"f9b8d2c16e12ad01f40fbb090f2a2eb99cbfd1df","unresolved":false,"context_lines":[{"line_number":58,"context_line":"2. list user: list all users for a specified cluster ID"},{"line_number":59,"context_line":"3. update user: updates a specific user for a cluster"},{"line_number":60,"context_line":"4. delete user: deletes a specific user"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Configuration"},{"line_number":64,"context_line":"-------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa32b979_2b00de65","line":61,"updated":"2015-06-28 07:18:36.000000000","message":"create and delete user misses information about including cluster information as argument.","commit_id":"ec020f3e0c9cba68bd1a860851dc9ddf0089062b"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"1c82f94c782e2f1787b1e11536cdde105f8c9bff","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"None"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Public API"},{"line_number":74,"context_line":"----------"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Request::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a50d1a3_04b47332","line":73,"updated":"2015-07-23 03:15:04.000000000","message":"For each request in your public API, it would help if you provided a one line description of the intended purpose.","commit_id":"ec020f3e0c9cba68bd1a860851dc9ddf0089062b"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"a14a7a9fdd35a38df226645573a129dc9e9c8427","unresolved":false,"context_lines":[{"line_number":74,"context_line":"----------"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Request::"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    POST /v1.0/​{tenantId}​/clusters/{clusterID}/users"},{"line_number":79,"context_line":"    {"},{"line_number":80,"context_line":"        \"users\": ["}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a41bdd9_ce19187b","line":77,"updated":"2015-07-14 11:30:30.000000000","message":"Can you also include the purpose/heading for each of these api requests. For example, creating users, delete user, etc.","commit_id":"ec020f3e0c9cba68bd1a860851dc9ddf0089062b"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"1c82f94c782e2f1787b1e11536cdde105f8c9bff","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Request::"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    POST /v1.0/​{tenantId}​/clusters/{clusterID}/users"},{"line_number":79,"context_line":"    {"},{"line_number":80,"context_line":"        \"users\": ["},{"line_number":81,"context_line":"            {"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a50d1a3_641f775b","line":78,"updated":"2015-07-23 03:15:04.000000000","message":"The current User API (for instances) provides a data packet that is subtly different from this. Could we use that structure?\n\nOr if we cannot, why not? A clarification of that would be useful.","commit_id":"ec020f3e0c9cba68bd1a860851dc9ddf0089062b"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"1c82f94c782e2f1787b1e11536cdde105f8c9bff","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        ]"},{"line_number":103,"context_line":"    }"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Response::"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"     {"},{"line_number":108,"context_line":"        “users”: ["}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a50d1a3_c453eb15","line":105,"updated":"2015-07-23 03:15:04.000000000","message":"Why don\u0027t we follow the same construct as the user create API which returns a 202.\n\nWhich brings me to the next question; what are the response codes?","commit_id":"ec020f3e0c9cba68bd1a860851dc9ddf0089062b"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"1c82f94c782e2f1787b1e11536cdde105f8c9bff","unresolved":false,"context_lines":[{"line_number":105,"context_line":"Response::"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"     {"},{"line_number":108,"context_line":"        “users”: ["},{"line_number":109,"context_line":"            {"},{"line_number":110,"context_line":"                 “created” : “2015-01-29T20:18:23”,"},{"line_number":111,"context_line":"                 \"databases\": ["}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a50d1a3_84596337","line":108,"updated":"2015-07-23 03:15:04.000000000","message":"I would request that this; consistent with instance user API, return nothing.","commit_id":"ec020f3e0c9cba68bd1a860851dc9ddf0089062b"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"f9b8d2c16e12ad01f40fbb090f2a2eb99cbfd1df","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                    }"},{"line_number":128,"context_line":"                ],"},{"line_number":129,"context_line":"                \"name\": \"dbuser4\","},{"line_number":130,"context_line":"                \"password\": \"secretsecret\""},{"line_number":131,"context_line":"            }"},{"line_number":132,"context_line":"        ]"},{"line_number":133,"context_line":"    }"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa32b979_4b11a2ae","line":130,"updated":"2015-06-28 07:18:36.000000000","message":"are you sure about this response that you would be returning all this information about created user, if yes then shall we re-think to mask the password or not reveal that.","commit_id":"ec020f3e0c9cba68bd1a860851dc9ddf0089062b"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"a14a7a9fdd35a38df226645573a129dc9e9c8427","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                    }"},{"line_number":128,"context_line":"                ],"},{"line_number":129,"context_line":"                \"name\": \"dbuser4\","},{"line_number":130,"context_line":"                \"password\": \"secretsecret\""},{"line_number":131,"context_line":"            }"},{"line_number":132,"context_line":"        ]"},{"line_number":133,"context_line":"    }"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a41bdd9_7ac8c722","line":130,"in_reply_to":"ba3cc151_30e5d408","updated":"2015-07-14 11:30:30.000000000","message":"+1. i agree we shouldnt be including the password in the response.","commit_id":"ec020f3e0c9cba68bd1a860851dc9ddf0089062b"},{"author":{"_account_id":1976,"name":"Jonathan Halterman","email":"jhalterman@hp.com","username":"jhalterman"},"change_message_id":"bba7276db4e186c7e57eb61432813dd6c021f797","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                    }"},{"line_number":128,"context_line":"                ],"},{"line_number":129,"context_line":"                \"name\": \"dbuser4\","},{"line_number":130,"context_line":"                \"password\": \"secretsecret\""},{"line_number":131,"context_line":"            }"},{"line_number":132,"context_line":"        ]"},{"line_number":133,"context_line":"    }"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba3cc151_30e5d408","line":130,"in_reply_to":"fa32b979_4b11a2ae","updated":"2015-06-29 18:06:41.000000000","message":"We may want to exclude the password from the response? There is a precedent here though, where root-enable returns a password in a response.","commit_id":"ec020f3e0c9cba68bd1a860851dc9ddf0089062b"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"a14a7a9fdd35a38df226645573a129dc9e9c8427","unresolved":false,"context_lines":[{"line_number":135,"context_line":"Request::"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    GET /v1.0/​{tenantId}​/clusters/​{clusterId}​/users"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Response::"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a41bdd9_ae2134fd","line":138,"updated":"2015-07-14 11:30:30.000000000","message":"what about the api for user_show? I am assuming this is the API for user_list","commit_id":"ec020f3e0c9cba68bd1a860851dc9ddf0089062b"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"1c82f94c782e2f1787b1e11536cdde105f8c9bff","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    GET /v1.0/​{tenantId}​/clusters/​{clusterId}​/users"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Response::"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    {"},{"line_number":143,"context_line":"        \"users\": ["}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a50d1a3_a477bf9e","line":140,"updated":"2015-07-23 03:15:04.000000000","message":"Codes?\n\nWhy is format different from instance users?","commit_id":"ec020f3e0c9cba68bd1a860851dc9ddf0089062b"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"1c82f94c782e2f1787b1e11536cdde105f8c9bff","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        ]"},{"line_number":164,"context_line":"    }"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Request::"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    PUT /v1.0/​{tenantId}​/clusters{clusterID}/users"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a50d1a3_a49edfb6","line":166,"updated":"2015-07-23 03:15:04.000000000","message":"The instance users API seems to manage just fine without a PUT; why do we need one?","commit_id":"ec020f3e0c9cba68bd1a860851dc9ddf0089062b"},{"author":{"_account_id":14009,"name":"Dan Ritchie","email":"dan.ritchie@hp.com","username":"danr"},"change_message_id":"c6ba3d5049e0f87523f6ad5a47ae682f6a22e904","unresolved":false,"context_lines":[{"line_number":166,"context_line":"Request::"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    PUT /v1.0/​{tenantId}​/clusters{clusterID}/users"},{"line_number":170,"context_line":"    {"},{"line_number":171,"context_line":"        \"users\": ["},{"line_number":172,"context_line":"            {"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa32b979_5ef0ff66","line":169,"updated":"2015-06-24 22:20:14.000000000","message":"This URI should include a user ID according to proposed change #3 above, and take a single user int he payload, not a collection.","commit_id":"ec020f3e0c9cba68bd1a860851dc9ddf0089062b"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"f9b8d2c16e12ad01f40fbb090f2a2eb99cbfd1df","unresolved":false,"context_lines":[{"line_number":166,"context_line":"Request::"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    PUT /v1.0/​{tenantId}​/clusters{clusterID}/users"},{"line_number":170,"context_line":"    {"},{"line_number":171,"context_line":"        \"users\": ["},{"line_number":172,"context_line":"            {"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa32b979_0b0b9a7e","line":169,"updated":"2015-06-28 07:18:36.000000000","message":"it should be \n\nPUT /v1.0/​{tenantId}​/clusters/{clusterID}/users/{user-name}\n\nit would be probably name as we can identify db users by their name and do not have their IDs.\n\nI agree to Dan, you should cater to only one user in case of updations.","commit_id":"ec020f3e0c9cba68bd1a860851dc9ddf0089062b"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"9be1cd5921be833f5d2cf46bcf5c9ebea2c84e8a","unresolved":false,"context_lines":[{"line_number":166,"context_line":"Request::"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    PUT /v1.0/​{tenantId}​/clusters{clusterID}/users"},{"line_number":170,"context_line":"    {"},{"line_number":171,"context_line":"        \"users\": ["},{"line_number":172,"context_line":"            {"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa32b979_3c4cf1c7","line":169,"in_reply_to":"fa32b979_1c024d0a","updated":"2015-06-25 21:16:22.000000000","message":"nit: you are missing / between clusters and {clusterID}","commit_id":"ec020f3e0c9cba68bd1a860851dc9ddf0089062b"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"1c82f94c782e2f1787b1e11536cdde105f8c9bff","unresolved":false,"context_lines":[{"line_number":166,"context_line":"Request::"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    PUT /v1.0/​{tenantId}​/clusters{clusterID}/users"},{"line_number":170,"context_line":"    {"},{"line_number":171,"context_line":"        \"users\": ["},{"line_number":172,"context_line":"            {"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a50d1a3_c4a1abf9","line":169,"in_reply_to":"fa32b979_3c4cf1c7","updated":"2015-07-23 03:15:04.000000000","message":"yup","commit_id":"ec020f3e0c9cba68bd1a860851dc9ddf0089062b"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"93c5faebe8d880bb879370d23dcafb96b00bebeb","unresolved":false,"context_lines":[{"line_number":166,"context_line":"Request::"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    PUT /v1.0/​{tenantId}​/clusters{clusterID}/users"},{"line_number":170,"context_line":"    {"},{"line_number":171,"context_line":"        \"users\": ["},{"line_number":172,"context_line":"            {"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa32b979_1c024d0a","line":169,"in_reply_to":"fa32b979_5ef0ff66","updated":"2015-06-25 20:56:39.000000000","message":"I think this should follow the PUT for /users/id (\u0027update\u0027 a single) or PUT for /users (\u0027update_all\u0027 collection of updates) we have for instances if we are using the same cli calls as well.\n\nhttps://github.com/openstack/trove/blob/master/trove/extensions/routes/mysql.py#L52-59","commit_id":"ec020f3e0c9cba68bd1a860851dc9ddf0089062b"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"f9b8d2c16e12ad01f40fbb090f2a2eb99cbfd1df","unresolved":false,"context_lines":[{"line_number":229,"context_line":"    DELETE /v1.0/​{accountId}​/clusters/​{clusterId}​/users/​{name}​"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"This operation has no response body"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"Public API Security"},{"line_number":234,"context_line":"-------------------"},{"line_number":235,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa32b979_2b853ece","line":232,"updated":"2015-06-28 07:18:36.000000000","message":"You are missing on listing the response codes.","commit_id":"ec020f3e0c9cba68bd1a860851dc9ddf0089062b"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"a14a7a9fdd35a38df226645573a129dc9e9c8427","unresolved":false,"context_lines":[{"line_number":229,"context_line":"    DELETE /v1.0/​{accountId}​/clusters/​{clusterId}​/users/​{name}​"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"This operation has no response body"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"Public API Security"},{"line_number":234,"context_line":"-------------------"},{"line_number":235,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a41bdd9_ae1b741a","line":232,"in_reply_to":"fa32b979_2b853ece","updated":"2015-07-14 11:30:30.000000000","message":"+1. What will be the response code when trying to delete users that dont exist. For that matter you havent included the response code in any of the above APIs","commit_id":"ec020f3e0c9cba68bd1a860851dc9ddf0089062b"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"f9b8d2c16e12ad01f40fbb090f2a2eb99cbfd1df","unresolved":false,"context_lines":[{"line_number":246,"context_line":"We need to modify the python-troveclient in order to get the user list,"},{"line_number":247,"context_line":"create user, delete user, etc. Currently, the positional argument: ID or"},{"line_number":248,"context_line":"name of the instance needs to be modified to ID or name"},{"line_number":249,"context_line":"of the instance or cluster."},{"line_number":250,"context_line":"- user-create                   Creates a user on an instance or a cluster."},{"line_number":251,"context_line":"- user-delete                   Deletes a user from an instance or a cluster."},{"line_number":252,"context_line":"- user-list                     Lists the users for an instance or a cluster."}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa32b979_2b5c5e7c","line":249,"updated":"2015-06-28 07:18:36.000000000","message":"I doubt on usage of same function for cluster and instance without the usage of any extra argument to specify that we want execution for cluster.\n\nThe simple case, as an example, could be where we have a same name cluster and instance existing.","commit_id":"ec020f3e0c9cba68bd1a860851dc9ddf0089062b"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"a14a7a9fdd35a38df226645573a129dc9e9c8427","unresolved":false,"context_lines":[{"line_number":284,"context_line":"Milestones"},{"line_number":285,"context_line":"----------"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"Target Milestone for completion: Liberty-1"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"Work Items"},{"line_number":290,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a41bdd9_cea9187d","line":287,"updated":"2015-07-14 11:30:30.000000000","message":"might need to update this","commit_id":"ec020f3e0c9cba68bd1a860851dc9ddf0089062b"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"f9b8d2c16e12ad01f40fbb090f2a2eb99cbfd1df","unresolved":false,"context_lines":[{"line_number":307,"context_line":"Testing"},{"line_number":308,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"Unittests will be added to validate implemented functions."},{"line_number":311,"context_line":""},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa32b979_8b4d6ac6","line":310,"updated":"2015-06-28 07:18:36.000000000","message":"Since we have Vertica integration tests too in the system now.\n\nWe should also aim to add integrate tests for the feature.","commit_id":"ec020f3e0c9cba68bd1a860851dc9ddf0089062b"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"f9b8d2c16e12ad01f40fbb090f2a2eb99cbfd1df","unresolved":false,"context_lines":[{"line_number":313,"context_line":"Documentation Impact"},{"line_number":314,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"None"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"References"},{"line_number":319,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa32b979_6bc90625","line":316,"updated":"2015-06-28 07:18:36.000000000","message":"This of-course should need a docimpact as you are adding new APIs","commit_id":"ec020f3e0c9cba68bd1a860851dc9ddf0089062b"}]}