)]}'
{"specs/liberty/cluster-scaling.rst":[{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"b337141a025cc352818047c8c0da613c6920f8ac","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        \"grow\": ["},{"line_number":73,"context_line":"          {"},{"line_number":74,"context_line":"            \"name\": \"redis-clstr-member-5\","},{"line_number":75,"context_line":"\t    \"instance_type\": \"master\","},{"line_number":76,"context_line":"            \"flavorRef\": \"2\","},{"line_number":77,"context_line":"            \"volume\": {"},{"line_number":78,"context_line":"              \"size\": 2"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_00eb82b1","line":75,"updated":"2015-06-15 19:02:29.000000000","message":"there is a tab at the beginning of the line","commit_id":"cafac63bb07d92783efc68a256cf1dd3865467c3"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"b337141a025cc352818047c8c0da613c6920f8ac","unresolved":false,"context_lines":[{"line_number":80,"context_line":"          },"},{"line_number":81,"context_line":"          {"},{"line_number":82,"context_line":"            \"name\": \"redis-clstr-member-6\","},{"line_number":83,"context_line":"\t    \"instance_type\": \"slave\","},{"line_number":84,"context_line":"\t    \"related_to\": \"redis-clstr-member-5\","},{"line_number":85,"context_line":"            \"flavorRef\": \"2\","},{"line_number":86,"context_line":"            \"volume\": {"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_a0d2d6fe","line":83,"updated":"2015-06-15 19:02:29.000000000","message":"there is a tab at the beginning of the line","commit_id":"cafac63bb07d92783efc68a256cf1dd3865467c3"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"b337141a025cc352818047c8c0da613c6920f8ac","unresolved":false,"context_lines":[{"line_number":81,"context_line":"          {"},{"line_number":82,"context_line":"            \"name\": \"redis-clstr-member-6\","},{"line_number":83,"context_line":"\t    \"instance_type\": \"slave\","},{"line_number":84,"context_line":"\t    \"related_to\": \"redis-clstr-member-5\","},{"line_number":85,"context_line":"            \"flavorRef\": \"2\","},{"line_number":86,"context_line":"            \"volume\": {"},{"line_number":87,"context_line":"              \"size\": 2"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_60dcce12","line":84,"updated":"2015-06-15 19:02:29.000000000","message":"there is a tab at the beginning of the line","commit_id":"cafac63bb07d92783efc68a256cf1dd3865467c3"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"b337141a025cc352818047c8c0da613c6920f8ac","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        \"\"\"Grow the specified cluster."},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        :param cluster: The cluster to grow"},{"line_number":214,"context_line":"\t:param instances: JSON describing instances to add"},{"line_number":215,"context_line":"        \"\"\""},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    def shrink(self, cluster, instances)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_00394241","line":214,"updated":"2015-06-15 19:02:29.000000000","message":"there is a tab at the beginning of the line","commit_id":"cafac63bb07d92783efc68a256cf1dd3865467c3"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"b337141a025cc352818047c8c0da613c6920f8ac","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        \"\"\"Shrink the specified cluster."},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        :param cluster: The cluster to shrink"},{"line_number":221,"context_line":"\t:param instances: JSON describing instances to remove"},{"line_number":222,"context_line":"        \"\"\""},{"line_number":223,"context_line":""},{"line_number":224,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_604a8ec7","line":221,"updated":"2015-06-15 19:02:29.000000000","message":"there is a tab at the beginning of the line","commit_id":"cafac63bb07d92783efc68a256cf1dd3865467c3"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"b337141a025cc352818047c8c0da613c6920f8ac","unresolved":false,"context_lines":[{"line_number":233,"context_line":""},{"line_number":234,"context_line":"::"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    $ trove cluster-grow mycluster --instance flavor\u003d7,name\u003dnewnode,count\u003d2"},{"line_number":237,"context_line":"    \u003cexample output to follow\u003e"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    --instance parameter may be specified multiple times."}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa32b979_60592e5a","line":236,"updated":"2015-06-15 19:02:29.000000000","message":"Just to clarify - can you specify volume size with a volume\u003dXX option?","commit_id":"cafac63bb07d92783efc68a256cf1dd3865467c3"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"49e83056eb8249fe6c6c5fa8cb421b5dd800ba3a","unresolved":false,"context_lines":[{"line_number":179,"context_line":"HTTP codes::"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    202 - Accepted."},{"line_number":182,"context_line":"    404 - Not found"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"Configuration"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_5b66bb51","line":182,"updated":"2015-06-18 21:10:16.000000000","message":"I think this should have something like \"Instance (id) not found.\"","commit_id":"d20b4b89099314bf43c3f3da436a79deb2437ee7"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"01fd2ef1edb2a7c311d39f815c89b11de347d216","unresolved":false,"context_lines":[{"line_number":179,"context_line":"HTTP codes::"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    202 - Accepted."},{"line_number":182,"context_line":"    404 - Not found"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"Configuration"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_281a2118","line":182,"in_reply_to":"fa32b979_5b66bb51","updated":"2015-06-22 15:05:17.000000000","message":"Done","commit_id":"d20b4b89099314bf43c3f3da436a79deb2437ee7"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"4b1a3d095ac56c0369e5db52bbaf15b55cfb0809","unresolved":false,"context_lines":[{"line_number":63,"context_line":":related_to: Defines a relationship from one member to another.  The"},{"line_number":64,"context_line":"             value is datastore specific, but will likely refer to the"},{"line_number":65,"context_line":"             name of a previously defined instance in the same ReST"},{"line_number":66,"context_line":"             payload."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Request::"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_5d0b5e2a","line":66,"updated":"2015-06-23 22:49:38.000000000","message":"what do you think about maybe making this parameter in a \u0027data-bag\u0027? \n\nThe only reason i might point this out is that its datastore specific and could be a set of parameters that we may need to set. Trying to think of a good example of this is escaping me atm but would like to hear another opinion one way or another.\n\nOn the other side since each dictionary in the \"grow\" list is not exactly an instance object but similar to an instance we could expand this to what other datastores may need. \n\nWith that being said i think it makes sense to keep the object as close to an instance object as possible so that its consistent with the rest of the api.","commit_id":"d522ee0b938eb163ede102f9a13e0fe4d3852c2c"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"4b1a3d095ac56c0369e5db52bbaf15b55cfb0809","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    400 - BadRequest. Server could not understand request."},{"line_number":153,"context_line":"    403 - Forbidden. Local storage not specified in flavor ID: \u003cID\u003e."},{"line_number":154,"context_line":"    403 - Forbidden. A flavor is required for each instance in the cluster."},{"line_number":155,"context_line":"    404 - Not Found. Flavor not found."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"cluster-shrink"},{"line_number":158,"context_line":"//////////////"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_7b550ac0","line":155,"updated":"2015-06-23 22:49:38.000000000","message":"Possible other errors:\n\n* Cluster id not found.\n* related instance not found.","commit_id":"d522ee0b938eb163ede102f9a13e0fe4d3852c2c"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"4b1a3d095ac56c0369e5db52bbaf15b55cfb0809","unresolved":false,"context_lines":[{"line_number":179,"context_line":"HTTP codes::"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    202 - Accepted."},{"line_number":182,"context_line":"    404 - Instance \u003cinstance_id\u003e not found."},{"line_number":183,"context_line":""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"Configuration"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_db0bf6d4","line":182,"updated":"2015-06-23 22:49:38.000000000","message":"* instance \u003cid\u003e not found in cluster \u003cid\u003e i think might be a better error message.\n* cluster not found","commit_id":"d522ee0b938eb163ede102f9a13e0fe4d3852c2c"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"4b1a3d095ac56c0369e5db52bbaf15b55cfb0809","unresolved":false,"context_lines":[{"line_number":198,"context_line":"----------"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"Does this change any API that an end-user has access to?"},{"line_number":201,"context_line":"Are there any exceptions in terms of consistency with other APIs?"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"Public API Security"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_1bfe3eae","line":201,"updated":"2015-06-23 22:49:38.000000000","message":"Can you answer these questions?","commit_id":"d522ee0b938eb163ede102f9a13e0fe4d3852c2c"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"4b1a3d095ac56c0369e5db52bbaf15b55cfb0809","unresolved":false,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":"::"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    $ trove cluster-grow mycluster --instance flavor\u003d7,name\u003dnewnode,count\u003d2"},{"line_number":245,"context_line":"    \u003cexample output to follow\u003e"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    --instance parameter may be specified multiple times."}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_fbc59a5b","line":244,"updated":"2015-06-23 22:49:38.000000000","message":"`mycluster` as the name is great but the cluster id should also be a documented option on the cli.","commit_id":"d522ee0b938eb163ede102f9a13e0fe4d3852c2c"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"4b1a3d095ac56c0369e5db52bbaf15b55cfb0809","unresolved":false,"context_lines":[{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    Use the count option to have multiple instances created with the same"},{"line_number":250,"context_line":"    flavor.  If a count greater than one is specified, an instance count"},{"line_number":251,"context_line":"    will be appended to the specified name (ex., newnode-1, newnode-2)."},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"Add Master and Slave"},{"line_number":254,"context_line":"++++++++++++++++++++"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_5b94c641","line":251,"updated":"2015-06-23 22:49:38.000000000","message":"i like the count option idea! That will be REALLY useful.","commit_id":"d522ee0b938eb163ede102f9a13e0fe4d3852c2c"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"4b1a3d095ac56c0369e5db52bbaf15b55cfb0809","unresolved":false,"context_lines":[{"line_number":313,"context_line":"  \u003claunchpad-id or None\u003e"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"Can list additional ids if they intend on doing substantial implementation work"},{"line_number":316,"context_line":"on this spec."},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"Milestones"},{"line_number":319,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_5bafe629","line":316,"updated":"2015-06-23 22:49:38.000000000","message":"please fill in this info. If its TBD i\u0027d like to see that stated as well.","commit_id":"d522ee0b938eb163ede102f9a13e0fe4d3852c2c"},{"author":{"_account_id":13355,"name":"Edmond Kotowski","email":"ekotowski@gmail.com","username":"ekotowski"},"change_message_id":"4b0a1e230da5aec418d71647cacaed93036ec7ca","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":":name: Name to assign to the instance"},{"line_number":62,"context_line":":data-bag: Datastore specific options."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Request::"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    POST /v1.0/\u003ctenant_id\u003e/clusters/\u003ccluster-id\u003e/action"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_6ecb3f73","line":63,"updated":"2015-06-30 21:42:03.000000000","message":"I don\u0027t see a data-bag example here. Are we proposing that each element in grow will now have dynamic keys and values based upon the type of cluster?","commit_id":"0b584925816408c99ea116ab1689bde21abd9d35"},{"author":{"_account_id":13355,"name":"Edmond Kotowski","email":"ekotowski@gmail.com","username":"ekotowski"},"change_message_id":"b2007f4979d012d9717d9c08c27f8d6c421ca071","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":":name: Name to assign to the instance"},{"line_number":62,"context_line":":data-bag: Datastore specific options."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Request::"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    POST /v1.0/\u003ctenant_id\u003e/clusters/\u003ccluster-id\u003e/action"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_eee18fd1","line":63,"in_reply_to":"ba3cc151_6ecb3f73","updated":"2015-06-30 21:43:43.000000000","message":"The whole payload of actions are essentially databags already? Are you  basically stating that flavorRef and volume and just custom values here and can differ per datastore?","commit_id":"0b584925816408c99ea116ab1689bde21abd9d35"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"8e435882c9a3c262f2a5869bea80f1a4d7b254f1","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":":name: Name to assign to the instance"},{"line_number":62,"context_line":":data-bag: Datastore specific options."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Request::"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    POST /v1.0/\u003ctenant_id\u003e/clusters/\u003ccluster-id\u003e/action"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_e65e8c11","line":63,"in_reply_to":"ba3cc151_eee18fd1","updated":"2015-07-01 03:16:17.000000000","message":"i made the comment if a few of the fields should be in some type of a bag... I think after talking about this its a bad idea. I like the way you had it before with the related_to and instance_type at the same level as the name of the instance.","commit_id":"0b584925816408c99ea116ab1689bde21abd9d35"},{"author":{"_account_id":13355,"name":"Edmond Kotowski","email":"ekotowski@gmail.com","username":"ekotowski"},"change_message_id":"4b0a1e230da5aec418d71647cacaed93036ec7ca","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            \"id\": \"965ef811-7c1d-47fc-89f2-a89dfdd23ef2\","},{"line_number":123,"context_line":"            \"name\": \"redis-clstr-member-6\","},{"line_number":124,"context_line":"\t    \"instance_type\": \"slave\","},{"line_number":125,"context_line":"\t    \"related_to\": \"redis-clstr-member-5\","},{"line_number":126,"context_line":"            \"status\": \"BUILD\","},{"line_number":127,"context_line":"            \"ip\": [],"},{"line_number":128,"context_line":"            \"links\": [{...}],"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_6e925f59","line":125,"updated":"2015-06-30 21:42:03.000000000","message":"Why would the related_to field still be here as it is not specified anywhere in  your post. This paylouad also refers to things like redis-clstr-member-6 still when your post payload names are now NewInst1 and NewInst2. Can we clean this up so the example is easier to parse?","commit_id":"0b584925816408c99ea116ab1689bde21abd9d35"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"8e435882c9a3c262f2a5869bea80f1a4d7b254f1","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            \"id\": \"965ef811-7c1d-47fc-89f2-a89dfdd23ef2\","},{"line_number":123,"context_line":"            \"name\": \"redis-clstr-member-6\","},{"line_number":124,"context_line":"\t    \"instance_type\": \"slave\","},{"line_number":125,"context_line":"\t    \"related_to\": \"redis-clstr-member-5\","},{"line_number":126,"context_line":"            \"status\": \"BUILD\","},{"line_number":127,"context_line":"            \"ip\": [],"},{"line_number":128,"context_line":"            \"links\": [{...}],"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba3cc151_66a91cdf","line":125,"in_reply_to":"ba3cc151_6e925f59","updated":"2015-07-01 03:16:17.000000000","message":"lets just change the post body and keep the response the same here. I think we chatted about this and morgan, edmond and i are on the same page.","commit_id":"0b584925816408c99ea116ab1689bde21abd9d35"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"d107a706bb6341269d21983e82e3ad35f324485d","unresolved":false,"context_lines":[{"line_number":63,"context_line":":instance_type: Datastore specific type of the instance (eg.,"},{"line_number":64,"context_line":"                query/replica for Mongo, master/slave for Redis)."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":":related_to: Defines a relationship from one member to another.  The"},{"line_number":67,"context_line":"             value is datastore specific, but will likely refer to the"},{"line_number":68,"context_line":"             name of a previously defined instance in the same ReST"},{"line_number":69,"context_line":"             payload."}],"source_content_type":"text/x-rst","patch_set":9,"id":"ba3cc151_7202270b","line":66,"updated":"2015-07-07 23:01:42.000000000","message":"Can you define here, say, two slaves instead of a slave and a master, and relation the two of them to a preexisting master instance?","commit_id":"f566920078ec051e560f652c3c50645d4defc5fb"},{"author":{"_account_id":13355,"name":"Edmond Kotowski","email":"ekotowski@gmail.com","username":"ekotowski"},"change_message_id":"c5ca0407b3090f1b1750133359b805654ccf4c92","unresolved":false,"context_lines":[{"line_number":63,"context_line":":instance_type: Datastore specific type of the instance (eg.,"},{"line_number":64,"context_line":"                query/replica for Mongo, master/slave for Redis)."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":":related_to: Defines a relationship from one member to another.  The"},{"line_number":67,"context_line":"             value is datastore specific, but will likely refer to the"},{"line_number":68,"context_line":"             name of a previously defined instance in the same ReST"},{"line_number":69,"context_line":"             payload."}],"source_content_type":"text/x-rst","patch_set":9,"id":"ba3cc151_fdbb3cc2","line":66,"in_reply_to":"ba3cc151_7202270b","updated":"2015-07-08 18:03:02.000000000","message":"That\u0027s a good question. In datastores where it makes sense I would think that we would be allowed to POST two slaves instances in the payload because we know the cluster ID so it would be assumed to attach to the master. If there wasn\u0027t a master I would think it would raise an exception?","commit_id":"f566920078ec051e560f652c3c50645d4defc5fb"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"4bb8159e836af317f64ba3ee5f4e203149d7104b","unresolved":false,"context_lines":[{"line_number":63,"context_line":":instance_type: Datastore specific type of the instance (eg.,"},{"line_number":64,"context_line":"                query/replica for Mongo, master/slave for Redis)."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":":related_to: Defines a relationship from one member to another.  The"},{"line_number":67,"context_line":"             value is datastore specific, but will likely refer to the"},{"line_number":68,"context_line":"             name of a previously defined instance in the same ReST"},{"line_number":69,"context_line":"             payload."}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a41bdd9_7e221b03","line":66,"in_reply_to":"ba3cc151_7202270b","updated":"2015-07-13 19:14:35.000000000","message":"YEs, the interpretation of the field, and what are acceptable values, will be left up to the datastore.","commit_id":"f566920078ec051e560f652c3c50645d4defc5fb"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"d107a706bb6341269d21983e82e3ad35f324485d","unresolved":false,"context_lines":[{"line_number":161,"context_line":"cluster-shrink"},{"line_number":162,"context_line":"//////////////"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Deletes the specified instances from the cluster."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Request::"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"ba3cc151_5274c39a","line":164,"updated":"2015-07-07 23:01:42.000000000","message":"Can you delete any instance? If it is peer based then I guess its ok, but what if its master/slave and its the only master? Is that controlled somewhere? Perhaps the saner approach is to leave this control to the user.","commit_id":"f566920078ec051e560f652c3c50645d4defc5fb"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"0bf34a046a0198003f874041f8cced087f3d46ce","unresolved":false,"context_lines":[{"line_number":161,"context_line":"cluster-shrink"},{"line_number":162,"context_line":"//////////////"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Deletes the specified instances from the cluster."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Request::"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a41bdd9_bfa3174f","line":164,"in_reply_to":"ba3cc151_11c9b25a","updated":"2015-07-10 22:56:25.000000000","message":"Nevermind a max config for instances doesnt really make sense for some datastores so i think we can leave it out. But going below 1 instance on a cluster still applies.","commit_id":"f566920078ec051e560f652c3c50645d4defc5fb"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"4bb8159e836af317f64ba3ee5f4e203149d7104b","unresolved":false,"context_lines":[{"line_number":161,"context_line":"cluster-shrink"},{"line_number":162,"context_line":"//////////////"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Deletes the specified instances from the cluster."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Request::"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a41bdd9_deeec78a","line":164,"in_reply_to":"ba3cc151_5274c39a","updated":"2015-07-13 19:14:35.000000000","message":"It is up to the datastore to ensure that the operation makes sense.  For example, redis would allow any instance to be deleted provided that there are no slots assigned to it, whereas Mongo *could* require that all the instances in a replica are deleted as a set.","commit_id":"f566920078ec051e560f652c3c50645d4defc5fb"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"ae200dc5facd3c6de322737df5a21c95409a2e84","unresolved":false,"context_lines":[{"line_number":161,"context_line":"cluster-shrink"},{"line_number":162,"context_line":"//////////////"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Deletes the specified instances from the cluster."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Request::"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"ba3cc151_11c9b25a","line":164,"in_reply_to":"ba3cc151_5274c39a","updated":"2015-07-10 16:39:26.000000000","message":"Yeah so i dont think we want to allow someone to delete all the instances in the cluster because then its just a dangling cluster id not doing anything. I think a single node in a cluster should be the smallest you can make a cluster.\n\nAdding an exception Forbidden that doesnt allow someone to shrink the cluster to a size of 0 instances.\n\nSay on the other side of growing a cluster maybe we should have a deployer configuration variable of a max number of instances in a cluster so that it can be controlled but set to a \"high\" max like 20.","commit_id":"f566920078ec051e560f652c3c50645d4defc5fb"}]}