)]}'
{"specs/mitaka/galera-cluster.rst":[{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"8da675fce64a183eb0d2317197b29899fe4009ad","unresolved":false,"context_lines":[{"line_number":53,"context_line":"* The cluster inspection will return IPs of all its nodes in order to"},{"line_number":54,"context_line":"  allow read and write to any node at any time."},{"line_number":55,"context_line":"* The name of each instance will be automatically generated;"},{"line_number":56,"context_line":"  it will be the \u003ccluster_name\u003e-\u003cinstance_num\u003e."},{"line_number":57,"context_line":"* Clusters shall allow the cluster nodes to be resizable for volume"},{"line_number":58,"context_line":"  and flavors."},{"line_number":59,"context_line":"  No validation will occur if a user resizes volumes or flavors"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa69d971_aa723d0f","line":56,"updated":"2016-01-05 20:48:21.000000000","message":"Do you intend to insure this in the context of grow and shrink?  If so, how?  If not, I suggest removing this comment.","commit_id":"7a76e7eeea36c3f439401e4463e0b986e42d7354"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"bed8f72e5dbf14d3031bf23a0fe827309c29e214","unresolved":false,"context_lines":[{"line_number":53,"context_line":"* The cluster inspection will return IPs of all its nodes in order to"},{"line_number":54,"context_line":"  allow read and write to any node at any time."},{"line_number":55,"context_line":"* The name of each instance will be automatically generated;"},{"line_number":56,"context_line":"  it will be the \u003ccluster_name\u003e-\u003cinstance_num\u003e."},{"line_number":57,"context_line":"* Clusters shall allow the cluster nodes to be resizable for volume"},{"line_number":58,"context_line":"  and flavors."},{"line_number":59,"context_line":"  No validation will occur if a user resizes volumes or flavors"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa69d971_962149b7","line":56,"in_reply_to":"fa69d971_53381cef","updated":"2016-01-07 15:54:33.000000000","message":"I think you missed my point.  You state that the name will be \u003ccluster\u003e-\u003cinstance num\u003e, but I don\u0027t think there\u0027s any easy way to guarantee that in the face of grow/shrink.  Other cluster implementations will generate duplicate names in this scenario.  If you don\u0027t intend to guarantee unique names, you should either state so or just say \"names will be automatically generated\" or somesuch.","commit_id":"7a76e7eeea36c3f439401e4463e0b986e42d7354"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"b097b5d3bd741d0d2bbe5da0f3f4a63e7c46464e","unresolved":false,"context_lines":[{"line_number":53,"context_line":"* The cluster inspection will return IPs of all its nodes in order to"},{"line_number":54,"context_line":"  allow read and write to any node at any time."},{"line_number":55,"context_line":"* The name of each instance will be automatically generated;"},{"line_number":56,"context_line":"  it will be the \u003ccluster_name\u003e-\u003cinstance_num\u003e."},{"line_number":57,"context_line":"* Clusters shall allow the cluster nodes to be resizable for volume"},{"line_number":58,"context_line":"  and flavors."},{"line_number":59,"context_line":"  No validation will occur if a user resizes volumes or flavors"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa69d971_53381cef","line":56,"in_reply_to":"fa69d971_aa723d0f","updated":"2016-01-05 22:17:18.000000000","message":"When you create your cluster you don\u0027t specify the name for each of the instances (check API below), it\u0027s generated following the pattern mentioned here. It\u0027s not related to cluster grow/shrink, although it will be useful when that feature is implemented.","commit_id":"7a76e7eeea36c3f439401e4463e0b986e42d7354"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"8da675fce64a183eb0d2317197b29899fe4009ad","unresolved":false,"context_lines":[{"line_number":62,"context_line":"The following will be changed:"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"* Base classes for Percona Cluster and Galera Cluster will be added to"},{"line_number":65,"context_line":"  common/strategies/cluster/experimental/mysql_common/{api,taskmanager,guestagent}.py"},{"line_number":66,"context_line":"* Percona Cluster specialization will live under"},{"line_number":67,"context_line":"  common/strategies/cluster/experimental/pxc/{api,taskmanger,guestagent}.py"},{"line_number":68,"context_line":"  This contains the API, the taskmanager strategy to handle the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa69d971_ed128f56","line":65,"updated":"2016-01-05 20:48:21.000000000","message":"I suggest making the common directory \"galera_common\" as per my comment below.","commit_id":"7a76e7eeea36c3f439401e4463e0b986e42d7354"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"b097b5d3bd741d0d2bbe5da0f3f4a63e7c46464e","unresolved":false,"context_lines":[{"line_number":62,"context_line":"The following will be changed:"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"* Base classes for Percona Cluster and Galera Cluster will be added to"},{"line_number":65,"context_line":"  common/strategies/cluster/experimental/mysql_common/{api,taskmanager,guestagent}.py"},{"line_number":66,"context_line":"* Percona Cluster specialization will live under"},{"line_number":67,"context_line":"  common/strategies/cluster/experimental/pxc/{api,taskmanger,guestagent}.py"},{"line_number":68,"context_line":"  This contains the API, the taskmanager strategy to handle the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa69d971_be74bf67","line":65,"in_reply_to":"fa69d971_ed128f56","updated":"2016-01-05 22:17:18.000000000","message":"Done","commit_id":"7a76e7eeea36c3f439401e4463e0b986e42d7354"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"8da675fce64a183eb0d2317197b29899fe4009ad","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  to handle the cluster provisioning, configuration and execution."},{"line_number":71,"context_line":"* Galera Cluster specialization will be added to"},{"line_number":72,"context_line":"  common/strategies/cluster/experimental/mariadb/{api,taskmanager,guestagent}.py"},{"line_number":73,"context_line":"  This contains the API, the taskmanager strategy to handle the"},{"line_number":74,"context_line":"  cluster provisioning for Galera and the guestagent strategy"},{"line_number":75,"context_line":"  to handle the cluster provisioning, configuration and execution."},{"line_number":76,"context_line":"* Unit and integration tests"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa69d971_6a6a05f0","line":73,"updated":"2016-01-05 20:48:21.000000000","message":"I believe that the Galera cluster is the base Codership implementation, whereas MariaDB has its own Galera implementation.  We may eventually need to support all 3.  I suggest making it clear which version you are supporting.","commit_id":"7a76e7eeea36c3f439401e4463e0b986e42d7354"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"bed8f72e5dbf14d3031bf23a0fe827309c29e214","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  to handle the cluster provisioning, configuration and execution."},{"line_number":71,"context_line":"* Galera Cluster specialization will be added to"},{"line_number":72,"context_line":"  common/strategies/cluster/experimental/mariadb/{api,taskmanager,guestagent}.py"},{"line_number":73,"context_line":"  This contains the API, the taskmanager strategy to handle the"},{"line_number":74,"context_line":"  cluster provisioning for Galera and the guestagent strategy"},{"line_number":75,"context_line":"  to handle the cluster provisioning, configuration and execution."},{"line_number":76,"context_line":"* Unit and integration tests"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa69d971_78192379","line":73,"in_reply_to":"fa69d971_1e5b8bf7","updated":"2016-01-07 15:54:33.000000000","message":"\"mysql_common\" is not the appropriate classifier as there are at least 3 different clustering implementations for mysql.","commit_id":"7a76e7eeea36c3f439401e4463e0b986e42d7354"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"b097b5d3bd741d0d2bbe5da0f3f4a63e7c46464e","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  to handle the cluster provisioning, configuration and execution."},{"line_number":71,"context_line":"* Galera Cluster specialization will be added to"},{"line_number":72,"context_line":"  common/strategies/cluster/experimental/mariadb/{api,taskmanager,guestagent}.py"},{"line_number":73,"context_line":"  This contains the API, the taskmanager strategy to handle the"},{"line_number":74,"context_line":"  cluster provisioning for Galera and the guestagent strategy"},{"line_number":75,"context_line":"  to handle the cluster provisioning, configuration and execution."},{"line_number":76,"context_line":"* Unit and integration tests"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa69d971_1e5b8bf7","line":73,"in_reply_to":"fa69d971_6a6a05f0","updated":"2016-01-05 22:17:18.000000000","message":"I\u0027ll be implementing Galera clustering strategy for MariaDB, or in other words, MariaDB Galera Cluster.\nAFAIK the three versions are:\nMariaDB Galera Cluster -\u003e MariaDB Server + Galera library (this spec)\nPercona XtraDB Cluster -\u003e Percona Server + Galera library (implemented by cp16net)\nGalera Cluster -\u003e MySQL Server + Galera library. (future spec)\n\nAs we did in the guestagent, I grouped SQL stores under \"mysql_common\". Basically that contains common code for MySQL and it forks, MariaDB and Percona. So I wanted to keep consistent with that approach.\n\nWhen the moment comes and we implement Galera Cluster, I expect we implement that under common/strategies/cluster/experimental/mysql.\n\nI think your comment makes sense though, since all three use Galera library and so much mysql overuse may cause confusion, so I\u0027ll make that change.","commit_id":"7a76e7eeea36c3f439401e4463e0b986e42d7354"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"8da675fce64a183eb0d2317197b29899fe4009ad","unresolved":false,"context_lines":[{"line_number":410,"context_line":"    Optional arguments:"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"      --instance \u003cflavor_id\u003dflavor_id,volume\u003dvolume,parameters\u003d\u003ckey\u003dvalue\u003e\u003e"},{"line_number":413,"context_line":"                            Create an instance for the cluster. Specify"},{"line_number":414,"context_line":"                            multiple times to create multiple instances."},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"Request::"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa69d971_aa531d38","line":413,"updated":"2016-01-05 20:48:21.000000000","message":"I don\u0027t think \"parameters\" was implemented for pxc, so there should be no need to implement it here.","commit_id":"7a76e7eeea36c3f439401e4463e0b986e42d7354"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"b097b5d3bd741d0d2bbe5da0f3f4a63e7c46464e","unresolved":false,"context_lines":[{"line_number":410,"context_line":"    Optional arguments:"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"      --instance \u003cflavor_id\u003dflavor_id,volume\u003dvolume,parameters\u003d\u003ckey\u003dvalue\u003e\u003e"},{"line_number":413,"context_line":"                            Create an instance for the cluster. Specify"},{"line_number":414,"context_line":"                            multiple times to create multiple instances."},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"Request::"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa69d971_7e6ac782","line":413,"in_reply_to":"fa69d971_aa531d38","updated":"2016-01-05 22:17:18.000000000","message":"Done","commit_id":"7a76e7eeea36c3f439401e4463e0b986e42d7354"}],"specs/mitaka/mariadb-clustering.rst":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"f3b3ce364bfeb125946770ec1f4e3b707dd0e297","unresolved":false,"context_lines":[{"line_number":277,"context_line":"          \"type\": \"mariadb\","},{"line_number":278,"context_line":"          \"version\": \"10\""},{"line_number":279,"context_line":"        },"},{"line_number":280,"context_line":"        \"ip\": [\"10.0.0.1\"],"},{"line_number":281,"context_line":"        \"flavor\": {"},{"line_number":282,"context_line":"          \"id\": \"7\","},{"line_number":283,"context_line":"          \"links\": [{...}],"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a5ae5dd_86a0e444","line":280,"range":{"start_line":280,"start_character":15,"end_line":280,"end_character":25},"updated":"2016-02-04 15:43:05.000000000","message":"Should this be a list?  It\u0027s a single instance in the cluster-show command ...","commit_id":"a9f74768cc2e45b18b0f4bc5f963739d184174ab"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"f3b3ce364bfeb125946770ec1f4e3b707dd0e297","unresolved":false,"context_lines":[{"line_number":435,"context_line":"    +-------------------+--------------------------------------+"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"The cluster-create command will create a cluster with identical instances."},{"line_number":438,"context_line":"Trove will choose a instance to start with the --wsrep-new-cluster option,"},{"line_number":439,"context_line":"then the remaining instances will be started sequentially."},{"line_number":440,"context_line":"The cluster will be marked ACTIVE when all instances have started and"},{"line_number":441,"context_line":"the database is available for use."}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a5ae5dd_e64e7895","line":438,"range":{"start_line":438,"start_character":18,"end_line":438,"end_character":19},"updated":"2016-02-04 15:43:05.000000000","message":"\u0027an\u0027","commit_id":"a9f74768cc2e45b18b0f4bc5f963739d184174ab"}]}