)]}'
{"specs/mitaka/pxc-root-enable.rst":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"d4cb574fbd843017cff8548a3b873fb2cb394074","unresolved":false,"context_lines":[{"line_number":42,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"PXC is lacking support for root enable cluster. This will allow a user"},{"line_number":45,"context_line":"to create a create a root user and either give a new random password or set"},{"line_number":46,"context_line":"the given password for the root user across the cluster."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Proposed Change"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da6ed579_7aa613af","line":45,"updated":"2016-01-15 17:13:15.000000000","message":"NIT. Remove \u0027a create\u0027","commit_id":"185c59df2fdf9ae16f63faf721453888b3ee7498"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"7bd3cbb599016e6c8200472f76dae4f70c0f2731","unresolved":false,"context_lines":[{"line_number":42,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"PXC is lacking support for root enable cluster. This will allow a user"},{"line_number":45,"context_line":"to create a create a root user and either give a new random password or set"},{"line_number":46,"context_line":"the given password for the root user across the cluster."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Proposed Change"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da6ed579_accd2bb9","line":45,"in_reply_to":"da6ed579_7aa613af","updated":"2016-01-15 19:50:33.000000000","message":"Done","commit_id":"185c59df2fdf9ae16f63faf721453888b3ee7498"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"d4cb574fbd843017cff8548a3b873fb2cb394074","unresolved":false,"context_lines":[{"line_number":49,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"PXC will use the existing root enable API call. This change will allow the"},{"line_number":52,"context_line":"cluster to enable root with from a cluster. The call will apply the root"},{"line_number":53,"context_line":"user and password to a single node in the cluster and since the cluster"},{"line_number":54,"context_line":"replicates to the other nodes they will get the same root user and password"},{"line_number":55,"context_line":"set."}],"source_content_type":"text/x-rst","patch_set":3,"id":"da6ed579_5abeafae","line":52,"updated":"2016-01-15 17:13:15.000000000","message":"NIT. \u0027... to enable root within a cluster\u0027","commit_id":"185c59df2fdf9ae16f63faf721453888b3ee7498"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"7bd3cbb599016e6c8200472f76dae4f70c0f2731","unresolved":false,"context_lines":[{"line_number":49,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"PXC will use the existing root enable API call. This change will allow the"},{"line_number":52,"context_line":"cluster to enable root with from a cluster. The call will apply the root"},{"line_number":53,"context_line":"user and password to a single node in the cluster and since the cluster"},{"line_number":54,"context_line":"replicates to the other nodes they will get the same root user and password"},{"line_number":55,"context_line":"set."}],"source_content_type":"text/x-rst","patch_set":3,"id":"da6ed579_4cc34f8b","line":52,"in_reply_to":"da6ed579_5abeafae","updated":"2016-01-15 19:50:33.000000000","message":"Done","commit_id":"185c59df2fdf9ae16f63faf721453888b3ee7498"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"d4cb574fbd843017cff8548a3b873fb2cb394074","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"PXC will need to extend the existing root enable calls into its clustered"},{"line_number":65,"context_line":"datastore implementation because currently the root enable calls raise an"},{"line_number":66,"context_line":"exception if root enable is called with a cluster because most datastores do"},{"line_number":67,"context_line":"not support this feature. This will require a configuration change for the"},{"line_number":68,"context_line":"guestagent and will be outlined below."},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"da6ed579_ba332b61","line":66,"updated":"2016-01-15 17:13:15.000000000","message":"NIT. s/because/since","commit_id":"185c59df2fdf9ae16f63faf721453888b3ee7498"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"7bd3cbb599016e6c8200472f76dae4f70c0f2731","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"PXC will need to extend the existing root enable calls into its clustered"},{"line_number":65,"context_line":"datastore implementation because currently the root enable calls raise an"},{"line_number":66,"context_line":"exception if root enable is called with a cluster because most datastores do"},{"line_number":67,"context_line":"not support this feature. This will require a configuration change for the"},{"line_number":68,"context_line":"guestagent and will be outlined below."},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"da6ed579_6cc0937d","line":66,"in_reply_to":"da6ed579_ba332b61","updated":"2016-01-15 19:50:33.000000000","message":"Done","commit_id":"185c59df2fdf9ae16f63faf721453888b3ee7498"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"d4cb574fbd843017cff8548a3b873fb2cb394074","unresolved":false,"context_lines":[{"line_number":67,"context_line":"not support this feature. This will require a configuration change for the"},{"line_number":68,"context_line":"guestagent and will be outlined below."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"This change is just adding the existing feature to the PXC datastore not"},{"line_number":71,"context_line":"changing the existing functionality of other datastores. This is not adding"},{"line_number":72,"context_line":"root enabled at cluster create time because that functionality does not"},{"line_number":73,"context_line":"currently exist in the api for cluster create."}],"source_content_type":"text/x-rst","patch_set":3,"id":"da6ed579_051bf881","line":70,"updated":"2016-01-15 17:13:15.000000000","message":"NIT. s/is just/only involves","commit_id":"185c59df2fdf9ae16f63faf721453888b3ee7498"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"7bd3cbb599016e6c8200472f76dae4f70c0f2731","unresolved":false,"context_lines":[{"line_number":67,"context_line":"not support this feature. This will require a configuration change for the"},{"line_number":68,"context_line":"guestagent and will be outlined below."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"This change is just adding the existing feature to the PXC datastore not"},{"line_number":71,"context_line":"changing the existing functionality of other datastores. This is not adding"},{"line_number":72,"context_line":"root enabled at cluster create time because that functionality does not"},{"line_number":73,"context_line":"currently exist in the api for cluster create."}],"source_content_type":"text/x-rst","patch_set":3,"id":"da6ed579_0cbd5702","line":70,"in_reply_to":"da6ed579_051bf881","updated":"2016-01-15 19:50:33.000000000","message":"Done","commit_id":"185c59df2fdf9ae16f63faf721453888b3ee7498"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"d4cb574fbd843017cff8548a3b873fb2cb394074","unresolved":false,"context_lines":[{"line_number":68,"context_line":"guestagent and will be outlined below."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"This change is just adding the existing feature to the PXC datastore not"},{"line_number":71,"context_line":"changing the existing functionality of other datastores. This is not adding"},{"line_number":72,"context_line":"root enabled at cluster create time because that functionality does not"},{"line_number":73,"context_line":"currently exist in the api for cluster create."},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"da6ed579_2005ca0f","line":71,"updated":"2016-01-15 17:13:15.000000000","message":"NIT. s/is not adding/won\u0027t add","commit_id":"185c59df2fdf9ae16f63faf721453888b3ee7498"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"7bd3cbb599016e6c8200472f76dae4f70c0f2731","unresolved":false,"context_lines":[{"line_number":68,"context_line":"guestagent and will be outlined below."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"This change is just adding the existing feature to the PXC datastore not"},{"line_number":71,"context_line":"changing the existing functionality of other datastores. This is not adding"},{"line_number":72,"context_line":"root enabled at cluster create time because that functionality does not"},{"line_number":73,"context_line":"currently exist in the api for cluster create."},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"da6ed579_2cba9b0b","line":71,"in_reply_to":"da6ed579_2005ca0f","updated":"2016-01-15 19:50:33.000000000","message":"Done","commit_id":"185c59df2fdf9ae16f63faf721453888b3ee7498"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"d4cb574fbd843017cff8548a3b873fb2cb394074","unresolved":false,"context_lines":[{"line_number":133,"context_line":"The Vertica datastore already has this feature and much of the code is reusable"},{"line_number":134,"context_line":"so we can move this code to a common location and build off of it."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"* Move the ``trove.extensions.vertica.models.VericaRoot`` class to"},{"line_number":137,"context_line":"  ``trove.extensions.common.models.ClusterRoot``"},{"line_number":138,"context_line":"* Move the ``trove.extensions.vertica.service.VericaRootController`` class to"},{"line_number":139,"context_line":"  ``trove.extensions.common.service.ClusterRootController``"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da6ed579_74eaa7dc","line":136,"updated":"2016-01-15 17:13:15.000000000","message":"NIT. typo s/Verica/Vertica","commit_id":"185c59df2fdf9ae16f63faf721453888b3ee7498"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"7bd3cbb599016e6c8200472f76dae4f70c0f2731","unresolved":false,"context_lines":[{"line_number":133,"context_line":"The Vertica datastore already has this feature and much of the code is reusable"},{"line_number":134,"context_line":"so we can move this code to a common location and build off of it."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"* Move the ``trove.extensions.vertica.models.VericaRoot`` class to"},{"line_number":137,"context_line":"  ``trove.extensions.common.models.ClusterRoot``"},{"line_number":138,"context_line":"* Move the ``trove.extensions.vertica.service.VericaRootController`` class to"},{"line_number":139,"context_line":"  ``trove.extensions.common.service.ClusterRootController``"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da6ed579_8cc867aa","line":136,"in_reply_to":"da6ed579_74eaa7dc","updated":"2016-01-15 19:50:33.000000000","message":"Done","commit_id":"185c59df2fdf9ae16f63faf721453888b3ee7498"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"d4cb574fbd843017cff8548a3b873fb2cb394074","unresolved":false,"context_lines":[{"line_number":148,"context_line":"The PXC guest agent will need the methods to enable root as well with or"},{"line_number":149,"context_line":"without a password. Since this feature didnt exist prior to now we only need"},{"line_number":150,"context_line":"the enable_root_with_password and not the enable_root method in the manager for"},{"line_number":151,"context_line":"PXC."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"* Add the enable_root_with_password method to the pxc manager."},{"line_number":154,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"da6ed579_7470670b","line":151,"updated":"2016-01-15 17:13:15.000000000","message":"I\u0027m not following this. Since you need enable root both with and without a password, why are you implementing enable_root_with_password only? Should you need to implement both?","commit_id":"185c59df2fdf9ae16f63faf721453888b3ee7498"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"7bd3cbb599016e6c8200472f76dae4f70c0f2731","unresolved":false,"context_lines":[{"line_number":148,"context_line":"The PXC guest agent will need the methods to enable root as well with or"},{"line_number":149,"context_line":"without a password. Since this feature didnt exist prior to now we only need"},{"line_number":150,"context_line":"the enable_root_with_password and not the enable_root method in the manager for"},{"line_number":151,"context_line":"PXC."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"* Add the enable_root_with_password method to the pxc manager."},{"line_number":154,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"da6ed579_ecd3235e","line":151,"in_reply_to":"da6ed579_7470670b","updated":"2016-01-15 19:50:33.000000000","message":"No the with_password is the new version of the root enable call. The old version that did not have a password was left for backward compatibility. The one with password allows for password or not.","commit_id":"185c59df2fdf9ae16f63faf721453888b3ee7498"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"8e20b98554a6c0f0bc70352235beff8eecf45b1c","unresolved":false,"context_lines":[{"line_number":148,"context_line":"The PXC guest agent will need the methods to enable root as well with or"},{"line_number":149,"context_line":"without a password. Since this feature didnt exist prior to now we only need"},{"line_number":150,"context_line":"the enable_root_with_password and not the enable_root method in the manager for"},{"line_number":151,"context_line":"PXC."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"* Add the enable_root_with_password method to the pxc manager."},{"line_number":154,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a68dd71_01f22206","line":151,"in_reply_to":"da6ed579_ecd3235e","updated":"2016-01-25 15:40:51.000000000","message":"Could you add this clarification to the spec?","commit_id":"185c59df2fdf9ae16f63faf721453888b3ee7498"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"d4cb574fbd843017cff8548a3b873fb2cb394074","unresolved":false,"context_lines":[{"line_number":193,"context_line":"----------"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"Targeting this for milestone:"},{"line_number":196,"context_line":"Mitaka"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"Work Items"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da6ed579_7442a7af","line":196,"updated":"2016-01-15 17:13:15.000000000","message":"Mitaka-3","commit_id":"185c59df2fdf9ae16f63faf721453888b3ee7498"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"7bd3cbb599016e6c8200472f76dae4f70c0f2731","unresolved":false,"context_lines":[{"line_number":193,"context_line":"----------"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"Targeting this for milestone:"},{"line_number":196,"context_line":"Mitaka"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"Work Items"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da6ed579_cc35ffa8","line":196,"in_reply_to":"da6ed579_7442a7af","updated":"2016-01-15 19:50:33.000000000","message":"Done","commit_id":"185c59df2fdf9ae16f63faf721453888b3ee7498"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"070fc2075be69e52bb72ff6b7a8b0bd0f2e16135","unresolved":false,"context_lines":[{"line_number":28,"context_line":".. contents::"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"For the Percona XtraDB Cluster (PXC) datastore we need the ability to enable"},{"line_number":31,"context_line":"root for a cluster to be able to manage the datastore with a privledged user."},{"line_number":32,"context_line":"For example, in order to integrate a PXC datastore cluster with Cloud Foundry"},{"line_number":33,"context_line":"it requires a root user to automatically manage the database users and"},{"line_number":34,"context_line":"databases on the cluster. This will add root enable to the PXC solution"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a68dd71_b89221f5","line":31,"range":{"start_line":31,"start_character":61,"end_line":31,"end_character":71},"updated":"2016-01-26 18:42:41.000000000","message":"privileged","commit_id":"3770432ded80a2b0ac41fb7a6e893131cf6c9fb5"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"070fc2075be69e52bb72ff6b7a8b0bd0f2e16135","unresolved":false,"context_lines":[{"line_number":103,"context_line":"* Cluster root enable - The existing call payload will not be changed."},{"line_number":104,"context_line":"  Implementing the root enable of a cluster resource will allow a user to"},{"line_number":105,"context_line":"  enable root across all instances in the cluster, as well as allow the user"},{"line_number":106,"context_line":"  to specifiy a password that will be used to enable root on the cluster."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Public API Security"},{"line_number":109,"context_line":"-------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a68dd71_3843916e","line":106,"range":{"start_line":106,"start_character":5,"end_line":106,"end_character":13},"updated":"2016-01-26 18:42:41.000000000","message":"specify","commit_id":"3770432ded80a2b0ac41fb7a6e893131cf6c9fb5"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"070fc2075be69e52bb72ff6b7a8b0bd0f2e16135","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"* ``root-enable`` with or without the --root_password given by user"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"No changes should be nessesary to accomplish these actions."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Internal API"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a68dd71_b880e18c","line":127,"range":{"start_line":127,"start_character":21,"end_line":127,"end_character":30},"updated":"2016-01-26 18:42:41.000000000","message":"necessary","commit_id":"3770432ded80a2b0ac41fb7a6e893131cf6c9fb5"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"070fc2075be69e52bb72ff6b7a8b0bd0f2e16135","unresolved":false,"context_lines":[{"line_number":146,"context_line":"-----------"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"The PXC guest agent will need the methods to enable root as well with or"},{"line_number":149,"context_line":"without a password. Since this feature didnt exist prior to now we only need"},{"line_number":150,"context_line":"the enable_root_with_password and not the enable_root method in the manager for"},{"line_number":151,"context_line":"PXC."},{"line_number":152,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a68dd71_f83e5928","line":149,"range":{"start_line":149,"start_character":39,"end_line":149,"end_character":44},"updated":"2016-01-26 18:42:41.000000000","message":"didn\u0027t","commit_id":"3770432ded80a2b0ac41fb7a6e893131cf6c9fb5"},{"author":{"_account_id":17360,"name":"Ishita Mandhan","email":"imandha@us.ibm.com","username":"imandhan"},"change_message_id":"8726e450556e256accf84c3587eff074a7ff743a","unresolved":false,"context_lines":[{"line_number":208,"context_line":"Upgrade Implications"},{"line_number":209,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Just the common updates since this is a new feature the guestagent will need to"},{"line_number":212,"context_line":"be updated."},{"line_number":213,"context_line":""},{"line_number":214,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a5ae5dd_caf128cf","line":211,"range":{"start_line":211,"start_character":9,"end_line":211,"end_character":23},"updated":"2016-02-04 00:08:06.000000000","message":"can you specify what you meant by that?","commit_id":"4b2c2de09e3ef73130a25b669fd22d333fef12af"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"eaf246ef3b558827f5c72ae0ea4b459d09f9b10c","unresolved":false,"context_lines":[{"line_number":208,"context_line":"Upgrade Implications"},{"line_number":209,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Just the common updates since this is a new feature the guestagent will need to"},{"line_number":212,"context_line":"be updated."},{"line_number":213,"context_line":""},{"line_number":214,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a5ae5dd_28ac51ec","line":211,"range":{"start_line":211,"start_character":9,"end_line":211,"end_character":23},"in_reply_to":"5a5ae5dd_caf128cf","updated":"2016-02-04 19:08:52.000000000","message":"there is really no specific things to be mentioned for this other than update everything so it works. this is what i mean by \"common updates\". nothing special is required.","commit_id":"4b2c2de09e3ef73130a25b669fd22d333fef12af"}]}
