)]}'
{"specs/ocata/data-store-version-cloud-init-support.rst":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"96a23de1292db3e0c13a8696353a68a5a7d6cd09","unresolved":false,"context_lines":[{"line_number":42,"context_line":"Problem Description"},{"line_number":43,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Trove does not support datastore version specific cloud-init."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Proposed Change"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a95cdbc_5dba65c1","line":45,"updated":"2016-10-06 15:12:26.000000000","message":"what does this mean?","commit_id":"f3cd9bf26e1baa2e946a1ef76947e107c578e621"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"6210cc5b04454f7279822bd9b8460bcc8b6b9629","unresolved":false,"context_lines":[{"line_number":42,"context_line":"Problem Description"},{"line_number":43,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Trove does not support datastore version specific cloud-init."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Proposed Change"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a629dbe_ad1bfec8","line":45,"in_reply_to":"1a95cdbc_5dba65c1","updated":"2016-11-10 19:53:20.000000000","message":"Yeah more detail is required here.\n\n\"Currently Trove supports cloud-init to be specific to datastore names only, this is a problem because it restricts the cloud-init to run on only one version. We want a way to be able to run cloud-init on not only specific to datastore names but also specific datastore version.\"","commit_id":"f3cd9bf26e1baa2e946a1ef76947e107c578e621"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"96a23de1292db3e0c13a8696353a68a5a7d6cd09","unresolved":false,"context_lines":[{"line_number":56,"context_line":"During deployment of trove, create as many cloudinit scripts as the number of"},{"line_number":57,"context_line":"datastore versions (to be supported for customer\u0027s use) in"},{"line_number":58,"context_line":"\u0027cloudinit_location\u0027 and can register only one image, with trove, for every"},{"line_number":59,"context_line":"datastore version. User will select specific version from dashboard."},{"line_number":60,"context_line":"Based on the selection, trove-taskmanager will use the corresponding"},{"line_number":61,"context_line":"cloud-init script and sends it to nova as user-data."},{"line_number":62,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a95cdbc_1d4b7db1","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":17},"updated":"2016-10-06 15:12:26.000000000","message":"so, when I register a new datastore version, (as an administrator) I have to now remember to go and create a file somewhere, even if it means I have to copy the previous file and put it there with a new name. Seems like a very bad idea.","commit_id":"f3cd9bf26e1baa2e946a1ef76947e107c578e621"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"6210cc5b04454f7279822bd9b8460bcc8b6b9629","unresolved":false,"context_lines":[{"line_number":56,"context_line":"During deployment of trove, create as many cloudinit scripts as the number of"},{"line_number":57,"context_line":"datastore versions (to be supported for customer\u0027s use) in"},{"line_number":58,"context_line":"\u0027cloudinit_location\u0027 and can register only one image, with trove, for every"},{"line_number":59,"context_line":"datastore version. User will select specific version from dashboard."},{"line_number":60,"context_line":"Based on the selection, trove-taskmanager will use the corresponding"},{"line_number":61,"context_line":"cloud-init script and sends it to nova as user-data."},{"line_number":62,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a629dbe_afa77109","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":17},"in_reply_to":"1a95cdbc_1d4b7db1","updated":"2016-11-10 19:53:20.000000000","message":"Instead of creating a file for every datastore version there are two alternatives I can think of: \n\n    1. if the file for the datastore version is not found we \ncan default to the old method, so the user is no longer \nrequired to create this file but in this case datastore\n version specific support is no longer available.\n\n    2. We can set in the default config the datastores and \nversions we want supported and then that will trigger the \nnecessary trove code to run and register the datastore \nversion specific managers and potentially modify cloud-init\nfiles (based on if we have a new version to support).","commit_id":"f3cd9bf26e1baa2e946a1ef76947e107c578e621"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"96a23de1292db3e0c13a8696353a68a5a7d6cd09","unresolved":false,"context_lines":[{"line_number":63,"context_line":"In order to support this, _prepare_userdata function in"},{"line_number":64,"context_line":"trove.taskmanager.models.py will now take additional parameter"},{"line_number":65,"context_line":"datastore_version. Functions that call this function, now needs to pass"},{"line_number":66,"context_line":"datastore_version parameter as well."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":".. code-block:: python"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a95cdbc_7de9e17f","line":66,"range":{"start_line":66,"start_character":0,"end_line":66,"end_character":17},"updated":"2016-10-06 15:12:26.000000000","message":"are we sure they have it?","commit_id":"f3cd9bf26e1baa2e946a1ef76947e107c578e621"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"6210cc5b04454f7279822bd9b8460bcc8b6b9629","unresolved":false,"context_lines":[{"line_number":63,"context_line":"In order to support this, _prepare_userdata function in"},{"line_number":64,"context_line":"trove.taskmanager.models.py will now take additional parameter"},{"line_number":65,"context_line":"datastore_version. Functions that call this function, now needs to pass"},{"line_number":66,"context_line":"datastore_version parameter as well."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":".. code-block:: python"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a629dbe_f5e5b808","line":66,"range":{"start_line":66,"start_character":0,"end_line":66,"end_character":17},"in_reply_to":"1a95cdbc_7de9e17f","updated":"2016-11-10 19:53:20.000000000","message":"if we can make datastore_version a property of datastore_manager, if it\u0027s not already, i think it will work.","commit_id":"f3cd9bf26e1baa2e946a1ef76947e107c578e621"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"96a23de1292db3e0c13a8696353a68a5a7d6cd09","unresolved":false,"context_lines":[{"line_number":83,"context_line":"Configuration"},{"line_number":84,"context_line":"-------------"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"No impact."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Database"},{"line_number":89,"context_line":"--------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a95cdbc_ddfe7537","line":86,"updated":"2016-10-06 15:12:26.000000000","message":"sounds like this whole proposal depends on new configuration.","commit_id":"f3cd9bf26e1baa2e946a1ef76947e107c578e621"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"96a23de1292db3e0c13a8696353a68a5a7d6cd09","unresolved":false,"context_lines":[{"line_number":108,"context_line":".. code-block:: python"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    create_instance(self, flavor, image_id, databases, users,"},{"line_number":111,"context_line":"                    datastore_manager, datastore_version, packages,"},{"line_number":112,"context_line":"                    volume_size, backup_id, availability_zone,"},{"line_number":113,"context_line":"                    root_password, nics, overrides, cluster_config,"},{"line_number":114,"context_line":"                    snapshot, volume_type):"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a95cdbc_7db72186","line":111,"range":{"start_line":111,"start_character":39,"end_line":111,"end_character":56},"updated":"2016-10-06 15:12:26.000000000","message":"do all callers have it? sounds like it may not be as easy ...","commit_id":"f3cd9bf26e1baa2e946a1ef76947e107c578e621"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"6210cc5b04454f7279822bd9b8460bcc8b6b9629","unresolved":false,"context_lines":[{"line_number":108,"context_line":".. code-block:: python"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    create_instance(self, flavor, image_id, databases, users,"},{"line_number":111,"context_line":"                    datastore_manager, datastore_version, packages,"},{"line_number":112,"context_line":"                    volume_size, backup_id, availability_zone,"},{"line_number":113,"context_line":"                    root_password, nics, overrides, cluster_config,"},{"line_number":114,"context_line":"                    snapshot, volume_type):"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a629dbe_efe5e908","line":111,"range":{"start_line":111,"start_character":39,"end_line":111,"end_character":56},"in_reply_to":"1a95cdbc_7db72186","updated":"2016-11-10 19:53:20.000000000","message":"This should be set to None by default so that the function will look for the non datastore version specific cloud init file (what it originally does) if datastore_version is not specified.","commit_id":"f3cd9bf26e1baa2e946a1ef76947e107c578e621"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"96a23de1292db3e0c13a8696353a68a5a7d6cd09","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"No impact."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Internal API"},{"line_number":123,"context_line":"------------"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"No impact."}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a95cdbc_7d45616e","line":122,"updated":"2016-10-06 15:12:26.000000000","message":"all the things you are changing are internal API\u0027s","commit_id":"f3cd9bf26e1baa2e946a1ef76947e107c578e621"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"96a23de1292db3e0c13a8696353a68a5a7d6cd09","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"No impact."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Alternatives"},{"line_number":133,"context_line":"------------"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a95cdbc_1d553d1c","line":132,"updated":"2016-10-06 15:12:26.000000000","message":"no alternatives?","commit_id":"f3cd9bf26e1baa2e946a1ef76947e107c578e621"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"96a23de1292db3e0c13a8696353a68a5a7d6cd09","unresolved":false,"context_lines":[{"line_number":159,"context_line":"Work Items"},{"line_number":160,"context_line":"----------"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"- implement code"},{"line_number":163,"context_line":"- implement unit tests"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Upgrade Implications"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a95cdbc_dd2115b6","line":163,"range":{"start_line":162,"start_character":0,"end_line":163,"end_character":22},"updated":"2016-10-06 15:12:26.000000000","message":"more detail would be nice; I think most reviewers would likely have guessed these two.","commit_id":"f3cd9bf26e1baa2e946a1ef76947e107c578e621"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"6210cc5b04454f7279822bd9b8460bcc8b6b9629","unresolved":false,"context_lines":[{"line_number":159,"context_line":"Work Items"},{"line_number":160,"context_line":"----------"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"- implement code"},{"line_number":163,"context_line":"- implement unit tests"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Upgrade Implications"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a629dbe_35a57046","line":163,"range":{"start_line":162,"start_character":0,"end_line":163,"end_character":22},"in_reply_to":"1a95cdbc_dd2115b6","updated":"2016-11-10 19:53:20.000000000","message":"the following makes sense to me:\n\n* add datastore_version parameter to _prepare_userdata\n* make functions that call _prepare_userdata pass datastore_version to it if possible\n* handle cases that don\u0027t have datastore_version to pass into _prepare_userdata\n* add unit tests to assert the functions run the way they were intended","commit_id":"f3cd9bf26e1baa2e946a1ef76947e107c578e621"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"96a23de1292db3e0c13a8696353a68a5a7d6cd09","unresolved":false,"context_lines":[{"line_number":166,"context_line":"Upgrade Implications"},{"line_number":167,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"file name format of cloud-init script changes from \u0027service_type.cloudinit\u0027"},{"line_number":170,"context_line":"to \u0027service_type-version.cloudinit\u0027."},{"line_number":171,"context_line":""},{"line_number":172,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a95cdbc_1d037d10","line":169,"updated":"2016-10-06 15:12:26.000000000","message":"and on upgrade, one has to create these files.\nwhen they do a guest upgrade, they\u0027d have to copy files.\n\nOn the whole, a kind of kludgy approach.","commit_id":"f3cd9bf26e1baa2e946a1ef76947e107c578e621"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"6210cc5b04454f7279822bd9b8460bcc8b6b9629","unresolved":false,"context_lines":[{"line_number":166,"context_line":"Upgrade Implications"},{"line_number":167,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"file name format of cloud-init script changes from \u0027service_type.cloudinit\u0027"},{"line_number":170,"context_line":"to \u0027service_type-version.cloudinit\u0027."},{"line_number":171,"context_line":""},{"line_number":172,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a629dbe_95439c6b","line":169,"in_reply_to":"1a95cdbc_1d037d10","updated":"2016-11-10 19:53:20.000000000","message":"is there no way to to pass datastore version outside of the filename?","commit_id":"f3cd9bf26e1baa2e946a1ef76947e107c578e621"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"6210cc5b04454f7279822bd9b8460bcc8b6b9629","unresolved":false,"context_lines":[{"line_number":179,"context_line":"Testing"},{"line_number":180,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"During deployment of trove, create as many cloudinit scripts as the number"},{"line_number":183,"context_line":"of datastore versions (to be supported for customer\u0027s use) in"},{"line_number":184,"context_line":"\u0027cloudinit_location\u0027 and can register only one image, with trove, for every"},{"line_number":185,"context_line":"datastore version. User will select specific version from dashboard. Based"},{"line_number":186,"context_line":"on the selection, trove-taskmanager will use the corresponding cloud-init"},{"line_number":187,"context_line":"script and sends it to nova as user-data."},{"line_number":188,"context_line":""},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a629dbe_551bc480","line":187,"range":{"start_line":182,"start_character":0,"end_line":187,"end_character":41},"updated":"2016-11-10 19:53:20.000000000","message":"I think you misplaced this text, this is from the \u0027proposed change\u0027 section.","commit_id":"f3cd9bf26e1baa2e946a1ef76947e107c578e621"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"96a23de1292db3e0c13a8696353a68a5a7d6cd09","unresolved":false,"context_lines":[{"line_number":190,"context_line":"Documentation Impact"},{"line_number":191,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"Yes, will upadte the documentation"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a95cdbc_5803530d","line":193,"range":{"start_line":193,"start_character":10,"end_line":193,"end_character":16},"updated":"2016-10-06 15:12:26.000000000","message":"and change this to \u0027update\u0027","commit_id":"f3cd9bf26e1baa2e946a1ef76947e107c578e621"}]}
