)]}'
{"specs/ocata/guestagent-image-metadata.rst":[{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"7c3c150764ad4b13323c96ca05020da738ac6b26","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"The paths and names depend on the platform, datastore version and installation"},{"line_number":50,"context_line":"package used. They may also be modified by the image builder at any time to"},{"line_number":51,"context_line":"match the user\u0027s requirements. It is not always possible for Trove to mandate"},{"line_number":52,"context_line":"the expected values and the logic to handle different cases becomes"},{"line_number":53,"context_line":"progressively more and more complex with every new platform and datastore"},{"line_number":54,"context_line":"version."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a629dbe_94d9e724","line":51,"range":{"start_line":50,"start_character":14,"end_line":51,"end_character":29},"updated":"2016-11-10 17:12:15.000000000","message":"How and when will the image builder modify the files? If it\u0027s during run time it makes sense to create the BaseApp class from the POC. If it\u0027s something that is going to be modified once and then used for the rest of the runtime then I agree with Morgan that this is too much.","commit_id":"a7617b79c33a22e2d073d4ad5f556f90aafa29f0"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"6e3877f7f105b7eed26bef1369fdab5a44cc753b","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"The paths and names depend on the platform, datastore version and installation"},{"line_number":50,"context_line":"package used. They may also be modified by the image builder at any time to"},{"line_number":51,"context_line":"match the user\u0027s requirements. It is not always possible for Trove to mandate"},{"line_number":52,"context_line":"the expected values and the logic to handle different cases becomes"},{"line_number":53,"context_line":"progressively more and more complex with every new platform and datastore"},{"line_number":54,"context_line":"version."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a629dbe_d2c30137","line":51,"range":{"start_line":50,"start_character":14,"end_line":51,"end_character":29},"in_reply_to":"9a629dbe_94d9e724","updated":"2016-11-14 17:43:45.000000000","message":"I am not against using oslo. It is just a technical detail (file format \u0026 access interface). We however need properties (or some utility access method) because Oslo itself if not flexible enough to let us handle different OS.","commit_id":"a7617b79c33a22e2d073d4ad5f556f90aafa29f0"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"494abad62840f2a53bea8b4acb8e32cd542b45e4","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"The paths and names depend on the platform, datastore version and installation"},{"line_number":50,"context_line":"package used. They may also be modified by the image builder at any time to"},{"line_number":51,"context_line":"match the user\u0027s requirements. It is not always possible for Trove to mandate"},{"line_number":52,"context_line":"the expected values and the logic to handle different cases becomes"},{"line_number":53,"context_line":"progressively more and more complex with every new platform and datastore"},{"line_number":54,"context_line":"version."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a629dbe_b2220d00","line":51,"range":{"start_line":50,"start_character":14,"end_line":51,"end_character":29},"in_reply_to":"9a629dbe_94d9e724","updated":"2016-11-14 17:46:48.000000000","message":"We need to be able to pick the right os-specific default values to support existing images which won\u0027t have the file.","commit_id":"a7617b79c33a22e2d073d4ad5f556f90aafa29f0"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"7c3c150764ad4b13323c96ca05020da738ac6b26","unresolved":false,"context_lines":[{"line_number":63,"context_line":"all these values."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"This document suggests introduction of an optional metadata file to the image"},{"line_number":67,"context_line":"from which the guests could obtain the required information."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a629dbe_54982fc0","line":66,"range":{"start_line":66,"start_character":14,"end_line":66,"end_character":35},"updated":"2016-11-10 17:12:15.000000000","message":"\"...suggests the introduction...\"","commit_id":"a7617b79c33a22e2d073d4ad5f556f90aafa29f0"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"3f5887e9108b2d927302a3131c595aa7e4d5fd88","unresolved":false,"context_lines":[{"line_number":71,"context_line":"guest-agent. The file may not be required (at least for the existing datastore)"},{"line_number":72,"context_line":"meaning that Trove would try to fall back to the current defaults in the"},{"line_number":73,"context_line":"absence of the metadata file."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"See POC review: https://review.openstack.org/#/c/345533/"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a629dbe_b2dfd638","line":74,"updated":"2016-11-10 19:02:48.000000000","message":"I was wondering if this could be made part of the existing configuration files that get copied from the image to the guest rather than create a new one. \n\nIf we are creating a new one, then shouldn\u0027t we make changes to the upstart script to copy the file over to the guest.","commit_id":"a7617b79c33a22e2d073d4ad5f556f90aafa29f0"}]}