)]}'
{"doc/source/index.rst":[{"author":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},"change_message_id":"db14a46827819d3886932c78e5e180664532b32c","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"   specs/*"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Queens approved specs:"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":".. toctree::"},{"line_number":18,"context_line":"   :glob:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f4b6375_c0d57f1d","line":15,"updated":"2017-11-05 19:42:37.000000000","message":"Would prefer to add Pike as well.","commit_id":"abba06a2f64680838658cd7c3ff0784fb3c1bd57"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"97aa8a267b26874be469ce678abb27d8dd4b89c1","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"   specs/*"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Queens approved specs:"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":".. toctree::"},{"line_number":18,"context_line":"   :glob:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f4b6375_663967a2","line":15,"in_reply_to":"3f4b6375_c0d57f1d","updated":"2017-11-06 01:38:59.000000000","message":"I\u0027ve done that in this patch :https://review.openstack.org/#/c/514574/.","commit_id":"abba06a2f64680838658cd7c3ff0784fb3c1bd57"}],"specs/queens/authentication-management-for-redis.rst":[{"author":{"_account_id":14203,"name":"yangzhenyu","email":"cdyangzhenyu@gmail.com","username":"yangzhenyu"},"change_message_id":"caf41eedcff5deb19f5c50f92f725d7d661e3b52","unresolved":false,"context_lines":[{"line_number":264,"context_line":"Appendix"},{"line_number":265,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"Any additional technical information and data."}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f4b6375_cdbe13b3","line":267,"range":{"start_line":267,"start_character":0,"end_line":267,"end_character":46},"updated":"2017-10-25 07:28:42.000000000","message":"need blank line","commit_id":"1a53aeabbaa3468c18748c22ea13a3a4fcb98883"},{"author":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"change_message_id":"70660d25c22b502bc82e30369fffadaf9870472b","unresolved":false,"context_lines":[{"line_number":51,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Implement root-enable, root-disable and root-show API for redis to add support"},{"line_number":54,"context_line":"for redis authentication management. It will support two scenarios include"},{"line_number":55,"context_line":"redis single instance and redis replica instances which these operations only"},{"line_number":56,"context_line":"support master instance but can make effect slave instances."},{"line_number":57,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f4b6375_61c0aae1","line":54,"range":{"start_line":54,"start_character":67,"end_line":54,"end_character":74},"updated":"2017-10-31 17:01:52.000000000","message":"include \u003e including","commit_id":"abba06a2f64680838658cd7c3ff0784fb3c1bd57"},{"author":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"change_message_id":"70660d25c22b502bc82e30369fffadaf9870472b","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"* Get slave instances of given instance."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"* Try to get origin auth password for the sake of rolling back."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"* Do root enable for given instance. Considering it\u0027s a single instance or"},{"line_number":73,"context_line":"  a master of redis replica sets, roll back once using origin auth password"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f4b6375_81628615","line":70,"range":{"start_line":70,"start_character":13,"end_line":70,"end_character":19},"updated":"2017-10-31 17:01:52.000000000","message":"origin \u003e original?","commit_id":"abba06a2f64680838658cd7c3ff0784fb3c1bd57"},{"author":{"_account_id":26311,"name":"tianhui","email":"tianhui@awcloud.com","username":"tianhui"},"change_message_id":"b59bb8ece43f559ba6853bdebe1c3c8d11eaed6c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"    This work is licensed under a Creative Commons Attribution 3.0 Unported"},{"line_number":3,"context_line":"    License."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"    http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    Sections of this template were taken directly from the Nova spec"},{"line_number":8,"context_line":"    template at:"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3f4b6375_7933b614","line":5,"range":{"start_line":5,"start_character":47,"end_line":5,"end_character":56},"updated":"2017-11-01 02:05:00.000000000","message":"https://creativecommons.org/licenses/by/3.0/legalcode","commit_id":"80d883e83239dc397f5c2f29a6a656b107e4ddb8"},{"author":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},"change_message_id":"db14a46827819d3886932c78e5e180664532b32c","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":15,"context_line":"Authentication Management for Redis"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":".. If section numbers are desired, unindent this"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f4b6375_f183d2c9","line":15,"updated":"2017-11-05 19:42:37.000000000","message":"A bit broad of a title. Since Redis does not have \u0027users\u0027, it is a bit misleading to imply that database users will be authenticated. Perhaps limit the title to the scope of the proposal: Implement root-enable/root-disable/root-show for Redis.","commit_id":"8f78aee08e5efaf226ad1fb25688f04cac00e2e4"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"7e231d62e31eff68d8753d568423ec2a602ee5da","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":15,"context_line":"Authentication Management for Redis"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":".. If section numbers are desired, unindent this"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f4b6375_2e522136","line":15,"in_reply_to":"3f4b6375_f183d2c9","updated":"2017-11-06 10:21:10.000000000","message":"Done","commit_id":"8f78aee08e5efaf226ad1fb25688f04cac00e2e4"},{"author":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},"change_message_id":"db14a46827819d3886932c78e5e180664532b32c","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    .. contents::"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Trove currently has support for enabling root user, disabling root user"},{"line_number":25,"context_line":"and showing root-enabled status for database instance, but that functionality"},{"line_number":26,"context_line":"is lacking for redis. This blueprint outlines a framework and API for"},{"line_number":27,"context_line":"implementing authentication management for redis."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f4b6375_110c2e92","line":25,"updated":"2017-11-05 19:42:37.000000000","message":"instances","commit_id":"8f78aee08e5efaf226ad1fb25688f04cac00e2e4"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"7e231d62e31eff68d8753d568423ec2a602ee5da","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    .. contents::"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Trove currently has support for enabling root user, disabling root user"},{"line_number":25,"context_line":"and showing root-enabled status for database instance, but that functionality"},{"line_number":26,"context_line":"is lacking for redis. This blueprint outlines a framework and API for"},{"line_number":27,"context_line":"implementing authentication management for redis."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f4b6375_ee3529f8","line":25,"in_reply_to":"3f4b6375_110c2e92","updated":"2017-11-06 10:21:10.000000000","message":"Done","commit_id":"8f78aee08e5efaf226ad1fb25688f04cac00e2e4"},{"author":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},"change_message_id":"db14a46827819d3886932c78e5e180664532b32c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Trove does not currently support root-enable, root-disable, root-show for"},{"line_number":37,"context_line":"redis instance."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Proposed Change"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f4b6375_d129f6e5","line":37,"updated":"2017-11-05 19:42:37.000000000","message":"instances","commit_id":"8f78aee08e5efaf226ad1fb25688f04cac00e2e4"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"7e231d62e31eff68d8753d568423ec2a602ee5da","unresolved":false,"context_lines":[{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Trove does not currently support root-enable, root-disable, root-show for"},{"line_number":37,"context_line":"redis instance."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Proposed Change"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f4b6375_8e26b5cd","line":37,"in_reply_to":"3f4b6375_d129f6e5","updated":"2017-11-06 10:21:10.000000000","message":"Done","commit_id":"8f78aee08e5efaf226ad1fb25688f04cac00e2e4"},{"author":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},"change_message_id":"db14a46827819d3886932c78e5e180664532b32c","unresolved":false,"context_lines":[{"line_number":40,"context_line":"Proposed Change"},{"line_number":41,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Implement root-enable, root-disable and root-show API for redis to add support"},{"line_number":44,"context_line":"for redis authentication management. It will support two scenarios including"},{"line_number":45,"context_line":"redis single instance and redis replica instances which these operations only"},{"line_number":46,"context_line":"support master instance but can make effect slave instances."},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f4b6375_d16e962d","line":44,"range":{"start_line":43,"start_character":64,"end_line":44,"end_character":35},"updated":"2017-11-05 19:42:37.000000000","message":"delete reference to authentication management.","commit_id":"8f78aee08e5efaf226ad1fb25688f04cac00e2e4"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"7e231d62e31eff68d8753d568423ec2a602ee5da","unresolved":false,"context_lines":[{"line_number":40,"context_line":"Proposed Change"},{"line_number":41,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Implement root-enable, root-disable and root-show API for redis to add support"},{"line_number":44,"context_line":"for redis authentication management. It will support two scenarios including"},{"line_number":45,"context_line":"redis single instance and redis replica instances which these operations only"},{"line_number":46,"context_line":"support master instance but can make effect slave instances."},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f4b6375_0e1c0576","line":44,"range":{"start_line":43,"start_character":64,"end_line":44,"end_character":35},"in_reply_to":"3f4b6375_d16e962d","updated":"2017-11-06 10:21:10.000000000","message":"Done","commit_id":"8f78aee08e5efaf226ad1fb25688f04cac00e2e4"},{"author":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},"change_message_id":"db14a46827819d3886932c78e5e180664532b32c","unresolved":false,"context_lines":[{"line_number":45,"context_line":"redis single instance and redis replica instances which these operations only"},{"line_number":46,"context_line":"support master instance but can make effect slave instances."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"This implementation do not support redis cluster."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Here are the details:"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f4b6375_31672a50","line":48,"range":{"start_line":48,"start_character":35,"end_line":48,"end_character":48},"updated":"2017-11-05 19:42:37.000000000","message":"a cluster of redis instances.","commit_id":"8f78aee08e5efaf226ad1fb25688f04cac00e2e4"},{"author":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},"change_message_id":"db14a46827819d3886932c78e5e180664532b32c","unresolved":false,"context_lines":[{"line_number":45,"context_line":"redis single instance and redis replica instances which these operations only"},{"line_number":46,"context_line":"support master instance but can make effect slave instances."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"This implementation do not support redis cluster."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Here are the details:"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f4b6375_716fe227","line":48,"range":{"start_line":48,"start_character":20,"end_line":48,"end_character":22},"updated":"2017-11-05 19:42:37.000000000","message":"does","commit_id":"8f78aee08e5efaf226ad1fb25688f04cac00e2e4"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"7e231d62e31eff68d8753d568423ec2a602ee5da","unresolved":false,"context_lines":[{"line_number":45,"context_line":"redis single instance and redis replica instances which these operations only"},{"line_number":46,"context_line":"support master instance but can make effect slave instances."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"This implementation do not support redis cluster."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Here are the details:"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f4b6375_8e0fd535","line":48,"range":{"start_line":48,"start_character":35,"end_line":48,"end_character":48},"in_reply_to":"3f4b6375_31672a50","updated":"2017-11-06 10:21:10.000000000","message":"Done","commit_id":"8f78aee08e5efaf226ad1fb25688f04cac00e2e4"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"7e231d62e31eff68d8753d568423ec2a602ee5da","unresolved":false,"context_lines":[{"line_number":45,"context_line":"redis single instance and redis replica instances which these operations only"},{"line_number":46,"context_line":"support master instance but can make effect slave instances."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"This implementation do not support redis cluster."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Here are the details:"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f4b6375_6e0a5926","line":48,"range":{"start_line":48,"start_character":20,"end_line":48,"end_character":22},"in_reply_to":"3f4b6375_716fe227","updated":"2017-11-06 10:21:10.000000000","message":"Done","commit_id":"8f78aee08e5efaf226ad1fb25688f04cac00e2e4"},{"author":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},"change_message_id":"db14a46827819d3886932c78e5e180664532b32c","unresolved":false,"context_lines":[{"line_number":161,"context_line":"* Add requirepass and masterauth into redis.conf when executing root enable,"},{"line_number":162,"context_line":"  and apply overrides to bring into effect without restarting redis service."},{"line_number":163,"context_line":"  Rebuild admin client to make sure guest agent can still talk to task manager"},{"line_number":164,"context_line":"  after enabling authentication in redis."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"* Remove requirepass and masterauth in redis.conf when executing root disable,"},{"line_number":167,"context_line":"  and apply overrides to bring into effect without restarting redis service."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f4b6375_714802b2","line":164,"range":{"start_line":164,"start_character":8,"end_line":164,"end_character":40},"updated":"2017-11-05 19:42:37.000000000","message":"adding enabling/disabling root.","commit_id":"8f78aee08e5efaf226ad1fb25688f04cac00e2e4"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"7e231d62e31eff68d8753d568423ec2a602ee5da","unresolved":false,"context_lines":[{"line_number":161,"context_line":"* Add requirepass and masterauth into redis.conf when executing root enable,"},{"line_number":162,"context_line":"  and apply overrides to bring into effect without restarting redis service."},{"line_number":163,"context_line":"  Rebuild admin client to make sure guest agent can still talk to task manager"},{"line_number":164,"context_line":"  after enabling authentication in redis."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"* Remove requirepass and masterauth in redis.conf when executing root disable,"},{"line_number":167,"context_line":"  and apply overrides to bring into effect without restarting redis service."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f4b6375_f12ce899","line":164,"range":{"start_line":164,"start_character":8,"end_line":164,"end_character":40},"in_reply_to":"3f4b6375_714802b2","updated":"2017-11-06 10:21:10.000000000","message":"Done","commit_id":"8f78aee08e5efaf226ad1fb25688f04cac00e2e4"},{"author":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},"change_message_id":"db14a46827819d3886932c78e5e180664532b32c","unresolved":false,"context_lines":[{"line_number":219,"context_line":"Testing"},{"line_number":220,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"Please discuss how the change will be tested. We especially want to know what"},{"line_number":223,"context_line":"int tests and tempest tests will be added. It is assumed that unit"},{"line_number":224,"context_line":"test coverage will be added so that doesn\u0027t need to be mentioned"},{"line_number":225,"context_line":"explicitly, but discussion of why you think unit tests are sufficient"},{"line_number":226,"context_line":"and we don\u0027t need to add more tempest tests would need to be included."},{"line_number":227,"context_line":""},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f4b6375_31ccca33","line":226,"range":{"start_line":222,"start_character":0,"end_line":226,"end_character":70},"updated":"2017-11-05 19:42:37.000000000","message":"Could you add something about how this will be tested?","commit_id":"8f78aee08e5efaf226ad1fb25688f04cac00e2e4"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"7e231d62e31eff68d8753d568423ec2a602ee5da","unresolved":false,"context_lines":[{"line_number":219,"context_line":"Testing"},{"line_number":220,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"Please discuss how the change will be tested. We especially want to know what"},{"line_number":223,"context_line":"int tests and tempest tests will be added. It is assumed that unit"},{"line_number":224,"context_line":"test coverage will be added so that doesn\u0027t need to be mentioned"},{"line_number":225,"context_line":"explicitly, but discussion of why you think unit tests are sufficient"},{"line_number":226,"context_line":"and we don\u0027t need to add more tempest tests would need to be included."},{"line_number":227,"context_line":""},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f4b6375_d1a8cc8c","line":226,"range":{"start_line":222,"start_character":0,"end_line":226,"end_character":70},"in_reply_to":"3f4b6375_31ccca33","updated":"2017-11-06 10:21:10.000000000","message":"I will add these things later. Kind of stuck in work today. :/","commit_id":"8f78aee08e5efaf226ad1fb25688f04cac00e2e4"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"9c5c2fb8b7201918185e6c1c2414bc919ccad0aa","unresolved":false,"context_lines":[{"line_number":219,"context_line":"Testing"},{"line_number":220,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"Please discuss how the change will be tested. We especially want to know what"},{"line_number":223,"context_line":"int tests and tempest tests will be added. It is assumed that unit"},{"line_number":224,"context_line":"test coverage will be added so that doesn\u0027t need to be mentioned"},{"line_number":225,"context_line":"explicitly, but discussion of why you think unit tests are sufficient"},{"line_number":226,"context_line":"and we don\u0027t need to add more tempest tests would need to be included."},{"line_number":227,"context_line":""},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1f485f77_3fe2e9d6","line":226,"range":{"start_line":222,"start_character":0,"end_line":226,"end_character":70},"in_reply_to":"3f4b6375_d1a8cc8c","updated":"2017-11-13 03:28:25.000000000","message":"Done","commit_id":"8f78aee08e5efaf226ad1fb25688f04cac00e2e4"},{"author":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},"change_message_id":"db14a46827819d3886932c78e5e180664532b32c","unresolved":false,"context_lines":[{"line_number":229,"context_line":"Documentation Impact"},{"line_number":230,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"What is the impact on the docs team of this change? Some changes might require"},{"line_number":233,"context_line":"donating resources to the docs team to have the documentation updated. Don\u0027t"},{"line_number":234,"context_line":"repeat details discussed above, but please reference them here."},{"line_number":235,"context_line":""},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f4b6375_11cf8e29","line":234,"range":{"start_line":232,"start_character":0,"end_line":234,"end_character":63},"updated":"2017-11-05 19:42:37.000000000","message":"Same here, could you add the documentation impact?","commit_id":"8f78aee08e5efaf226ad1fb25688f04cac00e2e4"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"7e231d62e31eff68d8753d568423ec2a602ee5da","unresolved":false,"context_lines":[{"line_number":229,"context_line":"Documentation Impact"},{"line_number":230,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"What is the impact on the docs team of this change? Some changes might require"},{"line_number":233,"context_line":"donating resources to the docs team to have the documentation updated. Don\u0027t"},{"line_number":234,"context_line":"repeat details discussed above, but please reference them here."},{"line_number":235,"context_line":""},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f4b6375_f193c84d","line":234,"range":{"start_line":232,"start_character":0,"end_line":234,"end_character":63},"in_reply_to":"3f4b6375_11cf8e29","updated":"2017-11-06 10:21:10.000000000","message":"I will do it later.","commit_id":"8f78aee08e5efaf226ad1fb25688f04cac00e2e4"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"9c5c2fb8b7201918185e6c1c2414bc919ccad0aa","unresolved":false,"context_lines":[{"line_number":229,"context_line":"Documentation Impact"},{"line_number":230,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"What is the impact on the docs team of this change? Some changes might require"},{"line_number":233,"context_line":"donating resources to the docs team to have the documentation updated. Don\u0027t"},{"line_number":234,"context_line":"repeat details discussed above, but please reference them here."},{"line_number":235,"context_line":""},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1f485f77_5fdda512","line":234,"range":{"start_line":232,"start_character":0,"end_line":234,"end_character":63},"in_reply_to":"3f4b6375_f193c84d","updated":"2017-11-13 03:28:25.000000000","message":"Done","commit_id":"8f78aee08e5efaf226ad1fb25688f04cac00e2e4"}]}