)]}'
{"trove_tempest_plugin/tests/scenario/test_instance_basic.py":[{"author":{"_account_id":36080,"name":"Erkin Mussurmankulov","display_name":"Eric","email":"mangust404@gmail.com","username":"mongoose404","status":"PS Cloud services employee"},"change_message_id":"d8b30be83fd277f8fac0be31f8fb1dbb1843bf0c","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        update_user_body \u003d {\"user\": {\"password\": new_pass}}"},{"line_number":153,"context_line":"        self.client.put_resource("},{"line_number":154,"context_line":"            f\u0027instances/{self.instance_id}/users/{user1}\u0027, update_user_body)"},{"line_number":155,"context_line":"        time.sleep(3)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        LOG.info(\"Accessing database with updated password, \""},{"line_number":158,"context_line":"                 f\"user: {user1}, db: {db1}\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"276d62cd_d9a3c02e","line":155,"updated":"2026-02-11 18:22:35.000000000","message":"Hello, Wu.\nI can see a lot of ``time.sleep(3)`` in the code. It looks like a bad pattern for me. If db container will freeze for a while (during a high load), the whole test will fail. More sleeps in the test scenario increases the probability for this to happen.\n\nMaybe we should add helper methods like:\n- ``wait_for_database_creation(dbname)`` [in BaseTroveTest]\n- ``wait_for_user_added(username)`` [in TestInstanceBasicBase]\n- ``wait_for_user_removed(username)`` [in TestInstanceBasicBase]\n- ``wait_for_database_accessible(dbname, username)`` [in TestInstanceBasicBase]\n- ``wait_for_database_inaccessible(dbname, username)`` [in TestInstanceBasicBase]\n\nAnd get rid of sleeps here and in MySQL tests too (probably there are few more places to use them). How do you think?\n\nNot within this commit, in a new one will be better IMO, after merging of this commit.\n\nI\u0027m taking a deep dive into trove tempest plugin right now, and I can help with this task by the way.","commit_id":"01672d24d26b9b6ec2c750c1ff6c1b4092af769a"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"42a5f671e94c978f6ad0f31b4b917c020caed380","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        update_user_body \u003d {\"user\": {\"password\": new_pass}}"},{"line_number":153,"context_line":"        self.client.put_resource("},{"line_number":154,"context_line":"            f\u0027instances/{self.instance_id}/users/{user1}\u0027, update_user_body)"},{"line_number":155,"context_line":"        time.sleep(3)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        LOG.info(\"Accessing database with updated password, \""},{"line_number":158,"context_line":"                 f\"user: {user1}, db: {db1}\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"c89e37ea_81326f2a","line":155,"in_reply_to":"276d62cd_d9a3c02e","updated":"2026-02-12 13:13:31.000000000","message":"The purpose of adding sleep(3) is to wait for the resource to be created. It is acceptable to add wait functions for these resources, and a new commit is required.\n\nOnce you have a better solution, you can push it to Gerrit. thanks in advance.","commit_id":"01672d24d26b9b6ec2c750c1ff6c1b4092af769a"}]}