)]}'
{"id":"openstack%2Ftrove~1001018","triplet_id":"openstack%2Ftrove~stable%2F2026.1~I6173f8172adb9b6fd5ab7ae75f21eb09c286a260","project":"openstack/trove","branch":"stable/2026.1","attention_set":{},"removed_from_attention_set":{"36080":{"account":{"_account_id":36080,"name":"Erkin Mussurmankulov","display_name":"Eric","email":"erkin.mussurmankulov@ps.kz","username":"mongoose404","status":"PS Cloud services employee"},"last_update":"2026-08-16 19:56:26.000000000","reason":"\u003cGERRIT_ACCOUNT_36080\u003e replied on the change","reason_account":{"_account_id":36080,"name":"Erkin Mussurmankulov","display_name":"Eric","email":"erkin.mussurmankulov@ps.kz","username":"mongoose404","status":"PS Cloud services employee"}},"37598":{"account":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"last_update":"2026-08-16 20:47:05.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I6173f8172adb9b6fd5ab7ae75f21eb09c286a260","subject":"Fix \u0027swfit\u0027 typo in backup storage driver default","status":"MERGED","created":"2026-08-15 08:25:21.000000000","updated":"2026-08-16 20:47:59.000000000","submitted":"2026-08-16 20:47:05.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1001018","cherry_pick_of_change":1000806,"cherry_pick_of_patch_set":1,"meta_rev_id":"de42335ae3fa61ed9400fc7d87cf752125b85d5b","_number":1001018,"virtual_id_number":1001018,"owner":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":36080,"name":"Erkin Mussurmankulov","display_name":"Eric","email":"erkin.mussurmankulov@ps.kz","username":"mongoose404","status":"PS Cloud services employee"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2026-08-16 20:47:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":36080,"name":"Erkin Mussurmankulov","display_name":"Eric","email":"erkin.mussurmankulov@ps.kz","username":"mongoose404","status":"PS Cloud services employee"},"all":[{"value":2,"date":"2026-08-16 19:56:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":36080,"name":"Erkin Mussurmankulov","display_name":"Eric","email":"erkin.mussurmankulov@ps.kz","username":"mongoose404","status":"PS Cloud services employee"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":36080,"name":"Erkin Mussurmankulov","display_name":"Eric","email":"erkin.mussurmankulov@ps.kz","username":"mongoose404","status":"PS Cloud services employee"},"all":[{"value":1,"date":"2026-08-16 19:56:26.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":36080,"name":"Erkin Mussurmankulov","display_name":"Eric","email":"erkin.mussurmankulov@ps.kz","username":"mongoose404","status":"PS Cloud services employee"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":36080,"name":"Erkin Mussurmankulov","display_name":"Eric","email":"erkin.mussurmankulov@ps.kz","username":"mongoose404","status":"PS Cloud services employee"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"}],"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":36080,"name":"Erkin Mussurmankulov","display_name":"Eric","email":"erkin.mussurmankulov@ps.kz","username":"mongoose404","status":"PS Cloud services employee"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-08-15 08:25:21.000000000","updated_by":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"reviewer":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"state":"CC"},{"updated":"2026-08-15 08:35:15.000000000","updated_by":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"reviewer":{"_account_id":36080,"name":"Erkin Mussurmankulov","display_name":"Eric","email":"erkin.mussurmankulov@ps.kz","username":"mongoose404","status":"PS Cloud services employee"},"state":"REVIEWER"},{"updated":"2026-08-15 10:21:49.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f5d9767da13ddb2317939888126965c82f4d01e3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"date":"2026-08-15 08:25:21.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"8c08746b45b6ae514245adcff89b33dd490bd9d5","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-08-15 10:21:49.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/f3ad949f564c453ca163d50b2dd92114\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/365c8624ebe847b5b1c9bc9317e75499 : FAILURE in 7m 05s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8bdcd3f1ad084462a27df9bed57aebd8 : SUCCESS in 4m 23s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/5789ece3ec85407687ea03e426c930c4 : FAILURE in 3m 15s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/a12ef4dd6fbe4357a7a432612f030f6e : FAILURE in 4m 37s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/2ea683acd6d948ce9150298ce74cb490 : FAILURE in 7m 14s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/496235cfba834cb4bfcd38e5d5dbed21 : SUCCESS in 5m 11s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/36f4bcf750b24c09ab5978448e65f99e : SUCCESS in 6m 08s\n- trove-tempest-ubuntu-base-mysql8.4 https://zuul.opendev.org/t/openstack/build/ea1863a0199345edbdcca5dbce1e6313 : SUCCESS in 1h 02m 45s\n- trove-tempest-ubuntu-backup-mysql8.4 https://zuul.opendev.org/t/openstack/build/7d52fdc2e14d4b49aab231f434c65b01 : SUCCESS in 1h 46m 15s (non-voting)\n- trove-tempest-ubuntu-replication-mysql8.4 https://zuul.opendev.org/t/openstack/build/680081fccdcd4c4ab34db3c761a8365a : SUCCESS in 1h 30m 38s (non-voting)\n- trove-tempest-cinder-storage-driver-mysql8.4 https://zuul.opendev.org/t/openstack/build/4b3b8a6f9153478fa976f780759de248 : SUCCESS in 1h 45m 07s (non-voting)\n- trove-tempest-ubuntu-base-mariadb11.4 https://zuul.opendev.org/t/openstack/build/8ff93a48b6424fb3af20f2f707dc3f03 : SUCCESS in 56m 36s\n- trove-tempest-ubuntu-backup-mariadb11.4 https://zuul.opendev.org/t/openstack/build/9c520268263a46b9b48cc442796c6c4d : SUCCESS in 1h 55m 04s (non-voting)\n- trove-tempest-ubuntu-replication-mariadb11.4 https://zuul.opendev.org/t/openstack/build/063a71a9a15942029cf5b0bbfc980493 : SUCCESS in 1h 21m 23s (non-voting)\n- trove-tempest-cinder-storage-driver-mariadb11.4 https://zuul.opendev.org/t/openstack/build/68f8f50d943b4ead98baac3e7c8439c2 : SUCCESS in 1h 29m 14s (non-voting)\n- trove-tempest-ubuntu-base-postgresql17 https://zuul.opendev.org/t/openstack/build/7ceaa50f3f984fe6a92ee018e0584d24 : SUCCESS in 50m 07s\n- trove-tempest-ubuntu-backup-postgresql17 https://zuul.opendev.org/t/openstack/build/f8ba4043f81d4557a100818ba00a6c52 : SUCCESS in 1h 27m 24s (non-voting)\n- trove-tempest-ubuntu-replication-postgresql17 https://zuul.opendev.org/t/openstack/build/bff06de758a041b881b3392351a17b5e : SUCCESS in 1h 10m 45s (non-voting)\n- trove-tempest-cinder-storage-driver-postgresql17 https://zuul.opendev.org/t/openstack/build/80fc5220294f4e09a1e61db56592300d : SUCCESS in 1h 36m 59s (non-voting)\n- trove-tox-bandit-baseline https://zuul.opendev.org/t/openstack/build/acf408f7480247dab319c0a23ee5a46f : SUCCESS in 6m 30s","accounts_in_message":[],"_revision_number":1},{"id":"13293a56f89ce1656be3551ebb45858dc1795266","tag":"autogenerated:gerrit:setWorkInProgress","author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"date":"2026-08-15 13:00:03.000000000","message":"Set Work In Progress","accounts_in_message":[],"_revision_number":1},{"id":"3ae03beae2e7849df261bf9e803eac8ae9ba72cd","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"date":"2026-08-15 13:02:58.000000000","message":"Patch Set 2: Published edit on patch set 1.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"NEVER\")\n","accounts_in_message":[],"_revision_number":2},{"id":"610e0f6138ff0ac57ee17e0c14b0a58c273e3480","author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"date":"2026-08-15 14:28:18.000000000","message":"Patch Set 2:\n\nThis change is ready for review.","accounts_in_message":[],"_revision_number":2},{"id":"66c83aaf99f58942cdf9d3e466d879377e9aa1ab","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-08-15 15:14:16.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/057cbbd5f6b641709ad19f5bd8a79d74\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/06bc4fcc2b8f4231afd59524545fb3f7 : SUCCESS in 4m 50s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ef36550e3e954eff82cf0d692ec0cfc6 : SUCCESS in 4m 58s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/724f8561eeb54abd9790d7b685a8f539 : SUCCESS in 5m 04s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/7295f82803804e7997466b65b650f8c4 : SUCCESS in 4m 10s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/4ed7f4ab9fda4186adf9ac1d3c10bdf2 : SUCCESS in 6m 51s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/fd8e39a91f4e4193b559da63ff2cec21 : SUCCESS in 4m 30s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/358ddfa5f4b24e0e941a8715b479ca54 : SUCCESS in 7m 19s\n- trove-tempest-ubuntu-base-mysql8.4 https://zuul.opendev.org/t/openstack/build/bf0231806aab4a87ab4b00497df6b14c : SUCCESS in 49m 30s\n- trove-tempest-ubuntu-backup-mysql8.4 https://zuul.opendev.org/t/openstack/build/125e48265cf54ae99413180a1877ccd3 : SUCCESS in 1h 54m 27s (non-voting)\n- trove-tempest-ubuntu-replication-mysql8.4 https://zuul.opendev.org/t/openstack/build/66abfedf2fde4215a6fd1b07b34d9bdd : SUCCESS in 1h 36m 12s (non-voting)\n- trove-tempest-cinder-storage-driver-mysql8.4 https://zuul.opendev.org/t/openstack/build/4147381cf10b45d8ab53e2eeab9c832d : SUCCESS in 2h 10m 09s (non-voting)\n- trove-tempest-ubuntu-base-mariadb11.4 https://zuul.opendev.org/t/openstack/build/98da1720888544e0ba120868a9e2904d : SUCCESS in 44m 09s\n- trove-tempest-ubuntu-backup-mariadb11.4 https://zuul.opendev.org/t/openstack/build/9a9365f5f3cb4648aa8080c2a300e406 : SUCCESS in 1h 45m 21s (non-voting)\n- trove-tempest-ubuntu-replication-mariadb11.4 https://zuul.opendev.org/t/openstack/build/9e7acfca64314860b294a4380e08393d : SUCCESS in 1h 16m 29s (non-voting)\n- trove-tempest-cinder-storage-driver-mariadb11.4 https://zuul.opendev.org/t/openstack/build/600dde8ccf01474c95f8993ade9c1d54 : SUCCESS in 1h 40m 13s (non-voting)\n- trove-tempest-ubuntu-base-postgresql17 https://zuul.opendev.org/t/openstack/build/02b2c4312945418ba90d3b397449a5ce : SUCCESS in 44m 36s\n- trove-tempest-ubuntu-backup-postgresql17 https://zuul.opendev.org/t/openstack/build/3284e608455744af8a672c99b5036210 : SUCCESS in 1h 32m 47s (non-voting)\n- trove-tempest-ubuntu-replication-postgresql17 https://zuul.opendev.org/t/openstack/build/ed01ec1d23da46e7aa6e6a075e68cdcb : SUCCESS in 1h 23m 43s (non-voting)\n- trove-tempest-cinder-storage-driver-postgresql17 https://zuul.opendev.org/t/openstack/build/6cca9af01aa4476b9ff9476a694e76e6 : SUCCESS in 1h 27m 43s (non-voting)\n- trove-tox-bandit-baseline https://zuul.opendev.org/t/openstack/build/524a9e2f5f874a689ff8cc3ddcb202b7 : SUCCESS in 5m 02s","accounts_in_message":[],"_revision_number":2},{"id":"da23ceeddfce2fe7cb7f746b3270cc36822744c1","author":{"_account_id":36080,"name":"Erkin Mussurmankulov","display_name":"Eric","email":"erkin.mussurmankulov@ps.kz","username":"mongoose404","status":"PS Cloud services employee"},"date":"2026-08-16 19:56:26.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"ad1bedffa3ac834a89755a583b6da486917ccf39","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-08-16 19:56:51.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"959d781d20c85f133de3c5f21ebec37193aefc9d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-08-16 20:47:05.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/16d9269edb044aa1ba15c034608e2093\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a01fb85c08e749cca5344ca29fc16942 : SUCCESS in 4m 27s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/3c5d6ff0a2fb4f41874b9ed95a099b26 : SUCCESS in 4m 47s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/c23e25dd4096480a8ce1a3f0ae23f11d : SUCCESS in 5m 02s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/04298f5cdd054013b97b8ad64b619c95 : SUCCESS in 7m 00s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/cb15a15ae0894ef9aeba3f1eac56eaa2 : SUCCESS in 7m 22s\n- trove-tempest-ubuntu-base-mysql8.4 https://zuul.opendev.org/t/openstack/build/2e4047efbe8c459399999d82105cf320 : SUCCESS in 47m 53s\n- trove-tempest-ubuntu-base-mariadb11.4 https://zuul.opendev.org/t/openstack/build/97ac8f86fd6745bead5b9d632ccdb844 : SUCCESS in 44m 33s\n- trove-tempest-ubuntu-base-postgresql17 https://zuul.opendev.org/t/openstack/build/e9bbaacac07244f5aad2e9358a8faa57 : SUCCESS in 46m 49s","accounts_in_message":[],"_revision_number":2},{"id":"89eff89c6ea6e54ca813c7cf3effcd4c30343d27","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-08-16 20:47:05.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2},{"id":"de42335ae3fa61ed9400fc7d87cf752125b85d5b","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-08-16 20:47:59.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/c4ee5ae810044f2ba898dae885a679f2\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7f14b3b191254f55a15915d3d4d55683 : SUCCESS in 41s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/315668edc1994c769a70283061fbd8bc : SUCCESS in 39s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"8ca365ba0e32ef3b2be91fd120ed6f5f3f771874","revisions":{"1933b8ec908531a97481f024d286373e0e84c243":{"kind":"REWORK","_number":1,"created":"2026-08-15 08:25:21.000000000","uploader":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"ref":"refs/changes/18/1001018/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/trove","ref":"refs/changes/18/1001018/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/trove refs/changes/18/1001018/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/trove refs/changes/18/1001018/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/trove refs/changes/18/1001018/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/trove refs/changes/18/1001018/1"}}},"commit":{"parents":[{"commit":"3d1f393aa48c24bc9491ce2a0e24c10c52be6cec","subject":"Unmount volume before instance rebuild","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/trove/commit/3d1f393aa48c24bc9491ce2a0e24c10c52be6cec"}]}],"author":{"name":"Kieran Spear","email":"kieran@aptira.com","date":"2026-08-13 03:06:53.000000000","tz":600},"committer":{"name":"Ivan Anfimov","email":"lazekteam@gmail.com","date":"2026-08-15 08:25:21.000000000","tz":0},"subject":"Fix \u0027swfit\u0027 typo in backup storage driver default","message":"Fix \u0027swfit\u0027 typo in backup storage driver default\n\nBuiltInstanceTasks.create_backup defaults the storage driver to the\nmisspelled string \u0027swfit\u0027 when backup_info lacks a \u0027storage_driver\u0027\nkey. \u0027swfit\u0027 matches neither \"cinder\" nor \u0027swift\u0027, so the taskmanager\ncasts the backup to the guest without injecting swift_url. Since\n804f960b (\"Use pre-auth Swift client, drop Keystone re-auth\") the\nguest agent hard-requires swift_url and rejects such a request with\n\"Missing swift_url in backup metadata\".\n\nThe broken default is hard to reach in practice: both in-tree\nproducers of backup_info always set storage_driver (falling back to\nCONF.storage_strategy), so hitting it requires either a mixed-version\nrolling upgrade — a trove-api still running code from before e4113c55\n(\"Support new storage driver for backup objects\", which introduced\nboth the field and this typo) casting create_backup to a current\ntaskmanager, backup_info being a plain dict with no versioned schema\n— or an out-of-tree caller of the taskmanager RPC API. On the stable\nbranches that carry the typo it is currently harmless, because the\nguest-side swift_url requirement only exists on master.\n\nFix the default and add regression coverage for\nBuiltInstanceTasks.create_backup, which previously had no tests.\n\nGenerated-By: Claude Fable 5\nChange-Id: I6173f8172adb9b6fd5ab7ae75f21eb09c286a260\nSigned-off-by: Kieran Spear \u003ckieran@aptira.com\u003e\n(cherry picked from commit 130ce3b572efee97d6ca6bd847db0d20adbdba29)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/trove/commit/1933b8ec908531a97481f024d286373e0e84c243"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/trove/commit/1933b8ec908531a97481f024d286373e0e84c243"}]},"branch":"refs/heads/stable/2026.1","conflicts":{"base":"af8ebb3604d092b522d9376afe50ac01e58f1e31","ours":"3d1f393aa48c24bc9491ce2a0e24c10c52be6cec","theirs":"130ce3b572efee97d6ca6bd847db0d20adbdba29","merge_strategy":"recursive","contains_conflicts":false}},"8ca365ba0e32ef3b2be91fd120ed6f5f3f771874":{"kind":"REWORK","_number":2,"created":"2026-08-15 13:02:58.000000000","uploader":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"ref":"refs/changes/18/1001018/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/trove","ref":"refs/changes/18/1001018/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/trove refs/changes/18/1001018/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/trove refs/changes/18/1001018/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/trove refs/changes/18/1001018/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/trove refs/changes/18/1001018/2"}}},"commit":{"parents":[{"commit":"3d1f393aa48c24bc9491ce2a0e24c10c52be6cec","subject":"Unmount volume before instance rebuild","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/trove/commit/3d1f393aa48c24bc9491ce2a0e24c10c52be6cec"}]}],"author":{"name":"Kieran Spear","email":"kieran@aptira.com","date":"2026-08-13 03:06:53.000000000","tz":600},"committer":{"name":"Ivan Anfimov","email":"lazekteam@gmail.com","date":"2026-08-15 13:02:56.000000000","tz":0},"subject":"Fix \u0027swfit\u0027 typo in backup storage driver default","message":"Fix \u0027swfit\u0027 typo in backup storage driver default\n\nBuiltInstanceTasks.create_backup defaults the storage driver to the\nmisspelled string \u0027swfit\u0027 when backup_info lacks a \u0027storage_driver\u0027\nkey. \u0027swfit\u0027 matches neither \"cinder\" nor \u0027swift\u0027, so the taskmanager\ncasts the backup to the guest without injecting swift_url. Since\n804f960b (\"Use pre-auth Swift client, drop Keystone re-auth\") the\nguest agent hard-requires swift_url and rejects such a request with\n\"Missing swift_url in backup metadata\".\n\nThe broken default is hard to reach in practice: both in-tree\nproducers of backup_info always set storage_driver (falling back to\nCONF.storage_strategy), so hitting it requires either a mixed-version\nrolling upgrade — a trove-api still running code from before e4113c55\n(\"Support new storage driver for backup objects\", which introduced\nboth the field and this typo) casting create_backup to a current\ntaskmanager, backup_info being a plain dict with no versioned schema\n— or an out-of-tree caller of the taskmanager RPC API. On the stable\nbranches that carry the typo it is currently harmless, because the\nguest-side swift_url requirement only exists on master.\n\nFix the default and add regression coverage for\nBuiltInstanceTasks.create_backup, which previously had no tests.\n\nGenerated-By: Claude Fable 5\nChange-Id: I6173f8172adb9b6fd5ab7ae75f21eb09c286a260\nSigned-off-by: Kieran Spear \u003ckieran@aptira.com\u003e\n(cherry picked from commit 130ce3b572efee97d6ca6bd847db0d20adbdba29)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/trove/commit/8ca365ba0e32ef3b2be91fd120ed6f5f3f771874"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/trove/commit/8ca365ba0e32ef3b2be91fd120ed6f5f3f771874"}]},"branch":"refs/heads/stable/2026.1"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":36080,"name":"Erkin Mussurmankulov","display_name":"Eric","email":"erkin.mussurmankulov@ps.kz","username":"mongoose404","status":"PS Cloud services employee"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":36080,"name":"Erkin Mussurmankulov","display_name":"Eric","email":"erkin.mussurmankulov@ps.kz","username":"mongoose404","status":"PS Cloud services employee"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}