)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9749,"name":"Greg Lucas","email":"greg@glucas.net","username":"glucas"},"change_message_id":"7c7848976b7ce0e153db052f26a6f43c58bd5dcd","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixed restore to work correctly with pexpect"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixed an issue with restore where it was failing with pexpect 3.2."},{"line_number":10,"context_line":"pexpect attempts to stop the temp mysqld process which fails due to"},{"line_number":11,"context_line":"a difference in privilege level (since the process was run with sudo)."},{"line_number":12,"context_line":"We now use mysqladmin shutdown to stop the temp mysqld process."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1abeadc6_47e79940","line":9,"updated":"2014-08-26 15:23:50.000000000","message":"Closes-Bug: 1343344\n\n(The issue is not with pexpect, because the behavior in question is the same in pexpect 2.3 vs 3.2. It is caused by a change in the sudo implementation after Ubuntu 12.04, as noted in the bug comments.)","commit_id":"ef82ab1d60d2fa3d10a2c452d516f2320746a113"}],"trove/guestagent/strategies/restore/mysql_impl.py":[{"author":{"_account_id":9749,"name":"Greg Lucas","email":"greg@glucas.net","username":"glucas"},"change_message_id":"5ace3511959537724a7df7f64b79c20b5424ab65","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            LOG.info(_(\"Root password reset successfully!\"))"},{"line_number":80,"context_line":"            LOG.info(_(\"Cleaning up the temp mysqld process...\"))"},{"line_number":81,"context_line":"            utils.execute_with_timeout(\"mysqladmin\", \"-uroot\","},{"line_number":82,"context_line":"                                       \"--protocol\u003dtcp\", \"shutdown\")"},{"line_number":83,"context_line":"            utils.execute_with_timeout(\"sudo\", \"killall\", \"mysqld_safe\")"},{"line_number":84,"context_line":"            utils.execute_with_timeout(\"sudo\", \"killall\", \"mysqld\")"},{"line_number":85,"context_line":"            self.poll_until_then_raise("}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_704b1b2b","line":82,"updated":"2014-07-18 21:35:34.000000000","message":"Looks like you still need to pass the password here, even though it has been set to empty string. This works for me in bash:\n\n mysqladmin -uroot --protocol\u003dtcp --password\u003d\"\" shutdown","commit_id":"0817322978eb7899771627aed1e6e2bcb07c626c"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"1ebc8c01af4125da7800d1a8e840b8354835393f","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            LOG.info(_(\"Root password reset successfully!\"))"},{"line_number":80,"context_line":"            LOG.info(_(\"Cleaning up the temp mysqld process...\"))"},{"line_number":81,"context_line":"            utils.execute_with_timeout(\"mysqladmin\", \"-uroot\","},{"line_number":82,"context_line":"                                       \"--protocol\u003dtcp\", \"shutdown\")"},{"line_number":83,"context_line":"            utils.execute_with_timeout(\"sudo\", \"killall\", \"mysqld_safe\")"},{"line_number":84,"context_line":"            utils.execute_with_timeout(\"sudo\", \"killall\", \"mysqld\")"},{"line_number":85,"context_line":"            self.poll_until_then_raise("}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_66e7e512","line":82,"in_reply_to":"baada198_704b1b2b","updated":"2014-07-18 22:36:38.000000000","message":"+1","commit_id":"0817322978eb7899771627aed1e6e2bcb07c626c"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"4826627381347b1d5f53dc7585eff522a3c1c420","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            LOG.info(_(\"Root password reset successfully!\"))"},{"line_number":80,"context_line":"            LOG.info(_(\"Cleaning up the temp mysqld process...\"))"},{"line_number":81,"context_line":"            utils.execute_with_timeout(\"mysqladmin\", \"-uroot\","},{"line_number":82,"context_line":"                                       \"--protocol\u003dtcp\", \"shutdown\")"},{"line_number":83,"context_line":"            utils.execute_with_timeout(\"sudo\", \"killall\", \"mysqld_safe\")"},{"line_number":84,"context_line":"            utils.execute_with_timeout(\"sudo\", \"killall\", \"mysqld\")"},{"line_number":85,"context_line":"            self.poll_until_then_raise("}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_d05f64e3","line":82,"in_reply_to":"baada198_704b1b2b","updated":"2014-07-21 09:36:05.000000000","message":"Ah, must be a difference between mysql and percona-server. Probably safe to set it like you mention, though.","commit_id":"0817322978eb7899771627aed1e6e2bcb07c626c"},{"author":{"_account_id":9749,"name":"Greg Lucas","email":"greg@glucas.net","username":"glucas"},"change_message_id":"5ace3511959537724a7df7f64b79c20b5424ab65","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            utils.execute_with_timeout(\"mysqladmin\", \"-uroot\","},{"line_number":82,"context_line":"                                       \"--protocol\u003dtcp\", \"shutdown\")"},{"line_number":83,"context_line":"            utils.execute_with_timeout(\"sudo\", \"killall\", \"mysqld_safe\")"},{"line_number":84,"context_line":"            utils.execute_with_timeout(\"sudo\", \"killall\", \"mysqld\")"},{"line_number":85,"context_line":"            self.poll_until_then_raise("},{"line_number":86,"context_line":"                self.mysql_is_not_running,"},{"line_number":87,"context_line":"                base.RestoreError(\"Reset root password failed: \""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_d065c7af","line":84,"updated":"2014-07-18 21:35:34.000000000","message":"Should we use base.exec_with_root_helper for these two sudo commands?","commit_id":"0817322978eb7899771627aed1e6e2bcb07c626c"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"1ebc8c01af4125da7800d1a8e840b8354835393f","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            utils.execute_with_timeout(\"mysqladmin\", \"-uroot\","},{"line_number":82,"context_line":"                                       \"--protocol\u003dtcp\", \"shutdown\")"},{"line_number":83,"context_line":"            utils.execute_with_timeout(\"sudo\", \"killall\", \"mysqld_safe\")"},{"line_number":84,"context_line":"            utils.execute_with_timeout(\"sudo\", \"killall\", \"mysqld\")"},{"line_number":85,"context_line":"            self.poll_until_then_raise("},{"line_number":86,"context_line":"                self.mysql_is_not_running,"},{"line_number":87,"context_line":"                base.RestoreError(\"Reset root password failed: \""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_c6c1914f","line":84,"in_reply_to":"baada198_d065c7af","updated":"2014-07-18 22:36:38.000000000","message":"it seems like another wrapper for processutil.exec\nso, actually nothing would changed i suppose.","commit_id":"0817322978eb7899771627aed1e6e2bcb07c626c"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"0c996b217a95cf06801a132f02384f7d7fc1f863","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            LOG.info(_(\"Root password reset successfully!\"))"},{"line_number":80,"context_line":"            LOG.info(_(\"Cleaning up the temp mysqld process...\"))"},{"line_number":81,"context_line":"            utils.execute_with_timeout(\"mysqladmin\", \"-uroot\", \"--password\u003d\u0027\u0027\","},{"line_number":82,"context_line":"                                       \"--protocol\u003dtcp\", \"shutdown\")"},{"line_number":83,"context_line":"            utils.execute_with_timeout(\"killall\", \"mysqld_safe\","},{"line_number":84,"context_line":"                                       root_helper\u003d\"sudo\", run_as_root\u003dTrue)"},{"line_number":85,"context_line":"            utils.execute_with_timeout(\"killall\", \"mysqld\","}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_f135e4f7","line":82,"updated":"2014-08-25 21:03:49.000000000","message":"can we change this to mysqladmin shutdown? so it works with debian","commit_id":"64a4f95005f74d261fb65e14b50177db02260481"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"b5f8a02f813e3ed2c6fba2868d15cc71ca404cd8","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            LOG.info(_(\"Root password reset successfully!\"))"},{"line_number":80,"context_line":"            LOG.info(_(\"Cleaning up the temp mysqld process...\"))"},{"line_number":81,"context_line":"            utils.execute_with_timeout(\"mysqladmin\", \"-uroot\", \"--password\u003d\u0027\u0027\","},{"line_number":82,"context_line":"                                       \"--protocol\u003dtcp\", \"shutdown\")"},{"line_number":83,"context_line":"            utils.execute_with_timeout(\"killall\", \"mysqld_safe\","},{"line_number":84,"context_line":"                                       root_helper\u003d\"sudo\", run_as_root\u003dTrue)"},{"line_number":85,"context_line":"            utils.execute_with_timeout(\"killall\", \"mysqld\","}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_4385edab","line":82,"in_reply_to":"1abeadc6_f135e4f7","updated":"2014-08-25 22:48:59.000000000","message":"This works without supplying a password on ubuntu 14.04. I think it should work similarly with debian. \n\nI\u0027ve updated the patch based on this; please confirm for debian as well. Thanks!","commit_id":"64a4f95005f74d261fb65e14b50177db02260481"}]}