)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"9686f2d80eaa86a4d6a2c76100bca81672080004","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add notifications for trove.instance.* actions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Reasons:"},{"line_number":10,"context_line":" - Trove should emmit notifications at certain stages."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Changes:"},{"line_number":13,"context_line":" - adding instance.:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ae5cdf2_68e5a1a2","line":10,"updated":"2014-06-21 22:39:57.000000000","message":"also, this should be \u0027emit\u0027.","commit_id":"0db3b57073b22d944ee1c00008e3555ce5e508fc"}],"trove/taskmanager/models.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"a56cfeeb1a3ee3337fb5c954230bb34cbf2ff890","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        return datastore_manager_id"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def send_usage_event(self, event_type, **kwargs):"},{"line_number":89,"context_line":"        event_type \u003d \u0027trove.instance.%s\u0027 % event_type"},{"line_number":90,"context_line":"        publisher_id \u003d CONF.host"},{"line_number":91,"context_line":"        # Grab the instance size from the kwargs or from the nova client"},{"line_number":92,"context_line":"        instance_size \u003d kwargs.pop(\u0027instance_size\u0027, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_885aed7f","side":"PARENT","line":89,"updated":"2014-06-21 22:39:24.000000000","message":"would this be a problem?","commit_id":"cb5405e756a784fb339f1057a2a28c3944865e1e"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"a56cfeeb1a3ee3337fb5c954230bb34cbf2ff890","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        # Default payload"},{"line_number":100,"context_line":"        created_time \u003d timeutils.isotime(self.db_info.created)"},{"line_number":101,"context_line":"        payload \u003d {"},{"line_number":102,"context_line":"            \u0027availability_zone\u0027: az,"},{"line_number":103,"context_line":"            \u0027created_at\u0027: created_time,"},{"line_number":104,"context_line":"            \u0027name\u0027: self.name,"},{"line_number":105,"context_line":"            \u0027instance_id\u0027: self.id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_48646548","side":"PARENT","line":102,"updated":"2014-06-21 22:39:24.000000000","message":"a potentially unintended consequence of your change above is that if the event type is not self.instance_create_start, then az may not be set.","commit_id":"cb5405e756a784fb339f1057a2a28c3944865e1e"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"a56cfeeb1a3ee3337fb5c954230bb34cbf2ff890","unresolved":false,"context_lines":[{"line_number":259,"context_line":"                             time_out\u003dusage_timeout)"},{"line_number":260,"context_line":"            self.send_usage_event(\u0027create\u0027, instance_size\u003dflavor[\u0027ram\u0027])"},{"line_number":261,"context_line":"        except PollTimeOut:"},{"line_number":262,"context_line":"            LOG.error(_(\"Timeout for service changing to active. \""},{"line_number":263,"context_line":"                      \"No usage create-event sent.\"))"},{"line_number":264,"context_line":"            self.update_statuses_on_time_out()"},{"line_number":265,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_c8d6b5c2","side":"PARENT","line":262,"updated":"2014-06-21 22:39:24.000000000","message":"no .error needed here?","commit_id":"cb5405e756a784fb339f1057a2a28c3944865e1e"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"a56cfeeb1a3ee3337fb5c954230bb34cbf2ff890","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    This adds the ability to send usage events to an Instance object."},{"line_number":77,"context_line":"    \"\"\""},{"line_number":78,"context_line":"    INSTANCE_CREATE_START \u003d \"create.start\""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def _get_service_id(self, datastore_manager, id_map):"},{"line_number":81,"context_line":"        if datastore_manager in id_map:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_08189dcb","line":78,"updated":"2014-06-21 22:39:24.000000000","message":"you use this variable just once, why bother creating it?","commit_id":"0db3b57073b22d944ee1c00008e3555ce5e508fc"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"a56cfeeb1a3ee3337fb5c954230bb34cbf2ff890","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            instance_size \u003d flavor.ram"},{"line_number":97,"context_line":"        az \u003d kwargs.pop(\u0027az\u0027, None)"},{"line_number":98,"context_line":"        if not az:"},{"line_number":99,"context_line":"            if not event_type !\u003d self.INSTANCE_CREATE_START:"},{"line_number":100,"context_line":"                server \u003d kwargs.pop(\u0027server\u0027, None)"},{"line_number":101,"context_line":"                if server is None:"},{"line_number":102,"context_line":"                    server \u003d self.nova_client.servers.get(self.server_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_481625a8","line":99,"updated":"2014-06-21 22:39:24.000000000","message":"is there a particular reason why you chose \n\nIF NOT A !\u003d B?\n\nCould this be written more simply?\n\nAlso, this is the only place where you use INSTANCE_CREATE_START. Does it provide one any utility?","commit_id":"0db3b57073b22d944ee1c00008e3555ce5e508fc"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"a56cfeeb1a3ee3337fb5c954230bb34cbf2ff890","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            \u0027name\u0027: self.name,"},{"line_number":111,"context_line":"            \u0027instance_id\u0027: self.id,"},{"line_number":112,"context_line":"            \u0027instance_name\u0027: self.name,"},{"line_number":113,"context_line":"            \u0027instance_size\u0027: instance_size,"},{"line_number":114,"context_line":"            \u0027instance_type\u0027: flavor.name,"},{"line_number":115,"context_line":"            \u0027instance_type_id\u0027: flavor.id,"},{"line_number":116,"context_line":"            \u0027launched_at\u0027: created_time,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_88d10dce","line":113,"updated":"2014-06-21 22:39:24.000000000","message":"why is this?","commit_id":"0db3b57073b22d944ee1c00008e3555ce5e508fc"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"a56cfeeb1a3ee3337fb5c954230bb34cbf2ff890","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            packages\u003dpackages, volume_size\u003dvolume_size,"},{"line_number":181,"context_line":"            backup_id\u003dbackup_id, root_password\u003droot_password,"},{"line_number":182,"context_line":"            nics\u003dnics, overrides\u003doverrides"},{"line_number":183,"context_line":"        )"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        security_groups \u003d None"},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_a8db29eb","line":183,"updated":"2014-06-21 22:39:24.000000000","message":"There seem to be many circumstances where you would have a create.start but no corresponding .end. Is that advisable?","commit_id":"0db3b57073b22d944ee1c00008e3555ce5e508fc"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"022b7a786abedba678ce2181d78da75cfb091fe3","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            packages\u003dpackages, volume_size\u003dvolume_size,"},{"line_number":181,"context_line":"            backup_id\u003dbackup_id, root_password\u003droot_password,"},{"line_number":182,"context_line":"            nics\u003dnics, overrides\u003doverrides"},{"line_number":183,"context_line":"        )"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        security_groups \u003d None"},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_55286c85","line":183,"in_reply_to":"1ae5cdf2_a8db29eb","updated":"2014-06-23 08:43:00.000000000","message":"There are two possible notifications for create method:\n1. create.create\n2. create.end/error\n\nSo, if you looked over all patchset you will see, that if error will happen - only start/error will happen.\nAnd if no error will apper - start/end.","commit_id":"0db3b57073b22d944ee1c00008e3555ce5e508fc"},{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"d7e65079bb77a73b7f0db2617e54b79b3bc3446c","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                        self.server_id)"},{"line_number":103,"context_line":"                except nova_exceptions.NotFound:"},{"line_number":104,"context_line":"                    pass"},{"line_number":105,"context_line":"                finally:"},{"line_number":106,"context_line":"                    if server:"},{"line_number":107,"context_line":"                        az \u003d getattr("},{"line_number":108,"context_line":"                            server, \u0027OS-EXT-AZ:availability_zone\u0027, None)"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_9606d61b","line":105,"updated":"2014-07-04 11:43:16.000000000","message":"If server is not None (at the time of the \"if not server and\" stmt) then this finally block won\u0027t get executed. I don\u0027t think that is the behaviour you are expecting? (i.e. the az wouldn\u0027t get set if the server is passed in)","commit_id":"ce0d6a4f02a6154bcc73d12ae9a17413489a81a9"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"6e6f1aeb58d56a634326df64d6431fd29d4f833e","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                        self.server_id)"},{"line_number":103,"context_line":"                except nova_exceptions.NotFound:"},{"line_number":104,"context_line":"                    pass"},{"line_number":105,"context_line":"                finally:"},{"line_number":106,"context_line":"                    if server:"},{"line_number":107,"context_line":"                        az \u003d getattr("},{"line_number":108,"context_line":"                            server, \u0027OS-EXT-AZ:availability_zone\u0027, None)"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_df85c107","line":105,"in_reply_to":"baada198_9606d61b","updated":"2014-07-04 14:04:05.000000000","message":"Agreed. I\u0027ll fix it in a new patchset.","commit_id":"ce0d6a4f02a6154bcc73d12ae9a17413489a81a9"}]}