)]}'
{"trove/guestagent/strategies/restore/mysql_impl.py":[{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"3c2661c8b65be596030ed7990fdd4f66147e0b3c","unresolved":false,"context_lines":[{"line_number":211,"context_line":"            # for *this* backup set the incremental_dir"},{"line_number":212,"context_line":"            # just use the checksum for the incremental path as it is"},{"line_number":213,"context_line":"            # sufficently unique /tmp/\u003cchecksum\u003e"},{"line_number":214,"context_line":"            incremental_dir \u003d os.path.join(\u0027/tmp\u0027, checksum)"},{"line_number":215,"context_line":"            utils.execute(\"mkdir\", \"-p\", incremental_dir,"},{"line_number":216,"context_line":"                          root_helper\u003d\"sudo\","},{"line_number":217,"context_line":"                          run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_d8bd2369","line":214,"updated":"2014-06-25 17:25:22.000000000","message":"I am not sure that’s the right fix.  The issue with using /tmp is having enough space.  I think the right fix is to continue to use /var/lib/mysql (which will have space) and then delete after the restore is complete.","commit_id":"f856aed860b165ebb131704748824f91c6fd0e52"}],"trove/tests/api/backups.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"b14e6f00561ffaafd56367b0b51090a9149e0104","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    @test"},{"line_number":254,"context_line":"    def test_create_db(self):"},{"line_number":255,"context_line":"        global total_num_dbs"},{"line_number":256,"context_line":"        total_num_dbs \u003d len(instance_info.dbaas.databases.list("},{"line_number":257,"context_line":"            instance_info.id))"},{"line_number":258,"context_line":"        databases \u003d [{\u0027name\u0027: incremental_db}]"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_16471c1e","line":255,"updated":"2014-06-27 06:14:09.000000000","message":"please do not use globals in tests, find another way","commit_id":"a4c4555b6ffd9488cc7aac3112663edf87598578"},{"author":{"_account_id":11316,"name":"Steve Leon","email":"kokhang@gmail.com","username":"kokhang"},"change_message_id":"bde0ab844ec2c69073160d5c02eedf99ef2be066","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    @test"},{"line_number":254,"context_line":"    def test_create_db(self):"},{"line_number":255,"context_line":"        global total_num_dbs"},{"line_number":256,"context_line":"        total_num_dbs \u003d len(instance_info.dbaas.databases.list("},{"line_number":257,"context_line":"            instance_info.id))"},{"line_number":258,"context_line":"        databases \u003d [{\u0027name\u0027: incremental_db}]"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_82ccb762","line":255,"in_reply_to":"1ae5cdf2_16471c1e","updated":"2014-06-27 16:14:03.000000000","message":"Why dont you like globals? They are being used through out this test.\nI understand that globals can be confusing and not appealing in programming. But this is just a test. So i think it is ok.","commit_id":"a4c4555b6ffd9488cc7aac3112663edf87598578"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"715f1d992d11fe28472f134b295aa53b3649743a","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    @test"},{"line_number":254,"context_line":"    def test_create_db(self):"},{"line_number":255,"context_line":"        global total_num_dbs"},{"line_number":256,"context_line":"        total_num_dbs \u003d len(instance_info.dbaas.databases.list("},{"line_number":257,"context_line":"            instance_info.id))"},{"line_number":258,"context_line":"        databases \u003d [{\u0027name\u0027: incremental_db}]"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_10ebad13","line":255,"in_reply_to":"1ae5cdf2_82ccb762","updated":"2014-07-04 10:55:55.000000000","message":"It\u0027s hard to parallelize tests that has globals, just find out another way to operate with needed attributes\nSimple solution: user \u0027self.xxxx\u0027","commit_id":"a4c4555b6ffd9488cc7aac3112663edf87598578"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"56cfbf644645590a49f6fc3dfc264d8599f9ed58","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    @test"},{"line_number":254,"context_line":"    def test_create_db(self):"},{"line_number":255,"context_line":"        global total_num_dbs"},{"line_number":256,"context_line":"        total_num_dbs \u003d len(instance_info.dbaas.databases.list("},{"line_number":257,"context_line":"            instance_info.id))"},{"line_number":258,"context_line":"        databases \u003d [{\u0027name\u0027: incremental_db}]"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_89f1c96c","line":255,"in_reply_to":"baada198_03d59f42","updated":"2014-07-09 21:33:28.000000000","message":"The issue is that test_database_restored_incremental is in a different class. So it wont be able to access the self.total_numb_dbs defined in this class. I can make it a class variable.","commit_id":"a4c4555b6ffd9488cc7aac3112663edf87598578"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"7e51a7b6d551c019bf3e8736dc9756c99b982c26","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    @test"},{"line_number":254,"context_line":"    def test_create_db(self):"},{"line_number":255,"context_line":"        global total_num_dbs"},{"line_number":256,"context_line":"        total_num_dbs \u003d len(instance_info.dbaas.databases.list("},{"line_number":257,"context_line":"            instance_info.id))"},{"line_number":258,"context_line":"        databases \u003d [{\u0027name\u0027: incremental_db}]"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_2420629a","line":255,"in_reply_to":"baada198_10ebad13","updated":"2014-07-06 12:44:22.000000000","message":"if one test really cared about the number of databases around, and another test was either creating or deleting them, globals don\u0027t make the problem any worse. Inherently there is a dependency between the tests and a latent race condition.","commit_id":"a4c4555b6ffd9488cc7aac3112663edf87598578"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"2d08b9546adfbc57b5b445840408c7d4514f5bdb","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    @test"},{"line_number":254,"context_line":"    def test_create_db(self):"},{"line_number":255,"context_line":"        global total_num_dbs"},{"line_number":256,"context_line":"        total_num_dbs \u003d len(instance_info.dbaas.databases.list("},{"line_number":257,"context_line":"            instance_info.id))"},{"line_number":258,"context_line":"        databases \u003d [{\u0027name\u0027: incremental_db}]"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_87e3c9d7","line":255,"in_reply_to":"baada198_2420629a","updated":"2014-07-07 20:46:45.000000000","message":"Hey Denis, removing the globals is out of the scope of this bug fix and will delay this bug fix. As i mentioned, this is how the test is. Removing all the globals will required a rewrite on all these tests in the suites.","commit_id":"a4c4555b6ffd9488cc7aac3112663edf87598578"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"4f8f2e75e1bb3363a6cbbcbaa14f90cacd5537e9","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    @test"},{"line_number":254,"context_line":"    def test_create_db(self):"},{"line_number":255,"context_line":"        global total_num_dbs"},{"line_number":256,"context_line":"        total_num_dbs \u003d len(instance_info.dbaas.databases.list("},{"line_number":257,"context_line":"            instance_info.id))"},{"line_number":258,"context_line":"        databases \u003d [{\u0027name\u0027: incremental_db}]"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_03d59f42","line":255,"in_reply_to":"baada198_87e3c9d7","updated":"2014-07-09 17:46:05.000000000","message":"I don\u0027t think Denis\u0027 asking to change all the globals. I think what he\u0027s saying is that it\u0027s probably better for this global introduced (self.total_numb_dbs) to be a an instance variable, since the only other test that should be reading from it is \u0027test_database_restored_incremental\u0027. I think that should work, right?","commit_id":"a4c4555b6ffd9488cc7aac3112663edf87598578"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"c5371bd37b8bc62d1f7b107cf330c9507ad65cef","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    @test"},{"line_number":254,"context_line":"    def test_create_db(self):"},{"line_number":255,"context_line":"        global total_num_dbs"},{"line_number":256,"context_line":"        total_num_dbs \u003d len(instance_info.dbaas.databases.list("},{"line_number":257,"context_line":"            instance_info.id))"},{"line_number":258,"context_line":"        databases \u003d [{\u0027name\u0027: incremental_db}]"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_c6347ce1","line":255,"in_reply_to":"baada198_89f1c96c","updated":"2014-07-10 08:42:08.000000000","message":"Ah, I was basing my comment off of the comment above, but failed to notice that you\u0027re using total_num_dbs across classes.","commit_id":"a4c4555b6ffd9488cc7aac3112663edf87598578"}]}