)]}'
{"etc/trove/trove.conf.sample":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"29efd08876c0e4087991e8de3a7dff8f6f6ed3b6","unresolved":false,"context_lines":[{"line_number":12,"context_line":"bind_port \u003d 8779"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Number of workers for the API service. The default will"},{"line_number":15,"context_line":"# be the number of CPUs available. (integer value)"},{"line_number":16,"context_line":"#trove_api_workers\u003dNone"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# The RabbitMQ broker address where a single node is used."}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baada198_5ba79a4f","line":15,"updated":"2014-07-01 08:24:47.000000000","message":"cfh.py says that there\u0027s no default for this configuration attribute. Comment should be re-written.","commit_id":"bfb0f2438e4b2bc62512c80132ea050423034def"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"929343fc61085a4fc32a032d1def3491b205a0fa","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Number of workers for the API service. The default will"},{"line_number":15,"context_line":"# be the number of CPUs available. (integer value)"},{"line_number":16,"context_line":"#trove_api_workers\u003dNone"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# The RabbitMQ broker address where a single node is used."},{"line_number":19,"context_line":"# (string value)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baada198_87aad0d2","line":16,"updated":"2014-06-30 16:21:00.000000000","message":"why does string assinged to integer? Should be any int, but not string.","commit_id":"bfb0f2438e4b2bc62512c80132ea050423034def"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d928fc0c330c1eac708e8c3f3de3671b2231e241","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Number of workers for the API service. The default will"},{"line_number":15,"context_line":"# be the number of CPUs available. (integer value)"},{"line_number":16,"context_line":"#trove_api_workers\u003dNone"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# The RabbitMQ broker address where a single node is used."},{"line_number":19,"context_line":"# (string value)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baada198_b97369b0","line":16,"in_reply_to":"baada198_87aad0d2","updated":"2014-07-01 00:58:45.000000000","message":"Because None is how you check that it isn\u0027t set, otherwise you have to put logic in for some other marker value, like -1 or 0, and then it\u0027s inconsistent with how this is done in nova, cinder and glance.","commit_id":"bfb0f2438e4b2bc62512c80132ea050423034def"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"29efd08876c0e4087991e8de3a7dff8f6f6ed3b6","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Number of workers for the API service. The default will"},{"line_number":15,"context_line":"# be the number of CPUs available. (integer value)"},{"line_number":16,"context_line":"#trove_api_workers\u003dNone"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# The RabbitMQ broker address where a single node is used."},{"line_number":19,"context_line":"# (string value)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baada198_bbd196cf","line":16,"in_reply_to":"baada198_b97369b0","updated":"2014-07-01 08:24:47.000000000","message":"It is a sample config, and int _should_ assigned instead of None","commit_id":"bfb0f2438e4b2bc62512c80132ea050423034def"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ffc4949fb8c456fcc28c27d1c0db30987216201e","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Number of workers for the API service. The default will"},{"line_number":15,"context_line":"# be the number of CPUs available. (integer value)"},{"line_number":16,"context_line":"#trove_api_workers\u003dNone"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# The RabbitMQ broker address where a single node is used."},{"line_number":19,"context_line":"# (string value)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baada198_e61d24bf","line":16,"in_reply_to":"baada198_bbd196cf","updated":"2014-07-01 15:28:06.000000000","message":"None is the default for IntOpt in oslo.config and is used as the flag for determining if the new default of processutils.get_worker_count() should be used, this is how it\u0027s done in nova/cinder/glance also.\n\nIf not None, what do you propose? 0? -1?  0 has a different meaning for this value in glance, so that would be confusing to an admin setting up the various services - same with -1.  If trove uses different default values for the worker settings it\u0027s going to be confusing for configuration when you\u0027re used to how this is done in 3 other core projects.","commit_id":"bfb0f2438e4b2bc62512c80132ea050423034def"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b66a6f51344627031a4ad7611e083868eaefccb3","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Number of workers for the API service. The default will"},{"line_number":15,"context_line":"# be the number of CPUs available. (integer value)"},{"line_number":16,"context_line":"#trove_api_workers\u003dNone"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# The RabbitMQ broker address where a single node is used."},{"line_number":19,"context_line":"# (string value)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baada198_9a6af718","line":16,"in_reply_to":"baada198_e61d24bf","updated":"2014-07-01 16:56:23.000000000","message":"(a) this is a sample file\n(b) I looked at the code in other projects that use this and None is the way in which they setup for unspecified value. Using magic values seems like the wrong thing to do.\n\nI agree with Matt that this is a good proposal","commit_id":"bfb0f2438e4b2bc62512c80132ea050423034def"}],"etc/trove/trove.conf.test":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"929343fc61085a4fc32a032d1def3491b205a0fa","unresolved":false,"context_lines":[{"line_number":35,"context_line":"bind_port \u003d 8779"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# Number of workers for the API service. The default will"},{"line_number":38,"context_line":"# be the number of CPUs available. (integer value)"},{"line_number":39,"context_line":"#trove_api_workers\u003dNone"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# AMQP Connection info"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baada198_07b6c03d","line":38,"updated":"2014-06-30 16:21:00.000000000","message":"same","commit_id":"bfb0f2438e4b2bc62512c80132ea050423034def"}],"trove/common/cfg.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"929343fc61085a4fc32a032d1def3491b205a0fa","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    cfg.BoolOpt(\u0027trove_security_groups_support\u0027, default\u003dTrue),"},{"line_number":157,"context_line":"    cfg.StrOpt(\u0027trove_security_group_name_prefix\u0027, default\u003d\u0027SecGroup\u0027),"},{"line_number":158,"context_line":"    cfg.StrOpt(\u0027trove_security_group_rule_cidr\u0027, default\u003d\u00270.0.0.0/0\u0027),"},{"line_number":159,"context_line":"    cfg.IntOpt(\u0027trove_api_workers\u0027,"},{"line_number":160,"context_line":"               help\u003d\"Number of workers for the API service. The default will \""},{"line_number":161,"context_line":"               \"be the number of CPUs available.\"),"},{"line_number":162,"context_line":"    cfg.IntOpt(\u0027usage_sleep_time\u0027, default\u003d5,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_e7bd4c04","line":159,"updated":"2014-06-30 16:21:00.000000000","message":"i\u0027d suggest to use default from operating system environment. Or use \u0027nproc\u0027 to define how many CPU\u0027s server has","commit_id":"bfb0f2438e4b2bc62512c80132ea050423034def"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"29efd08876c0e4087991e8de3a7dff8f6f6ed3b6","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    cfg.BoolOpt(\u0027trove_security_groups_support\u0027, default\u003dTrue),"},{"line_number":157,"context_line":"    cfg.StrOpt(\u0027trove_security_group_name_prefix\u0027, default\u003d\u0027SecGroup\u0027),"},{"line_number":158,"context_line":"    cfg.StrOpt(\u0027trove_security_group_rule_cidr\u0027, default\u003d\u00270.0.0.0/0\u0027),"},{"line_number":159,"context_line":"    cfg.IntOpt(\u0027trove_api_workers\u0027,"},{"line_number":160,"context_line":"               help\u003d\"Number of workers for the API service. The default will \""},{"line_number":161,"context_line":"               \"be the number of CPUs available.\"),"},{"line_number":162,"context_line":"    cfg.IntOpt(\u0027usage_sleep_time\u0027, default\u003d5,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_9bf3f272","line":159,"in_reply_to":"baada198_59740d9c","updated":"2014-07-01 08:24:47.000000000","message":"Ok. Then config samples are should be updated.","commit_id":"bfb0f2438e4b2bc62512c80132ea050423034def"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ffc4949fb8c456fcc28c27d1c0db30987216201e","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    cfg.BoolOpt(\u0027trove_security_groups_support\u0027, default\u003dTrue),"},{"line_number":157,"context_line":"    cfg.StrOpt(\u0027trove_security_group_name_prefix\u0027, default\u003d\u0027SecGroup\u0027),"},{"line_number":158,"context_line":"    cfg.StrOpt(\u0027trove_security_group_rule_cidr\u0027, default\u003d\u00270.0.0.0/0\u0027),"},{"line_number":159,"context_line":"    cfg.IntOpt(\u0027trove_api_workers\u0027,"},{"line_number":160,"context_line":"               help\u003d\"Number of workers for the API service. The default will \""},{"line_number":161,"context_line":"               \"be the number of CPUs available.\"),"},{"line_number":162,"context_line":"    cfg.IntOpt(\u0027usage_sleep_time\u0027, default\u003d5,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_06de9811","line":159,"in_reply_to":"baada198_9bf3f272","updated":"2014-07-01 15:28:06.000000000","message":"Updated how?  I already updated the wording in the config samples.  The default for an IntOpt in oslo.config is None, which is used as a flag in the code to use the new default of processutils.get_worker_count().","commit_id":"bfb0f2438e4b2bc62512c80132ea050423034def"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d928fc0c330c1eac708e8c3f3de3671b2231e241","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    cfg.BoolOpt(\u0027trove_security_groups_support\u0027, default\u003dTrue),"},{"line_number":157,"context_line":"    cfg.StrOpt(\u0027trove_security_group_name_prefix\u0027, default\u003d\u0027SecGroup\u0027),"},{"line_number":158,"context_line":"    cfg.StrOpt(\u0027trove_security_group_rule_cidr\u0027, default\u003d\u00270.0.0.0/0\u0027),"},{"line_number":159,"context_line":"    cfg.IntOpt(\u0027trove_api_workers\u0027,"},{"line_number":160,"context_line":"               help\u003d\"Number of workers for the API service. The default will \""},{"line_number":161,"context_line":"               \"be the number of CPUs available.\"),"},{"line_number":162,"context_line":"    cfg.IntOpt(\u0027usage_sleep_time\u0027, default\u003d5,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_59740d9c","line":159,"in_reply_to":"baada198_e7bd4c04","updated":"2014-07-01 00:58:45.000000000","message":"That\u0027s what the code does when it gets the value.","commit_id":"bfb0f2438e4b2bc62512c80132ea050423034def"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"6b8c9698bd6733ca43dffd01df61de2e4bbd69c9","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    cfg.StrOpt(\u0027trove_security_group_rule_cidr\u0027, default\u003d\u00270.0.0.0/0\u0027),"},{"line_number":159,"context_line":"    cfg.IntOpt(\u0027trove_api_workers\u0027,"},{"line_number":160,"context_line":"               help\u003d\"Number of workers for the API service. The default will \""},{"line_number":161,"context_line":"               \"be the number of CPUs available.\"),"},{"line_number":162,"context_line":"    cfg.IntOpt(\u0027usage_sleep_time\u0027, default\u003d5,"},{"line_number":163,"context_line":"               help\u003d\u0027Time to sleep during the check active guest.\u0027),"},{"line_number":164,"context_line":"    cfg.StrOpt(\u0027region\u0027, default\u003d\u0027LOCAL_DEV\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab895d6_45742d9c","line":161,"updated":"2014-06-29 18:47:04.000000000","message":"The default IS the number of CPUs available; the use of \"will be\" appears incorrect.","commit_id":"bfb0f2438e4b2bc62512c80132ea050423034def"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"13ddaac8b8ea696740526c6416b5d6debce46aeb","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    cfg.StrOpt(\u0027trove_security_group_rule_cidr\u0027, default\u003d\u00270.0.0.0/0\u0027),"},{"line_number":159,"context_line":"    cfg.IntOpt(\u0027trove_api_workers\u0027,"},{"line_number":160,"context_line":"               help\u003d\"Number of workers for the API service. The default will \""},{"line_number":161,"context_line":"               \"be the number of CPUs available.\"),"},{"line_number":162,"context_line":"    cfg.IntOpt(\u0027usage_sleep_time\u0027, default\u003d5,"},{"line_number":163,"context_line":"               help\u003d\u0027Time to sleep during the check active guest.\u0027),"},{"line_number":164,"context_line":"    cfg.StrOpt(\u0027region\u0027, default\u003d\u0027LOCAL_DEV\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_215e54ea","line":161,"in_reply_to":"dab895d6_45742d9c","updated":"2014-06-30 15:24:14.000000000","message":"I just used the same wording as was in nova, cinder and glance.","commit_id":"bfb0f2438e4b2bc62512c80132ea050423034def"}]}