)]}'
{"trove/cmd/manage.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"9a40c35e10c34b3bf000bf2c76bcc29a17f14c0c","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        except exception.DatastoreVersionNotFound as e:"},{"line_number":65,"context_line":"            print(e)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def datastore_version_update(self, datastore_id_or_name, version_name,"},{"line_number":68,"context_line":"                                 manager, image_id, packages, active):"},{"line_number":69,"context_line":"        try:"},{"line_number":70,"context_line":"            datastore_models.update_datastore_version(datastore_id_or_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_1b8fadcd","line":67,"updated":"2014-07-02 11:58:22.000000000","message":"this should not be changed","commit_id":"9131ba88ff86a72d5d4f9968c2786451370796ed"},{"author":{"_account_id":10749,"name":"Rueben Ramirez","email":"ruebenramirez@gmail.com","username":"rramirez"},"change_message_id":"3e5dfbc12cc7b8fe81f06d0327cd9122e2e12af7","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        except exception.DatastoreVersionNotFound as e:"},{"line_number":65,"context_line":"            print(e)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def datastore_version_update(self, datastore_id_or_name, version_name,"},{"line_number":68,"context_line":"                                 manager, image_id, packages, active):"},{"line_number":69,"context_line":"        try:"},{"line_number":70,"context_line":"            datastore_models.update_datastore_version(datastore_id_or_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_fce2ecff","line":67,"in_reply_to":"baada198_1b8fadcd","updated":"2014-07-02 14:12:00.000000000","message":"Good catch Denis.","commit_id":"9131ba88ff86a72d5d4f9968c2786451370796ed"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"9a40c35e10c34b3bf000bf2c76bcc29a17f14c0c","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            capability_override \u003d datastore_models.CapabilityOverride.load("},{"line_number":121,"context_line":"                capability_id, datastore_version_id)"},{"line_number":122,"context_line":"            capability_override.delete()"},{"line_number":123,"context_line":"        except (exception.CapabilityNotFound,"},{"line_number":124,"context_line":"                SQLAlchemyException.InvalidRequestError) as e:"},{"line_number":125,"context_line":"            print(\u0027Unable to remove capability override for \\\u0027%s\\\u0027: %s\u0027 %"},{"line_number":126,"context_line":"                  capability_id, e)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_db7295e2","line":123,"updated":"2014-07-02 11:58:22.000000000","message":"also, should be checked for ModelNotFound","commit_id":"9131ba88ff86a72d5d4f9968c2786451370796ed"},{"author":{"_account_id":10749,"name":"Rueben Ramirez","email":"ruebenramirez@gmail.com","username":"rramirez"},"change_message_id":"3e5dfbc12cc7b8fe81f06d0327cd9122e2e12af7","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            capability_override \u003d datastore_models.CapabilityOverride.load("},{"line_number":121,"context_line":"                capability_id, datastore_version_id)"},{"line_number":122,"context_line":"            capability_override.delete()"},{"line_number":123,"context_line":"        except (exception.CapabilityNotFound,"},{"line_number":124,"context_line":"                SQLAlchemyException.InvalidRequestError) as e:"},{"line_number":125,"context_line":"            print(\u0027Unable to remove capability override for \\\u0027%s\\\u0027: %s\u0027 %"},{"line_number":126,"context_line":"                  capability_id, e)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_cf964c94","line":123,"in_reply_to":"baada198_db7295e2","updated":"2014-07-02 14:12:00.000000000","message":"Where would ModelNotFound come into play?  I\u0027m adding coverage for deleting a non-existent override, but the behavior I\u0027ve found is much the same as test_remove_a_nonexistant_capability (trove/tests/unittests/datastore/test_capability.py line 194)","commit_id":"9131ba88ff86a72d5d4f9968c2786451370796ed"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"5093cb5272f5c41870564b842ac9150dba79d0f1","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        except exception.DatastoreVersionNotFound as e:"},{"line_number":65,"context_line":"            print(e)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def datastore_version_update(self, datastore, version_name, manager,"},{"line_number":68,"context_line":"                                 image_id, packages, active):"},{"line_number":69,"context_line":"        try:"},{"line_number":70,"context_line":"            datastore_models.update_datastore_version(datastore,"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_ab064ccc","line":67,"updated":"2014-07-03 07:51:43.000000000","message":"still the same, method should not be modified","commit_id":"a46445846fcf1919a11890258cb7363b527ae466"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"b1ff00941b7dcafcc1d0a78a528ed50927ca479f","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            print(\u0027Unable to remove capability override for \\\u0027%s\\\u0027: %s\u0027 %"},{"line_number":126,"context_line":"                  capability_id, e)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def remove_capability_overrides(self, capability_id, enabled\u003d\u0027everything\u0027):"},{"line_number":129,"context_line":"        \"\"\"Remove overrides for a capability.\"\"\""},{"line_number":130,"context_line":"        try:"},{"line_number":131,"context_line":"            datastore_models.CapabilityOverrides.delete_overrides("}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_0e5911fe","line":128,"updated":"2014-07-10 20:58:35.000000000","message":"we could use the same filter here and pass in values \u0027enabled\u0027, \u0027disabled\u0027, \u0027everything\u0027","commit_id":"a46445846fcf1919a11890258cb7363b527ae466"}],"trove/datastore/models.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"9a40c35e10c34b3bf000bf2c76bcc29a17f14c0c","unresolved":false,"context_lines":[{"line_number":207,"context_line":"    def load_overrides(cls, capability_id):"},{"line_number":208,"context_line":"        return cls.load(capability_id)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    @classmethod"},{"line_number":211,"context_line":"    def load(cls, capability_id, enabled\u003dTrue, disabled\u003dTrue):"},{"line_number":212,"context_line":"        \"\"\""},{"line_number":213,"context_line":"        Generates a list of CapabilityOverride Objects for the given base"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_0647544c","line":210,"updated":"2014-07-02 11:58:22.000000000","message":"As for me, this method should be rewritten.\nFirst of all:\n\n1. Methods signature: should be load(**kwargs).\n\n2. kwargs should ba passed into find_all(**kwargs), method should be generic as for disabled or enabled, and no need to keen inside method signature additional attributes like enabled\u003dTrue, disabled\u003dTrue.\n\n3.","commit_id":"9131ba88ff86a72d5d4f9968c2786451370796ed"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"9a40c35e10c34b3bf000bf2c76bcc29a17f14c0c","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        cls.delete(capability_id, enabled\u003dTrue, disabled\u003dTrue)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    @classmethod"},{"line_number":258,"context_line":"    def delete(cls, capability_id, enabled\u003dTrue, disabled\u003dTrue):"},{"line_number":259,"context_line":"        \"\"\""},{"line_number":260,"context_line":"        delete all capability overrides for a given base capability id"},{"line_number":261,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_a6ddc872","line":258,"updated":"2014-07-02 11:58:22.000000000","message":"enabled\u003dTrue, disabled\u003dTrue - not used at all.","commit_id":"9131ba88ff86a72d5d4f9968c2786451370796ed"},{"author":{"_account_id":10749,"name":"Rueben Ramirez","email":"ruebenramirez@gmail.com","username":"rramirez"},"change_message_id":"3e5dfbc12cc7b8fe81f06d0327cd9122e2e12af7","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        cls.delete(capability_id, enabled\u003dTrue, disabled\u003dTrue)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    @classmethod"},{"line_number":258,"context_line":"    def delete(cls, capability_id, enabled\u003dTrue, disabled\u003dTrue):"},{"line_number":259,"context_line":"        \"\"\""},{"line_number":260,"context_line":"        delete all capability overrides for a given base capability id"},{"line_number":261,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_597a0af2","line":258,"in_reply_to":"baada198_a6ddc872","updated":"2014-07-02 14:12:00.000000000","message":"great catch!  Thanks!","commit_id":"9131ba88ff86a72d5d4f9968c2786451370796ed"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"9a40c35e10c34b3bf000bf2c76bcc29a17f14c0c","unresolved":false,"context_lines":[{"line_number":530,"context_line":"        return self._datastore_name"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"    # TODO(tim.simpson): This would be less confusing if it was called"},{"line_number":533,"context_line":"    #                    \"version\" and datastore_name was called \"name\"."},{"line_number":534,"context_line":"    @property"},{"line_number":535,"context_line":"    def name(self):"},{"line_number":536,"context_line":"        return self.db_info.name"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_065114d8","line":533,"updated":"2014-07-02 11:58:22.000000000","message":"why it was changed?","commit_id":"9131ba88ff86a72d5d4f9968c2786451370796ed"},{"author":{"_account_id":10749,"name":"Rueben Ramirez","email":"ruebenramirez@gmail.com","username":"rramirez"},"change_message_id":"3e5dfbc12cc7b8fe81f06d0327cd9122e2e12af7","unresolved":false,"context_lines":[{"line_number":530,"context_line":"        return self._datastore_name"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"    # TODO(tim.simpson): This would be less confusing if it was called"},{"line_number":533,"context_line":"    #                    \"version\" and datastore_name was called \"name\"."},{"line_number":534,"context_line":"    @property"},{"line_number":535,"context_line":"    def name(self):"},{"line_number":536,"context_line":"        return self.db_info.name"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_59320a11","line":533,"in_reply_to":"baada198_065114d8","updated":"2014-07-02 14:12:00.000000000","message":"pep 8 linter wasn\u0027t passing because of line length","commit_id":"9131ba88ff86a72d5d4f9968c2786451370796ed"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"9a40c35e10c34b3bf000bf2c76bcc29a17f14c0c","unresolved":false,"context_lines":[{"line_number":592,"context_line":"    datastore \u003d Datastore.load(datastore)"},{"line_number":593,"context_line":"    version \u003d version or datastore.default_version_id"},{"line_number":594,"context_line":"    if not version:"},{"line_number":595,"context_line":"        raise exception.DatastoreDefaultVersionNotFound("},{"line_number":596,"context_line":"            datastore\u003ddatastore.name)"},{"line_number":597,"context_line":"    datastore_version \u003d DatastoreVersion.load(datastore, version)"},{"line_number":598,"context_line":"    if datastore_version.datastore_id !\u003d datastore.id:"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_46622cae","line":595,"updated":"2014-07-02 11:58:22.000000000","message":"same","commit_id":"9131ba88ff86a72d5d4f9968c2786451370796ed"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"9a40c35e10c34b3bf000bf2c76bcc29a17f14c0c","unresolved":false,"context_lines":[{"line_number":600,"context_line":"                                           version\u003ddatastore_version.name)"},{"line_number":601,"context_line":"    if not datastore_version.active:"},{"line_number":602,"context_line":"        raise exception.DatastoreVersionInactive("},{"line_number":603,"context_line":"            version\u003ddatastore_version.name)"},{"line_number":604,"context_line":"    return (datastore, datastore_version)"},{"line_number":605,"context_line":""},{"line_number":606,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_865c44ef","line":603,"updated":"2014-07-02 11:58:22.000000000","message":"same","commit_id":"9131ba88ff86a72d5d4f9968c2786451370796ed"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"5093cb5272f5c41870564b842ac9150dba79d0f1","unresolved":false,"context_lines":[{"line_number":207,"context_line":"    def load_overrides(cls, capability_id):"},{"line_number":208,"context_line":"        return cls.load(capability_id)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    @classmethod"},{"line_number":211,"context_line":"    def load(cls, capability_id, enabled\u003dTrue, disabled\u003dTrue):"},{"line_number":212,"context_line":"        \"\"\""},{"line_number":213,"context_line":"        Generates a list of CapabilityOverride Objects for the given base"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_8b16e8ef","line":210,"updated":"2014-07-03 07:51:43.000000000","message":"Comments weren\u0027t addressed.This method should be rewritten. First of all:\n\n1. Methods signature: should be load(**kwargs).\n\n2. kwargs should ba passed into find_all(**kwargs), method should be generic as for disabled or enabled, and no need to keen inside method signature additional attributes like enabled\u003dTrue, disabled\u003dTrue.","commit_id":"a46445846fcf1919a11890258cb7363b527ae466"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"b1ff00941b7dcafcc1d0a78a528ed50927ca479f","unresolved":false,"context_lines":[{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    @classmethod"},{"line_number":211,"context_line":"    def load(cls, capability_id, enabled\u003dTrue, disabled\u003dTrue):"},{"line_number":212,"context_line":"        \"\"\""},{"line_number":213,"context_line":"        Generates a list of CapabilityOverride Objects for the given base"},{"line_number":214,"context_line":"        capability"},{"line_number":215,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_0e583131","line":212,"updated":"2014-07-10 20:58:35.000000000","message":"or we could pass in a filter which could have values \u0027enabled\u0027, \u0027disabled\u0027 or \u0027all\u0027","commit_id":"a46445846fcf1919a11890258cb7363b527ae466"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"5093cb5272f5c41870564b842ac9150dba79d0f1","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        cls.delete(capability_id, enabled\u003dTrue, disabled\u003dTrue)"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    @classmethod"},{"line_number":259,"context_line":"    def delete(cls, capability_id, enabled\u003dTrue, disabled\u003dTrue):"},{"line_number":260,"context_line":"        \"\"\""},{"line_number":261,"context_line":"        delete all capability overrides for a given base capability id"},{"line_number":262,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_4be3f004","line":259,"updated":"2014-07-03 07:51:43.000000000","message":"according to comments to load method, this methods also should be rewritten","commit_id":"a46445846fcf1919a11890258cb7363b527ae466"}],"trove/tests/unittests/datastore/test_capability.py":[{"author":{"_account_id":10749,"name":"Rueben Ramirez","email":"ruebenramirez@gmail.com","username":"rramirez"},"change_message_id":"3e5dfbc12cc7b8fe81f06d0327cd9122e2e12af7","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        self.assertRaises(exception.CapabilityNotFound, Capability.load,"},{"line_number":192,"context_line":"                          \"non-existent\")"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def test_remove_a_nonexistant_capability(self):"},{"line_number":195,"context_line":"        \"\"\""},{"line_number":196,"context_line":"        if capability already removed, SQLAlchemy exception is thrown"},{"line_number":197,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_cfaf2ce2","line":194,"updated":"2014-07-02 14:12:00.000000000","message":"ModelNotFound exceptions not raised here.","commit_id":"9131ba88ff86a72d5d4f9968c2786451370796ed"}]}
