)]}'
{"etc/trove/trove-guestagent.conf.sample":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"804cb843659b2badc790e7e593812a369dc59978","unresolved":false,"context_lines":[{"line_number":75,"context_line":"# For storage to Swift, use the following as defaults:"},{"line_number":76,"context_line":"# storage_strategy \u003d SwiftStorage"},{"line_number":77,"context_line":"# storage_namespace \u003d trove.guestagent.strategies.storage.swift"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"# Default config options for storing backups to swift"},{"line_number":80,"context_line":"# backup_swift_container \u003d database_backups"},{"line_number":81,"context_line":"# backup_use_gzip_compression \u003d True"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"baada198_3fb78b86","line":78,"updated":"2014-07-21 12:01:36.000000000","message":"after couchbase backup/restore feature was merged, this options are not per datastore, please fix it.","commit_id":"a715b6a7001cca3773d19d387a14d84719641a3b"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"804cb843659b2badc790e7e593812a369dc59978","unresolved":false,"context_lines":[{"line_number":90,"context_line":"# backup_runner_options \u003d InnoBackupEx:--no-lock,  MySQLDump:--events --routines --triggers"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d Trove Conductor Configuration \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"# Control Exchange used to communicate with trove-conductor"},{"line_number":96,"context_line":"control_exchange \u003d trove"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"baada198_3f3cebe0","line":93,"updated":"2014-07-21 12:01:36.000000000","message":"Could you please find more appropriate name for this section that would not confuse deployers when they\u0027ll see conductor configuration in guest config","commit_id":"a715b6a7001cca3773d19d387a14d84719641a3b"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"1a49dd1ecabd8a4db1194e3708000868542ed51e","unresolved":false,"context_lines":[{"line_number":40,"context_line":"# Configuration options for talking to nova via the novaclient."},{"line_number":41,"context_line":"# These options are for an admin user in your keystone config."},{"line_number":42,"context_line":"# It proxies the token received from the user to send to nova via this admin users creds,"},{"line_number":43,"context_line":"# basically acting like the client via that proxy token."},{"line_number":44,"context_line":"nova_proxy_admin_user \u003d admin"},{"line_number":45,"context_line":"nova_proxy_admin_pass \u003d 3de4922d8b6ac5a1aad9"},{"line_number":46,"context_line":"nova_proxy_admin_tenant_name \u003d admin"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"fa98f980_0e5d91e9","side":"PARENT","line":43,"updated":"2014-09-02 18:21:06.000000000","message":"the rest of the changes aren\u0027t \"breaking\", but the removal of these nova values is in the sense that:\n\n(1) the default values in cfg.py do not match these.\n(2) it\u0027s actually used in the guest (albeit, pointlessly in guestagent/datastore/service.py)","commit_id":"5c40395ad62ad87a8016937bbde65610a4ba916a"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"bd904d3a4c8dbfb938da9388d7b56eb47b21b769","unresolved":false,"context_lines":[{"line_number":40,"context_line":"# Configuration options for talking to nova via the novaclient."},{"line_number":41,"context_line":"# These options are for an admin user in your keystone config."},{"line_number":42,"context_line":"# It proxies the token received from the user to send to nova via this admin users creds,"},{"line_number":43,"context_line":"# basically acting like the client via that proxy token."},{"line_number":44,"context_line":"nova_proxy_admin_user \u003d admin"},{"line_number":45,"context_line":"nova_proxy_admin_pass \u003d 3de4922d8b6ac5a1aad9"},{"line_number":46,"context_line":"nova_proxy_admin_tenant_name \u003d admin"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"fa98f980_7b9b3e72","side":"PARENT","line":43,"in_reply_to":"fa98f980_0e5d91e9","updated":"2014-09-02 19:10:26.000000000","message":"meh, not important enough to hold up merge before juno. +2\u0027ing.","commit_id":"5c40395ad62ad87a8016937bbde65610a4ba916a"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"9eaf8e1fef0cac79c2e5cb48c8453cddcb8f3a23","unresolved":false,"context_lines":[{"line_number":40,"context_line":"# Configuration options for talking to nova via the novaclient."},{"line_number":41,"context_line":"# These options are for an admin user in your keystone config."},{"line_number":42,"context_line":"# It proxies the token received from the user to send to nova via this admin users creds,"},{"line_number":43,"context_line":"# basically acting like the client via that proxy token."},{"line_number":44,"context_line":"nova_proxy_admin_user \u003d admin"},{"line_number":45,"context_line":"nova_proxy_admin_pass \u003d 3de4922d8b6ac5a1aad9"},{"line_number":46,"context_line":"nova_proxy_admin_tenant_name \u003d admin"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"fa98f980_bebe74d2","side":"PARENT","line":43,"in_reply_to":"fa98f980_7b9b3e72","updated":"2014-09-02 19:33:57.000000000","message":"The guest code actually using these values is bogus -- it simply uses this to construct a dictionary to pass to the conductor which does nothing with it. There is a different bug that is open to tackle cleaning up the bogus code in the guest agent: https://bugs.launchpad.net/trove/+bug/1339349. \n\nAs far as I can tell, since nothing is actually using this on the guest agent, removing this (or using bogus values for these entries) doesn\u0027t really affect or break anything. \n\nThanks!","commit_id":"5c40395ad62ad87a8016937bbde65610a4ba916a"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"8df286dcde1ee02dea352ec72105d4ecb3a5d3c1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d Sample RabbitMQ Configuration \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# The RabbitMQ broker address where a single node is used."},{"line_number":6,"context_line":"# (string value)"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"fa98f980_f82b2992","line":3,"updated":"2014-08-30 22:13:29.000000000","message":"Why we don\u0027t have the same part for the QPID?\n\nI consider to add this in another patch.","commit_id":"40244847b64c1a3fee699ec711a9d5a5108ae02c"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"a764582dec6749577f45b874b4ff504416e7b68f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d Sample RabbitMQ Configuration \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# The RabbitMQ broker address where a single node is used."},{"line_number":6,"context_line":"# (string value)"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"fa98f980_1b82a752","line":3,"in_reply_to":"fa98f980_f82b2992","updated":"2014-08-30 22:45:21.000000000","message":"Sergey, I haven\u0027t tested qpid settings -- so it would be awesome if you could drive adding that as part of a patch on top of this one. \n\nThanks!","commit_id":"40244847b64c1a3fee699ec711a9d5a5108ae02c"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"40ed35ffbbdbb229a0c0ad9a2cc1888149fea45d","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# Default config options for storing backups to swift"},{"line_number":77,"context_line":"# backup_swift_container \u003d database_backups"},{"line_number":78,"context_line":"# backup_use_gzip_compression \u003d True"},{"line_number":79,"context_line":"# backup_use_openssl_encryption \u003d True"},{"line_number":80,"context_line":"# backup_aes_cbc_key \u003d \"default_aes_cbc_key\""},{"line_number":81,"context_line":"# backup_use_snet \u003d False"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"1abeadc6_739ceac0","line":78,"updated":"2014-08-28 21:37:19.000000000","message":"I have always wonder where we draw the line whether to have a sample config commented out and not having anything at all. These config are (should be) well documented elsewhere for the user.\n\nI sometimes feel that having too much comments and samples make the config file looks look messy and might make things confusing. I think removing these examples will make this look cleaner, specially for configs where the default values will work fine among most deployers.\n\nMy $0.02 :P","commit_id":"40244847b64c1a3fee699ec711a9d5a5108ae02c"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"fb93b0eb61c9c5cdbe349df36320d143ac8ec450","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# Default config options for storing backups to swift"},{"line_number":77,"context_line":"# backup_swift_container \u003d database_backups"},{"line_number":78,"context_line":"# backup_use_gzip_compression \u003d True"},{"line_number":79,"context_line":"# backup_use_openssl_encryption \u003d True"},{"line_number":80,"context_line":"# backup_aes_cbc_key \u003d \"default_aes_cbc_key\""},{"line_number":81,"context_line":"# backup_use_snet \u003d False"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"1abeadc6_f320fa4a","line":78,"in_reply_to":"1abeadc6_739ceac0","updated":"2014-08-28 21:47:16.000000000","message":"I like having the comments and examples. thats why its the .sample file. It saves me the hassle of having to go and look up the docs.","commit_id":"40244847b64c1a3fee699ec711a9d5a5108ae02c"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"edd77bdc40db9300719d08bcca6c15b3a4c5b1d0","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# Default config options for storing backups to swift"},{"line_number":77,"context_line":"# backup_swift_container \u003d database_backups"},{"line_number":78,"context_line":"# backup_use_gzip_compression \u003d True"},{"line_number":79,"context_line":"# backup_use_openssl_encryption \u003d True"},{"line_number":80,"context_line":"# backup_aes_cbc_key \u003d \"default_aes_cbc_key\""},{"line_number":81,"context_line":"# backup_use_snet \u003d False"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"1abeadc6_5665dc42","line":78,"in_reply_to":"1abeadc6_899da9be","updated":"2014-08-30 09:57:19.000000000","message":"Why do we need to draw a line? Why not document all config options as part of the sample conf to make it easier to look up for operators? \n\nAs an operator, I\u0027d hate to break into code to see what config options exist.","commit_id":"40244847b64c1a3fee699ec711a9d5a5108ae02c"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"f1ce3b9123aff3d2e8556c8358f9318557805581","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# Default config options for storing backups to swift"},{"line_number":77,"context_line":"# backup_swift_container \u003d database_backups"},{"line_number":78,"context_line":"# backup_use_gzip_compression \u003d True"},{"line_number":79,"context_line":"# backup_use_openssl_encryption \u003d True"},{"line_number":80,"context_line":"# backup_aes_cbc_key \u003d \"default_aes_cbc_key\""},{"line_number":81,"context_line":"# backup_use_snet \u003d False"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"1abeadc6_899da9be","line":78,"in_reply_to":"1abeadc6_f320fa4a","updated":"2014-08-29 17:46:05.000000000","message":"I agree but where do we draw the line? There are tons of configs in trove.\nFor configs that are commonly set by deployers, my guess it would make sense.","commit_id":"40244847b64c1a3fee699ec711a9d5a5108ae02c"}],"trove/guestagent/db/models.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"2cb8477bffc2511847720332e6e6a9b90ff1eaeb","unresolved":false,"context_lines":[{"line_number":366,"context_line":"            return True"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    def _is_valid_user_name(self, value):"},{"line_number":369,"context_line":"        if (value \u003d\u003d \u0027root\u0027 or (self._is_valid(value) and"},{"line_number":370,"context_line":"                                value.lower() not in self._ignore_users)):"},{"line_number":371,"context_line":"            return True"},{"line_number":372,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_70a869db","line":369,"updated":"2014-07-04 10:54:25.000000000","message":"i guess this is out of scope of given bug-report","commit_id":"637c28adb11e39e130fa6ad700589910b19b105b"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"bc0a91ad5dca66b825e7248e8a70e9dcf5411881","unresolved":false,"context_lines":[{"line_number":366,"context_line":"            return True"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    def _is_valid_user_name(self, value):"},{"line_number":369,"context_line":"        if (value \u003d\u003d \u0027root\u0027 or (self._is_valid(value) and"},{"line_number":370,"context_line":"                                value.lower() not in self._ignore_users)):"},{"line_number":371,"context_line":"            return True"},{"line_number":372,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_9317b6ed","line":369,"in_reply_to":"baada198_70a869db","updated":"2014-07-21 09:56:56.000000000","message":"Done","commit_id":"637c28adb11e39e130fa6ad700589910b19b105b"}]}
