)]}'
{"trove/common/configurations.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"73503660be4e9abbec609e30c20028df3a994014","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            elif line_clean and \"\u003d\" not in line_clean:"},{"line_number":92,"context_line":"                LOG.debug(\"fixing line without \u0027\u003d\u0027 in it: %s\" % line_clean)"},{"line_number":93,"context_line":"                ret.append(line_clean + \" \u003d 1\")"},{"line_number":94,"context_line":"            elif \u0027#\u0027 in line_clean:"},{"line_number":95,"context_line":"                start_comment \u003d line_clean.find(\u0027#\u0027)"},{"line_number":96,"context_line":"                ret.append(line_clean[:start_comment])"},{"line_number":97,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_daa70fa6","line":94,"updated":"2014-07-23 01:57:43.000000000","message":"this could go south with a # in a quoted string. The check above is less risky because it is a negated check (not in).","commit_id":"bc2cfa8ac4a973585137c05cbc5731e114febca2"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"73f58a3393c2745c08c09ca260d4d200af74161b","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            elif line_clean and \"\u003d\" not in line_clean:"},{"line_number":92,"context_line":"                LOG.debug(\"fixing line without \u0027\u003d\u0027 in it: %s\" % line_clean)"},{"line_number":93,"context_line":"                ret.append(line_clean + \" \u003d 1\")"},{"line_number":94,"context_line":"            elif \u0027#\u0027 in line_clean:"},{"line_number":95,"context_line":"                start_comment \u003d line_clean.find(\u0027#\u0027)"},{"line_number":96,"context_line":"                ret.append(line_clean[:start_comment])"},{"line_number":97,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_c1439fad","line":94,"in_reply_to":"baada198_daa70fa6","updated":"2014-07-23 05:44:41.000000000","message":"yeah thats true. i guess the best way to do this would be to make a nasty regex.","commit_id":"bc2cfa8ac4a973585137c05cbc5731e114febca2"}],"trove/guestagent/datastore/mysql/service.py":[{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"59cbd823168961c488026c889f7877a270971f91","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        LOG.debug(\"Expired password removed.\")"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"def get_auth_password():"},{"line_number":98,"context_line":"    user_name \u003d None"},{"line_number":99,"context_line":"    password \u003d None"},{"line_number":100,"context_line":"    with open(MYSQL_CONFIG, \u0027r\u0027) as f:"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_92c0e57d","line":97,"updated":"2014-07-02 21:48:06.000000000","message":"Instead of creating your own parser for this config file, why not use a parsing library such as ConfigParser to do this?","commit_id":"9f700d8294915ff41b5f4c3208e73eae231381ad"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"59cbd823168961c488026c889f7877a270971f91","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        is_in_client \u003d False"},{"line_number":102,"context_line":"        lines \u003d f.readlines()"},{"line_number":103,"context_line":"        for line in lines:"},{"line_number":104,"context_line":"            print(line)"},{"line_number":105,"context_line":"            if \"[client]\" in line:"},{"line_number":106,"context_line":"                is_in_client \u003d True"},{"line_number":107,"context_line":"            elif is_in_client:"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_12793593","line":104,"updated":"2014-07-02 21:48:06.000000000","message":"Is your intention to print out the line? Use LOG.debug if you mean to output the lines otherwise just remove it","commit_id":"9f700d8294915ff41b5f4c3208e73eae231381ad"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"59cbd823168961c488026c889f7877a270971f91","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                        user_name \u003d m.group(2)"},{"line_number":113,"context_line":"                    elif \"password\" \u003d\u003d m.group(1):"},{"line_number":114,"context_line":"                        password \u003d m.group(2)"},{"line_number":115,"context_line":"    if user_name and password:"},{"line_number":116,"context_line":"        return password.strip()"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_d2b5fd31","line":115,"updated":"2014-07-02 21:48:06.000000000","message":"raise an error if you cant find the password because the caller expects a password returned","commit_id":"9f700d8294915ff41b5f4c3208e73eae231381ad"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"2105b5d589b4f5b641c5721e6629e9327ff2b1e2","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        password \u003d content_dict.get(\"client\", \"password\")"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    if user_name and password:"},{"line_number":109,"context_line":"        return password.strip()"},{"line_number":110,"context_line":"    raise Exception(_(\"No auth password found in file %s\") % MYSQL_CONFIG)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_6f748efe","line":109,"updated":"2014-07-22 20:47:29.000000000","message":"we didnt check for username before? it seems like a new check being introduced if I am not mistaken. if we do want to include it can u mention it in commit/bug","commit_id":"bc2cfa8ac4a973585137c05cbc5731e114febca2"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"a9979c42341b8b3f7b0ea23882c73376048cee90","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        password \u003d content_dict.get(\"client\", \"password\")"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    if user_name and password:"},{"line_number":109,"context_line":"        return password.strip()"},{"line_number":110,"context_line":"    raise Exception(_(\"No auth password found in file %s\") % MYSQL_CONFIG)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_8f6abb19","line":109,"in_reply_to":"baada198_6f748efe","updated":"2014-07-23 01:04:13.000000000","message":"hmm i think we may need to get the user and password. i\u0027ll leave it as just the password. If we need the username as well i\u0027ll add that later.","commit_id":"bc2cfa8ac4a973585137c05cbc5731e114febca2"}]}