)]}'
{"trove/tests/fakes/nova.py":[{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"ff7e1d9e934925eeb6100293e83542f36f2e4149","unresolved":false,"context_lines":[{"line_number":488,"context_line":"            else:"},{"line_number":489,"context_line":"                raise nova_exceptions.NotFound(404, \"Bad permissions\")"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"    def create(self, size, name\u003dNone, description\u003dNone, volume_type\u003dNone):"},{"line_number":492,"context_line":"        id \u003d \"FAKE_VOL_%s\" % uuid.uuid4()"},{"line_number":493,"context_line":"        volume \u003d FakeVolume(self, self.context, id, size, name,"},{"line_number":494,"context_line":"                            description)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_043dccbb","line":491,"updated":"2014-07-08 19:50:15.000000000","message":"volume_type is never used? i imagine you meant to pass it along to FakeVolume, etc. etc.","commit_id":"aefc4071aa84f59bab13e46d4b412d9959b82259"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"5c3b5f41fa8d1fb4c4e331ed07b8a7fa5d66eb7d","unresolved":false,"context_lines":[{"line_number":488,"context_line":"            else:"},{"line_number":489,"context_line":"                raise nova_exceptions.NotFound(404, \"Bad permissions\")"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"    def create(self, size, name\u003dNone, description\u003dNone, volume_type\u003dNone):"},{"line_number":492,"context_line":"        id \u003d \"FAKE_VOL_%s\" % uuid.uuid4()"},{"line_number":493,"context_line":"        volume \u003d FakeVolume(self, self.context, id, size, name,"},{"line_number":494,"context_line":"                            description)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_34367be8","line":491,"in_reply_to":"baada198_043dccbb","updated":"2014-07-08 21:10:33.000000000","message":"Hey Auston, It needs to be in FakeVolumes because the TM is passing volume_type to the volume client, which is FakeVolumes in fake mode","commit_id":"aefc4071aa84f59bab13e46d4b412d9959b82259"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"1bc6589980f5e25759dcde80eb637834189003cb","unresolved":false,"context_lines":[{"line_number":488,"context_line":"            else:"},{"line_number":489,"context_line":"                raise nova_exceptions.NotFound(404, \"Bad permissions\")"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"    def create(self, size, name\u003dNone, description\u003dNone, volume_type\u003dNone):"},{"line_number":492,"context_line":"        id \u003d \"FAKE_VOL_%s\" % uuid.uuid4()"},{"line_number":493,"context_line":"        volume \u003d FakeVolume(self, self.context, id, size, name,"},{"line_number":494,"context_line":"                            description)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_e7b8d7e7","line":491,"in_reply_to":"baada198_145df748","updated":"2014-07-08 22:00:46.000000000","message":"ahh i see. If i dont include it, i get an error saying that the create() got an unexpected argument.\n\nThis is because the TM is passing an extra argument to the create(), which is the volume_type","commit_id":"aefc4071aa84f59bab13e46d4b412d9959b82259"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"21a2521a48e4ef0e143baeb4b0188b3ca981b603","unresolved":false,"context_lines":[{"line_number":488,"context_line":"            else:"},{"line_number":489,"context_line":"                raise nova_exceptions.NotFound(404, \"Bad permissions\")"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"    def create(self, size, name\u003dNone, description\u003dNone, volume_type\u003dNone):"},{"line_number":492,"context_line":"        id \u003d \"FAKE_VOL_%s\" % uuid.uuid4()"},{"line_number":493,"context_line":"        volume \u003d FakeVolume(self, self.context, id, size, name,"},{"line_number":494,"context_line":"                            description)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_145df748","line":491,"in_reply_to":"baada198_34367be8","updated":"2014-07-08 21:47:39.000000000","message":"i get why it needs to be in the signature, i\u0027m just confused why you\u0027re not including it below in your FakeVolume() instantiation. i suppose it doesn\u0027t accomplish anything...","commit_id":"aefc4071aa84f59bab13e46d4b412d9959b82259"}]}