)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"1e6253dd5e0fa9d27d51acd246a8f9547e31f3da","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change default for update_status_on_fail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The default behavior for instances stuck in BUILD should be to time out"},{"line_number":10,"context_line":"and move them to ERROR."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: 1339826"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baada198_bd7c0074","line":9,"updated":"2014-07-10 01:38:43.000000000","message":"s/time out/timeout\n\nOh, sorry, that\u0027s what the bug says ;)","commit_id":"fb4901cc591bc0ba9ac1e53ea770966f43e79162"},{"author":{"_account_id":9749,"name":"Greg Lucas","email":"greg@glucas.net","username":"glucas"},"change_message_id":"5f8fb6b1215ea2b2ed31746a6c085d4a37e65966","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change default for update_status_on_fail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The default behavior for instances stuck in BUILD should be to time out"},{"line_number":10,"context_line":"and move them to ERROR."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: 1339826"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baada198_83d6e1c1","line":9,"in_reply_to":"baada198_bd7c0074","updated":"2014-07-10 17:39:59.000000000","message":"Reworked the message to provide more detail.","commit_id":"fb4901cc591bc0ba9ac1e53ea770966f43e79162"}],"etc/trove/trove-taskmanager.conf.sample":[{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"9bb20820ae0a15512ff164d706784d41a9d4fbeb","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# Show debugging output in logs (sets DEBUG log level output)"},{"line_number":6,"context_line":"debug \u003d True"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# Updates service and instance task statuses if instance failed become active"},{"line_number":9,"context_line":"update_status_on_fail \u003d True"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# The RabbitMQ broker address where a single node is used."}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baada198_4fb41135","line":8,"updated":"2014-07-09 22:14:17.000000000","message":"I know this is probably out of scope - but this comment is should be clearer - at the very least grammatically correct \n...if instance failed TO become active or ...FAILS TO become active. It would probably also be useful to point out there is some timeout?","commit_id":"fb4901cc591bc0ba9ac1e53ea770966f43e79162"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"1e6253dd5e0fa9d27d51acd246a8f9547e31f3da","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# Show debugging output in logs (sets DEBUG log level output)"},{"line_number":6,"context_line":"debug \u003d True"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# Updates service and instance task statuses if instance failed become active"},{"line_number":9,"context_line":"update_status_on_fail \u003d True"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# The RabbitMQ broker address where a single node is used."}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baada198_5de20430","line":8,"in_reply_to":"baada198_4fb41135","updated":"2014-07-10 01:38:43.000000000","message":"+1 ... changing this comment\n\nNo, I\u0027d do it. It wouldn\u0027t be \"out of scope\" for this fix (I don\u0027t think).","commit_id":"fb4901cc591bc0ba9ac1e53ea770966f43e79162"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"f33835d96c7c80dfbe7a675476c6f743dfff5849","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# Show debugging output in logs (sets DEBUG log level output)"},{"line_number":6,"context_line":"debug \u003d True"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# Updates service and instance task statuses if instance failed become active"},{"line_number":9,"context_line":"update_status_on_fail \u003d True"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# The RabbitMQ broker address where a single node is used."}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baada198_5aa5ad45","line":8,"in_reply_to":"baada198_4fb41135","updated":"2014-07-09 23:10:10.000000000","message":"+1 with the need of fixing the comment","commit_id":"fb4901cc591bc0ba9ac1e53ea770966f43e79162"},{"author":{"_account_id":9749,"name":"Greg Lucas","email":"greg@glucas.net","username":"glucas"},"change_message_id":"5f8fb6b1215ea2b2ed31746a6c085d4a37e65966","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# Show debugging output in logs (sets DEBUG log level output)"},{"line_number":6,"context_line":"debug \u003d True"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# Updates service and instance task statuses if instance failed become active"},{"line_number":9,"context_line":"update_status_on_fail \u003d True"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# The RabbitMQ broker address where a single node is used."}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baada198_03f2d16e","line":8,"in_reply_to":"baada198_5de20430","updated":"2014-07-10 17:39:59.000000000","message":"Agreed - updated the comment.","commit_id":"fb4901cc591bc0ba9ac1e53ea770966f43e79162"}],"trove/common/cfg.py":[{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"9bb20820ae0a15512ff164d706784d41a9d4fbeb","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    cfg.ListOpt(\u0027admin_roles\u0027, default\u003d[\u0027admin\u0027]),"},{"line_number":48,"context_line":"    cfg.BoolOpt(\u0027update_status_on_fail\u0027, default\u003dTrue,"},{"line_number":49,"context_line":"                help\u003d\u0027If instance fails to become active, \u0027"},{"line_number":50,"context_line":"                     \u0027taskmanager updates statuses, \u0027"},{"line_number":51,"context_line":"                     \u0027service status \u003d FAILED_TIMEOUT_GUESTAGENT, \u0027"},{"line_number":52,"context_line":"                     \u0027instance task status \u003d BUILDING_ERROR_TIMEOUT_GA.\u0027),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027os_region_name\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_8fec692b","line":50,"updated":"2014-07-09 22:14:17.000000000","message":"Again, probably out of scope but maybe it should say \n...updates statuses AFTER THESE TIMEOUTS...\n(assuming that suggestion is accurate)","commit_id":"fb4901cc591bc0ba9ac1e53ea770966f43e79162"},{"author":{"_account_id":9749,"name":"Greg Lucas","email":"greg@glucas.net","username":"glucas"},"change_message_id":"5f8fb6b1215ea2b2ed31746a6c085d4a37e65966","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    cfg.ListOpt(\u0027admin_roles\u0027, default\u003d[\u0027admin\u0027]),"},{"line_number":48,"context_line":"    cfg.BoolOpt(\u0027update_status_on_fail\u0027, default\u003dTrue,"},{"line_number":49,"context_line":"                help\u003d\u0027If instance fails to become active, \u0027"},{"line_number":50,"context_line":"                     \u0027taskmanager updates statuses, \u0027"},{"line_number":51,"context_line":"                     \u0027service status \u003d FAILED_TIMEOUT_GUESTAGENT, \u0027"},{"line_number":52,"context_line":"                     \u0027instance task status \u003d BUILDING_ERROR_TIMEOUT_GA.\u0027),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027os_region_name\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_a3aa0517","line":50,"in_reply_to":"baada198_7d37c8b0","updated":"2014-07-10 17:39:59.000000000","message":"Actually, I don\u0027t see how the internal names of these status constants are useful to a user. Revised the help text to explain the key point which is that the service and instance task are put in an error state.","commit_id":"fb4901cc591bc0ba9ac1e53ea770966f43e79162"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"1e6253dd5e0fa9d27d51acd246a8f9547e31f3da","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    cfg.ListOpt(\u0027admin_roles\u0027, default\u003d[\u0027admin\u0027]),"},{"line_number":48,"context_line":"    cfg.BoolOpt(\u0027update_status_on_fail\u0027, default\u003dTrue,"},{"line_number":49,"context_line":"                help\u003d\u0027If instance fails to become active, \u0027"},{"line_number":50,"context_line":"                     \u0027taskmanager updates statuses, \u0027"},{"line_number":51,"context_line":"                     \u0027service status \u003d FAILED_TIMEOUT_GUESTAGENT, \u0027"},{"line_number":52,"context_line":"                     \u0027instance task status \u003d BUILDING_ERROR_TIMEOUT_GA.\u0027),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027os_region_name\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_7d37c8b0","line":50,"in_reply_to":"baada198_8fec692b","updated":"2014-07-10 01:38:43.000000000","message":"I\u0027d verify the end statuses and update the help text if appropriate.","commit_id":"fb4901cc591bc0ba9ac1e53ea770966f43e79162"}]}