)]}'
{"trove/guestagent/datastore/cassandra/manager.py":[{"author":{"_account_id":9749,"name":"Greg Lucas","email":"greg@glucas.net","username":"glucas"},"change_message_id":"16f836f2ba37f2b77033fc7324575c482a436066","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            self.app.stop_db()"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"            if config_contents:"},{"line_number":78,"context_line":"                LOG.debug(_(\"Processing configuration.\"))"},{"line_number":79,"context_line":"                self.app.write_config(config_contents)"},{"line_number":80,"context_line":"                self.app.make_host_reachable()"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_26136367","line":78,"updated":"2014-07-10 18:09:54.000000000","message":"Since this a debug message now (which makes sense to me) you no longer need the _(..).","commit_id":"509ac49d96b186cfc5c6f19915ad65996a7bd49a"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"7318391506736e210a5ece2c3686319422286d2d","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        self.app.init_storage_structure(mount_point)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        if config_contents or device_path:"},{"line_number":71,"context_line":"            # while we fix the configuration and the data volume"},{"line_number":72,"context_line":"            # the database should not be running; install_if_needed()"},{"line_number":73,"context_line":"            # above will leave the database running. So, stop it."},{"line_number":74,"context_line":"            LOG.debug(\"Stopping database prior to changes.\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_08bae8bf","line":71,"updated":"2014-07-10 20:41:11.000000000","message":"Please add bug-link from Cassandra bug tracker \nhttps://issues.apache.org/jira/browse/CASSANDRA-2356\nAnd mention that code should be simplified after it gets fixed.","commit_id":"801c12887b0fb50db76c35581f872ec6d2b40b8e"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"20bd18027572d8bf5be822c68a603ec7247b0bf5","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        self.app.init_storage_structure(mount_point)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        if config_contents or device_path:"},{"line_number":71,"context_line":"            # while we fix the configuration and the data volume"},{"line_number":72,"context_line":"            # the database should not be running; install_if_needed()"},{"line_number":73,"context_line":"            # above will leave the database running. So, stop it."},{"line_number":74,"context_line":"            # FIXME(amrith) Once the cassandra bug"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_35d1b9fb","line":71,"updated":"2014-07-11 01:19:17.000000000","message":"Nitpicking but we probably dont need all these comments. All these comments make it look like a hack :-)\nI think the code is clear and all the other datastores do this similarly (stop first and then migrate). So we probably dont need the comments.","commit_id":"4fc3d3140f3b37a7dd7ae5a6ec129377798583e0"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b4dc2b5c140d94d2ba2f57ad78a637557b4cb37b","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        self.app.init_storage_structure(mount_point)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        if config_contents or device_path:"},{"line_number":71,"context_line":"            # while we fix the configuration and the data volume"},{"line_number":72,"context_line":"            # the database should not be running; install_if_needed()"},{"line_number":73,"context_line":"            # above will leave the database running. So, stop it."},{"line_number":74,"context_line":"            # FIXME(amrith) Once the cassandra bug"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_f809f82c","line":71,"in_reply_to":"baada198_35d1b9fb","updated":"2014-07-11 01:35:56.000000000","message":"Done","commit_id":"4fc3d3140f3b37a7dd7ae5a6ec129377798583e0"}],"trove/tests/unittests/guestagent/test_cassandra_manager.py":[{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"20bd18027572d8bf5be822c68a603ec7247b0bf5","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        mock_app.make_host_reachable.assert_any_call()"},{"line_number":141,"context_line":"        mock_app.start_db.assert_any_call()"},{"line_number":142,"context_line":"        mock_app.stop_db.assert_any_call()"},{"line_number":143,"context_line":"        self.assertEquals(0, mock_app.restart.call_count)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_f5fe616a","line":143,"updated":"2014-07-11 01:19:17.000000000","message":"i am ok to remove this check: self.assertEquals(0, mock_app.restart.call_count)\n\nThe code changed but we dont need to check how it was behaving before","commit_id":"4fc3d3140f3b37a7dd7ae5a6ec129377798583e0"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b4dc2b5c140d94d2ba2f57ad78a637557b4cb37b","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        mock_app.make_host_reachable.assert_any_call()"},{"line_number":141,"context_line":"        mock_app.start_db.assert_any_call()"},{"line_number":142,"context_line":"        mock_app.stop_db.assert_any_call()"},{"line_number":143,"context_line":"        self.assertEquals(0, mock_app.restart.call_count)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_580e6433","line":143,"in_reply_to":"baada198_f5fe616a","updated":"2014-07-11 01:35:56.000000000","message":"Done","commit_id":"4fc3d3140f3b37a7dd7ae5a6ec129377798583e0"}]}