)]}'
{"etc/trove/trove-taskmanager.conf.sample":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"70176713c34a5cb48ed3052b75059f8f6eb381fd","unresolved":false,"context_lines":[{"line_number":175,"context_line":"# Format (single port or port range): A, B-C"},{"line_number":176,"context_line":"# where C greater than B"},{"line_number":177,"context_line":"tcp_ports \u003d 6379"},{"line_number":178,"context_line":"volume_support \u003d False"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"[cassandra]"},{"line_number":181,"context_line":"tcp_ports \u003d 7000, 7001, 9042, 9160"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"baada198_33185f75","line":178,"updated":"2014-07-15 20:59:18.000000000","message":"what about other datastores?","commit_id":"414371dbdd5606c71241c59ad2baf0587b154251"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"6d056677de8ab4089f5c2e594d57d9ea7bae20cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"baada198_8b67dde9","line":188,"updated":"2014-07-17 15:58:08.000000000","message":"missing mongodb","commit_id":"7ce2ad55ebfc1f27e3c31120d2e66490cd7a909a"}],"etc/trove/trove.conf.sample":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"70176713c34a5cb48ed3052b75059f8f6eb381fd","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"[redis]"},{"line_number":182,"context_line":"tcp_ports \u003d 6379"},{"line_number":183,"context_line":"volume_support \u003d False"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"[cassandra]"},{"line_number":186,"context_line":"tcp_ports \u003d 7000, 7001, 9042, 9160"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"baada198_931e8b5e","line":183,"updated":"2014-07-15 20:59:18.000000000","message":"same question","commit_id":"414371dbdd5606c71241c59ad2baf0587b154251"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"6d056677de8ab4089f5c2e594d57d9ea7bae20cb","unresolved":false,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"[couchbase]"},{"line_number":191,"context_line":"tcp_ports \u003d 8091, 8092, 4369, 11209-11211, 21100-21199"},{"line_number":192,"context_line":"volume_support \u003d True"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"baada198_cb61d5d4","line":192,"updated":"2014-07-17 15:58:08.000000000","message":"same","commit_id":"7ce2ad55ebfc1f27e3c31120d2e66490cd7a909a"}],"etc/trove/trove.conf.test":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"70176713c34a5cb48ed3052b75059f8f6eb381fd","unresolved":false,"context_lines":[{"line_number":136,"context_line":"paste_config_file\u003dapi-paste.ini.test"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"[redis]"},{"line_number":139,"context_line":"volume_support \u003d False"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"[composite:trove]"},{"line_number":142,"context_line":"use \u003d call:trove.common.wsgi:versioned_urlmap"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"baada198_b3238fa6","line":139,"updated":"2014-07-15 20:59:18.000000000","message":"same question","commit_id":"414371dbdd5606c71241c59ad2baf0587b154251"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"fc9cfe0c9585bafea7e3fa31fc2922dd7a3c85b7","unresolved":false,"context_lines":[{"line_number":136,"context_line":"paste_config_file\u003dapi-paste.ini.test"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"[redis]"},{"line_number":139,"context_line":"volume_support \u003d False"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"[composite:trove]"},{"line_number":142,"context_line":"use \u003d call:trove.common.wsgi:versioned_urlmap"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"baada198_3e49ffb7","line":139,"in_reply_to":"baada198_b3238fa6","updated":"2014-07-16 03:02:24.000000000","message":"They would end up using same value as trove_support_volume. I can add that in","commit_id":"414371dbdd5606c71241c59ad2baf0587b154251"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"6d056677de8ab4089f5c2e594d57d9ea7bae20cb","unresolved":false,"context_lines":[{"line_number":141,"context_line":"[redis]"},{"line_number":142,"context_line":"volume_support \u003d False"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"[cassandra]"},{"line_number":145,"context_line":"volume_support \u003d True"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"[couchbase]"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"baada198_2b9ed1b8","line":144,"updated":"2014-07-17 15:58:08.000000000","message":"missing mongodb","commit_id":"7ce2ad55ebfc1f27e3c31120d2e66490cd7a909a"}],"trove/common/apischema.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"70176713c34a5cb48ed3052b75059f8f6eb381fd","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        \"properties\": {"},{"line_number":189,"context_line":"            \"instance\": {"},{"line_number":190,"context_line":"                \"type\": \"object\","},{"line_number":191,"context_line":"                \"required\": [\"name\", \"flavorRef\"],"},{"line_number":192,"context_line":"                \"additionalProperties\": True,"},{"line_number":193,"context_line":"                \"properties\": {"},{"line_number":194,"context_line":"                    \"name\": non_empty_string,"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_534b135f","line":191,"updated":"2014-07-15 20:59:18.000000000","message":"this breaks API scheme, we should not do this, at least until API v1.x or v2.0","commit_id":"414371dbdd5606c71241c59ad2baf0587b154251"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"93e0c400f3038d335bcf44e084b7c189828b00e9","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        \"properties\": {"},{"line_number":189,"context_line":"            \"instance\": {"},{"line_number":190,"context_line":"                \"type\": \"object\","},{"line_number":191,"context_line":"                \"required\": [\"name\", \"flavorRef\"],"},{"line_number":192,"context_line":"                \"additionalProperties\": True,"},{"line_number":193,"context_line":"                \"properties\": {"},{"line_number":194,"context_line":"                    \"name\": non_empty_string,"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_dea38efe","line":191,"in_reply_to":"baada198_44b42435","updated":"2014-07-16 13:10:34.000000000","message":"We do not know the datastore manager name here. Since this is a generic schema specification","commit_id":"414371dbdd5606c71241c59ad2baf0587b154251"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"fc9cfe0c9585bafea7e3fa31fc2922dd7a3c85b7","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        \"properties\": {"},{"line_number":189,"context_line":"            \"instance\": {"},{"line_number":190,"context_line":"                \"type\": \"object\","},{"line_number":191,"context_line":"                \"required\": [\"name\", \"flavorRef\"],"},{"line_number":192,"context_line":"                \"additionalProperties\": True,"},{"line_number":193,"context_line":"                \"properties\": {"},{"line_number":194,"context_line":"                    \"name\": non_empty_string,"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_7eca971b","line":191,"in_reply_to":"baada198_534b135f","updated":"2014-07-16 03:02:24.000000000","message":"We are just being more permissive. That should not break api contract.","commit_id":"414371dbdd5606c71241c59ad2baf0587b154251"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"1e79ec34698feef462d7bcf8f5a1050746f0575c","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        \"properties\": {"},{"line_number":189,"context_line":"            \"instance\": {"},{"line_number":190,"context_line":"                \"type\": \"object\","},{"line_number":191,"context_line":"                \"required\": [\"name\", \"flavorRef\"],"},{"line_number":192,"context_line":"                \"additionalProperties\": True,"},{"line_number":193,"context_line":"                \"properties\": {"},{"line_number":194,"context_line":"                    \"name\": non_empty_string,"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_44b42435","line":191,"in_reply_to":"baada198_7eca971b","updated":"2014-07-16 05:02:23.000000000","message":"Perhaps you can do a \u0027if CONF.get(datastore_manager).trove_volume_support\"","commit_id":"414371dbdd5606c71241c59ad2baf0587b154251"}],"trove/common/cfg.py":[{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"1e79ec34698feef462d7bcf8f5a1050746f0575c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"import os.path"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"UNKNOWN_SERVICE_ID \u003d \u0027unknown-service-id-error\u0027"},{"line_number":24,"context_line":"VOLUME_SUPPORT \u003d True"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"path_opts \u003d ["},{"line_number":27,"context_line":"    cfg.StrOpt(\u0027pybasedir\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_e4da9878","line":24,"updated":"2014-07-16 05:02:23.000000000","message":"I am not sure if this is a good idea. Can the default be different for different datastore? I think so, otherwise you wouldn\u0027t be fixing this :)","commit_id":"414371dbdd5606c71241c59ad2baf0587b154251"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"1abb5073b8459a1f13149c0c2775200e6364cc63","unresolved":false,"context_lines":[{"line_number":21,"context_line":"import os.path"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"UNKNOWN_SERVICE_ID \u003d \u0027unknown-service-id-error\u0027"},{"line_number":24,"context_line":"VOLUME_SUPPORT \u003d True"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"path_opts \u003d ["},{"line_number":27,"context_line":"    cfg.StrOpt(\u0027pybasedir\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_b1a347b0","line":24,"in_reply_to":"baada198_4fafc37d","updated":"2014-07-17 08:02:45.000000000","message":"By the default, for all datastores volume support should be enabled. So, i don\u0027t see any need in keeping global variable.","commit_id":"414371dbdd5606c71241c59ad2baf0587b154251"},{"author":{"_account_id":2559,"name":"Joe Cruz","email":"jcruz7@gmail.com","username":"jcruz7"},"change_message_id":"d551dbb7207b517a7fdc805a3463f443a16e0b8e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"import os.path"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"UNKNOWN_SERVICE_ID \u003d \u0027unknown-service-id-error\u0027"},{"line_number":24,"context_line":"VOLUME_SUPPORT \u003d True"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"path_opts \u003d ["},{"line_number":27,"context_line":"    cfg.StrOpt(\u0027pybasedir\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_4fafc37d","line":24,"in_reply_to":"baada198_9ece76b6","updated":"2014-07-16 19:09:51.000000000","message":"Yeah I don\u0027t like defining a global variable \u0027VOLUME_SUPPORT\u0027.  I think it would be better if you just set them explicitly to True or False (personally I\u0027m leaning towards False but I\u0027m cool with either).\n\nI think its up to other people to suggest here or make future reviews to what the defaults should be for specific datastores.","commit_id":"414371dbdd5606c71241c59ad2baf0587b154251"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"93e0c400f3038d335bcf44e084b7c189828b00e9","unresolved":false,"context_lines":[{"line_number":21,"context_line":"import os.path"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"UNKNOWN_SERVICE_ID \u003d \u0027unknown-service-id-error\u0027"},{"line_number":24,"context_line":"VOLUME_SUPPORT \u003d True"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"path_opts \u003d ["},{"line_number":27,"context_line":"    cfg.StrOpt(\u0027pybasedir\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_9ece76b6","line":24,"in_reply_to":"baada198_e4da9878","updated":"2014-07-16 13:10:34.000000000","message":"Yes it can be. I would be happy to take default recommendations from the community on different datastores and add them in. Any suggestions?","commit_id":"414371dbdd5606c71241c59ad2baf0587b154251"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"70176713c34a5cb48ed3052b75059f8f6eb381fd","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    cfg.StrOpt(\u0027api_paste_config\u0027,"},{"line_number":46,"context_line":"               default\u003d\"api-paste.ini\","},{"line_number":47,"context_line":"               help\u003d\u0027File name for the paste.deploy config for trove-api.\u0027),"},{"line_number":48,"context_line":"    cfg.BoolOpt(\u0027trove_volume_support\u0027,"},{"line_number":49,"context_line":"                default\u003dVOLUME_SUPPORT,"},{"line_number":50,"context_line":"                help\u003d\u0027Whether to provision a cinder volume for datadir.\u0027),"},{"line_number":51,"context_line":"    cfg.ListOpt(\u0027admin_roles\u0027, default\u003d[\u0027admin\u0027]),"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_733ad799","line":48,"updated":"2014-07-15 20:59:18.000000000","message":"it still exists, so at previous file, so, i think we should not modify API scheme and validate volume support for datastore while create call appears.","commit_id":"414371dbdd5606c71241c59ad2baf0587b154251"}],"trove/instance/models.py":[{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"1aa8c86bc83c6165fdcaf7d28a05ebf277dca713","unresolved":false,"context_lines":[{"line_number":515,"context_line":"            task_api.API(self.context).delete_instance(self.id)"},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"        deltas \u003d {\u0027instances\u0027: -1}"},{"line_number":518,"context_line":"        if self.volume_support:"},{"line_number":519,"context_line":"            deltas[\u0027volumes\u0027] \u003d -self.volume_size"},{"line_number":520,"context_line":"        return run_with_quotas(self.tenant_id,"},{"line_number":521,"context_line":"                               deltas,"}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_f904011b","line":518,"updated":"2014-07-29 14:27:22.000000000","message":"This looks great!","commit_id":"65639095c13ca58117ed09789896aac886813beb"},{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"1aa8c86bc83c6165fdcaf7d28a05ebf277dca713","unresolved":false,"context_lines":[{"line_number":627,"context_line":"        else:"},{"line_number":628,"context_line":"            if volume_size is not None:"},{"line_number":629,"context_line":"                raise exception.VolumeNotSupported()"},{"line_number":630,"context_line":"            ephemeral_support \u003d CONF.get(datastore_version.manager).device_path"},{"line_number":631,"context_line":"            if ephemeral_support and flavor.ephemeral \u003d\u003d 0:"},{"line_number":632,"context_line":"                raise exception.LocalStorageNotSpecified(flavor\u003dflavor_id)"},{"line_number":633,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_59140d50","line":630,"updated":"2014-07-29 14:27:22.000000000","message":"I wonder if this should be made a property as well. To me I don\u0027t inherently just \"get\" (as in understand) why if something has a device_path and no volume support it has ephemeral_support, so it would be nice to tuck this into a property.","commit_id":"65639095c13ca58117ed09789896aac886813beb"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"b82b24ff58d62d5d6ee40e480042ae5148e5df2e","unresolved":false,"context_lines":[{"line_number":627,"context_line":"        else:"},{"line_number":628,"context_line":"            if volume_size is not None:"},{"line_number":629,"context_line":"                raise exception.VolumeNotSupported()"},{"line_number":630,"context_line":"            ephemeral_support \u003d CONF.get(datastore_version.manager).device_path"},{"line_number":631,"context_line":"            if ephemeral_support and flavor.ephemeral \u003d\u003d 0:"},{"line_number":632,"context_line":"                raise exception.LocalStorageNotSpecified(flavor\u003dflavor_id)"},{"line_number":633,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_e4e29801","line":630,"in_reply_to":"baada198_59140d50","updated":"2014-07-29 14:32:45.000000000","message":"the datastore manager is passed in as a argument in the function. thats why its not a property yet cause instance doesnt exist.","commit_id":"65639095c13ca58117ed09789896aac886813beb"}],"trove/instance/views.py":[{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"7236fd4b13ca58eff1516221dd19691f82dbe800","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                self.instance.volume_used):"},{"line_number":90,"context_line":"            used \u003d self.instance.volume_used"},{"line_number":91,"context_line":"            if (CONF.get(self.instance.datastore_version.manager)"},{"line_number":92,"context_line":"                    .volume_support):"},{"line_number":93,"context_line":"                result[\u0027instance\u0027][\u0027volume\u0027][\u0027used\u0027] \u003d used"},{"line_number":94,"context_line":"            else:"},{"line_number":95,"context_line":"                # either ephemeral or root partition"}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_675be722","line":92,"updated":"2014-07-29 15:45:04.000000000","message":"This is something that I believe could use the properties as well, such as:\n\n...\nif self.instance.volume_support:\n...","commit_id":"65639095c13ca58117ed09789896aac886813beb"}],"trove/quota/quota.py":[{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"1e79ec34698feef462d7bcf8f5a1050746f0575c","unresolved":false,"context_lines":[{"line_number":313,"context_line":"\u0027\u0027\u0027 Define all kind of resources here \u0027\u0027\u0027"},{"line_number":314,"context_line":"resources \u003d [Resource(Resource.INSTANCES, \u0027max_instances_per_user\u0027),"},{"line_number":315,"context_line":"             Resource(Resource.BACKUPS, \u0027max_backups_per_user\u0027),"},{"line_number":316,"context_line":"             Resource(Resource.VOLUMES, \u0027max_volumes_per_user\u0027)]"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"QUOTAS.register_resources(resources)"},{"line_number":319,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_c45bd4f4","line":316,"updated":"2014-07-16 05:02:23.000000000","message":"What is the reason for removing the check? If we dont use volume, we shouldnt be tracking volume resources for quota.","commit_id":"414371dbdd5606c71241c59ad2baf0587b154251"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"93e0c400f3038d335bcf44e084b7c189828b00e9","unresolved":false,"context_lines":[{"line_number":313,"context_line":"\u0027\u0027\u0027 Define all kind of resources here \u0027\u0027\u0027"},{"line_number":314,"context_line":"resources \u003d [Resource(Resource.INSTANCES, \u0027max_instances_per_user\u0027),"},{"line_number":315,"context_line":"             Resource(Resource.BACKUPS, \u0027max_backups_per_user\u0027),"},{"line_number":316,"context_line":"             Resource(Resource.VOLUMES, \u0027max_volumes_per_user\u0027)]"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"QUOTAS.register_resources(resources)"},{"line_number":319,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_de0d4eea","line":316,"in_reply_to":"baada198_c45bd4f4","updated":"2014-07-16 13:10:34.000000000","message":"Since now volume support is dependent on datastore type. We do not know which datastore the user is going to spin up an instance for, and that datastore may or may not support volumes. So we want to always be tracking it.","commit_id":"414371dbdd5606c71241c59ad2baf0587b154251"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"1abb5073b8459a1f13149c0c2775200e6364cc63","unresolved":false,"context_lines":[{"line_number":313,"context_line":"\u0027\u0027\u0027 Define all kind of resources here \u0027\u0027\u0027"},{"line_number":314,"context_line":"resources \u003d [Resource(Resource.INSTANCES, \u0027max_instances_per_user\u0027),"},{"line_number":315,"context_line":"             Resource(Resource.BACKUPS, \u0027max_backups_per_user\u0027),"},{"line_number":316,"context_line":"             Resource(Resource.VOLUMES, \u0027max_volumes_per_user\u0027)]"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"QUOTAS.register_resources(resources)"},{"line_number":319,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_918e4326","line":316,"in_reply_to":"baada198_de0d4eea","updated":"2014-07-17 08:02:45.000000000","message":"Icca, good point, agreed.","commit_id":"414371dbdd5606c71241c59ad2baf0587b154251"}],"trove/taskmanager/models.py":[{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"1aa8c86bc83c6165fdcaf7d28a05ebf277dca713","unresolved":false,"context_lines":[{"line_number":469,"context_line":"            err \u003d inst_models.InstanceTasks.BUILDING_ERROR_SERVER"},{"line_number":470,"context_line":"            self._log_and_raise(e, msg, err)"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"        device_path \u003d CONF.get(datastore_manager).device_path"},{"line_number":473,"context_line":"        mount_point \u003d CONF.get(datastore_manager).mount_point"},{"line_number":474,"context_line":"        volume_info \u003d {\u0027device_path\u0027: device_path, \u0027mount_point\u0027: mount_point}"},{"line_number":475,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_c4583434","line":472,"updated":"2014-07-29 14:27:22.000000000","message":"This and mount_path should use the property as well (remember they\u0027re an ancestor of SimpleInstance).","commit_id":"65639095c13ca58117ed09789896aac886813beb"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"b82b24ff58d62d5d6ee40e480042ae5148e5df2e","unresolved":false,"context_lines":[{"line_number":469,"context_line":"            err \u003d inst_models.InstanceTasks.BUILDING_ERROR_SERVER"},{"line_number":470,"context_line":"            self._log_and_raise(e, msg, err)"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"        device_path \u003d CONF.get(datastore_manager).device_path"},{"line_number":473,"context_line":"        mount_point \u003d CONF.get(datastore_manager).mount_point"},{"line_number":474,"context_line":"        volume_info \u003d {\u0027device_path\u0027: device_path, \u0027mount_point\u0027: mount_point}"},{"line_number":475,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_8489dc27","line":472,"in_reply_to":"baada198_c4583434","updated":"2014-07-29 14:32:45.000000000","message":"same thing here, since instance doesnt exist and its passed in as a fn arg we use it directly here","commit_id":"65639095c13ca58117ed09789896aac886813beb"},{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"1aa8c86bc83c6165fdcaf7d28a05ebf277dca713","unresolved":false,"context_lines":[{"line_number":1022,"context_line":"            self.instance.datastore_version.manager).mount_point"},{"line_number":1023,"context_line":"        return mount_point"},{"line_number":1024,"context_line":""},{"line_number":1025,"context_line":"    def get_device_path(self):"},{"line_number":1026,"context_line":"        device_path \u003d CONF.get("},{"line_number":1027,"context_line":"            self.instance.datastore_version.manager).device_path"},{"line_number":1028,"context_line":"        return device_path"}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_e491b89c","line":1025,"updated":"2014-07-29 14:27:22.000000000","message":"I feel it would be better if this accessed self.instance.device_path instead.","commit_id":"65639095c13ca58117ed09789896aac886813beb"}],"trove/tests/api/instances.py":[{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"1e79ec34698feef462d7bcf8f5a1050746f0575c","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    def tearDown(self):"},{"line_number":237,"context_line":"        quota_dict \u003d {\u0027instances\u0027: CONFIG.trove_max_instances_per_user,"},{"line_number":238,"context_line":"                      \u0027volumes\u0027: CONFIG.trove_max_volumes_per_user}"},{"line_number":239,"context_line":"        dbaas_admin.quota.update(self.test_info.user.tenant_id,"},{"line_number":240,"context_line":"                                 quota_dict)"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_4467c4b7","line":238,"updated":"2014-07-16 05:02:23.000000000","message":"Here too. If we dont use volume, we shouldnt track its resource.","commit_id":"414371dbdd5606c71241c59ad2baf0587b154251"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"93e0c400f3038d335bcf44e084b7c189828b00e9","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    def tearDown(self):"},{"line_number":237,"context_line":"        quota_dict \u003d {\u0027instances\u0027: CONFIG.trove_max_instances_per_user,"},{"line_number":238,"context_line":"                      \u0027volumes\u0027: CONFIG.trove_max_volumes_per_user}"},{"line_number":239,"context_line":"        dbaas_admin.quota.update(self.test_info.user.tenant_id,"},{"line_number":240,"context_line":"                                 quota_dict)"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_7efe02b0","line":238,"in_reply_to":"baada198_4467c4b7","updated":"2014-07-16 13:10:34.000000000","message":"Same reply as before.","commit_id":"414371dbdd5606c71241c59ad2baf0587b154251"}],"trove/tests/api/limits.py":[{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"1e79ec34698feef462d7bcf8f5a1050746f0575c","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        assert_equal(abs_limits.verb, \"ABSOLUTE\")"},{"line_number":94,"context_line":"        assert_equal(int(abs_limits.max_instances), DEFAULT_MAX_INSTANCES)"},{"line_number":95,"context_line":"        assert_equal(int(abs_limits.max_backups), DEFAULT_MAX_BACKUPS)"},{"line_number":96,"context_line":"        if CONFIG.trove_volume_support:"},{"line_number":97,"context_line":"            assert_equal(int(abs_limits.max_volumes), DEFAULT_MAX_VOLUMES)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        for k in d:"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_c412f408","side":"PARENT","line":96,"updated":"2014-07-16 05:02:23.000000000","message":"I think we should leave this in for folks/companies that run tests with volume disabled.","commit_id":"25162db5d90f9c209f2e5f8e7d718fab3ce46cde"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"93e0c400f3038d335bcf44e084b7c189828b00e9","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        assert_equal(abs_limits.verb, \"ABSOLUTE\")"},{"line_number":94,"context_line":"        assert_equal(int(abs_limits.max_instances), DEFAULT_MAX_INSTANCES)"},{"line_number":95,"context_line":"        assert_equal(int(abs_limits.max_backups), DEFAULT_MAX_BACKUPS)"},{"line_number":96,"context_line":"        if CONFIG.trove_volume_support:"},{"line_number":97,"context_line":"            assert_equal(int(abs_limits.max_volumes), DEFAULT_MAX_VOLUMES)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        for k in d:"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_fe8692da","side":"PARENT","line":96,"in_reply_to":"baada198_c412f408","updated":"2014-07-16 13:10:34.000000000","message":"Since we are moving to per datastore configs for volume support, again this config no longer becomes valid.","commit_id":"25162db5d90f9c209f2e5f8e7d718fab3ce46cde"}]}