)]}'
{"trove/guestagent/backup/backupagent.py":[{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"53da1aebed76ee153386c0746598b3d325405a49","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        parent_metadata \u003d {}"},{"line_number":75,"context_line":"        if backup_info.get(\u0027parent\u0027):"},{"line_number":76,"context_line":"            runner \u003d INCREMENTAL_RUNNER"},{"line_number":77,"context_line":"            LOG.info(_(\"Using incremental runner: %s.\") % runner.__name__)"},{"line_number":78,"context_line":"            parent \u003d backup_info[\u0027parent\u0027]"},{"line_number":79,"context_line":"            parent_metadata \u003d storage.load_metadata(parent[\u0027location\u0027],"},{"line_number":80,"context_line":"                                                    parent[\u0027checksum\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_cf052fc3","line":77,"updated":"2014-07-18 18:07:56.000000000","message":"maybe \"Using incremental BACKUP runner...\" would be more descriptive.","commit_id":"8f423a2d588fe1f9b57c0521629655160c9fa174"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"403f3cfa27be8443cde3c58dd9d2a4f8423ec6cc","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        parent_metadata \u003d {}"},{"line_number":75,"context_line":"        if backup_info.get(\u0027parent\u0027):"},{"line_number":76,"context_line":"            runner \u003d INCREMENTAL_RUNNER"},{"line_number":77,"context_line":"            LOG.info(_(\"Using incremental runner: %s.\") % runner.__name__)"},{"line_number":78,"context_line":"            parent \u003d backup_info[\u0027parent\u0027]"},{"line_number":79,"context_line":"            parent_metadata \u003d storage.load_metadata(parent[\u0027location\u0027],"},{"line_number":80,"context_line":"                                                    parent[\u0027checksum\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_ff4d2c3c","line":77,"in_reply_to":"baada198_cf052fc3","updated":"2014-07-19 21:22:27.000000000","message":"Done","commit_id":"8f423a2d588fe1f9b57c0521629655160c9fa174"},{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"53da1aebed76ee153386c0746598b3d325405a49","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            with runner(filename\u003dbackup_id, extra_opts\u003dextra_opts,"},{"line_number":103,"context_line":"                        **parent_metadata) as bkup:"},{"line_number":104,"context_line":"                try:"},{"line_number":105,"context_line":"                    LOG.info(_(\"Starting Backup %s.\"), backup_id)"},{"line_number":106,"context_line":"                    success, note, checksum, location \u003d storage.save("},{"line_number":107,"context_line":"                        bkup.manifest,"},{"line_number":108,"context_line":"                        bkup)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_ef0af3d0","line":105,"updated":"2014-07-18 18:07:56.000000000","message":"lowercase \"backup\"? for consistency?","commit_id":"8f423a2d588fe1f9b57c0521629655160c9fa174"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"403f3cfa27be8443cde3c58dd9d2a4f8423ec6cc","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            with runner(filename\u003dbackup_id, extra_opts\u003dextra_opts,"},{"line_number":103,"context_line":"                        **parent_metadata) as bkup:"},{"line_number":104,"context_line":"                try:"},{"line_number":105,"context_line":"                    LOG.info(_(\"Starting Backup %s.\"), backup_id)"},{"line_number":106,"context_line":"                    success, note, checksum, location \u003d storage.save("},{"line_number":107,"context_line":"                        bkup.manifest,"},{"line_number":108,"context_line":"                        bkup)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_3f6324b2","line":105,"in_reply_to":"baada198_ef0af3d0","updated":"2014-07-19 21:22:27.000000000","message":"I found one other place in this file with a Backup which I\u0027ve changed to backup (see next patch set)","commit_id":"8f423a2d588fe1f9b57c0521629655160c9fa174"},{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"53da1aebed76ee153386c0746598b3d325405a49","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                                    **backup)"},{"line_number":149,"context_line":"            raise"},{"line_number":150,"context_line":"        else:"},{"line_number":151,"context_line":"            LOG.info(_(\"Saving %(backup_id)s Backup Info to model\") % backup)"},{"line_number":152,"context_line":"            backup.update({\u0027state\u0027: BackupState.COMPLETED})"},{"line_number":153,"context_line":"            conductor.update_backup(CONF.guest_id,"},{"line_number":154,"context_line":"                                    sent\u003dtimeutils.float_utcnow(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_8f5177db","line":151,"updated":"2014-07-18 18:07:56.000000000","message":"given that you made all the other messages have \"backup\" before the id maybe this should say:\n\"Saving info for backup %(backup_id)s to model\"\nAlso, would an operator now what \"to model\" is? Maybe that should be dropped?","commit_id":"8f423a2d588fe1f9b57c0521629655160c9fa174"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"403f3cfa27be8443cde3c58dd9d2a4f8423ec6cc","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                                    **backup)"},{"line_number":149,"context_line":"            raise"},{"line_number":150,"context_line":"        else:"},{"line_number":151,"context_line":"            LOG.info(_(\"Saving %(backup_id)s Backup Info to model\") % backup)"},{"line_number":152,"context_line":"            backup.update({\u0027state\u0027: BackupState.COMPLETED})"},{"line_number":153,"context_line":"            conductor.update_backup(CONF.guest_id,"},{"line_number":154,"context_line":"                                    sent\u003dtimeutils.float_utcnow(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_5f5458c5","line":151,"in_reply_to":"baada198_8f5177db","updated":"2014-07-19 21:22:27.000000000","message":"Done","commit_id":"8f423a2d588fe1f9b57c0521629655160c9fa174"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"0d0a4a5bb4c8fa4eb66652e153779b5e63660309","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            auth_token\u003dCONF.nova_proxy_admin_pass)"},{"line_number":66,"context_line":"        conductor \u003d conductor_api.API(ctxt)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        LOG.info(_(\"Running backup %(id)s.\") % backup_info)"},{"line_number":69,"context_line":"        storage \u003d get_storage_strategy("},{"line_number":70,"context_line":"            CONF.storage_strategy,"},{"line_number":71,"context_line":"            CONF.storage_namespace)(context)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_30a98a7c","line":68,"updated":"2014-07-20 21:45:16.000000000","message":"Should be debug level","commit_id":"86971ac50d38fa4b3685c806be0ac9ff5f1c9d34"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"0d0a4a5bb4c8fa4eb66652e153779b5e63660309","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        parent_metadata \u003d {}"},{"line_number":75,"context_line":"        if backup_info.get(\u0027parent\u0027):"},{"line_number":76,"context_line":"            runner \u003d INCREMENTAL_RUNNER"},{"line_number":77,"context_line":"            LOG.info(_(\"Using incremental backup runner: %s.\") %"},{"line_number":78,"context_line":"                     runner.__name__)"},{"line_number":79,"context_line":"            parent \u003d backup_info[\u0027parent\u0027]"},{"line_number":80,"context_line":"            parent_metadata \u003d storage.load_metadata(parent[\u0027location\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_70b6a2dd","line":77,"updated":"2014-07-20 21:45:16.000000000","message":"Should be debug, see line 161","commit_id":"86971ac50d38fa4b3685c806be0ac9ff5f1c9d34"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"0d0a4a5bb4c8fa4eb66652e153779b5e63660309","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            with runner(filename\u003dbackup_id, extra_opts\u003dextra_opts,"},{"line_number":104,"context_line":"                        **parent_metadata) as bkup:"},{"line_number":105,"context_line":"                try:"},{"line_number":106,"context_line":"                    LOG.info(_(\"Starting backup %s.\"), backup_id)"},{"line_number":107,"context_line":"                    success, note, checksum, location \u003d storage.save("},{"line_number":108,"context_line":"                        bkup.manifest,"},{"line_number":109,"context_line":"                        bkup)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_708f8223","line":106,"updated":"2014-07-20 21:45:16.000000000","message":"Looks more like debug thing","commit_id":"86971ac50d38fa4b3685c806be0ac9ff5f1c9d34"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"0d0a4a5bb4c8fa4eb66652e153779b5e63660309","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                        \u0027backup_type\u0027: bkup.backup_type,"},{"line_number":117,"context_line":"                    })"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"                    LOG.info(_(\"Backup %(backup_id)s completed status: \""},{"line_number":120,"context_line":"                               \"%(success)s.\") % backup)"},{"line_number":121,"context_line":"                    LOG.info(_(\"Backup %(backup_id)s file swift checksum: \""},{"line_number":122,"context_line":"                               \"%(checksum)s.\") % backup)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_d09a0e61","line":119,"updated":"2014-07-20 21:45:16.000000000","message":"All this three calls are fitting into one","commit_id":"86971ac50d38fa4b3685c806be0ac9ff5f1c9d34"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"4f79b687b7fe17e134aeaedf7300eadee742e26e","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                        \u0027backup_type\u0027: bkup.backup_type,"},{"line_number":117,"context_line":"                    })"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"                    LOG.debug(\"Backup %(backup_id)s completed status: \""},{"line_number":120,"context_line":"                              \"%(success)s.\" % backup)"},{"line_number":121,"context_line":"                    LOG.debug(\"Backup %(backup_id)s file swift checksum: \""},{"line_number":122,"context_line":"                              \"%(checksum)s.\" % backup)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_7964c3e4","line":119,"updated":"2014-07-21 10:52:25.000000000","message":"all this three calls are fitting into one.\n\nLOG.debug(\"Backup %(backup_id)s completed status \"%(success)s. Swift checksum: %(checksum)s. Location: %(location)s.\" % backup)","commit_id":"8d6cac8d866af238f3358c5bc6fcdd931a376724"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"6a3e0ad15ec12afefffa72a7b597befc2a328e49","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                        \u0027backup_type\u0027: bkup.backup_type,"},{"line_number":117,"context_line":"                    })"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"                    LOG.debug(\"Backup %(backup_id)s completed status: \""},{"line_number":120,"context_line":"                              \"%(success)s.\" % backup)"},{"line_number":121,"context_line":"                    LOG.debug(\"Backup %(backup_id)s file swift checksum: \""},{"line_number":122,"context_line":"                              \"%(checksum)s.\" % backup)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_f0837d53","line":119,"in_reply_to":"baada198_7964c3e4","updated":"2014-07-21 14:21:21.000000000","message":"This is more readable so I will leave it this way.","commit_id":"8d6cac8d866af238f3358c5bc6fcdd931a376724"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"aed4c804f5d0582f6301e1b90d1f20eb6e05c6de","unresolved":false,"context_lines":[{"line_number":149,"context_line":"                                    **backup)"},{"line_number":150,"context_line":"            raise"},{"line_number":151,"context_line":"        else:"},{"line_number":152,"context_line":"            LOG.info(_(\"Saving information for %(backup_id)s\") % backup)"},{"line_number":153,"context_line":"            backup.update({\u0027state\u0027: BackupState.COMPLETED})"},{"line_number":154,"context_line":"            conductor.update_backup(CONF.guest_id,"},{"line_number":155,"context_line":"                                    sent\u003dtimeutils.float_utcnow(),"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_4297f18f","line":152,"updated":"2014-07-21 19:53:03.000000000","message":"Is this the best success message to output as INFO?  It doesn\u0027t actually say that the backup was successful...","commit_id":"8d6cac8d866af238f3358c5bc6fcdd931a376724"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"f73eec33f77e49496eb3fa3604fd0475bb208833","unresolved":false,"context_lines":[{"line_number":149,"context_line":"                                    **backup)"},{"line_number":150,"context_line":"            raise"},{"line_number":151,"context_line":"        else:"},{"line_number":152,"context_line":"            LOG.info(_(\"Saving information for %(backup_id)s\") % backup)"},{"line_number":153,"context_line":"            backup.update({\u0027state\u0027: BackupState.COMPLETED})"},{"line_number":154,"context_line":"            conductor.update_backup(CONF.guest_id,"},{"line_number":155,"context_line":"                                    sent\u003dtimeutils.float_utcnow(),"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_a030be9e","line":152,"in_reply_to":"baada198_4297f18f","updated":"2014-07-22 00:03:49.000000000","message":"Fixed.","commit_id":"8d6cac8d866af238f3358c5bc6fcdd931a376724"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"aed4c804f5d0582f6301e1b90d1f20eb6e05c6de","unresolved":false,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        except Exception as e:"},{"line_number":181,"context_line":"            LOG.error(e)"},{"line_number":182,"context_line":"            LOG.error(_(\"Error restoring backup %(id)s\") % backup_info)"},{"line_number":183,"context_line":"            raise"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_5f3b4a37","line":182,"updated":"2014-07-21 19:53:03.000000000","message":"A candidate for LOG.exception()","commit_id":"8d6cac8d866af238f3358c5bc6fcdd931a376724"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"f73eec33f77e49496eb3fa3604fd0475bb208833","unresolved":false,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        except Exception as e:"},{"line_number":181,"context_line":"            LOG.error(e)"},{"line_number":182,"context_line":"            LOG.error(_(\"Error restoring backup %(id)s\") % backup_info)"},{"line_number":183,"context_line":"            raise"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_c023f255","line":182,"in_reply_to":"baada198_5f3b4a37","updated":"2014-07-22 00:03:49.000000000","message":"Done","commit_id":"8d6cac8d866af238f3358c5bc6fcdd931a376724"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"aed4c804f5d0582f6301e1b90d1f20eb6e05c6de","unresolved":false,"context_lines":[{"line_number":183,"context_line":"            raise"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        else:"},{"line_number":186,"context_line":"            LOG.info(_(\"Restored backup %(id)s\") % backup_info)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_c29ce1c2","line":186,"updated":"2014-07-21 19:53:03.000000000","message":"This is the third INFO message from restore.  One is probably enough.","commit_id":"8d6cac8d866af238f3358c5bc6fcdd931a376724"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"f73eec33f77e49496eb3fa3604fd0475bb208833","unresolved":false,"context_lines":[{"line_number":183,"context_line":"            raise"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        else:"},{"line_number":186,"context_line":"            LOG.info(_(\"Restored backup %(id)s\") % backup_info)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_00216a4c","line":186,"in_reply_to":"baada198_c29ce1c2","updated":"2014-07-22 00:03:49.000000000","message":"Done","commit_id":"8d6cac8d866af238f3358c5bc6fcdd931a376724"}]}