)]}'
{"trove/guestagent/datastore/service.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"d5981dcf9cbf50981acd7e59a8f9716a78a9c783","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        LOG.debug(\"Ending install_if_needed or restart.\")"},{"line_number":78,"context_line":"        self.restart_mode \u003d False"},{"line_number":79,"context_line":"        real_status \u003d self._get_actual_db_status()"},{"line_number":80,"context_line":"        LOG.info(\"Updating database status to %s.\" % real_status)"},{"line_number":81,"context_line":"        self.set_status(real_status)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def _get_actual_db_status(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_ce5d2018","line":80,"updated":"2014-07-19 15:23:08.000000000","message":"should be wrapped","commit_id":"cd430a0b8d31b53eebd1af891cb7b804cd42b1e5"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"abeeb4ec5de97c96b0d19c30c9c059ba40abf526","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        LOG.debug(\"Ending install_if_needed or restart.\")"},{"line_number":78,"context_line":"        self.restart_mode \u003d False"},{"line_number":79,"context_line":"        real_status \u003d self._get_actual_db_status()"},{"line_number":80,"context_line":"        LOG.info(\"Updating database status to %s.\" % real_status)"},{"line_number":81,"context_line":"        self.set_status(real_status)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def _get_actual_db_status(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_5fd9b854","line":80,"in_reply_to":"baada198_ce5d2018","updated":"2014-07-19 21:28:47.000000000","message":"Done","commit_id":"cd430a0b8d31b53eebd1af891cb7b804cd42b1e5"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"d5981dcf9cbf50981acd7e59a8f9716a78a9c783","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                if update_db:"},{"line_number":153,"context_line":"                    self.set_status(actual_status)"},{"line_number":154,"context_line":"                return True"},{"line_number":155,"context_line":"        LOG.error(\"Time out while waiting for DB status to change!\")"},{"line_number":156,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_0e9b98c9","line":155,"updated":"2014-07-19 15:23:08.000000000","message":"should be wrapped","commit_id":"cd430a0b8d31b53eebd1af891cb7b804cd42b1e5"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"abeeb4ec5de97c96b0d19c30c9c059ba40abf526","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                if update_db:"},{"line_number":153,"context_line":"                    self.set_status(actual_status)"},{"line_number":154,"context_line":"                return True"},{"line_number":155,"context_line":"        LOG.error(\"Time out while waiting for DB status to change!\")"},{"line_number":156,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_5fb0d8fc","line":155,"in_reply_to":"baada198_0e9b98c9","updated":"2014-07-19 21:28:47.000000000","message":"Yes, and also fixed the words \"Time out\" and replaced with timeout.","commit_id":"cd430a0b8d31b53eebd1af891cb7b804cd42b1e5"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"e80291640ada9e49d6179226a982b1c64249ee2a","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            status \u003d self._get_actual_db_status()"},{"line_number":130,"context_line":"            self.set_status(status)"},{"line_number":131,"context_line":"        else:"},{"line_number":132,"context_line":"            LOG.debug(\"DB server is not installed or is in restart mode, so \""},{"line_number":133,"context_line":"                      \"for now we\u0027ll skip determining the status of DB on \""},{"line_number":134,"context_line":"                      \"this instance.\")"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_2ca45db8","line":132,"updated":"2014-07-22 23:42:45.000000000","message":"i\u0027m not understanding why the solution here seems to be: \"if it\u0027s missing _(), then automatically convert it to debug\". this message is extremely important in the logs, so i\u0027m not sure why it\u0027s been down-casted in priority. can you please explain the rubric you\u0027re using to up/downcast the logging levels?","commit_id":"8c83d7bf68941dd83c5f66d47f39a299ec48665e"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"785fec2b88c6aef17ae8566cd8ff1cf7880fc07f","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            status \u003d self._get_actual_db_status()"},{"line_number":130,"context_line":"            self.set_status(status)"},{"line_number":131,"context_line":"        else:"},{"line_number":132,"context_line":"            LOG.debug(\"DB server is not installed or is in restart mode, so \""},{"line_number":133,"context_line":"                      \"for now we\u0027ll skip determining the status of DB on \""},{"line_number":134,"context_line":"                      \"this instance.\")"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_f5eb0479","line":132,"in_reply_to":"baada198_2ca45db8","updated":"2014-07-23 02:57:57.000000000","message":"It was certainly not that if it was missing an _, make it debug. Believe me, I added lots of _\u0027s ;)\n\nIt was down casted because I incorrectly understood it to be not important. In running the system, I did see this message but only at what appeared to be the initial startup. But, if there\u0027s other situations where this message is valuable, by all means I\u0027ll revert it.","commit_id":"8c83d7bf68941dd83c5f66d47f39a299ec48665e"},{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"097a6701aaed3a257f3bb58a1398399cd9b90571","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        The database is updated and the status is also returned."},{"line_number":126,"context_line":"        \"\"\""},{"line_number":127,"context_line":"        if self.is_installed and not self._is_restarting:"},{"line_number":128,"context_line":"            LOG.debug(\"Determining status of DB server...\")"},{"line_number":129,"context_line":"            status \u003d self._get_actual_db_status()"},{"line_number":130,"context_line":"            self.set_status(status)"},{"line_number":131,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_12287296","line":128,"updated":"2014-07-23 12:50:26.000000000","message":"I believe in other logging commits you changed the use of ellipsis to a period - maybe do that for consistency?","commit_id":"212f5932abc6637c9b94ab44f4d55add2854dd52"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"50533e8b6a8b70b17843d144bcdb47092c8cb098","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        The database is updated and the status is also returned."},{"line_number":126,"context_line":"        \"\"\""},{"line_number":127,"context_line":"        if self.is_installed and not self._is_restarting:"},{"line_number":128,"context_line":"            LOG.debug(\"Determining status of DB server...\")"},{"line_number":129,"context_line":"            status \u003d self._get_actual_db_status()"},{"line_number":130,"context_line":"            self.set_status(status)"},{"line_number":131,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_e346eb7d","line":128,"in_reply_to":"baada198_12287296","updated":"2014-07-30 09:04:56.000000000","message":"+1","commit_id":"212f5932abc6637c9b94ab44f4d55add2854dd52"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"3aa0279c469f94b890a4171449eec1b7efaf4b46","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        The database is updated and the status is also returned."},{"line_number":126,"context_line":"        \"\"\""},{"line_number":127,"context_line":"        if self.is_installed and not self._is_restarting:"},{"line_number":128,"context_line":"            LOG.debug(\"Determining status of DB server...\")"},{"line_number":129,"context_line":"            status \u003d self._get_actual_db_status()"},{"line_number":130,"context_line":"            self.set_status(status)"},{"line_number":131,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_d7c35d04","line":128,"in_reply_to":"baada198_12287296","updated":"2014-07-30 10:53:24.000000000","message":"Done","commit_id":"212f5932abc6637c9b94ab44f4d55add2854dd52"},{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"097a6701aaed3a257f3bb58a1398399cd9b90571","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        while waited_time \u003c max_time:"},{"line_number":146,"context_line":"            time.sleep(WAIT_TIME)"},{"line_number":147,"context_line":"            waited_time +\u003d WAIT_TIME"},{"line_number":148,"context_line":"            LOG.debug(\"Waiting for DB status to change to %s...\" % status)"},{"line_number":149,"context_line":"            actual_status \u003d self._get_actual_db_status()"},{"line_number":150,"context_line":"            LOG.debug(\"DB status was %s after %d seconds.\""},{"line_number":151,"context_line":"                      % (actual_status, waited_time))"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_12ff9203","line":148,"updated":"2014-07-23 12:50:26.000000000","message":"same comment as above","commit_id":"212f5932abc6637c9b94ab44f4d55add2854dd52"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"3aa0279c469f94b890a4171449eec1b7efaf4b46","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        while waited_time \u003c max_time:"},{"line_number":146,"context_line":"            time.sleep(WAIT_TIME)"},{"line_number":147,"context_line":"            waited_time +\u003d WAIT_TIME"},{"line_number":148,"context_line":"            LOG.debug(\"Waiting for DB status to change to %s...\" % status)"},{"line_number":149,"context_line":"            actual_status \u003d self._get_actual_db_status()"},{"line_number":150,"context_line":"            LOG.debug(\"DB status was %s after %d seconds.\""},{"line_number":151,"context_line":"                      % (actual_status, waited_time))"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_f7c86123","line":148,"in_reply_to":"baada198_12ff9203","updated":"2014-07-30 10:53:24.000000000","message":"Done","commit_id":"212f5932abc6637c9b94ab44f4d55add2854dd52"}]}
