)]}'
{"trove/guestagent/strategies/restore/mysql_impl.py":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"b87d5613bdc59a16a808a3129da31b8ce87a67ce","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            LOG.debug(\"MySQL is up and running.\")"},{"line_number":42,"context_line":"            return True"},{"line_number":43,"context_line":"        else:"},{"line_number":44,"context_line":"            LOG.info(_(\"MySQL is not running.\"))"},{"line_number":45,"context_line":"            return False"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def mysql_is_not_running(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_a4e500a6","line":44,"updated":"2014-07-22 14:20:35.000000000","message":"Shouldn\u0027t these be all debug statements?  I don\u0027t think this is a high-level method.","commit_id":"c2d28bd7bc60073f0244d0ff547eb28b69c495f6"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"62d99977e50bd9b4203f76797d59d63296eaadd2","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            LOG.debug(\"MySQL is up and running.\")"},{"line_number":42,"context_line":"            return True"},{"line_number":43,"context_line":"        else:"},{"line_number":44,"context_line":"            LOG.info(_(\"MySQL is not running.\"))"},{"line_number":45,"context_line":"            return False"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def mysql_is_not_running(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_91cd87bd","line":44,"in_reply_to":"baada198_a4e500a6","updated":"2014-07-22 19:39:36.000000000","message":"No, I specifically made the negative messages INFO and the positive case messages as DEBUG. In most cases, were calling to check if something is up and if it is not, we want to know ...","commit_id":"c2d28bd7bc60073f0244d0ff547eb28b69c495f6"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"b87d5613bdc59a16a808a3129da31b8ce87a67ce","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def mysql_is_not_running(self):"},{"line_number":48,"context_line":"        if base.exec_with_root_helper(\"/usr/bin/pgrep\", \"mysqld\"):"},{"line_number":49,"context_line":"            LOG.info(_(\"MySQL is still running.\"))"},{"line_number":50,"context_line":"            return False"},{"line_number":51,"context_line":"        else:"},{"line_number":52,"context_line":"            LOG.debug(\"MySQL is not running.\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_24f9f04e","line":49,"updated":"2014-07-22 14:20:35.000000000","message":"ditto","commit_id":"c2d28bd7bc60073f0244d0ff547eb28b69c495f6"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"b87d5613bdc59a16a808a3129da31b8ce87a67ce","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            if i \u003d\u003d 0:"},{"line_number":69,"context_line":"                LOG.info(_(\"Starting MySQL\"))"},{"line_number":70,"context_line":"        except pexpect.TIMEOUT:"},{"line_number":71,"context_line":"            LOG.exception(_(\"wait_and_close_proc failed with TIMEOUT\"))"},{"line_number":72,"context_line":"        finally:"},{"line_number":73,"context_line":"            # There is a race condition here where we kill mysqld before"},{"line_number":74,"context_line":"            # the init file been executed. We need to ensure mysqld is up."}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_04586c56","line":71,"updated":"2014-07-22 14:20:35.000000000","message":"This doesn\u0027t sound like an operator message (and it references a method name different from its own)","commit_id":"c2d28bd7bc60073f0244d0ff547eb28b69c495f6"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"b87d5613bdc59a16a808a3129da31b8ce87a67ce","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                base.RestoreError(\"Reset root password failed: \""},{"line_number":78,"context_line":"                                  \"mysqld did not start!\"))"},{"line_number":79,"context_line":"            LOG.info(_(\"Root password reset successfully.\"))"},{"line_number":80,"context_line":"            LOG.info(_(\"Cleaning up the temp mysqld process.\"))"},{"line_number":81,"context_line":"            child.delayafterclose \u003d 1"},{"line_number":82,"context_line":"            child.delayafterterminate \u003d 1"},{"line_number":83,"context_line":"            child.close(force\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_c414b44f","line":80,"updated":"2014-07-22 14:20:35.000000000","message":"Probably a debug candidate","commit_id":"c2d28bd7bc60073f0244d0ff547eb28b69c495f6"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"62d99977e50bd9b4203f76797d59d63296eaadd2","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                base.RestoreError(\"Reset root password failed: \""},{"line_number":78,"context_line":"                                  \"mysqld did not start!\"))"},{"line_number":79,"context_line":"            LOG.info(_(\"Root password reset successfully.\"))"},{"line_number":80,"context_line":"            LOG.info(_(\"Cleaning up the temp mysqld process.\"))"},{"line_number":81,"context_line":"            child.delayafterclose \u003d 1"},{"line_number":82,"context_line":"            child.delayafterterminate \u003d 1"},{"line_number":83,"context_line":"            child.close(force\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_f1432311","line":80,"in_reply_to":"baada198_c414b44f","updated":"2014-07-22 19:39:36.000000000","message":"many of these messages are useful as the system is booting up to see what stage it has got to. We\u0027re not yet at the stage where a person can run a system at INFO level, if you make these all DEBUG. In the fullness of time, maybe. Not now.\n\nThe goal is to make it possible to run the system at INFO level; not require DEBUG.","commit_id":"c2d28bd7bc60073f0244d0ff547eb28b69c495f6"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"b87d5613bdc59a16a808a3129da31b8ce87a67ce","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        app \u003d dbaas.MySqlApp(dbaas.MySqlAppStatus.get())"},{"line_number":120,"context_line":"        app.stop_db()"},{"line_number":121,"context_line":"        LOG.info(_(\"Cleaning out restore location: %s.\"),"},{"line_number":122,"context_line":"                 self.restore_location)"},{"line_number":123,"context_line":"        utils.execute_with_timeout(\"chmod\", \"-R\", \"0777\","},{"line_number":124,"context_line":"                                   self.restore_location,"},{"line_number":125,"context_line":"                                   root_helper\u003d\"sudo\","}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_7f28d185","line":122,"updated":"2014-07-22 14:20:35.000000000","message":"Sounds like a debug message","commit_id":"c2d28bd7bc60073f0244d0ff547eb28b69c495f6"}]}