)]}'
{"trove/guestagent/datastore/mysql/manager.py":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"cfc6a3d3d8ebd1ab08f70cdbb9e03e1670191392","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        if backup_info:"},{"line_number":130,"context_line":"            self._perform_restore(backup_info, context,"},{"line_number":131,"context_line":"                                  mount_point, app)"},{"line_number":132,"context_line":"        LOG.info(_(\"Securing MySQL now.\"))"},{"line_number":133,"context_line":"        app.secure(config_contents, overrides)"},{"line_number":134,"context_line":"        enable_root_on_restore \u003d (backup_info and"},{"line_number":135,"context_line":"                                  MySqlAdmin().is_root_enabled())"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_a9a2783c","line":132,"updated":"2014-07-21 19:21:33.000000000","message":"Should this be a debug message?","commit_id":"656577315d29e2766bbd55d17722f5c41861b087"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"cfc6a3d3d8ebd1ab08f70cdbb9e03e1670191392","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        if users:"},{"line_number":150,"context_line":"            self.create_user(context, users)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        LOG.info(_(\u0027\"prepare\" call has finished.\u0027))"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def restart(self, context):"},{"line_number":155,"context_line":"        app \u003d MySqlApp(MySqlAppStatus.get())"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_ec2abe7c","line":152,"updated":"2014-07-21 19:21:33.000000000","message":"Can we make this a more \u0027operator-friendly\u0027 message?  Something like \"MySQL instance created successfully\" ?","commit_id":"656577315d29e2766bbd55d17722f5c41861b087"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"9812ccb9f8d9a93a213f3ff57bfa7d5189db48b3","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        if users:"},{"line_number":150,"context_line":"            self.create_user(context, users)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        LOG.info(_(\u0027\"prepare\" call has finished.\u0027))"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def restart(self, context):"},{"line_number":155,"context_line":"        app \u003d MySqlApp(MySqlAppStatus.get())"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_80057a7b","line":152,"in_reply_to":"baada198_ec2abe7c","updated":"2014-07-22 00:11:45.000000000","message":"Done","commit_id":"656577315d29e2766bbd55d17722f5c41861b087"},{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"5c219d62662919b30657791bce16561aecf2f7f6","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        LOG.debug(\"Resized the filesystem\")"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def update_overrides(self, context, overrides, remove\u003dFalse):"},{"line_number":200,"context_line":"        LOG.debug(\"Updating overrides.\")"},{"line_number":201,"context_line":"        app \u003d MySqlApp(MySqlAppStatus.get())"},{"line_number":202,"context_line":"        app.update_overrides(overrides, remove\u003dremove)"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_7400e102","line":200,"updated":"2014-07-22 20:29:38.000000000","message":"Given you are adding this message wouldn\u0027t it be useful to add some context? Maybe print out the overrides?","commit_id":"fd89d201231f82681efa593df3430282bfd09799"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"96c261d42abe3c1a2cea5f550e6008074c437aa0","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        LOG.debug(\"Resized the filesystem\")"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def update_overrides(self, context, overrides, remove\u003dFalse):"},{"line_number":200,"context_line":"        LOG.debug(\"Updating overrides.\")"},{"line_number":201,"context_line":"        app \u003d MySqlApp(MySqlAppStatus.get())"},{"line_number":202,"context_line":"        app.update_overrides(overrides, remove\u003dremove)"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_aa60540e","line":200,"in_reply_to":"baada198_7400e102","updated":"2014-07-22 21:17:16.000000000","message":"Done","commit_id":"fd89d201231f82681efa593df3430282bfd09799"},{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"5c219d62662919b30657791bce16561aecf2f7f6","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        app.update_overrides(overrides, remove\u003dremove)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def apply_overrides(self, context, overrides):"},{"line_number":205,"context_line":"        LOG.debug(\"Applying overrides.\")"},{"line_number":206,"context_line":"        app \u003d MySqlApp(MySqlAppStatus.get())"},{"line_number":207,"context_line":"        app.apply_overrides(overrides)"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_affce60d","line":205,"updated":"2014-07-22 20:29:38.000000000","message":"similar comment to above","commit_id":"fd89d201231f82681efa593df3430282bfd09799"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"96c261d42abe3c1a2cea5f550e6008074c437aa0","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        app.update_overrides(overrides, remove\u003dremove)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def apply_overrides(self, context, overrides):"},{"line_number":205,"context_line":"        LOG.debug(\"Applying overrides.\")"},{"line_number":206,"context_line":"        app \u003d MySqlApp(MySqlAppStatus.get())"},{"line_number":207,"context_line":"        app.apply_overrides(overrides)"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_ca65881e","line":205,"in_reply_to":"baada198_affce60d","updated":"2014-07-22 21:17:16.000000000","message":"Done","commit_id":"fd89d201231f82681efa593df3430282bfd09799"}],"trove/guestagent/datastore/mysql/service.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"91d4210192e1898c797542bc3e27b8bc14a4704e","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                pid \u003d out.split()[0]"},{"line_number":170,"context_line":"                # TODO(rnirmal): Need to create new statuses for instances"},{"line_number":171,"context_line":"                # where the mysql service is up, but unresponsive"},{"line_number":172,"context_line":"                LOG.info(\u0027MySQL pid: %(pid)s is BLOCKED\u0027 % {\u0027pid\u0027: pid})"},{"line_number":173,"context_line":"                return rd_instance.ServiceStatuses.BLOCKED"},{"line_number":174,"context_line":"            except exception.ProcessExecutionError as execerr:"},{"line_number":175,"context_line":"                LOG.error(\"Process execution failed %s.\" % execerr)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_3e4ded72","line":172,"updated":"2014-07-19 08:14:29.000000000","message":"Please wrap message","commit_id":"acaa927749a20da679c8605c28301e5a85298982"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"bef959886b777fa253faf0ac44c4d3bf9aa80a5c","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                pid \u003d out.split()[0]"},{"line_number":170,"context_line":"                # TODO(rnirmal): Need to create new statuses for instances"},{"line_number":171,"context_line":"                # where the mysql service is up, but unresponsive"},{"line_number":172,"context_line":"                LOG.info(\u0027MySQL pid: %(pid)s is BLOCKED\u0027 % {\u0027pid\u0027: pid})"},{"line_number":173,"context_line":"                return rd_instance.ServiceStatuses.BLOCKED"},{"line_number":174,"context_line":"            except exception.ProcessExecutionError as execerr:"},{"line_number":175,"context_line":"                LOG.error(\"Process execution failed %s.\" % execerr)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_9f3ef027","line":172,"in_reply_to":"baada198_3e4ded72","updated":"2014-07-19 21:40:50.000000000","message":"Done","commit_id":"acaa927749a20da679c8605c28301e5a85298982"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"91d4210192e1898c797542bc3e27b8bc14a4704e","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                LOG.info(\u0027MySQL pid: %(pid)s is BLOCKED\u0027 % {\u0027pid\u0027: pid})"},{"line_number":173,"context_line":"                return rd_instance.ServiceStatuses.BLOCKED"},{"line_number":174,"context_line":"            except exception.ProcessExecutionError as execerr:"},{"line_number":175,"context_line":"                LOG.error(\"Process execution failed %s.\" % execerr)"},{"line_number":176,"context_line":"                mysql_args \u003d load_mysqld_options()"},{"line_number":177,"context_line":"                pid_file \u003d mysql_args.get(\u0027pid_file\u0027,"},{"line_number":178,"context_line":"                                          \u0027/var/run/mysqld/mysqld.pid\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_5e52a113","line":175,"updated":"2014-07-19 08:14:29.000000000","message":"Same","commit_id":"acaa927749a20da679c8605c28301e5a85298982"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"bef959886b777fa253faf0ac44c4d3bf9aa80a5c","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                LOG.info(\u0027MySQL pid: %(pid)s is BLOCKED\u0027 % {\u0027pid\u0027: pid})"},{"line_number":173,"context_line":"                return rd_instance.ServiceStatuses.BLOCKED"},{"line_number":174,"context_line":"            except exception.ProcessExecutionError as execerr:"},{"line_number":175,"context_line":"                LOG.error(\"Process execution failed %s.\" % execerr)"},{"line_number":176,"context_line":"                mysql_args \u003d load_mysqld_options()"},{"line_number":177,"context_line":"                pid_file \u003d mysql_args.get(\u0027pid_file\u0027,"},{"line_number":178,"context_line":"                                          \u0027/var/run/mysqld/mysqld.pid\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_df44e8b9","line":175,"in_reply_to":"baada198_5e52a113","updated":"2014-07-19 21:40:50.000000000","message":"Done","commit_id":"acaa927749a20da679c8605c28301e5a85298982"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"91d4210192e1898c797542bc3e27b8bc14a4704e","unresolved":false,"context_lines":[{"line_number":177,"context_line":"                pid_file \u003d mysql_args.get(\u0027pid_file\u0027,"},{"line_number":178,"context_line":"                                          \u0027/var/run/mysqld/mysqld.pid\u0027)"},{"line_number":179,"context_line":"                if os.path.exists(pid_file):"},{"line_number":180,"context_line":"                    LOG.info(\"MySQL is CRASHED.\")"},{"line_number":181,"context_line":"                    return rd_instance.ServiceStatuses.CRASHED"},{"line_number":182,"context_line":"                else:"},{"line_number":183,"context_line":"                    LOG.info(\"MySQL is SHUTDOWN.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_9e58b932","line":180,"updated":"2014-07-19 08:14:29.000000000","message":"Same","commit_id":"acaa927749a20da679c8605c28301e5a85298982"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"bef959886b777fa253faf0ac44c4d3bf9aa80a5c","unresolved":false,"context_lines":[{"line_number":177,"context_line":"                pid_file \u003d mysql_args.get(\u0027pid_file\u0027,"},{"line_number":178,"context_line":"                                          \u0027/var/run/mysqld/mysqld.pid\u0027)"},{"line_number":179,"context_line":"                if os.path.exists(pid_file):"},{"line_number":180,"context_line":"                    LOG.info(\"MySQL is CRASHED.\")"},{"line_number":181,"context_line":"                    return rd_instance.ServiceStatuses.CRASHED"},{"line_number":182,"context_line":"                else:"},{"line_number":183,"context_line":"                    LOG.info(\"MySQL is SHUTDOWN.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_ff41aca6","line":180,"in_reply_to":"baada198_9e58b932","updated":"2014-07-19 21:40:50.000000000","message":"Done","commit_id":"acaa927749a20da679c8605c28301e5a85298982"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"91d4210192e1898c797542bc3e27b8bc14a4704e","unresolved":false,"context_lines":[{"line_number":180,"context_line":"                    LOG.info(\"MySQL is CRASHED.\")"},{"line_number":181,"context_line":"                    return rd_instance.ServiceStatuses.CRASHED"},{"line_number":182,"context_line":"                else:"},{"line_number":183,"context_line":"                    LOG.info(\"MySQL is SHUTDOWN.\")"},{"line_number":184,"context_line":"                    return rd_instance.ServiceStatuses.SHUTDOWN"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_be401d36","line":183,"updated":"2014-07-19 08:14:29.000000000","message":"Same","commit_id":"acaa927749a20da679c8605c28301e5a85298982"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"bef959886b777fa253faf0ac44c4d3bf9aa80a5c","unresolved":false,"context_lines":[{"line_number":180,"context_line":"                    LOG.info(\"MySQL is CRASHED.\")"},{"line_number":181,"context_line":"                    return rd_instance.ServiceStatuses.CRASHED"},{"line_number":182,"context_line":"                else:"},{"line_number":183,"context_line":"                    LOG.info(\"MySQL is SHUTDOWN.\")"},{"line_number":184,"context_line":"                    return rd_instance.ServiceStatuses.SHUTDOWN"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_1f12e0b3","line":183,"in_reply_to":"baada198_be401d36","updated":"2014-07-19 21:40:50.000000000","message":"Done","commit_id":"acaa927749a20da679c8605c28301e5a85298982"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"79157e3fee479ad925aa9487923fc3db5a015212","unresolved":false,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def _associate_dbs(self, user):"},{"line_number":222,"context_line":"        \"\"\"Internal. Given a MySQLUser, populate its databases attribute.\"\"\""},{"line_number":223,"context_line":"        LOG.debug(\"Associating dbs to user %s at %s.\" %"},{"line_number":224,"context_line":"                  (user.name, user.host))"},{"line_number":225,"context_line":"        with LocalSqlClient(get_engine()) as client:"},{"line_number":226,"context_line":"            q \u003d sql_query.Query()"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_cb6fdc5e","line":223,"updated":"2014-07-18 22:05:41.000000000","message":"can you explain why it was changed?","commit_id":"acaa927749a20da679c8605c28301e5a85298982"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"bef959886b777fa253faf0ac44c4d3bf9aa80a5c","unresolved":false,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def _associate_dbs(self, user):"},{"line_number":222,"context_line":"        \"\"\"Internal. Given a MySQLUser, populate its databases attribute.\"\"\""},{"line_number":223,"context_line":"        LOG.debug(\"Associating dbs to user %s at %s.\" %"},{"line_number":224,"context_line":"                  (user.name, user.host))"},{"line_number":225,"context_line":"        with LocalSqlClient(get_engine()) as client:"},{"line_number":226,"context_line":"            q \u003d sql_query.Query()"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_3f17a4a4","line":223,"in_reply_to":"baada198_cb6fdc5e","updated":"2014-07-19 21:40:50.000000000","message":"All errors are supposed to have a punctuation at the end. You will notice that in many of the changes.","commit_id":"acaa927749a20da679c8605c28301e5a85298982"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"27322175218f0ace29f34c1c5a0208516422b70d","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            out, err \u003d utils.execute_with_timeout("},{"line_number":160,"context_line":"                \"/usr/bin/mysqladmin\","},{"line_number":161,"context_line":"                \"ping\", run_as_root\u003dTrue, root_helper\u003d\"sudo\")"},{"line_number":162,"context_line":"            LOG.info(_(\"MySQL is RUNNING.\"))"},{"line_number":163,"context_line":"            return rd_instance.ServiceStatuses.RUNNING"},{"line_number":164,"context_line":"        except exception.ProcessExecutionError as err:"},{"line_number":165,"context_line":"            LOG.error(_(\"Process execution failed %s.\") % err)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_40eb8da3","line":162,"range":{"start_line":162,"start_character":22,"end_line":162,"end_character":24},"updated":"2014-07-21 05:09:46.000000000","message":"Can we change this to something like \"MySQL Service Status\"? These statuses (i.e. RUNNING / BLOCKED / CRASHED / SHUTDOWN) correspond to the status_id values in the trove ServiceStatuses table, and the logs should reflect this correlation.\n\nAlso, it\u0027s useful to have this while grepping logs to find out current / historical Service Status; grepping on MySQL is going to get you a lot more noise.","commit_id":"350bc6311dd93b84b563f1f1c41961b85220b534"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"27322175218f0ace29f34c1c5a0208516422b70d","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                pid \u003d out.split()[0]"},{"line_number":170,"context_line":"                # TODO(rnirmal): Need to create new statuses for instances"},{"line_number":171,"context_line":"                # where the mysql service is up, but unresponsive"},{"line_number":172,"context_line":"                LOG.info(_(\u0027MySQL pid: %(pid)s is BLOCKED.\u0027) % {\u0027pid\u0027: pid})"},{"line_number":173,"context_line":"                return rd_instance.ServiceStatuses.BLOCKED"},{"line_number":174,"context_line":"            except exception.ProcessExecutionError as execerr:"},{"line_number":175,"context_line":"                LOG.error(_(\"Process execution failed %s.\") % execerr)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_a031c95a","line":172,"updated":"2014-07-21 05:09:46.000000000","message":"Ditto","commit_id":"350bc6311dd93b84b563f1f1c41961b85220b534"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"27322175218f0ace29f34c1c5a0208516422b70d","unresolved":false,"context_lines":[{"line_number":177,"context_line":"                pid_file \u003d mysql_args.get(\u0027pid_file\u0027,"},{"line_number":178,"context_line":"                                          \u0027/var/run/mysqld/mysqld.pid\u0027)"},{"line_number":179,"context_line":"                if os.path.exists(pid_file):"},{"line_number":180,"context_line":"                    LOG.info(_(\"MySQL is CRASHED.\"))"},{"line_number":181,"context_line":"                    return rd_instance.ServiceStatuses.CRASHED"},{"line_number":182,"context_line":"                else:"},{"line_number":183,"context_line":"                    LOG.info(_(\"MySQL is SHUTDOWN.\"))"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_c036bd50","line":180,"updated":"2014-07-21 05:09:46.000000000","message":"Ditto","commit_id":"350bc6311dd93b84b563f1f1c41961b85220b534"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"27322175218f0ace29f34c1c5a0208516422b70d","unresolved":false,"context_lines":[{"line_number":180,"context_line":"                    LOG.info(_(\"MySQL is CRASHED.\"))"},{"line_number":181,"context_line":"                    return rd_instance.ServiceStatuses.CRASHED"},{"line_number":182,"context_line":"                else:"},{"line_number":183,"context_line":"                    LOG.info(_(\"MySQL is SHUTDOWN.\"))"},{"line_number":184,"context_line":"                    return rd_instance.ServiceStatuses.SHUTDOWN"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_e03e6128","line":183,"updated":"2014-07-21 05:09:46.000000000","message":"Ditto","commit_id":"350bc6311dd93b84b563f1f1c41961b85220b534"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"cfc6a3d3d8ebd1ab08f70cdbb9e03e1670191392","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            LOG.info(_(\"MySQL Service Status is RUNNING.\"))"},{"line_number":163,"context_line":"            return rd_instance.ServiceStatuses.RUNNING"},{"line_number":164,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":165,"context_line":"            LOG.exception(_(\"Process execution failed %s.\"))"},{"line_number":166,"context_line":"            try:"},{"line_number":167,"context_line":"                out, err \u003d utils.execute_with_timeout(\"/bin/ps\", \"-C\","},{"line_number":168,"context_line":"                                                      \"mysqld\", \"h\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_ec9f1eb2","line":165,"updated":"2014-07-21 19:21:33.000000000","message":"There\u0027s no argument here to put in the %s.","commit_id":"656577315d29e2766bbd55d17722f5c41861b087"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"cfc6a3d3d8ebd1ab08f70cdbb9e03e1670191392","unresolved":false,"context_lines":[{"line_number":595,"context_line":"            packager.pkg_install(packages, pkg_opts, self.TIME_OUT)"},{"line_number":596,"context_line":"            self._create_mysql_confd_dir()"},{"line_number":597,"context_line":"            LOG.debug(\"Finished installing MySQL server.\")"},{"line_number":598,"context_line":"        self.start_mysql()"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"    def complete_install_or_restart(self):"},{"line_number":601,"context_line":"        self.status.end_install_or_restart()"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_0c97f23a","line":598,"updated":"2014-07-21 19:21:33.000000000","message":"You left this info message in the redis service - we should probably be consistent.\n\n  LOG.info(_(\u0027Redis install_if_needed complete.\u0027))\n\nAlthough I would prefer an operator-style message instead:\n\n  LOG.info(_(\u0027MySQL installed successfully.\u0027))","commit_id":"656577315d29e2766bbd55d17722f5c41861b087"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"9812ccb9f8d9a93a213f3ff57bfa7d5189db48b3","unresolved":false,"context_lines":[{"line_number":595,"context_line":"            packager.pkg_install(packages, pkg_opts, self.TIME_OUT)"},{"line_number":596,"context_line":"            self._create_mysql_confd_dir()"},{"line_number":597,"context_line":"            LOG.debug(\"Finished installing MySQL server.\")"},{"line_number":598,"context_line":"        self.start_mysql()"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"    def complete_install_or_restart(self):"},{"line_number":601,"context_line":"        self.status.end_install_or_restart()"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_c0fbf278","line":598,"in_reply_to":"baada198_0c97f23a","updated":"2014-07-22 00:11:45.000000000","message":"Done","commit_id":"656577315d29e2766bbd55d17722f5c41861b087"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"cfc6a3d3d8ebd1ab08f70cdbb9e03e1670191392","unresolved":false,"context_lines":[{"line_number":645,"context_line":"        utils.execute_with_timeout(command, shell\u003dTrue)"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"    def _enable_mysql_on_boot(self):"},{"line_number":648,"context_line":"        LOG.info(_(\"Enabling MySQL on boot.\"))"},{"line_number":649,"context_line":"        try:"},{"line_number":650,"context_line":"            mysql_service \u003d operating_system.service_discovery("},{"line_number":651,"context_line":"                MYSQL_SERVICE_CANDIDATES)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_ccb7bad6","line":648,"updated":"2014-07-21 19:21:33.000000000","message":"Should this be a debug message?","commit_id":"656577315d29e2766bbd55d17722f5c41861b087"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"9812ccb9f8d9a93a213f3ff57bfa7d5189db48b3","unresolved":false,"context_lines":[{"line_number":645,"context_line":"        utils.execute_with_timeout(command, shell\u003dTrue)"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"    def _enable_mysql_on_boot(self):"},{"line_number":648,"context_line":"        LOG.info(_(\"Enabling MySQL on boot.\"))"},{"line_number":649,"context_line":"        try:"},{"line_number":650,"context_line":"            mysql_service \u003d operating_system.service_discovery("},{"line_number":651,"context_line":"                MYSQL_SERVICE_CANDIDATES)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_20502e5d","line":648,"in_reply_to":"baada198_ccb7bad6","updated":"2014-07-22 00:11:45.000000000","message":"I\u0027ve left all these messages as info as they are largely the only indication that these methods are invoked. If we ever want a person to be able to run the system at INFO (and not DEBUG), we need these. Later however, we may need less logging but for now, INFO is (IMHO) appropriate. I did fix the capitalization.","commit_id":"656577315d29e2766bbd55d17722f5c41861b087"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"cfc6a3d3d8ebd1ab08f70cdbb9e03e1670191392","unresolved":false,"context_lines":[{"line_number":716,"context_line":"            self._remove_overrides()"},{"line_number":717,"context_line":""},{"line_number":718,"context_line":"    def apply_overrides(self, overrides):"},{"line_number":719,"context_line":"        LOG.debug(\"applying overrides to MySQL.\")"},{"line_number":720,"context_line":"        with LocalSqlClient(get_engine()) as client:"},{"line_number":721,"context_line":"            LOG.debug(\"Updating override values in running MySQL.\")"},{"line_number":722,"context_line":"            for k, v in overrides.iteritems():"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_acd366ff","line":719,"updated":"2014-07-21 19:21:33.000000000","message":"Missed a capitalization","commit_id":"656577315d29e2766bbd55d17722f5c41861b087"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"cfc6a3d3d8ebd1ab08f70cdbb9e03e1670191392","unresolved":false,"context_lines":[{"line_number":785,"context_line":"        Update the os_admin user and password to the my.cnf"},{"line_number":786,"context_line":"        file for direct login from localhost."},{"line_number":787,"context_line":"        \"\"\""},{"line_number":788,"context_line":"        LOG.info(_(\"Writing my.cnf templates.\"))"},{"line_number":789,"context_line":"        if admin_password is None:"},{"line_number":790,"context_line":"            admin_password \u003d get_auth_password()"},{"line_number":791,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_0c81b2c2","line":788,"updated":"2014-07-21 19:21:33.000000000","message":"Looks like another debug candidate","commit_id":"656577315d29e2766bbd55d17722f5c41861b087"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"cfc6a3d3d8ebd1ab08f70cdbb9e03e1670191392","unresolved":false,"context_lines":[{"line_number":807,"context_line":"            self._write_config_overrides(overrides)"},{"line_number":808,"context_line":""},{"line_number":809,"context_line":"    def _write_config_overrides(self, overrideValues):"},{"line_number":810,"context_line":"        LOG.info(_(\"Writing new temp overrides.cnf file.\"))"},{"line_number":811,"context_line":""},{"line_number":812,"context_line":"        with open(MYCNF_OVERRIDES_TMP, \u0027w\u0027) as overrides:"},{"line_number":813,"context_line":"            overrides.write(overrideValues)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_4c556a4e","line":810,"updated":"2014-07-21 19:21:33.000000000","message":"ditto","commit_id":"656577315d29e2766bbd55d17722f5c41861b087"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"cfc6a3d3d8ebd1ab08f70cdbb9e03e1670191392","unresolved":false,"context_lines":[{"line_number":811,"context_line":""},{"line_number":812,"context_line":"        with open(MYCNF_OVERRIDES_TMP, \u0027w\u0027) as overrides:"},{"line_number":813,"context_line":"            overrides.write(overrideValues)"},{"line_number":814,"context_line":"        LOG.info(_(\"Moving overrides.cnf into correct location.\"))"},{"line_number":815,"context_line":"        utils.execute_with_timeout(\"sudo\", \"mv\", MYCNF_OVERRIDES_TMP,"},{"line_number":816,"context_line":"                                   MYCNF_OVERRIDES)"},{"line_number":817,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_ccc89a24","line":814,"updated":"2014-07-21 19:21:33.000000000","message":"ditto","commit_id":"656577315d29e2766bbd55d17722f5c41861b087"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"cfc6a3d3d8ebd1ab08f70cdbb9e03e1670191392","unresolved":false,"context_lines":[{"line_number":815,"context_line":"        utils.execute_with_timeout(\"sudo\", \"mv\", MYCNF_OVERRIDES_TMP,"},{"line_number":816,"context_line":"                                   MYCNF_OVERRIDES)"},{"line_number":817,"context_line":""},{"line_number":818,"context_line":"        LOG.info(_(\"Setting permissions on overrides.cnf.\"))"},{"line_number":819,"context_line":"        utils.execute_with_timeout(\"sudo\", \"chmod\", \"0711\","},{"line_number":820,"context_line":"                                   MYCNF_OVERRIDES)"},{"line_number":821,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_0ccff229","line":818,"updated":"2014-07-21 19:21:33.000000000","message":"ditto","commit_id":"656577315d29e2766bbd55d17722f5c41861b087"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"cfc6a3d3d8ebd1ab08f70cdbb9e03e1670191392","unresolved":false,"context_lines":[{"line_number":820,"context_line":"                                   MYCNF_OVERRIDES)"},{"line_number":821,"context_line":""},{"line_number":822,"context_line":"    def _remove_overrides(self):"},{"line_number":823,"context_line":"        LOG.info(_(\"Removing overrides configuration file.\"))"},{"line_number":824,"context_line":"        if os.path.exists(MYCNF_OVERRIDES):"},{"line_number":825,"context_line":"            utils.execute_with_timeout(\"sudo\", \"rm\", MYCNF_OVERRIDES)"},{"line_number":826,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_2cd2f6d0","line":823,"updated":"2014-07-21 19:21:33.000000000","message":"ditto","commit_id":"656577315d29e2766bbd55d17722f5c41861b087"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"cfc6a3d3d8ebd1ab08f70cdbb9e03e1670191392","unresolved":false,"context_lines":[{"line_number":861,"context_line":""},{"line_number":862,"context_line":"    def start_db_with_conf_changes(self, config_contents):"},{"line_number":863,"context_line":"        LOG.info(_(\"Starting MySQL with conf changes.\"))"},{"line_number":864,"context_line":"        LOG.info(_(\"inside the guest - self.status.is_mysql_running(%s).\")"},{"line_number":865,"context_line":"                 % self.status.is_running)"},{"line_number":866,"context_line":"        if self.status.is_running:"},{"line_number":867,"context_line":"            LOG.error(_(\"Cannot execute start_db_with_conf_changes because \""}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_6cd78ebf","line":864,"updated":"2014-07-21 19:21:33.000000000","message":"ditto","commit_id":"656577315d29e2766bbd55d17722f5c41861b087"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"3b10d2a0039b292983616fa0880360d2d2e17bff","unresolved":false,"context_lines":[{"line_number":773,"context_line":"                # to have MySQL start up before it\u0027s restarted and these have"},{"line_number":774,"context_line":"                # to be deleted. That\u0027s why its ok if they aren\u0027t found."},{"line_number":775,"context_line":"                LOG.exception(_(\"Could not delete logfile.\"))"},{"line_number":776,"context_line":"                # FIXME(amrith) this isn\u0027t how execute_with_timeout"},{"line_number":777,"context_line":"                # is supposed to be used. add the error that"},{"line_number":778,"context_line":"                # we want to ignore into check_exit_codes"},{"line_number":779,"context_line":"                if \"No such file or directory\" not in str(pe):"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_736017a5","line":776,"updated":"2014-07-22 12:02:31.000000000","message":"out of scope, submit another bug and fix it rather than putting #FIXME in independent patches","commit_id":"3d8010fbb437e5edd2f3936fb95ccfb3f20b6938"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"33e3f3727461014c538aa105b0116f81039160d0","unresolved":false,"context_lines":[{"line_number":773,"context_line":"                # to have MySQL start up before it\u0027s restarted and these have"},{"line_number":774,"context_line":"                # to be deleted. That\u0027s why its ok if they aren\u0027t found."},{"line_number":775,"context_line":"                LOG.exception(_(\"Could not delete logfile.\"))"},{"line_number":776,"context_line":"                # FIXME(amrith) this isn\u0027t how execute_with_timeout"},{"line_number":777,"context_line":"                # is supposed to be used. add the error that"},{"line_number":778,"context_line":"                # we want to ignore into check_exit_codes"},{"line_number":779,"context_line":"                if \"No such file or directory\" not in str(pe):"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_794c719e","line":776,"in_reply_to":"baada198_736017a5","updated":"2014-07-22 14:08:51.000000000","message":"I\u0027d have to agree with this","commit_id":"3d8010fbb437e5edd2f3936fb95ccfb3f20b6938"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"a369a430c5ed2c2a1751389cc3fb933b4049188b","unresolved":false,"context_lines":[{"line_number":773,"context_line":"                # to have MySQL start up before it\u0027s restarted and these have"},{"line_number":774,"context_line":"                # to be deleted. That\u0027s why its ok if they aren\u0027t found."},{"line_number":775,"context_line":"                LOG.exception(_(\"Could not delete logfile.\"))"},{"line_number":776,"context_line":"                # FIXME(amrith) this isn\u0027t how execute_with_timeout"},{"line_number":777,"context_line":"                # is supposed to be used. add the error that"},{"line_number":778,"context_line":"                # we want to ignore into check_exit_codes"},{"line_number":779,"context_line":"                if \"No such file or directory\" not in str(pe):"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_5173ef4d","line":776,"in_reply_to":"baada198_794c719e","updated":"2014-07-22 19:46:06.000000000","message":"That adding a comment for a !FIXME is out of scope! Really? \n\nSure, I\u0027ll remove the comment but I\u0027ll fix it and the new bug I entered for it. Then you\u0027ll likely tell me that I should submit two changes for this?","commit_id":"3d8010fbb437e5edd2f3936fb95ccfb3f20b6938"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"0ac81fe007850fa2158399dae828f86b78a6640f","unresolved":false,"context_lines":[{"line_number":173,"context_line":"                         {\u0027pid\u0027: pid})"},{"line_number":174,"context_line":"                return rd_instance.ServiceStatuses.BLOCKED"},{"line_number":175,"context_line":"            except exception.ProcessExecutionError:"},{"line_number":176,"context_line":"                LOG.exception(_(\"Process execution failed %s.\"))"},{"line_number":177,"context_line":"                mysql_args \u003d load_mysqld_options()"},{"line_number":178,"context_line":"                pid_file \u003d mysql_args.get(\u0027pid_file\u0027,"},{"line_number":179,"context_line":"                                          \u0027/var/run/mysqld/mysqld.pid\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_de024a08","line":176,"updated":"2014-08-01 05:12:19.000000000","message":"unnecessary %s here.","commit_id":"80ee42cb01ebed083dda84fa4a45d5f9a22b2f21"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"55b1a59b80c5c8f116264a9a3a107fff16052dc8","unresolved":false,"context_lines":[{"line_number":173,"context_line":"                         {\u0027pid\u0027: pid})"},{"line_number":174,"context_line":"                return rd_instance.ServiceStatuses.BLOCKED"},{"line_number":175,"context_line":"            except exception.ProcessExecutionError:"},{"line_number":176,"context_line":"                LOG.exception(_(\"Process execution failed %s.\"))"},{"line_number":177,"context_line":"                mysql_args \u003d load_mysqld_options()"},{"line_number":178,"context_line":"                pid_file \u003d mysql_args.get(\u0027pid_file\u0027,"},{"line_number":179,"context_line":"                                          \u0027/var/run/mysqld/mysqld.pid\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_2b369802","line":176,"in_reply_to":"baada198_de024a08","updated":"2014-08-01 14:08:51.000000000","message":"pisses me off no end. I explicitly added the check for unnecessary parameters but I forgot to include LOG.exception in my script.\n\nFixed that and will verify other code as well after I chkin this change.","commit_id":"80ee42cb01ebed083dda84fa4a45d5f9a22b2f21"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"0ac81fe007850fa2158399dae828f86b78a6640f","unresolved":false,"context_lines":[{"line_number":858,"context_line":""},{"line_number":859,"context_line":"    def start_db_with_conf_changes(self, config_contents):"},{"line_number":860,"context_line":"        LOG.info(_(\"Starting MySQL with conf changes.\"))"},{"line_number":861,"context_line":"        LOG.debug(\"inside the guest - self.status.is_mysql_running(%s).\""},{"line_number":862,"context_line":"                  % self.status.is_running)"},{"line_number":863,"context_line":"        if self.status.is_running:"},{"line_number":864,"context_line":"            LOG.error(_(\"Cannot execute start_db_with_conf_changes because \""}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_9e2b727b","line":861,"updated":"2014-08-01 05:12:19.000000000","message":"you didn\u0027t capitalize this sentence (yet you did so in many other places)","commit_id":"80ee42cb01ebed083dda84fa4a45d5f9a22b2f21"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"55b1a59b80c5c8f116264a9a3a107fff16052dc8","unresolved":false,"context_lines":[{"line_number":858,"context_line":""},{"line_number":859,"context_line":"    def start_db_with_conf_changes(self, config_contents):"},{"line_number":860,"context_line":"        LOG.info(_(\"Starting MySQL with conf changes.\"))"},{"line_number":861,"context_line":"        LOG.debug(\"inside the guest - self.status.is_mysql_running(%s).\""},{"line_number":862,"context_line":"                  % self.status.is_running)"},{"line_number":863,"context_line":"        if self.status.is_running:"},{"line_number":864,"context_line":"            LOG.error(_(\"Cannot execute start_db_with_conf_changes because \""}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_eb166057","line":861,"in_reply_to":"baada198_9e2b727b","updated":"2014-08-01 14:08:51.000000000","message":"Yup, will do that.","commit_id":"80ee42cb01ebed083dda84fa4a45d5f9a22b2f21"}]}