)]}'
{"trove/taskmanager/models.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"db08dea03a3f7abc6b27c9a84c81bca4134227b4","unresolved":false,"context_lines":[{"line_number":425,"context_line":"                    sleep_time\u003dUSAGE_SLEEP_TIME,"},{"line_number":426,"context_line":"                    time_out\u003dHEAT_TIME_OUT)"},{"line_number":427,"context_line":"            except PollTimeOut:"},{"line_number":428,"context_line":"                raise TroveError(\"Failed to obtain Heat stack status. \""},{"line_number":429,"context_line":"                                 \"Timeout occurred.\")"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"            stack \u003d client.stacks.get(stack_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_2b1db862","line":428,"updated":"2014-07-18 22:02:02.000000000","message":"No need to add project name into exception message, please remove \"Heat\"","commit_id":"54ae6f9b60404cd3ff25eb79db61cd3fef776903"},{"author":{"_account_id":10266,"name":"Simon Chang","email":"schang@tesora.com","username":"changsimon"},"change_message_id":"0c6b568e4b8e8e81e6175e414d5cb79af68ff4fd","unresolved":false,"context_lines":[{"line_number":425,"context_line":"                    sleep_time\u003dUSAGE_SLEEP_TIME,"},{"line_number":426,"context_line":"                    time_out\u003dHEAT_TIME_OUT)"},{"line_number":427,"context_line":"            except PollTimeOut:"},{"line_number":428,"context_line":"                raise TroveError(\"Failed to obtain Heat stack status. \""},{"line_number":429,"context_line":"                                 \"Timeout occurred.\")"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"            stack \u003d client.stacks.get(stack_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_41b45d81","line":428,"in_reply_to":"baada198_2b1db862","updated":"2014-07-21 19:22:22.000000000","message":"This is an exception message. I think exception messages needs to be very clear about the cause of the issue ... In this case, it\u0027s a Heat issue.","commit_id":"54ae6f9b60404cd3ff25eb79db61cd3fef776903"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"db08dea03a3f7abc6b27c9a84c81bca4134227b4","unresolved":false,"context_lines":[{"line_number":431,"context_line":"            stack \u003d client.stacks.get(stack_name)"},{"line_number":432,"context_line":"            if ((stack.action, stack.stack_status)"},{"line_number":433,"context_line":"                    not in HEAT_STACK_SUCCESSFUL_STATUSES):"},{"line_number":434,"context_line":"                raise TroveError(\"Failed to create Heat stack.\")"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"            resource \u003d client.resources.get(stack.id, \u0027BaseInstance\u0027)"},{"line_number":437,"context_line":"            if resource.resource_status !\u003d HEAT_RESOURCE_SUCCESSFUL_STATE:"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_6b3a50ce","line":434,"updated":"2014-07-18 22:02:02.000000000","message":"same","commit_id":"54ae6f9b60404cd3ff25eb79db61cd3fef776903"},{"author":{"_account_id":10266,"name":"Simon Chang","email":"schang@tesora.com","username":"changsimon"},"change_message_id":"0c6b568e4b8e8e81e6175e414d5cb79af68ff4fd","unresolved":false,"context_lines":[{"line_number":431,"context_line":"            stack \u003d client.stacks.get(stack_name)"},{"line_number":432,"context_line":"            if ((stack.action, stack.stack_status)"},{"line_number":433,"context_line":"                    not in HEAT_STACK_SUCCESSFUL_STATUSES):"},{"line_number":434,"context_line":"                raise TroveError(\"Failed to create Heat stack.\")"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"            resource \u003d client.resources.get(stack.id, \u0027BaseInstance\u0027)"},{"line_number":437,"context_line":"            if resource.resource_status !\u003d HEAT_RESOURCE_SUCCESSFUL_STATE:"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_613c01e2","line":434,"in_reply_to":"baada198_6b3a50ce","updated":"2014-07-21 19:22:22.000000000","message":"The original code also has \"Heat\" in the exception message. For the reason I mentioned in the above comment, I\u0027m leaving the message as is.","commit_id":"54ae6f9b60404cd3ff25eb79db61cd3fef776903"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"db08dea03a3f7abc6b27c9a84c81bca4134227b4","unresolved":false,"context_lines":[{"line_number":435,"context_line":""},{"line_number":436,"context_line":"            resource \u003d client.resources.get(stack.id, \u0027BaseInstance\u0027)"},{"line_number":437,"context_line":"            if resource.resource_status !\u003d HEAT_RESOURCE_SUCCESSFUL_STATE:"},{"line_number":438,"context_line":"                raise TroveError(\"Failed to provision Heat base instance.\")"},{"line_number":439,"context_line":"            instance_id \u003d resource.physical_resource_id"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"            if CONF.trove_volume_support:"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_cb2d1c91","line":438,"updated":"2014-07-18 22:02:02.000000000","message":"same","commit_id":"54ae6f9b60404cd3ff25eb79db61cd3fef776903"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"db08dea03a3f7abc6b27c9a84c81bca4134227b4","unresolved":false,"context_lines":[{"line_number":441,"context_line":"            if CONF.trove_volume_support:"},{"line_number":442,"context_line":"                resource \u003d client.resources.get(stack.id, \u0027DataVolume\u0027)"},{"line_number":443,"context_line":"                if resource.resource_status !\u003d HEAT_RESOURCE_SUCCESSFUL_STATE:"},{"line_number":444,"context_line":"                    raise TroveError(\"Failed to provision Heat data volume.\")"},{"line_number":445,"context_line":"                volume_id \u003d resource.physical_resource_id"},{"line_number":446,"context_line":"                self.update_db(compute_instance_id\u003dinstance_id,"},{"line_number":447,"context_line":"                               volume_id\u003dvolume_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_4b590c34","line":444,"updated":"2014-07-18 22:02:02.000000000","message":"same","commit_id":"54ae6f9b60404cd3ff25eb79db61cd3fef776903"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"db08dea03a3f7abc6b27c9a84c81bca4134227b4","unresolved":false,"context_lines":[{"line_number":464,"context_line":""},{"line_number":465,"context_line":"        except (TroveError, heat_exceptions.HTTPNotFound,"},{"line_number":466,"context_line":"                heat_exceptions.HTTPException) as e:"},{"line_number":467,"context_line":"            msg \u003d _(\"Error occurred during Heat stack creation for \""},{"line_number":468,"context_line":"                    \"instance %s.\") % self.id"},{"line_number":469,"context_line":"            err \u003d inst_models.InstanceTasks.BUILDING_ERROR_SERVER"},{"line_number":470,"context_line":"            self._log_and_raise(e, msg, err)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_cb443c49","line":467,"updated":"2014-07-18 22:02:02.000000000","message":"same","commit_id":"54ae6f9b60404cd3ff25eb79db61cd3fef776903"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"db08dea03a3f7abc6b27c9a84c81bca4134227b4","unresolved":false,"context_lines":[{"line_number":480,"context_line":"                                           security_groups, datastore_manager,"},{"line_number":481,"context_line":"                                           volume_size,"},{"line_number":482,"context_line":"                                           availability_zone, nics):"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"        LOG.debug(\"Begin _create_server_volume_individually for id: %s\" %"},{"line_number":485,"context_line":"                  self.id)"},{"line_number":486,"context_line":"        server \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_2b6bf8b9","line":483,"updated":"2014-07-18 22:02:02.000000000","message":"please remove it","commit_id":"54ae6f9b60404cd3ff25eb79db61cd3fef776903"},{"author":{"_account_id":10266,"name":"Simon Chang","email":"schang@tesora.com","username":"changsimon"},"change_message_id":"0c6b568e4b8e8e81e6175e414d5cb79af68ff4fd","unresolved":false,"context_lines":[{"line_number":480,"context_line":"                                           security_groups, datastore_manager,"},{"line_number":481,"context_line":"                                           volume_size,"},{"line_number":482,"context_line":"                                           availability_zone, nics):"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"        LOG.debug(\"Begin _create_server_volume_individually for id: %s\" %"},{"line_number":485,"context_line":"                  self.id)"},{"line_number":486,"context_line":"        server \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_7073ed7f","line":483,"in_reply_to":"baada198_2b6bf8b9","updated":"2014-07-21 19:22:22.000000000","message":"Done","commit_id":"54ae6f9b60404cd3ff25eb79db61cd3fef776903"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"db08dea03a3f7abc6b27c9a84c81bca4134227b4","unresolved":false,"context_lines":[{"line_number":496,"context_line":"            # Save server ID."},{"line_number":497,"context_line":"            self.update_db(compute_instance_id\u003dserver_id)"},{"line_number":498,"context_line":"        except Exception as e:"},{"line_number":499,"context_line":"            msg \u003d _(\"Failed to create volume for instance %s\") % self.id"},{"line_number":500,"context_line":"            err \u003d inst_models.InstanceTasks.BUILDING_ERROR_SERVER"},{"line_number":501,"context_line":"            self._log_and_raise(e, msg, err)"},{"line_number":502,"context_line":"        LOG.debug(\"End _create_server_volume_individually for id: %s\" %"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_6b6890ba","line":499,"updated":"2014-07-18 22:02:02.000000000","message":"create server","commit_id":"54ae6f9b60404cd3ff25eb79db61cd3fef776903"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"db08dea03a3f7abc6b27c9a84c81bca4134227b4","unresolved":false,"context_lines":[{"line_number":804,"context_line":"        LOG.info(_(\"Resized instance %s successfully.\") % self.id)"},{"line_number":805,"context_line":""},{"line_number":806,"context_line":"    def migrate(self, host):"},{"line_number":807,"context_line":"        LOG.info(\"Initiating migration with host %s.\" % host)"},{"line_number":808,"context_line":"        action \u003d MigrateAction(self, host)"},{"line_number":809,"context_line":"        action.execute()"},{"line_number":810,"context_line":"        LOG.info(\"Initiated migration with host %s successfully.\" % host)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_ab8c6881","line":807,"updated":"2014-07-18 22:02:02.000000000","message":"Initiating migration to host","commit_id":"54ae6f9b60404cd3ff25eb79db61cd3fef776903"},{"author":{"_account_id":10266,"name":"Simon Chang","email":"schang@tesora.com","username":"changsimon"},"change_message_id":"0c6b568e4b8e8e81e6175e414d5cb79af68ff4fd","unresolved":false,"context_lines":[{"line_number":804,"context_line":"        LOG.info(_(\"Resized instance %s successfully.\") % self.id)"},{"line_number":805,"context_line":""},{"line_number":806,"context_line":"    def migrate(self, host):"},{"line_number":807,"context_line":"        LOG.info(\"Initiating migration with host %s.\" % host)"},{"line_number":808,"context_line":"        action \u003d MigrateAction(self, host)"},{"line_number":809,"context_line":"        action.execute()"},{"line_number":810,"context_line":"        LOG.info(\"Initiated migration with host %s successfully.\" % host)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_303fb588","line":807,"in_reply_to":"baada198_ab8c6881","updated":"2014-07-21 19:22:22.000000000","message":"Done","commit_id":"54ae6f9b60404cd3ff25eb79db61cd3fef776903"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"db08dea03a3f7abc6b27c9a84c81bca4134227b4","unresolved":false,"context_lines":[{"line_number":807,"context_line":"        LOG.info(\"Initiating migration with host %s.\" % host)"},{"line_number":808,"context_line":"        action \u003d MigrateAction(self, host)"},{"line_number":809,"context_line":"        action.execute()"},{"line_number":810,"context_line":"        LOG.info(\"Initiated migration with host %s successfully.\" % host)"},{"line_number":811,"context_line":""},{"line_number":812,"context_line":"    def create_backup(self, backup_info):"},{"line_number":813,"context_line":"        LOG.info(_(\"Initiating backup for instance %s.\") % self.id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_0bef141f","line":810,"updated":"2014-07-18 22:02:02.000000000","message":"same","commit_id":"54ae6f9b60404cd3ff25eb79db61cd3fef776903"},{"author":{"_account_id":10266,"name":"Simon Chang","email":"schang@tesora.com","username":"changsimon"},"change_message_id":"0c6b568e4b8e8e81e6175e414d5cb79af68ff4fd","unresolved":false,"context_lines":[{"line_number":807,"context_line":"        LOG.info(\"Initiating migration with host %s.\" % host)"},{"line_number":808,"context_line":"        action \u003d MigrateAction(self, host)"},{"line_number":809,"context_line":"        action.execute()"},{"line_number":810,"context_line":"        LOG.info(\"Initiated migration with host %s successfully.\" % host)"},{"line_number":811,"context_line":""},{"line_number":812,"context_line":"    def create_backup(self, backup_info):"},{"line_number":813,"context_line":"        LOG.info(_(\"Initiating backup for instance %s.\") % self.id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_103c7192","line":810,"in_reply_to":"baada198_0bef141f","updated":"2014-07-21 19:22:22.000000000","message":"Done","commit_id":"54ae6f9b60404cd3ff25eb79db61cd3fef776903"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"db08dea03a3f7abc6b27c9a84c81bca4134227b4","unresolved":false,"context_lines":[{"line_number":810,"context_line":"        LOG.info(\"Initiated migration with host %s successfully.\" % host)"},{"line_number":811,"context_line":""},{"line_number":812,"context_line":"    def create_backup(self, backup_info):"},{"line_number":813,"context_line":"        LOG.info(_(\"Initiating backup for instance %s.\") % self.id)"},{"line_number":814,"context_line":"        self.guest.create_backup(backup_info)"},{"line_number":815,"context_line":"        LOG.info(_(\"Initiated backup for instance %s successfully.\") % self.id)"},{"line_number":816,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_cbe0bc28","line":813,"updated":"2014-07-18 22:02:02.000000000","message":"swap Initiating with Creating","commit_id":"54ae6f9b60404cd3ff25eb79db61cd3fef776903"},{"author":{"_account_id":10266,"name":"Simon Chang","email":"schang@tesora.com","username":"changsimon"},"change_message_id":"0c6b568e4b8e8e81e6175e414d5cb79af68ff4fd","unresolved":false,"context_lines":[{"line_number":810,"context_line":"        LOG.info(\"Initiated migration with host %s successfully.\" % host)"},{"line_number":811,"context_line":""},{"line_number":812,"context_line":"    def create_backup(self, backup_info):"},{"line_number":813,"context_line":"        LOG.info(_(\"Initiating backup for instance %s.\") % self.id)"},{"line_number":814,"context_line":"        self.guest.create_backup(backup_info)"},{"line_number":815,"context_line":"        LOG.info(_(\"Initiated backup for instance %s successfully.\") % self.id)"},{"line_number":816,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_816e752d","line":813,"in_reply_to":"baada198_cbe0bc28","updated":"2014-07-21 19:22:22.000000000","message":"Backup is an async operation. Since we have been using the word \"initiate\" in all async operations, I\u0027m going to keep the word here.","commit_id":"54ae6f9b60404cd3ff25eb79db61cd3fef776903"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"db08dea03a3f7abc6b27c9a84c81bca4134227b4","unresolved":false,"context_lines":[{"line_number":812,"context_line":"    def create_backup(self, backup_info):"},{"line_number":813,"context_line":"        LOG.info(_(\"Initiating backup for instance %s.\") % self.id)"},{"line_number":814,"context_line":"        self.guest.create_backup(backup_info)"},{"line_number":815,"context_line":"        LOG.info(_(\"Initiated backup for instance %s successfully.\") % self.id)"},{"line_number":816,"context_line":""},{"line_number":817,"context_line":"    def reboot(self):"},{"line_number":818,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_ebd02055","line":815,"updated":"2014-07-18 22:02:02.000000000","message":"same, and even more, you actually don\u0027t know if it\u0027s finished successfuly or not\n\nremove the last word, please","commit_id":"54ae6f9b60404cd3ff25eb79db61cd3fef776903"},{"author":{"_account_id":10266,"name":"Simon Chang","email":"schang@tesora.com","username":"changsimon"},"change_message_id":"0c6b568e4b8e8e81e6175e414d5cb79af68ff4fd","unresolved":false,"context_lines":[{"line_number":812,"context_line":"    def create_backup(self, backup_info):"},{"line_number":813,"context_line":"        LOG.info(_(\"Initiating backup for instance %s.\") % self.id)"},{"line_number":814,"context_line":"        self.guest.create_backup(backup_info)"},{"line_number":815,"context_line":"        LOG.info(_(\"Initiated backup for instance %s successfully.\") % self.id)"},{"line_number":816,"context_line":""},{"line_number":817,"context_line":"    def reboot(self):"},{"line_number":818,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_615b2186","line":815,"in_reply_to":"baada198_ebd02055","updated":"2014-07-21 19:22:22.000000000","message":"Done","commit_id":"54ae6f9b60404cd3ff25eb79db61cd3fef776903"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"db08dea03a3f7abc6b27c9a84c81bca4134227b4","unresolved":false,"context_lines":[{"line_number":816,"context_line":""},{"line_number":817,"context_line":"    def reboot(self):"},{"line_number":818,"context_line":"        try:"},{"line_number":819,"context_line":"            LOG.debug(\"Instance %s calling stop_db...\" % self.id)"},{"line_number":820,"context_line":"            self.guest.stop_db()"},{"line_number":821,"context_line":"            LOG.info(_(\"Rebooting instance %s.\") % self.id)"},{"line_number":822,"context_line":"            self.server.reboot()"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_eb3740ae","line":819,"updated":"2014-07-18 22:02:02.000000000","message":"fix it please\n\nStopping datastore on instance %s","commit_id":"54ae6f9b60404cd3ff25eb79db61cd3fef776903"},{"author":{"_account_id":10266,"name":"Simon Chang","email":"schang@tesora.com","username":"changsimon"},"change_message_id":"0c6b568e4b8e8e81e6175e414d5cb79af68ff4fd","unresolved":false,"context_lines":[{"line_number":816,"context_line":""},{"line_number":817,"context_line":"    def reboot(self):"},{"line_number":818,"context_line":"        try:"},{"line_number":819,"context_line":"            LOG.debug(\"Instance %s calling stop_db...\" % self.id)"},{"line_number":820,"context_line":"            self.guest.stop_db()"},{"line_number":821,"context_line":"            LOG.info(_(\"Rebooting instance %s.\") % self.id)"},{"line_number":822,"context_line":"            self.server.reboot()"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_41c8dda7","line":819,"in_reply_to":"baada198_eb3740ae","updated":"2014-07-21 19:22:22.000000000","message":"Done","commit_id":"54ae6f9b60404cd3ff25eb79db61cd3fef776903"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"db08dea03a3f7abc6b27c9a84c81bca4134227b4","unresolved":false,"context_lines":[{"line_number":848,"context_line":"        LOG.info(_(\"Restarting datastore on instance %s.\") % self.id)"},{"line_number":849,"context_line":"        try:"},{"line_number":850,"context_line":"            self.guest.restart()"},{"line_number":851,"context_line":"            LOG.info(_(\"Restarted datastore on instance %s successfully.\")"},{"line_number":852,"context_line":"                     % self.id)"},{"line_number":853,"context_line":"        except GuestError:"},{"line_number":854,"context_line":"            LOG.error(_(\"Failed to restart datastore on instance %s.\") %"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_cb4efc37","line":851,"updated":"2014-07-18 22:02:02.000000000","message":"again, you don\u0027t know how does restart finished at this stage, please remove work \u0027successfuly\u0027","commit_id":"54ae6f9b60404cd3ff25eb79db61cd3fef776903"},{"author":{"_account_id":10266,"name":"Simon Chang","email":"schang@tesora.com","username":"changsimon"},"change_message_id":"0c6b568e4b8e8e81e6175e414d5cb79af68ff4fd","unresolved":false,"context_lines":[{"line_number":848,"context_line":"        LOG.info(_(\"Restarting datastore on instance %s.\") % self.id)"},{"line_number":849,"context_line":"        try:"},{"line_number":850,"context_line":"            self.guest.restart()"},{"line_number":851,"context_line":"            LOG.info(_(\"Restarted datastore on instance %s successfully.\")"},{"line_number":852,"context_line":"                     % self.id)"},{"line_number":853,"context_line":"        except GuestError:"},{"line_number":854,"context_line":"            LOG.error(_(\"Failed to restart datastore on instance %s.\") %"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_b08d857e","line":851,"in_reply_to":"baada198_cb4efc37","updated":"2014-07-21 19:22:22.000000000","message":"Done","commit_id":"54ae6f9b60404cd3ff25eb79db61cd3fef776903"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"db08dea03a3f7abc6b27c9a84c81bca4134227b4","unresolved":false,"context_lines":[{"line_number":858,"context_line":"            self.reset_task_status()"},{"line_number":859,"context_line":""},{"line_number":860,"context_line":"    def update_overrides(self, overrides, remove\u003dFalse):"},{"line_number":861,"context_line":"        LOG.info(\"Updating datastore configurations on instance %s.\""},{"line_number":862,"context_line":"                 % self.id)"},{"line_number":863,"context_line":"        LOG.debug(\"overrides: %s\" % overrides)"},{"line_number":864,"context_line":"        LOG.debug(\"self.ds_version: %s\" % self.ds_version.__dict__)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_2b55b8c1","line":861,"updated":"2014-07-18 22:02:02.000000000","message":"should be wrapped","commit_id":"54ae6f9b60404cd3ff25eb79db61cd3fef776903"},{"author":{"_account_id":10266,"name":"Simon Chang","email":"schang@tesora.com","username":"changsimon"},"change_message_id":"0c6b568e4b8e8e81e6175e414d5cb79af68ff4fd","unresolved":false,"context_lines":[{"line_number":858,"context_line":"            self.reset_task_status()"},{"line_number":859,"context_line":""},{"line_number":860,"context_line":"    def update_overrides(self, overrides, remove\u003dFalse):"},{"line_number":861,"context_line":"        LOG.info(\"Updating datastore configurations on instance %s.\""},{"line_number":862,"context_line":"                 % self.id)"},{"line_number":863,"context_line":"        LOG.debug(\"overrides: %s\" % overrides)"},{"line_number":864,"context_line":"        LOG.debug(\"self.ds_version: %s\" % self.ds_version.__dict__)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_b1a580b6","line":861,"in_reply_to":"baada198_2b55b8c1","updated":"2014-07-21 19:22:22.000000000","message":"Done","commit_id":"54ae6f9b60404cd3ff25eb79db61cd3fef776903"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"db08dea03a3f7abc6b27c9a84c81bca4134227b4","unresolved":false,"context_lines":[{"line_number":937,"context_line":"        self.update_overrides(overrides, remove\u003dTrue)"},{"line_number":938,"context_line":"        self.update_db(configuration_id\u003dNone)"},{"line_number":939,"context_line":""},{"line_number":940,"context_line":"        LOG.info(_(\"Removed configuration group %(config_id)s from \""},{"line_number":941,"context_line":"                 \"instance %(instance_id)s successfully.\")"},{"line_number":942,"context_line":"                 % {\u0027config_id\u0027: configuration_id,"},{"line_number":943,"context_line":"                    \u0027instance_id\u0027: self.id})"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_4bdf4c3a","line":940,"updated":"2014-07-18 22:02:02.000000000","message":"again, you can\u0027t know if removing procedure finished successfuly, at this stage instance is in RESTART REQUIRED state, only after restart you can know for sure this everything is ok","commit_id":"54ae6f9b60404cd3ff25eb79db61cd3fef776903"},{"author":{"_account_id":10266,"name":"Simon Chang","email":"schang@tesora.com","username":"changsimon"},"change_message_id":"0c6b568e4b8e8e81e6175e414d5cb79af68ff4fd","unresolved":false,"context_lines":[{"line_number":937,"context_line":"        self.update_overrides(overrides, remove\u003dTrue)"},{"line_number":938,"context_line":"        self.update_db(configuration_id\u003dNone)"},{"line_number":939,"context_line":""},{"line_number":940,"context_line":"        LOG.info(_(\"Removed configuration group %(config_id)s from \""},{"line_number":941,"context_line":"                 \"instance %(instance_id)s successfully.\")"},{"line_number":942,"context_line":"                 % {\u0027config_id\u0027: configuration_id,"},{"line_number":943,"context_line":"                    \u0027instance_id\u0027: self.id})"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_11962c4c","line":940,"in_reply_to":"baada198_4bdf4c3a","updated":"2014-07-21 19:22:22.000000000","message":"Done","commit_id":"54ae6f9b60404cd3ff25eb79db61cd3fef776903"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"0e242c192216afd3b681bf0fbed13f46a6287516","unresolved":false,"context_lines":[{"line_number":425,"context_line":"                    sleep_time\u003dUSAGE_SLEEP_TIME,"},{"line_number":426,"context_line":"                    time_out\u003dHEAT_TIME_OUT)"},{"line_number":427,"context_line":"            except PollTimeOut:"},{"line_number":428,"context_line":"                raise TroveError(\"Failed to obtain Heat stack status. \""},{"line_number":429,"context_line":"                                 \"Timeout occurred.\")"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"            stack \u003d client.stacks.get(stack_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_4ee60c4c","line":428,"updated":"2014-07-22 12:15:33.000000000","message":"I still stand on removing project name. Everybody knows that _only_ heat can deliver stacks. Fix it all over _create_server_volume_heat method.","commit_id":"addbe5748bcd44817a0970e90cff31de3f59a24c"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"826ef2ed0373b2dc498ca10885450f9e1d1e0e1a","unresolved":false,"context_lines":[{"line_number":425,"context_line":"                    sleep_time\u003dUSAGE_SLEEP_TIME,"},{"line_number":426,"context_line":"                    time_out\u003dHEAT_TIME_OUT)"},{"line_number":427,"context_line":"            except PollTimeOut:"},{"line_number":428,"context_line":"                raise TroveError(\"Failed to obtain Heat stack status. \""},{"line_number":429,"context_line":"                                 \"Timeout occurred.\")"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"            stack \u003d client.stacks.get(stack_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_c9fcbd0f","line":428,"in_reply_to":"baada198_4ee60c4c","updated":"2014-07-22 19:12:17.000000000","message":"I wouldn\u0027t bet that all operators know that only heat can deliver stacks.  It\u0027s probably better to be explicit in this case.","commit_id":"addbe5748bcd44817a0970e90cff31de3f59a24c"},{"author":{"_account_id":10266,"name":"Simon Chang","email":"schang@tesora.com","username":"changsimon"},"change_message_id":"8cf9f4eedabd0b2c1ac493bf49336858cf963c23","unresolved":false,"context_lines":[{"line_number":425,"context_line":"                    sleep_time\u003dUSAGE_SLEEP_TIME,"},{"line_number":426,"context_line":"                    time_out\u003dHEAT_TIME_OUT)"},{"line_number":427,"context_line":"            except PollTimeOut:"},{"line_number":428,"context_line":"                raise TroveError(\"Failed to obtain Heat stack status. \""},{"line_number":429,"context_line":"                                 \"Timeout occurred.\")"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"            stack \u003d client.stacks.get(stack_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_65482d5d","line":428,"in_reply_to":"baada198_c9fcbd0f","updated":"2014-07-22 21:22:46.000000000","message":"I agree, developers may know \"stack\" is related to Heat, but operators may not know. Therefore this exception message needs to be explicit. I\u0027m keeping this change as is.","commit_id":"addbe5748bcd44817a0970e90cff31de3f59a24c"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"0e242c192216afd3b681bf0fbed13f46a6287516","unresolved":false,"context_lines":[{"line_number":495,"context_line":"            # Save server ID."},{"line_number":496,"context_line":"            self.update_db(compute_instance_id\u003dserver_id)"},{"line_number":497,"context_line":"        except Exception as e:"},{"line_number":498,"context_line":"            msg \u003d _(\"Failed to create volume for instance %s\") % self.id"},{"line_number":499,"context_line":"            err \u003d inst_models.InstanceTasks.BUILDING_ERROR_SERVER"},{"line_number":500,"context_line":"            self._log_and_raise(e, msg, err)"},{"line_number":501,"context_line":"        LOG.debug(\"End _create_server_volume_individually for id: %s\" %"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_aecc08bd","line":498,"updated":"2014-07-22 12:15:33.000000000","message":"msg \u003d _(\"Failed to create server for instance %s\") % self.id","commit_id":"addbe5748bcd44817a0970e90cff31de3f59a24c"},{"author":{"_account_id":10266,"name":"Simon Chang","email":"schang@tesora.com","username":"changsimon"},"change_message_id":"8cf9f4eedabd0b2c1ac493bf49336858cf963c23","unresolved":false,"context_lines":[{"line_number":495,"context_line":"            # Save server ID."},{"line_number":496,"context_line":"            self.update_db(compute_instance_id\u003dserver_id)"},{"line_number":497,"context_line":"        except Exception as e:"},{"line_number":498,"context_line":"            msg \u003d _(\"Failed to create volume for instance %s\") % self.id"},{"line_number":499,"context_line":"            err \u003d inst_models.InstanceTasks.BUILDING_ERROR_SERVER"},{"line_number":500,"context_line":"            self._log_and_raise(e, msg, err)"},{"line_number":501,"context_line":"        LOG.debug(\"End _create_server_volume_individually for id: %s\" %"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_2f3c5630","line":498,"in_reply_to":"baada198_693bb1c8","updated":"2014-07-22 21:22:46.000000000","message":"Done","commit_id":"addbe5748bcd44817a0970e90cff31de3f59a24c"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"826ef2ed0373b2dc498ca10885450f9e1d1e0e1a","unresolved":false,"context_lines":[{"line_number":495,"context_line":"            # Save server ID."},{"line_number":496,"context_line":"            self.update_db(compute_instance_id\u003dserver_id)"},{"line_number":497,"context_line":"        except Exception as e:"},{"line_number":498,"context_line":"            msg \u003d _(\"Failed to create volume for instance %s\") % self.id"},{"line_number":499,"context_line":"            err \u003d inst_models.InstanceTasks.BUILDING_ERROR_SERVER"},{"line_number":500,"context_line":"            self._log_and_raise(e, msg, err)"},{"line_number":501,"context_line":"        LOG.debug(\"End _create_server_volume_individually for id: %s\" %"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_693bb1c8","line":498,"in_reply_to":"baada198_aecc08bd","updated":"2014-07-22 19:12:17.000000000","message":"I agree, it should say server not volume.","commit_id":"addbe5748bcd44817a0970e90cff31de3f59a24c"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"826ef2ed0373b2dc498ca10885450f9e1d1e0e1a","unresolved":false,"context_lines":[{"line_number":806,"context_line":"        LOG.info(_(\"Initiating migration to host %s.\") % host)"},{"line_number":807,"context_line":"        action \u003d MigrateAction(self, host)"},{"line_number":808,"context_line":"        action.execute()"},{"line_number":809,"context_line":"        LOG.info(_(\"Initiated migration to host %s.\") % host)"},{"line_number":810,"context_line":""},{"line_number":811,"context_line":"    def create_backup(self, backup_info):"},{"line_number":812,"context_line":"        LOG.info(_(\"Initiating backup for instance %s.\") % self.id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_093f9588","line":809,"updated":"2014-07-22 19:12:17.000000000","message":"Is this an async call?  If so, you probably don\u0027t need another message.  If not, the message should probably be:\n\n  LOG.info(_(\"Migration to host %s completed.\") % host)","commit_id":"addbe5748bcd44817a0970e90cff31de3f59a24c"},{"author":{"_account_id":10266,"name":"Simon Chang","email":"schang@tesora.com","username":"changsimon"},"change_message_id":"8cf9f4eedabd0b2c1ac493bf49336858cf963c23","unresolved":false,"context_lines":[{"line_number":806,"context_line":"        LOG.info(_(\"Initiating migration to host %s.\") % host)"},{"line_number":807,"context_line":"        action \u003d MigrateAction(self, host)"},{"line_number":808,"context_line":"        action.execute()"},{"line_number":809,"context_line":"        LOG.info(_(\"Initiated migration to host %s.\") % host)"},{"line_number":810,"context_line":""},{"line_number":811,"context_line":"    def create_backup(self, backup_info):"},{"line_number":812,"context_line":"        LOG.info(_(\"Initiating backup for instance %s.\") % self.id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_2f51b663","line":809,"in_reply_to":"baada198_093f9588","updated":"2014-07-22 21:22:46.000000000","message":"It is async, I\u0027ve removed the second \"initiated\" message in the new commit.","commit_id":"addbe5748bcd44817a0970e90cff31de3f59a24c"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"826ef2ed0373b2dc498ca10885450f9e1d1e0e1a","unresolved":false,"context_lines":[{"line_number":811,"context_line":"    def create_backup(self, backup_info):"},{"line_number":812,"context_line":"        LOG.info(_(\"Initiating backup for instance %s.\") % self.id)"},{"line_number":813,"context_line":"        self.guest.create_backup(backup_info)"},{"line_number":814,"context_line":"        LOG.info(_(\"Initiated backup for instance %s.\") % self.id)"},{"line_number":815,"context_line":""},{"line_number":816,"context_line":"    def reboot(self):"},{"line_number":817,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_2944591a","line":814,"updated":"2014-07-22 19:12:17.000000000","message":"ditto - \"Backup for instance %s completed\"\n\nThere are a few other cases as well","commit_id":"addbe5748bcd44817a0970e90cff31de3f59a24c"},{"author":{"_account_id":10266,"name":"Simon Chang","email":"schang@tesora.com","username":"changsimon"},"change_message_id":"8cf9f4eedabd0b2c1ac493bf49336858cf963c23","unresolved":false,"context_lines":[{"line_number":811,"context_line":"    def create_backup(self, backup_info):"},{"line_number":812,"context_line":"        LOG.info(_(\"Initiating backup for instance %s.\") % self.id)"},{"line_number":813,"context_line":"        self.guest.create_backup(backup_info)"},{"line_number":814,"context_line":"        LOG.info(_(\"Initiated backup for instance %s.\") % self.id)"},{"line_number":815,"context_line":""},{"line_number":816,"context_line":"    def reboot(self):"},{"line_number":817,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_8f4802b5","line":814,"in_reply_to":"baada198_2944591a","updated":"2014-07-22 21:22:46.000000000","message":"It is async, I\u0027ve removed the second \"initiated\" message in the new commit.","commit_id":"addbe5748bcd44817a0970e90cff31de3f59a24c"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"826ef2ed0373b2dc498ca10885450f9e1d1e0e1a","unresolved":false,"context_lines":[{"line_number":840,"context_line":"            LOG.error(_(\"Failed to reboot instance %(id)s: %(e)s\") %"},{"line_number":841,"context_line":"                      {\u0027id\u0027: self.id, \u0027e\u0027: str(e)})"},{"line_number":842,"context_line":"        finally:"},{"line_number":843,"context_line":"            LOG.debug(\"Rebooting FINALLY  %s\" % self.id)"},{"line_number":844,"context_line":"            self.reset_task_status()"},{"line_number":845,"context_line":""},{"line_number":846,"context_line":"    def restart(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_295b79f7","line":843,"range":{"start_line":843,"start_character":40,"end_line":843,"end_character":42},"updated":"2014-07-22 19:12:17.000000000","message":"Nit: There shouldn\u0027t be two spaces after FINALLY","commit_id":"addbe5748bcd44817a0970e90cff31de3f59a24c"},{"author":{"_account_id":10266,"name":"Simon Chang","email":"schang@tesora.com","username":"changsimon"},"change_message_id":"8cf9f4eedabd0b2c1ac493bf49336858cf963c23","unresolved":false,"context_lines":[{"line_number":840,"context_line":"            LOG.error(_(\"Failed to reboot instance %(id)s: %(e)s\") %"},{"line_number":841,"context_line":"                      {\u0027id\u0027: self.id, \u0027e\u0027: str(e)})"},{"line_number":842,"context_line":"        finally:"},{"line_number":843,"context_line":"            LOG.debug(\"Rebooting FINALLY  %s\" % self.id)"},{"line_number":844,"context_line":"            self.reset_task_status()"},{"line_number":845,"context_line":""},{"line_number":846,"context_line":"    def restart(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_afc4e60e","line":843,"range":{"start_line":843,"start_character":40,"end_line":843,"end_character":42},"in_reply_to":"baada198_295b79f7","updated":"2014-07-22 21:22:46.000000000","message":"Done","commit_id":"addbe5748bcd44817a0970e90cff31de3f59a24c"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"826ef2ed0373b2dc498ca10885450f9e1d1e0e1a","unresolved":false,"context_lines":[{"line_number":891,"context_line":""},{"line_number":892,"context_line":"        def _find_item(items, item_name):"},{"line_number":893,"context_line":"            LOG.debug(\"items: %s\" % items)"},{"line_number":894,"context_line":"            LOG.debug(\"item_name: %s\" % item_name)"},{"line_number":895,"context_line":"            # find the item in the list"},{"line_number":896,"context_line":"            for i in items:"},{"line_number":897,"context_line":"                if i[0] \u003d\u003d item_name:"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_9bda081c","line":894,"updated":"2014-07-22 19:12:17.000000000","message":"How about:\n\n  LOG.debug(\"Searching for %s in: %s\" % (item_name, items))","commit_id":"addbe5748bcd44817a0970e90cff31de3f59a24c"},{"author":{"_account_id":10266,"name":"Simon Chang","email":"schang@tesora.com","username":"changsimon"},"change_message_id":"8cf9f4eedabd0b2c1ac493bf49336858cf963c23","unresolved":false,"context_lines":[{"line_number":891,"context_line":""},{"line_number":892,"context_line":"        def _find_item(items, item_name):"},{"line_number":893,"context_line":"            LOG.debug(\"items: %s\" % items)"},{"line_number":894,"context_line":"            LOG.debug(\"item_name: %s\" % item_name)"},{"line_number":895,"context_line":"            # find the item in the list"},{"line_number":896,"context_line":"            for i in items:"},{"line_number":897,"context_line":"                if i[0] \u003d\u003d item_name:"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_4a6258da","line":894,"in_reply_to":"baada198_9bda081c","updated":"2014-07-22 21:22:46.000000000","message":"Done","commit_id":"addbe5748bcd44817a0970e90cff31de3f59a24c"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"753a7a05ea63a72c3e4f281ac4de2e069e0e6a9c","unresolved":false,"context_lines":[{"line_number":425,"context_line":"                    sleep_time\u003dUSAGE_SLEEP_TIME,"},{"line_number":426,"context_line":"                    time_out\u003dHEAT_TIME_OUT)"},{"line_number":427,"context_line":"            except PollTimeOut:"},{"line_number":428,"context_line":"                raise TroveError(\"Failed to obtain Heat stack status. \""},{"line_number":429,"context_line":"                                 \"Timeout occurred.\")"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"            stack \u003d client.stacks.get(stack_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_68f43355","line":428,"updated":"2014-07-24 14:15:41.000000000","message":"Same, again, please remove \"Heat\" from message at all places","commit_id":"ba004c0aa1548fcf12b2228fb221d2d2aaff22bd"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"d517967ab81242945dcf579f2e004cfc20d3e29b","unresolved":false,"context_lines":[{"line_number":425,"context_line":"                    sleep_time\u003dUSAGE_SLEEP_TIME,"},{"line_number":426,"context_line":"                    time_out\u003dHEAT_TIME_OUT)"},{"line_number":427,"context_line":"            except PollTimeOut:"},{"line_number":428,"context_line":"                raise TroveError(\"Failed to obtain Heat stack status. \""},{"line_number":429,"context_line":"                                 \"Timeout occurred.\")"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"            stack \u003d client.stacks.get(stack_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_52ff4a00","line":428,"in_reply_to":"baada198_68f43355","updated":"2014-07-30 18:27:46.000000000","message":"Why is this a requirement? If you look at the previous logs, this already exists (eg. L406 LOG.error(_(\"heat template ascii encode issue\")))","commit_id":"ba004c0aa1548fcf12b2228fb221d2d2aaff22bd"}]}