)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"8288f1eb2ec1efaffd829c4382b53793c1bb6e3f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Denis Makogon \u003cdmakogon@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-07-21 17:20:30 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add instance ID validation stage"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Reasons:"},{"line_number":10,"context_line":" - user is able to create incremental backup"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"baada198_4278dc2a","line":7,"updated":"2014-07-21 16:17:35.000000000","message":"Please improve summary; add validation stage to what?","commit_id":"d401acb2963c00a086762cfde74de4a896378366"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"2cbdf94747426f08c1ec9fecca620ee9c1da7864","unresolved":false,"context_lines":[{"line_number":20,"context_line":"   parent from different instance server side"},{"line_number":21,"context_line":"   will raise ParentBackupIDMismatch exception;"},{"line_number":22,"context_line":" - from user perspective exception will be interpreted"},{"line_number":23,"context_line":"   as HTTP Forbidden(403) according to RFC 2616 -- Trove server site"},{"line_number":24,"context_line":"   understood the request, but is refusing to fulfill"},{"line_number":25,"context_line":"   it due to IDs mismatch."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"baada198_df7d9ae8","line":23,"updated":"2014-07-22 00:39:15.000000000","message":"I agree!\n\nThat\u0027s what I suggested in https://review.openstack.org/#/c/106050/10/ ;)","commit_id":"f9f0735e2bab9bb13951a4d6d3da6c184a45c807"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"6419beb8fe662a4905067d78efa6d93f2b2e7ce1","unresolved":false,"context_lines":[{"line_number":16,"context_line":" - unit/int tests proposed."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Behaviour:"},{"line_number":19,"context_line":" - when when attempting to create incremental backup by using"},{"line_number":20,"context_line":"   parent from different instance server side"},{"line_number":21,"context_line":"   will raise ParentBackupIDMismatch exception;"},{"line_number":22,"context_line":" - from user perspective exception will be interpreted"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"fa98f980_5b03dab7","line":19,"updated":"2014-09-10 20:04:00.000000000","message":"when","commit_id":"438dc351e786bb21021af0ab7a4b7c4e83559c37"}],"trove/backup/models.py":[{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"ba8fb697f67d016648982fd311d1a19b838d3eb4","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            # taken from the same instance as parent"},{"line_number":110,"context_line":"            if _parent and instance_id !\u003d _parent.instance_id:"},{"line_number":111,"context_line":"                raise exception.ParentBackupInstanceIDMismatchError("},{"line_number":112,"context_line":"                    expected\u003dinstance_id, actual\u003d_parent.instance_id)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"            # verify that the instance exists and can perform actions"},{"line_number":115,"context_line":"            from trove.instance.models import Instance"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa98f980_4850715e","line":112,"updated":"2014-09-02 21:26:00.000000000","message":"Based on this exception, you have the two arguments backward. \u0027expected\u0027 should be the _parent.instance_id and \u0027actual\u0027 should be instance_id","commit_id":"69c09701bdf911ae69831cdb0846065cdef18949"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"6419beb8fe662a4905067d78efa6d93f2b2e7ce1","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        \"\"\""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        def _create_resources():"},{"line_number":88,"context_line":"            _parent, parent \u003d None, None"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"            # parse the ID from the Ref"},{"line_number":91,"context_line":"            instance_id \u003d utils.get_id_from_href(instance)"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa98f980_3bfd363c","line":88,"updated":"2014-09-10 20:04:00.000000000","message":"it is unclear to me why we need parent and _parent. can\u0027t we just store parent.[\u0027instance_id\u0027]?","commit_id":"438dc351e786bb21021af0ab7a4b7c4e83559c37"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"6419beb8fe662a4905067d78efa6d93f2b2e7ce1","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                    \u0027checksum\u0027: _parent.checksum,"},{"line_number":112,"context_line":"                }"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"            # Verify that incremental backup is going to be"},{"line_number":115,"context_line":"            # taken from the same instance as parent"},{"line_number":116,"context_line":"            if _parent and instance_id !\u003d _parent.instance_id:"},{"line_number":117,"context_line":"                raise exception.ParentBackupInstanceIDMismatchError("}],"source_content_type":"text/x-python","patch_set":17,"id":"fa98f980_5be59aa6","line":114,"updated":"2014-09-10 20:04:00.000000000","message":"This code would (IMHO) be easier to understand if it was indented over and the if just had\n\n\nif instance_id !\u003d _parent_backup.instance_id","commit_id":"438dc351e786bb21021af0ab7a4b7c4e83559c37"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dbdd9d9d24de0b0e99e0ebbd25dd1e7428661e3b","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                    \u0027checksum\u0027: _parent.checksum,"},{"line_number":112,"context_line":"                }"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"            # Verify that incremental backup is going to be"},{"line_number":115,"context_line":"            # taken from the same instance as parent"},{"line_number":116,"context_line":"            if _parent and instance_id !\u003d _parent.instance_id:"},{"line_number":117,"context_line":"                raise exception.ParentBackupInstanceIDMismatchError("}],"source_content_type":"text/x-python","patch_set":17,"id":"fa98f980_d1f51bee","line":114,"in_reply_to":"fa98f980_5be59aa6","updated":"2014-09-18 14:03:03.000000000","message":"Done","commit_id":"438dc351e786bb21021af0ab7a4b7c4e83559c37"}],"trove/common/exception.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"8288f1eb2ec1efaffd829c4382b53793c1bb6e3f","unresolved":false,"context_lines":[{"line_number":372,"context_line":""},{"line_number":373,"context_line":"class ParentBackupInstanceIDMismatchError(TroveError):"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"    message \u003d _(\"Parent backup instance ID mismatch.\""},{"line_number":376,"context_line":"                \" Expected: %(expected)s. Actual: %(actual)s.\")"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_e28010c1","line":375,"updated":"2014-07-21 16:17:35.000000000","message":"Please change wording to \n\nParent backup instance ID %(expected)s does not match this instance %(actual)s","commit_id":"d401acb2963c00a086762cfde74de4a896378366"}],"trove/common/wsgi.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"8288f1eb2ec1efaffd829c4382b53793c1bb6e3f","unresolved":false,"context_lines":[{"line_number":339,"context_line":"            exception.BackupNotCompleteError,"},{"line_number":340,"context_line":"            exception.RestoreBackupIntegrityError,"},{"line_number":341,"context_line":"            exception.ParentBackupFailedError,"},{"line_number":342,"context_line":"            exception.ParentBackupInstanceIDMismatchError,"},{"line_number":343,"context_line":"        ],"},{"line_number":344,"context_line":"        webob.exc.HTTPRequestEntityTooLarge: ["},{"line_number":345,"context_line":"            exception.OverLimit,"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_c2cb0c1c","line":342,"updated":"2014-07-21 16:17:35.000000000","message":"Shouldn\u0027t this be a HTTPBadRequest ?","commit_id":"d401acb2963c00a086762cfde74de4a896378366"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"dbfa3b75a07adc20057a990d425ff338637e815c","unresolved":false,"context_lines":[{"line_number":339,"context_line":"            exception.BackupNotCompleteError,"},{"line_number":340,"context_line":"            exception.RestoreBackupIntegrityError,"},{"line_number":341,"context_line":"            exception.ParentBackupFailedError,"},{"line_number":342,"context_line":"            exception.ParentBackupInstanceIDMismatchError,"},{"line_number":343,"context_line":"        ],"},{"line_number":344,"context_line":"        webob.exc.HTTPRequestEntityTooLarge: ["},{"line_number":345,"context_line":"            exception.OverLimit,"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_683141ec","line":342,"updated":"2014-07-21 16:42:08.000000000","message":"Probably could be \n\n403 Forbidden\n\nThe server understood the request, but is refusing to fulfill it. Authorization will not help and the request SHOULD NOT be repeated. If the request method was not HEAD and the server wishes to make public why the request has not been fulfilled, it SHOULD describe the reason for the refusal in the entity. If the server does not wish to make this information available to the client, the status code 404 (Not Found) can be used instead.","commit_id":"97dce6a5f7168ddc298fd57f359704dd089ce2ec"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"0000350570894ec771551933d2986db779d9ab85","unresolved":false,"context_lines":[{"line_number":339,"context_line":"            exception.BackupNotCompleteError,"},{"line_number":340,"context_line":"            exception.RestoreBackupIntegrityError,"},{"line_number":341,"context_line":"            exception.ParentBackupFailedError,"},{"line_number":342,"context_line":"            exception.ParentBackupInstanceIDMismatchError,"},{"line_number":343,"context_line":"        ],"},{"line_number":344,"context_line":"        webob.exc.HTTPRequestEntityTooLarge: ["},{"line_number":345,"context_line":"            exception.OverLimit,"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_a1d44047","line":342,"in_reply_to":"baada198_683141ec","updated":"2014-07-22 00:37:50.000000000","message":"I agree, that\u0027s what I suggested in https://review.openstack.org/#/c/106050/10/","commit_id":"97dce6a5f7168ddc298fd57f359704dd089ce2ec"}]}