)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"b978418ee6d83444f95a392e52bb1590c1dd5637","unresolved":false,"context_lines":[{"line_number":9,"context_line":"SUSE uses /etc/my.cnf instead of /etc/mysql/my.cnf. This patch changes"},{"line_number":10,"context_line":"MYSQL_CONFIG from string to a dictionary using the operative system"},{"line_number":11,"context_line":"name as key to identify where mysql\u0027s configuration is located."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Co-Authored-By: Ionut Artarisi \u003ciartarisi@suse.cz\u003e"},{"line_number":14,"context_line":"Change-Id: Ibb17fa584ae3bc632e970f0a3dd99af2ac51b441"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa98f980_8af36309","line":12,"updated":"2014-09-09 08:37:47.000000000","message":"Now that we have a bp for this, can we add that to the commit message, please? Thanks","commit_id":"1313df908e68706bd7d0440f48c156d51d3ad326"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"33959ac285bcf9dea148742f8d42b4d698b7572e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add SUSE support in mysql datastore"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"SUSE uses /etc/my.cnf instead of /etc/mysql/my.cnf. This patch changes"},{"line_number":10,"context_line":"MYSQL_CONFIG from string to a dictionary using the operative system"},{"line_number":11,"context_line":"name as key to identify where mysql\u0027s configuration is located."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa98f980_dddecc10","line":9,"updated":"2014-09-11 11:13:54.000000000","message":"it\u0027s abit incorrect, should be:\n\n MySQL deployed over SUSE platform uses /etc/my.cnf instead of /etc/mysql/my.cnf","commit_id":"6f89c962ce3995b6253ba63356aad42093151920"}],"trove/guestagent/datastore/mysql/service.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"888cbf1400bb7c2871db201032745016a269ad75","unresolved":false,"context_lines":[{"line_number":57,"context_line":"OS_NAME \u003d operating_system.get_os()"},{"line_number":58,"context_line":"MYSQL_CONFIG \u003d {operating_system.REDHAT: \"/etc/mysql/my.cnf\","},{"line_number":59,"context_line":"                operating_system.DEBIAN: \"/etc/mysql/my.cnf\","},{"line_number":60,"context_line":"                operating_system.SUSE: \"/etc/my.cnf\"}[OS_NAME]"},{"line_number":61,"context_line":"MYSQL_SERVICE_CANDIDATES \u003d [\"mysql\", \"mysqld\", \"mysql-server\"]"},{"line_number":62,"context_line":"MYSQL_BIN_CANDIDATES \u003d [\"/usr/sbin/mysqld\", \"/usr/libexec/mysqld\"]"},{"line_number":63,"context_line":"MYCNF_OVERRIDES \u003d \"/etc/mysql/conf.d/overrides.cnf\""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_d9f7078b","line":60,"updated":"2014-09-09 11:58:37.000000000","message":"if SUSE is the only with with a different location, this form of code will require an update for each new os.\n\nwhy not make it an ...\n\nMYSQL_CONFIG_SUSE \u003d \u0027/etc/my.cnf\u0027\nMYSQL_CONFIG_DEFAULT \u003d \u0027/etc/mysql/my.cnf\u0027\nMYSQL_CONFIG \u003d MYSQL_CONFIG_SUSE if OS_NAME \u003d operating_system.SUSE else MYSQL_CONFIG_DEFAULT\n\nor some such thing that won\u0027t require an update each time.\n\non the other hand, if we feel that this will have to be updated more often anyway, maybe a different approach is required similar to cfg.py","commit_id":"1313df908e68706bd7d0440f48c156d51d3ad326"},{"author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"change_message_id":"0c5ea516619b381c7d63d2549882e27a935a5ce8","unresolved":false,"context_lines":[{"line_number":57,"context_line":"OS_NAME \u003d operating_system.get_os()"},{"line_number":58,"context_line":"MYSQL_CONFIG \u003d {operating_system.REDHAT: \"/etc/mysql/my.cnf\","},{"line_number":59,"context_line":"                operating_system.DEBIAN: \"/etc/mysql/my.cnf\","},{"line_number":60,"context_line":"                operating_system.SUSE: \"/etc/my.cnf\"}[OS_NAME]"},{"line_number":61,"context_line":"MYSQL_SERVICE_CANDIDATES \u003d [\"mysql\", \"mysqld\", \"mysql-server\"]"},{"line_number":62,"context_line":"MYSQL_BIN_CANDIDATES \u003d [\"/usr/sbin/mysqld\", \"/usr/libexec/mysqld\"]"},{"line_number":63,"context_line":"MYCNF_OVERRIDES \u003d \"/etc/mysql/conf.d/overrides.cnf\""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_8c0098ac","line":60,"in_reply_to":"fa98f980_d9f7078b","updated":"2014-09-11 08:56:51.000000000","message":"I feel the code is much cleaner and more readable this way than with two additional \"constants\". While I do not think this code will be updated often, I think it\u0027s also hard to foresee whether the next OS which will be added will be using the \"default\" path or a new one.","commit_id":"1313df908e68706bd7d0440f48c156d51d3ad326"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"33959ac285bcf9dea148742f8d42b4d698b7572e","unresolved":false,"context_lines":[{"line_number":60,"context_line":"}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"OS_NAME \u003d operating_system.get_os()"},{"line_number":63,"context_line":"MYSQL_CONFIG \u003d {operating_system.REDHAT: \"/etc/mysql/my.cnf\","},{"line_number":64,"context_line":"                operating_system.DEBIAN: \"/etc/mysql/my.cnf\","},{"line_number":65,"context_line":"                operating_system.SUSE: \"/etc/my.cnf\"}[OS_NAME]"},{"line_number":66,"context_line":"MYSQL_SERVICE_CANDIDATES \u003d [\"mysql\", \"mysqld\", \"mysql-server\"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_5dd2dc00","line":63,"updated":"2014-09-11 11:13:54.000000000","message":"in general it looks good, but, i\u0027d suggest to move this peace of code into PackageMixin meta class, where guest tries to identify platform.\n\nand we don\u0027t need a dict, once we know which platform is used we need just patch(re-initialize) MYSQL_CONFIG, no need to involve dict operations.","commit_id":"6f89c962ce3995b6253ba63356aad42093151920"},{"author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"change_message_id":"f3bcd8eec674594681a599c8c1211a6174d7eac0","unresolved":false,"context_lines":[{"line_number":60,"context_line":"}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"OS_NAME \u003d operating_system.get_os()"},{"line_number":63,"context_line":"MYSQL_CONFIG \u003d {operating_system.REDHAT: \"/etc/mysql/my.cnf\","},{"line_number":64,"context_line":"                operating_system.DEBIAN: \"/etc/mysql/my.cnf\","},{"line_number":65,"context_line":"                operating_system.SUSE: \"/etc/my.cnf\"}[OS_NAME]"},{"line_number":66,"context_line":"MYSQL_SERVICE_CANDIDATES \u003d [\"mysql\", \"mysqld\", \"mysql-server\"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_3d70b8db","line":63,"in_reply_to":"fa98f980_5dd2dc00","updated":"2014-09-11 11:22:09.000000000","message":"Denis, I don\u0027t understand what you mean with moving MYSQL_CONFIG to the PackageMixin class. This constant is used here, for example in get_auth_password and in MysqlApp. \n\nAnd I think you\u0027re just nit-picking with the dict.","commit_id":"6f89c962ce3995b6253ba63356aad42093151920"}]}