)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"cbfdf42a45a49f530f7542aa1cd951efa0c1eff1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sree Harsha Chivukula \u003cschivuk@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-08-01 14:36:10 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix to check if device_path set to empty string"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I82664305fe12efc5db4eefcb20dfd4d905c47ff7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baada198_e3ffcb67","line":7,"updated":"2014-08-06 15:13:52.000000000","message":"You should put the info you typed in the comment into the commit message as well.  See https://wiki.openstack.org/wiki/GitCommitMessages for some examples.","commit_id":"1e182413b6783a30fdd31d56ece26273c9b36c0f"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"9be6c1738b5e9a70957ed462358817baf672cd0a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sree Harsha Chivukula \u003cschivuk@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-08-01 14:36:10 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix to check if device_path set to empty string"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I82664305fe12efc5db4eefcb20dfd4d905c47ff7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa98f980_59a237af","line":7,"in_reply_to":"baada198_e3ffcb67","updated":"2014-09-01 22:50:59.000000000","message":"And file a bug and associate this patch with a  bug","commit_id":"1e182413b6783a30fdd31d56ece26273c9b36c0f"}],"trove/instance/models.py":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"cbfdf42a45a49f530f7542aa1cd951efa0c1eff1","unresolved":false,"context_lines":[{"line_number":731,"context_line":"                raise exception.LocalStorageNotSupported()"},{"line_number":732,"context_line":"            if new_flavor_size \u003d\u003d old_flavor_size:"},{"line_number":733,"context_line":"                raise exception.CannotResizeToSameSize()"},{"line_number":734,"context_line":"        elif CONF.device_path is not None or CONF.device_path !\u003d \u0027\u0027:"},{"line_number":735,"context_line":"            # ephemeral support enabled"},{"line_number":736,"context_line":"            if new_flavor.ephemeral \u003d\u003d 0:"},{"line_number":737,"context_line":"                raise exception.LocalStorageNotSpecified(flavor\u003dnew_flavor_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_63901b50","line":734,"updated":"2014-08-06 15:13:52.000000000","message":"I believe you meant this to have an \u0027and\u0027 instead of \u0027or\u0027 (as the \u0027or\u0027 part would not be checked once device_path was not None). This can be shortened (and it will then resemble the \u0027if\u0027 above) to:\n\n  elif CONF.device_path:\n\nIt would also be great if you added a unit test to trap this issue.","commit_id":"1e182413b6783a30fdd31d56ece26273c9b36c0f"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"76fefbdef835ebf632a07f802d3b23b687ed007a","unresolved":false,"context_lines":[{"line_number":731,"context_line":"                raise exception.LocalStorageNotSupported()"},{"line_number":732,"context_line":"            if new_flavor_size \u003d\u003d old_flavor_size:"},{"line_number":733,"context_line":"                raise exception.CannotResizeToSameSize()"},{"line_number":734,"context_line":"        elif CONF.device_path is not None or CONF.device_path !\u003d \u0027\u0027:"},{"line_number":735,"context_line":"            # ephemeral support enabled"},{"line_number":736,"context_line":"            if new_flavor.ephemeral \u003d\u003d 0:"},{"line_number":737,"context_line":"                raise exception.LocalStorageNotSpecified(flavor\u003dnew_flavor_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_463452fb","line":734,"in_reply_to":"baada198_63901b50","updated":"2014-09-16 13:07:19.000000000","message":"I have better one:\n\n\n   elif CONF.devise_path not in [None, \u0027\u0027]:","commit_id":"1e182413b6783a30fdd31d56ece26273c9b36c0f"}]}