)]}'
{"trove/templates/default.heat.template":[{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"41c3bca585c8c4723a240af7b676411bce4708da","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            content:"},{"line_number":42,"context_line":"              str_replace:"},{"line_number":43,"context_line":"                template: |"},{"line_number":44,"context_line":"                  [DEFAULT] "},{"line_number":45,"context_line":"                  guest_id\u003d$GUEST"},{"line_number":46,"context_line":"                  datastore_manager\u003d$MANAGER"},{"line_number":47,"context_line":"                  tenant_id\u003d$TENANT"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"5a890539_90dda343","line":44,"updated":"2014-12-04 21:51:59.000000000","message":"Is this blank space ok?","commit_id":"1751210e61b33ed9506a2da76d869824dec1db62"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"c421f2bfc0de25cf67085c7d48cb3a2fd360e5f3","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            content:"},{"line_number":42,"context_line":"              str_replace:"},{"line_number":43,"context_line":"                template: |"},{"line_number":44,"context_line":"                  [DEFAULT] "},{"line_number":45,"context_line":"                  guest_id\u003d$GUEST"},{"line_number":46,"context_line":"                  datastore_manager\u003d$MANAGER"},{"line_number":47,"context_line":"                  tenant_id\u003d$TENANT"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1a930d6b_0f4a4980","line":44,"in_reply_to":"5a890539_90dda343","updated":"2015-01-21 16:00:13.000000000","message":"I\u0027d say it should be removed (even if heat ignores it, it\u0027s good to keep the templates clean)","commit_id":"1751210e61b33ed9506a2da76d869824dec1db62"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"4b1d67e7f0881c51bf66f4ce419aecd0db268171","unresolved":false,"context_lines":[{"line_number":96,"context_line":"{% endfor %}"},{"line_number":97,"context_line":"{% endif %}"},{"line_number":98,"context_line":"  DatabaseIPAddress:"},{"line_number":99,"context_line":"    type: AWS::EC2::EIP"},{"line_number":100,"context_line":"  DatabaseIPAssoc :"},{"line_number":101,"context_line":"    type: AWS::EC2::EIPAssociation"},{"line_number":102,"context_line":"    properties:"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"5a890539_b8b454f1","line":99,"updated":"2014-12-04 15:00:56.000000000","message":"what about floating IP resource ?","commit_id":"1751210e61b33ed9506a2da76d869824dec1db62"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"31bb831ff7cb7dab8333100c7001ece80711d196","unresolved":false,"context_lines":[{"line_number":96,"context_line":"{% endfor %}"},{"line_number":97,"context_line":"{% endif %}"},{"line_number":98,"context_line":"  DatabaseIPAddress:"},{"line_number":99,"context_line":"    type: AWS::EC2::EIP"},{"line_number":100,"context_line":"  DatabaseIPAssoc :"},{"line_number":101,"context_line":"    type: AWS::EC2::EIPAssociation"},{"line_number":102,"context_line":"    properties:"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"5a890539_369cf569","line":99,"in_reply_to":"5a890539_b8b454f1","updated":"2014-12-04 16:07:54.000000000","message":"In principle we could have some logic around, and use either OS::Nova::FloatingIP* or OS::Neutron:: ones depending on using neutron or not. Do we have some way of knowing it in the Jinja template (like can I write {% if ports %} so that non-empty ports list is an indicator of using Neutron or not)? That though would require some more information for Neutron case, at least the name/id of the public network to take IPs from. Also, the Neutron floating ips must be assoiciated with Port, so we should wisely choose which of the ports would that be (and actually pass them all to networks property of the instance to bind them).\n\nAlso, in Neutron case, the SecurityGroup must not be assigned not to the instance itself (now it is actually done twice), so the logic of deciding on network backend is actually needed in several places.\n\nIf implemented it would leave security group only, as there is no OS::Nova:: one.","commit_id":"1751210e61b33ed9506a2da76d869824dec1db62"}]}
