)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"6d7c35f810a449b225436eb8b8c5c0dfb5878863","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Amrith Kumar \u003camrith@tesora.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-09-23 15:45:33 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove unused entries in cfg.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"backup_namespace and restore_namespace are now referenced on a"},{"line_number":10,"context_line":"per-datastore basis. Having them in the common options is now no"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"da9df570_5d585532","line":7,"updated":"2014-09-23 20:00:10.000000000","message":"not to be pedantic, but you\u0027re using the word \"remove\" and \"deleted\" (see below) when you really mean \"deprecated\". when i saw the patch-set fly by, i was worried that they were actually deleted, because references in the code rely on them for fallback (ex: https://github.com/openstack/trove/blob/513ffdc0a571acddea9a0576f95f6afc37505909/trove/guestagent/backup/backupagent.py#L34-L39)\n\nwould you mind amending the language here? thanks!","commit_id":"434d10eb56c8fa80a611bd45eb9df9391f87fc77"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"aae0f13de19febf00a9c0518c899a5d205624950","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Amrith Kumar \u003camrith@tesora.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-09-23 15:45:33 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove unused entries in cfg.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"backup_namespace and restore_namespace are now referenced on a"},{"line_number":10,"context_line":"per-datastore basis. Having them in the common options is now no"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"da9df570_3d1631a8","line":7,"in_reply_to":"da9df570_5d585532","updated":"2014-09-23 20:16:34.000000000","message":"Not a problem. I checked the bug and it correctly specifies both options (delete or deprecate) so I don\u0027t have to update the bug. I\u0027m assuming that the only thing that needs updating is the commit message.","commit_id":"434d10eb56c8fa80a611bd45eb9df9391f87fc77"}],"trove/common/cfg.py":[{"author":{"_account_id":9749,"name":"Greg Lucas","email":"greg@glucas.net","username":"glucas"},"change_message_id":"35784514c23fb1c2abfa3effb53b8f101c533fee","unresolved":false,"context_lines":[{"line_number":173,"context_line":"    cfg.DictOpt(\u0027backup_runner_options\u0027, default\u003d{},"},{"line_number":174,"context_line":"                help\u003d\u0027Additional options to be passed to the backup runner.\u0027),"},{"line_number":175,"context_line":"    cfg.StrOpt(\u0027backup_strategy\u0027, default\u003d\u0027InnoBackupEx\u0027,"},{"line_number":176,"context_line":"               help\u003d\u0027Default strategy to perform backups.\u0027),"},{"line_number":177,"context_line":"    cfg.DictOpt(\u0027backup_incremental_strategy\u0027,"},{"line_number":178,"context_line":"                default\u003d{\u0027InnoBackupEx\u0027: \u0027InnoBackupExIncremental\u0027},"},{"line_number":179,"context_line":"                help\u003d\u0027Incremental Backup Runner based on the default\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_773795e4","line":176,"updated":"2014-08-08 20:44:22.000000000","message":"Actually there is more to clean up here:\n\n - backup_strategy has been moved to the datastores and should be removed from DEFAULT\n - backup_incremental_strategy seems datastore-specific so I assume it should be moved as well?","commit_id":"088fe8f6425471bc65fec80c7d56fd886e766f40"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"837aa9478b5cb9783040e55b015024f19f73343a","unresolved":false,"context_lines":[{"line_number":173,"context_line":"    cfg.DictOpt(\u0027backup_runner_options\u0027, default\u003d{},"},{"line_number":174,"context_line":"                help\u003d\u0027Additional options to be passed to the backup runner.\u0027),"},{"line_number":175,"context_line":"    cfg.StrOpt(\u0027backup_strategy\u0027, default\u003d\u0027InnoBackupEx\u0027,"},{"line_number":176,"context_line":"               help\u003d\u0027Default strategy to perform backups.\u0027),"},{"line_number":177,"context_line":"    cfg.DictOpt(\u0027backup_incremental_strategy\u0027,"},{"line_number":178,"context_line":"                default\u003d{\u0027InnoBackupEx\u0027: \u0027InnoBackupExIncremental\u0027},"},{"line_number":179,"context_line":"                help\u003d\u0027Incremental Backup Runner based on the default\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_76c4e20d","line":176,"in_reply_to":"baada198_70586989","updated":"2014-08-10 22:56:19.000000000","message":"I\u0027ll take it that you are OK not moving incremental backup in that case ;)","commit_id":"088fe8f6425471bc65fec80c7d56fd886e766f40"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"d0238e0ea341a8d73468984970ce67654b5415d2","unresolved":false,"context_lines":[{"line_number":173,"context_line":"    cfg.DictOpt(\u0027backup_runner_options\u0027, default\u003d{},"},{"line_number":174,"context_line":"                help\u003d\u0027Additional options to be passed to the backup runner.\u0027),"},{"line_number":175,"context_line":"    cfg.StrOpt(\u0027backup_strategy\u0027, default\u003d\u0027InnoBackupEx\u0027,"},{"line_number":176,"context_line":"               help\u003d\u0027Default strategy to perform backups.\u0027),"},{"line_number":177,"context_line":"    cfg.DictOpt(\u0027backup_incremental_strategy\u0027,"},{"line_number":178,"context_line":"                default\u003d{\u0027InnoBackupEx\u0027: \u0027InnoBackupExIncremental\u0027},"},{"line_number":179,"context_line":"                help\u003d\u0027Incremental Backup Runner based on the default\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_daf24868","line":176,"in_reply_to":"baada198_773795e4","updated":"2014-08-08 21:25:52.000000000","message":"Disagree about incremetal strategy, for now it exists as common parameter, and it\u0027s not so big improvement to create datastore specific option of it.","commit_id":"088fe8f6425471bc65fec80c7d56fd886e766f40"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"7b94df991e0ffcc11caa3de4380d585ad90efd4b","unresolved":false,"context_lines":[{"line_number":173,"context_line":"    cfg.DictOpt(\u0027backup_runner_options\u0027, default\u003d{},"},{"line_number":174,"context_line":"                help\u003d\u0027Additional options to be passed to the backup runner.\u0027),"},{"line_number":175,"context_line":"    cfg.StrOpt(\u0027backup_strategy\u0027, default\u003d\u0027InnoBackupEx\u0027,"},{"line_number":176,"context_line":"               help\u003d\u0027Default strategy to perform backups.\u0027),"},{"line_number":177,"context_line":"    cfg.DictOpt(\u0027backup_incremental_strategy\u0027,"},{"line_number":178,"context_line":"                default\u003d{\u0027InnoBackupEx\u0027: \u0027InnoBackupExIncremental\u0027},"},{"line_number":179,"context_line":"                help\u003d\u0027Incremental Backup Runner based on the default\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_ab61bed5","line":176,"in_reply_to":"baada198_773795e4","updated":"2014-08-09 20:06:19.000000000","message":"There are many other things in the area of config that need cleaning up as you point out, but I\u0027d like to deal with backup_namespace and restore_namespace as part of this change.\n\nbackup_incremental_strategy is still referenced as a DEFAULT option in code so short of going and cleaning that up as well, there\u0027s no way to move it from here.\n\nWhat you are raising is the fact that there was a time when there was only one data store. And when there were two, we didn\u0027t quick decide what was datastore specific and what was going to remain common.","commit_id":"088fe8f6425471bc65fec80c7d56fd886e766f40"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"837aa9478b5cb9783040e55b015024f19f73343a","unresolved":false,"context_lines":[{"line_number":173,"context_line":"    cfg.DictOpt(\u0027backup_runner_options\u0027, default\u003d{},"},{"line_number":174,"context_line":"                help\u003d\u0027Additional options to be passed to the backup runner.\u0027),"},{"line_number":175,"context_line":"    cfg.StrOpt(\u0027backup_strategy\u0027, default\u003d\u0027InnoBackupEx\u0027,"},{"line_number":176,"context_line":"               help\u003d\u0027Default strategy to perform backups.\u0027),"},{"line_number":177,"context_line":"    cfg.DictOpt(\u0027backup_incremental_strategy\u0027,"},{"line_number":178,"context_line":"                default\u003d{\u0027InnoBackupEx\u0027: \u0027InnoBackupExIncremental\u0027},"},{"line_number":179,"context_line":"                help\u003d\u0027Incremental Backup Runner based on the default\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_96c97627","line":176,"in_reply_to":"baada198_90509d60","updated":"2014-08-10 22:56:19.000000000","message":"Fair enough, I will remove backup strategy and add the deprecation tags to the places where it went.","commit_id":"088fe8f6425471bc65fec80c7d56fd886e766f40"},{"author":{"_account_id":9749,"name":"Greg Lucas","email":"greg@glucas.net","username":"glucas"},"change_message_id":"a17a490c2ecb35147ddf36b62df169e4d54b601d","unresolved":false,"context_lines":[{"line_number":173,"context_line":"    cfg.DictOpt(\u0027backup_runner_options\u0027, default\u003d{},"},{"line_number":174,"context_line":"                help\u003d\u0027Additional options to be passed to the backup runner.\u0027),"},{"line_number":175,"context_line":"    cfg.StrOpt(\u0027backup_strategy\u0027, default\u003d\u0027InnoBackupEx\u0027,"},{"line_number":176,"context_line":"               help\u003d\u0027Default strategy to perform backups.\u0027),"},{"line_number":177,"context_line":"    cfg.DictOpt(\u0027backup_incremental_strategy\u0027,"},{"line_number":178,"context_line":"                default\u003d{\u0027InnoBackupEx\u0027: \u0027InnoBackupExIncremental\u0027},"},{"line_number":179,"context_line":"                help\u003d\u0027Incremental Backup Runner based on the default\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_90509d60","line":176,"in_reply_to":"baada198_ab61bed5","updated":"2014-08-10 19:46:25.000000000","message":"As I mentioned above I\u0027m fine punting on incremental backup since that expands the change beyond cfg cleanup. \n\nI don\u0027t see why we would not remove backup_strategy from DEFAULT as part of your commit, though. The code is already reading backup_strategy from the datastore group and in fact it is the same code (backupagent.py) that reads backup_namespace / restore_namespace.","commit_id":"088fe8f6425471bc65fec80c7d56fd886e766f40"},{"author":{"_account_id":9749,"name":"Greg Lucas","email":"greg@glucas.net","username":"glucas"},"change_message_id":"a17a490c2ecb35147ddf36b62df169e4d54b601d","unresolved":false,"context_lines":[{"line_number":173,"context_line":"    cfg.DictOpt(\u0027backup_runner_options\u0027, default\u003d{},"},{"line_number":174,"context_line":"                help\u003d\u0027Additional options to be passed to the backup runner.\u0027),"},{"line_number":175,"context_line":"    cfg.StrOpt(\u0027backup_strategy\u0027, default\u003d\u0027InnoBackupEx\u0027,"},{"line_number":176,"context_line":"               help\u003d\u0027Default strategy to perform backups.\u0027),"},{"line_number":177,"context_line":"    cfg.DictOpt(\u0027backup_incremental_strategy\u0027,"},{"line_number":178,"context_line":"                default\u003d{\u0027InnoBackupEx\u0027: \u0027InnoBackupExIncremental\u0027},"},{"line_number":179,"context_line":"                help\u003d\u0027Incremental Backup Runner based on the default\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_70586989","line":176,"in_reply_to":"baada198_daf24868","updated":"2014-08-10 19:46:25.000000000","message":"I don\u0027t understand how \u0027incremental backup\u0027 is any different than \u0027backup\u0027 -- particularly when they both default to the same thing, which is specific to MySQL. \n\nBut to Amrith\u0027s point: that change is beyond the scope of what he\u0027s cleaning up here, so withdrawn for this patch set.","commit_id":"088fe8f6425471bc65fec80c7d56fd886e766f40"},{"author":{"_account_id":9749,"name":"Greg Lucas","email":"greg@glucas.net","username":"glucas"},"change_message_id":"35784514c23fb1c2abfa3effb53b8f101c533fee","unresolved":false,"context_lines":[{"line_number":371,"context_line":"                     \u0027if trove_security_groups_support is True).\u0027),"},{"line_number":372,"context_line":"    cfg.StrOpt(\u0027backup_strategy\u0027, default\u003dNone,"},{"line_number":373,"context_line":"               help\u003d\u0027Default strategy to perform backups.\u0027),"},{"line_number":374,"context_line":"    cfg.StrOpt(\u0027backup_namespace\u0027,"},{"line_number":375,"context_line":"               default\u003dNone,"},{"line_number":376,"context_line":"               deprecated_name\u003d\u0027backup_namespace\u0027,"},{"line_number":377,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_f77f2567","line":374,"updated":"2014-08-08 20:44:22.000000000","message":"In cases where backup_strategy defaults to None we probably don\u0027t need the namespace options. The namespaces are only used to load a backup_strategy when one exists.","commit_id":"088fe8f6425471bc65fec80c7d56fd886e766f40"},{"author":{"_account_id":9749,"name":"Greg Lucas","email":"greg@glucas.net","username":"glucas"},"change_message_id":"f6b899da3c9b6bb1ebdc5a4440c12b1814e94a40","unresolved":false,"context_lines":[{"line_number":371,"context_line":"                     \u0027if trove_security_groups_support is True).\u0027),"},{"line_number":372,"context_line":"    cfg.StrOpt(\u0027backup_strategy\u0027, default\u003dNone,"},{"line_number":373,"context_line":"               help\u003d\u0027Default strategy to perform backups.\u0027),"},{"line_number":374,"context_line":"    cfg.StrOpt(\u0027backup_namespace\u0027,"},{"line_number":375,"context_line":"               default\u003dNone,"},{"line_number":376,"context_line":"               deprecated_name\u003d\u0027backup_namespace\u0027,"},{"line_number":377,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_f09f19f4","line":374,"in_reply_to":"baada198_cb5a721e","updated":"2014-08-10 20:06:05.000000000","message":"I\u0027d call it an observation rather than an assumption. In backup/models we check for a non-None backup strategy to determine if backups are allowed. If not, the other options should never be read. We are using the same pattern for the new replication strategy.\n\nMinor nit, though -- not worth a new patch set on its own.","commit_id":"088fe8f6425471bc65fec80c7d56fd886e766f40"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"837aa9478b5cb9783040e55b015024f19f73343a","unresolved":false,"context_lines":[{"line_number":371,"context_line":"                     \u0027if trove_security_groups_support is True).\u0027),"},{"line_number":372,"context_line":"    cfg.StrOpt(\u0027backup_strategy\u0027, default\u003dNone,"},{"line_number":373,"context_line":"               help\u003d\u0027Default strategy to perform backups.\u0027),"},{"line_number":374,"context_line":"    cfg.StrOpt(\u0027backup_namespace\u0027,"},{"line_number":375,"context_line":"               default\u003dNone,"},{"line_number":376,"context_line":"               deprecated_name\u003d\u0027backup_namespace\u0027,"},{"line_number":377,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_b6cafa16","line":374,"in_reply_to":"baada198_f09f19f4","updated":"2014-08-10 22:56:19.000000000","message":"I hadn\u0027t gone that far so yes, for me it is an assumption, for you it is an observation ;)\n\nBased on your observation, it sounds like a good thing to do. So yes. It will be done!","commit_id":"088fe8f6425471bc65fec80c7d56fd886e766f40"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"7b94df991e0ffcc11caa3de4380d585ad90efd4b","unresolved":false,"context_lines":[{"line_number":371,"context_line":"                     \u0027if trove_security_groups_support is True).\u0027),"},{"line_number":372,"context_line":"    cfg.StrOpt(\u0027backup_strategy\u0027, default\u003dNone,"},{"line_number":373,"context_line":"               help\u003d\u0027Default strategy to perform backups.\u0027),"},{"line_number":374,"context_line":"    cfg.StrOpt(\u0027backup_namespace\u0027,"},{"line_number":375,"context_line":"               default\u003dNone,"},{"line_number":376,"context_line":"               deprecated_name\u003d\u0027backup_namespace\u0027,"},{"line_number":377,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_cb5a721e","line":374,"in_reply_to":"baada198_f77f2567","updated":"2014-08-09 20:06:19.000000000","message":"You are right but you assume that the code only looks for backup_namespace if finds a backup_strategy.","commit_id":"088fe8f6425471bc65fec80c7d56fd886e766f40"},{"author":{"_account_id":9749,"name":"Greg Lucas","email":"greg@glucas.net","username":"glucas"},"change_message_id":"35784514c23fb1c2abfa3effb53b8f101c533fee","unresolved":false,"context_lines":[{"line_number":454,"context_line":"    cfg.StrOpt(\u0027backup_namespace\u0027,"},{"line_number":455,"context_line":"               default\u003d\u0027trove.guestagent.strategies.backup.couchbase_impl\u0027,"},{"line_number":456,"context_line":"               deprecated_name\u003d\u0027backup_namespace\u0027,"},{"line_number":457,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":458,"context_line":"    cfg.StrOpt(\u0027restore_namespace\u0027,"},{"line_number":459,"context_line":"               default\u003d\u0027trove.guestagent.strategies.restore.couchbase_impl\u0027,"},{"line_number":460,"context_line":"               deprecated_name\u003d\u0027restore_namespace\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_d76221a6","line":457,"updated":"2014-08-08 20:44:22.000000000","message":"Thinking about this further: Can we assume that before these options moved in to datastore groups there was only support for MySQL? In that case we should only add the deprecated info for MySQL (and related) datastores.\n\nIf we cannot assume that we may want to ditch the deprecated fields altogether. (Yes, I know I\u0027m the one who brought it up to begin with...)\n\nOtherwise someone with an old conf file with backup_strategy in the DEFAULT group will wind up in the odd situation where backup is considered a valid operation for e.g. mongodb, but always fails because the strategy is InnoBackupEx.","commit_id":"088fe8f6425471bc65fec80c7d56fd886e766f40"},{"author":{"_account_id":9749,"name":"Greg Lucas","email":"greg@glucas.net","username":"glucas"},"change_message_id":"a17a490c2ecb35147ddf36b62df169e4d54b601d","unresolved":false,"context_lines":[{"line_number":454,"context_line":"    cfg.StrOpt(\u0027backup_namespace\u0027,"},{"line_number":455,"context_line":"               default\u003d\u0027trove.guestagent.strategies.backup.couchbase_impl\u0027,"},{"line_number":456,"context_line":"               deprecated_name\u003d\u0027backup_namespace\u0027,"},{"line_number":457,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":458,"context_line":"    cfg.StrOpt(\u0027restore_namespace\u0027,"},{"line_number":459,"context_line":"               default\u003d\u0027trove.guestagent.strategies.restore.couchbase_impl\u0027,"},{"line_number":460,"context_line":"               deprecated_name\u003d\u0027restore_namespace\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_30c99125","line":457,"in_reply_to":"baada198_0b98eaca","updated":"2014-08-10 19:46:25.000000000","message":"OK, I\u0027m fine with what you\u0027ve got here.","commit_id":"088fe8f6425471bc65fec80c7d56fd886e766f40"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"7b94df991e0ffcc11caa3de4380d585ad90efd4b","unresolved":false,"context_lines":[{"line_number":454,"context_line":"    cfg.StrOpt(\u0027backup_namespace\u0027,"},{"line_number":455,"context_line":"               default\u003d\u0027trove.guestagent.strategies.backup.couchbase_impl\u0027,"},{"line_number":456,"context_line":"               deprecated_name\u003d\u0027backup_namespace\u0027,"},{"line_number":457,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":458,"context_line":"    cfg.StrOpt(\u0027restore_namespace\u0027,"},{"line_number":459,"context_line":"               default\u003d\u0027trove.guestagent.strategies.restore.couchbase_impl\u0027,"},{"line_number":460,"context_line":"               deprecated_name\u003d\u0027restore_namespace\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_0b98eaca","line":457,"in_reply_to":"baada198_d76221a6","updated":"2014-08-09 20:06:19.000000000","message":"there could have been sites that were using development versions of trove that did have it.","commit_id":"088fe8f6425471bc65fec80c7d56fd886e766f40"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"281c708ea1ef3efa015ba74daa660932925f39d5","unresolved":false,"context_lines":[{"line_number":292,"context_line":"    cfg.StrOpt(\u0027backup_strategy\u0027, default\u003d\u0027InnoBackupEx\u0027,"},{"line_number":293,"context_line":"               help\u003d\u0027Default strategy to perform backups.\u0027,"},{"line_number":294,"context_line":"               deprecated_name\u003d\u0027backup_strategy\u0027,"},{"line_number":295,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":296,"context_line":"    cfg.StrOpt(\u0027mount_point\u0027, default\u003d\u0027/var/lib/mysql\u0027,"},{"line_number":297,"context_line":"               help\u003d\"Filesystem path for mounting \""},{"line_number":298,"context_line":"                    \"volumes if volume support is enabled.\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_8205a569","line":295,"updated":"2014-08-11 10:44:05.000000000","message":"Agreed, since we did changes during single release we need to mark them as deprecated.","commit_id":"e72699ffadc4376a02bc1cad448710d5993a85ac"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"4af5cede4912212466088ac3c2aafa6448c1f539","unresolved":false,"context_lines":[{"line_number":166,"context_line":"               help\u003d\u0027Time to sleep during the check active guest.\u0027),"},{"line_number":167,"context_line":"    cfg.StrOpt(\u0027region\u0027, default\u003d\u0027LOCAL_DEV\u0027,"},{"line_number":168,"context_line":"               help\u003d\u0027The region this service is located.\u0027),"},{"line_number":169,"context_line":"    cfg.StrOpt(\u0027backup_runner\u0027,"},{"line_number":170,"context_line":"               default\u003d\u0027trove.guestagent.backup.backup_types.InnoBackupEx\u0027),"},{"line_number":171,"context_line":"    cfg.DictOpt(\u0027backup_runner_options\u0027, default\u003d{},"},{"line_number":172,"context_line":"                help\u003d\u0027Additional options to be passed to the backup runner.\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_a93185a3","line":169,"updated":"2014-08-29 18:09:41.000000000","message":"Any idea if backup_runner is being used or if it should be moved datastore\u0027s specific as well?","commit_id":"c2870f3e55ef51e37b7ba91deab85d991908eefc"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"4af5cede4912212466088ac3c2aafa6448c1f539","unresolved":false,"context_lines":[{"line_number":168,"context_line":"               help\u003d\u0027The region this service is located.\u0027),"},{"line_number":169,"context_line":"    cfg.StrOpt(\u0027backup_runner\u0027,"},{"line_number":170,"context_line":"               default\u003d\u0027trove.guestagent.backup.backup_types.InnoBackupEx\u0027),"},{"line_number":171,"context_line":"    cfg.DictOpt(\u0027backup_runner_options\u0027, default\u003d{},"},{"line_number":172,"context_line":"                help\u003d\u0027Additional options to be passed to the backup runner.\u0027),"},{"line_number":173,"context_line":"    cfg.DictOpt(\u0027backup_incremental_strategy\u0027,"},{"line_number":174,"context_line":"                default\u003d{\u0027InnoBackupEx\u0027: \u0027InnoBackupExIncremental\u0027},"}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_69ea0dd9","line":171,"updated":"2014-08-29 18:09:41.000000000","message":"As for backup_runner_options, i know it is only used in mysql (and percona). Do you know how easy (or difficult is it to move this one as well?)","commit_id":"c2870f3e55ef51e37b7ba91deab85d991908eefc"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"4af5cede4912212466088ac3c2aafa6448c1f539","unresolved":false,"context_lines":[{"line_number":291,"context_line":"                     \u0027if trove_security_groups_support is True).\u0027),"},{"line_number":292,"context_line":"    cfg.StrOpt(\u0027backup_strategy\u0027, default\u003d\u0027InnoBackupEx\u0027,"},{"line_number":293,"context_line":"               help\u003d\u0027Default strategy to perform backups.\u0027,"},{"line_number":294,"context_line":"               deprecated_name\u003d\u0027backup_strategy\u0027,"},{"line_number":295,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":296,"context_line":"    cfg.StrOpt(\u0027replication_strategy\u0027, default\u003d\u0027MysqlBinlogReplication\u0027,"},{"line_number":297,"context_line":"               help\u003d\u0027Default strategy for replication.\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_a479ac94","line":294,"updated":"2014-08-29 18:09:41.000000000","message":"Just wondering what the effort is to have the deprecated_name? Is it so that old trove code can run with new version of the configuration?","commit_id":"c2870f3e55ef51e37b7ba91deab85d991908eefc"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"e879b49bfea1a4eca98be333468504ad3b00343c","unresolved":false,"context_lines":[{"line_number":578,"context_line":"                help\u003d\u0027List of UPD ports and/or port ranges to open\u0027"},{"line_number":579,"context_line":"                     \u0027 in the security group (only applicable \u0027"},{"line_number":580,"context_line":"                     \u0027if trove_security_groups_support is True).\u0027),"},{"line_number":581,"context_line":"    cfg.StrOpt(\u0027backup_strategy\u0027, default\u003d\u0027PgDump\u0027,"},{"line_number":582,"context_line":"               help\u003d\u0027Default strategy to perform backups.\u0027),"},{"line_number":583,"context_line":"    cfg.StrOpt(\u0027mount_point\u0027, default\u003d\u0027/var/lib/postgresql\u0027,"},{"line_number":584,"context_line":"               help\u003d\"Filesystem path for mounting \""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa98f980_bbf31009","line":581,"updated":"2014-09-09 15:51:28.000000000","message":"Amrith, is there a reason why we havent included the deprecated name and group for postgreSQL configurations? Thanks.","commit_id":"1823237cdbca9c41853a7db54ecef1cf84c5528f"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"3eb1872bdb53f761243312344d0b41ec4e64665f","unresolved":false,"context_lines":[{"line_number":578,"context_line":"                help\u003d\u0027List of UPD ports and/or port ranges to open\u0027"},{"line_number":579,"context_line":"                     \u0027 in the security group (only applicable \u0027"},{"line_number":580,"context_line":"                     \u0027if trove_security_groups_support is True).\u0027),"},{"line_number":581,"context_line":"    cfg.StrOpt(\u0027backup_strategy\u0027, default\u003d\u0027PgDump\u0027,"},{"line_number":582,"context_line":"               help\u003d\u0027Default strategy to perform backups.\u0027),"},{"line_number":583,"context_line":"    cfg.StrOpt(\u0027mount_point\u0027, default\u003d\u0027/var/lib/postgresql\u0027,"},{"line_number":584,"context_line":"               help\u003d\"Filesystem path for mounting \""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa98f980_de57b800","line":581,"in_reply_to":"fa98f980_bb3a0696","updated":"2014-09-10 20:05:08.000000000","message":"That makes sense. Thanks for explaining Amrith. Appreciate it.","commit_id":"1823237cdbca9c41853a7db54ecef1cf84c5528f"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"48b7d2bca92930d59c9d2ddd3a20000ac171f809","unresolved":false,"context_lines":[{"line_number":578,"context_line":"                help\u003d\u0027List of UPD ports and/or port ranges to open\u0027"},{"line_number":579,"context_line":"                     \u0027 in the security group (only applicable \u0027"},{"line_number":580,"context_line":"                     \u0027if trove_security_groups_support is True).\u0027),"},{"line_number":581,"context_line":"    cfg.StrOpt(\u0027backup_strategy\u0027, default\u003d\u0027PgDump\u0027,"},{"line_number":582,"context_line":"               help\u003d\u0027Default strategy to perform backups.\u0027),"},{"line_number":583,"context_line":"    cfg.StrOpt(\u0027mount_point\u0027, default\u003d\u0027/var/lib/postgresql\u0027,"},{"line_number":584,"context_line":"               help\u003d\"Filesystem path for mounting \""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa98f980_bb3a0696","line":581,"in_reply_to":"fa98f980_bbf31009","updated":"2014-09-10 19:44:28.000000000","message":"Mariam, it wouldn\u0027t be deprecated in PostgreSQL because PostgreSQL is only going out in Juno and we\u0027re hoping that this fix makes it in Juno as well.\n\nTherefore, in theory, no one could have had code that used PostgreSQL configs (from this file) who will be impacted.","commit_id":"1823237cdbca9c41853a7db54ecef1cf84c5528f"}]}