)]}'
{"trove/common/cfg.py":[{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"284fb8402b54c6f743d20ef40f76e7eb81b5e233","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    cfg.IntOpt(\u0027usage_sleep_time\u0027, default\u003d5,"},{"line_number":168,"context_line":"               help\u003d\u0027Time to sleep during the check active guest.\u0027),"},{"line_number":169,"context_line":"    cfg.StrOpt(\u0027region\u0027, default\u003d\u0027LOCAL_DEV\u0027,"},{"line_number":170,"context_line":"               help\u003d\u0027The region this service is located.\u0027),"},{"line_number":171,"context_line":"    cfg.StrOpt(\u0027backup_runner\u0027,"},{"line_number":172,"context_line":"               default\u003d\u0027trove.guestagent.backup.backup_types.InnoBackupEx\u0027),"},{"line_number":173,"context_line":"    cfg.DictOpt(\u0027backup_runner_options\u0027, default\u003d{},"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_7a5cc47d","line":170,"updated":"2014-08-28 17:57:08.000000000","message":"Hey Amrith, i know this is not the scope of this fix but since this is somewhat related, i was wondering if this could be pigged back here. There are some backup config that are defined globally (and probably are no longer used). I am referring to backup_runner,  backup_runner_options, backup_namespace, restore_namespace, backup_namespace, restore_namespace just to name a few.\n\nIt you prefer to open a new bug to address this, that is ok. Let me know what you think.","commit_id":"e063b5b1b835ec1bf952476a4baf0a8642697d85"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"2d8b80d79bcf87998c6b8affbe38d230e490ddd1","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    cfg.IntOpt(\u0027usage_sleep_time\u0027, default\u003d5,"},{"line_number":168,"context_line":"               help\u003d\u0027Time to sleep during the check active guest.\u0027),"},{"line_number":169,"context_line":"    cfg.StrOpt(\u0027region\u0027, default\u003d\u0027LOCAL_DEV\u0027,"},{"line_number":170,"context_line":"               help\u003d\u0027The region this service is located.\u0027),"},{"line_number":171,"context_line":"    cfg.StrOpt(\u0027backup_runner\u0027,"},{"line_number":172,"context_line":"               default\u003d\u0027trove.guestagent.backup.backup_types.InnoBackupEx\u0027),"},{"line_number":173,"context_line":"    cfg.DictOpt(\u0027backup_runner_options\u0027, default\u003d{},"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_7a14c44c","line":170,"in_reply_to":"1abeadc6_7a5cc47d","updated":"2014-08-28 18:04:35.000000000","message":"will take a look. doesn\u0027t appear too hard, at first blush. I can easily add these to the existing bug if they are easy to crank out.","commit_id":"e063b5b1b835ec1bf952476a4baf0a8642697d85"}],"trove/guestagent/backup/backupagent.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"6743e839da264957709205799c0fc6046195f36f","unresolved":false,"context_lines":[{"line_number":45,"context_line":"# Try to get the incremental strategy or return the default \u0027backup_strategy\u0027"},{"line_number":46,"context_line":"INCREMENTAL \u003d CONF.get("},{"line_number":47,"context_line":"    \u0027mysql\u0027 if not MANAGER"},{"line_number":48,"context_line":"    else MANAGER).backup_incremental_strategy.get(STRATEGY, STRATEGY)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"INCREMENTAL_RUNNER \u003d get_backup_strategy(INCREMENTAL, BACKUP_NAMESPACE)"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_c26997fa","line":48,"updated":"2014-08-27 22:33:40.000000000","message":"As i can see, we have area for improvements.\nLets extract group definition and then just call it for a specific option.\n\nIt would look easier and smoother then we have it now.","commit_id":"d10b4a7b488dc33dedb47d785dcfc2214415504f"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"31db9028558f61ccbc5fb15cfcc6d2ad57116868","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# Try to get the incremental strategy or return the default \u0027backup_strategy\u0027"},{"line_number":42,"context_line":"INCREMENTAL \u003d CONF.get("},{"line_number":43,"context_line":"    \u0027mysql\u0027 if not MANAGER"},{"line_number":44,"context_line":"    else MANAGER).backup_incremental_strategy.get(STRATEGY, STRATEGY)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"INCREMENTAL_RUNNER \u003d get_backup_strategy(INCREMENTAL, BACKUP_NAMESPACE)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1abeadc6_2fb787f6","line":43,"updated":"2014-08-28 07:18:42.000000000","message":"MANAGER always would be something, if there\u0027s no default_datastore, MANAGER would equal to \u0027mysql\u0027, so this can be simplified. See lines #35-37","commit_id":"f1e9949557911789d2e94b40f8659c48071d524c"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"ad66c2e34ef7e0800fc636f640725d0370905068","unresolved":false,"context_lines":[{"line_number":42,"context_line":"INCREMENTAL \u003d CONF.get(MANAGER).backup_incremental_strategy.get("},{"line_number":43,"context_line":"    STRATEGY, STRATEGY)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"INCREMENTAL_RUNNER \u003d get_backup_strategy(INCREMENTAL, BACKUP_NAMESPACE)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"class BackupAgent(object):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_0aa70fa8","line":45,"updated":"2014-08-28 13:01:02.000000000","message":"The last thing that i\u0027d suggest to take into account and fix is to define global variable that is responsible for configuration group, not only MANAGER:\n\n     MANAGER \u003d \u0027mysql\u0027 if not CONF.datastore_manager else CONF.datastore_manager\n\n     CONFIG_GROUP \u003d CONF.get(MANAGER)\n     STRATEGY \u003d CONFIG_GROUP.backup_strategy\n     BACKUP_NAMESPACE \u003d CONFIG_GROUP.backup_namespace\n     RESTORE_NAMESPACE \u003d CONFIG_GROUP.restore_namespace\n     RUNNER \u003d get_backup_strategy(STRATEGY, BACKUP_NAMESPACE)\n\n\nWe can reduce amount of \"getattr\" calls.","commit_id":"e063b5b1b835ec1bf952476a4baf0a8642697d85"}]}