)]}'
{"trove/cmd/api.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"eb871f9d2935f384df37d739c4919cc25e821614","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    conf_file \u003d CONF.find_file(CONF.api_paste_config)"},{"line_number":23,"context_line":"    workers \u003d CONF.trove_api_workers or processutils.get_worker_count()"},{"line_number":24,"context_line":"    launcher \u003d wsgi.launch(\u0027trove\u0027, CONF.bind_port, conf_file,"},{"line_number":25,"context_line":"                           host\u003dCONF.bind_host, workers\u003dworkers)"},{"line_number":26,"context_line":"    launcher.wait()"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_6d6e73cd","line":25,"updated":"2014-08-12 23:23:51.000000000","message":"what\u0027s the benefit, it seems like 0.0.0.0 (which you now provide) is the default?","commit_id":"2b97934343ba7efd8908c748df32e394997be378"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"7bcec3299cd581ac071f0cca7854fe9d4b66485f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    conf_file \u003d CONF.find_file(CONF.api_paste_config)"},{"line_number":23,"context_line":"    workers \u003d CONF.trove_api_workers or processutils.get_worker_count()"},{"line_number":24,"context_line":"    launcher \u003d wsgi.launch(\u0027trove\u0027, CONF.bind_port, conf_file,"},{"line_number":25,"context_line":"                           host\u003dCONF.bind_host, workers\u003dworkers)"},{"line_number":26,"context_line":"    launcher.wait()"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_802b6f7b","line":25,"in_reply_to":"baada198_6d6e73cd","updated":"2014-08-13 14:04:12.000000000","message":"+1 until there\u0027s a bug report with full description of a problem.","commit_id":"2b97934343ba7efd8908c748df32e394997be378"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"10608b76c9980da029494907de1cc337b43f7eb4","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    from trove.common import wsgi"},{"line_number":22,"context_line":"    conf_file \u003d CONF.find_file(CONF.api_paste_config)"},{"line_number":23,"context_line":"    workers \u003d CONF.trove_api_workers or processutils.get_worker_count()"},{"line_number":24,"context_line":"    launcher \u003d wsgi.launch(\u0027trove\u0027, CONF.bind_port or 8779, conf_file,"},{"line_number":25,"context_line":"                           workers\u003dworkers)"},{"line_number":26,"context_line":"    launcher.wait()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_08d8931c","side":"PARENT","line":24,"updated":"2014-08-17 22:04:43.000000000","message":"why remove the \u0027or 8779\u0027?","commit_id":"804644c3a8db3e799fdcf1b644f865d4222ae861"},{"author":{"_account_id":8984,"name":"George Peristerakis","email":"gperiste@redhat.com","username":"peristeri"},"change_message_id":"88130bc9b2a433a2dd7ab65d0a67caf49bcd856b","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    from trove.common import wsgi"},{"line_number":22,"context_line":"    conf_file \u003d CONF.find_file(CONF.api_paste_config)"},{"line_number":23,"context_line":"    workers \u003d CONF.trove_api_workers or processutils.get_worker_count()"},{"line_number":24,"context_line":"    launcher \u003d wsgi.launch(\u0027trove\u0027, CONF.bind_port or 8779, conf_file,"},{"line_number":25,"context_line":"                           workers\u003dworkers)"},{"line_number":26,"context_line":"    launcher.wait()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_5c0a4cd3","side":"PARENT","line":24,"in_reply_to":"1abeadc6_08d8931c","updated":"2014-08-18 00:29:02.000000000","message":"CONF.bind_port has a default value when set. If that value changes, this will prevent that from happening. In other words, CONF.bind_port will always return a value.","commit_id":"804644c3a8db3e799fdcf1b644f865d4222ae861"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"7345d11526676c30a8b9af94fb19c3e8ce5a67f6","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    from trove.common import wsgi"},{"line_number":22,"context_line":"    conf_file \u003d CONF.find_file(CONF.api_paste_config)"},{"line_number":23,"context_line":"    workers \u003d CONF.trove_api_workers or processutils.get_worker_count()"},{"line_number":24,"context_line":"    launcher \u003d wsgi.launch(\u0027trove\u0027, CONF.bind_port or 8779, conf_file,"},{"line_number":25,"context_line":"                           workers\u003dworkers)"},{"line_number":26,"context_line":"    launcher.wait()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_5fc15ee3","side":"PARENT","line":24,"in_reply_to":"1abeadc6_5c0a4cd3","updated":"2014-08-18 02:07:02.000000000","message":"What if the default value of CONF.bind_port is None?  \n\nAlso this change doesn\u0027t seem related to setting the bind_host, so I\u0027m not sure why we\u0027re changing it at all. If it ain\u0027t broke, don\u0027t fix it. :)","commit_id":"804644c3a8db3e799fdcf1b644f865d4222ae861"}],"trove/common/cfg.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"9886ff05254911a0647e9d350b0c4a27e46e16e9","unresolved":false,"context_lines":[{"line_number":36,"context_line":"               secret\u003dTrue),"},{"line_number":37,"context_line":"    cfg.IntOpt(\u0027sql_idle_timeout\u0027, default\u003d3600),"},{"line_number":38,"context_line":"    cfg.BoolOpt(\u0027sql_query_log\u0027, default\u003dFalse),"},{"line_number":39,"context_line":"    cfg.StrOpt(\u0027bind_host\u0027, default\u003d\u00270.0.0.0\u0027),"},{"line_number":40,"context_line":"    cfg.IntOpt(\u0027bind_port\u0027, default\u003d8779),"},{"line_number":41,"context_line":"    cfg.StrOpt(\u0027api_extensions_path\u0027, default\u003d\u0027$pybasedir/extensions/routes\u0027,"},{"line_number":42,"context_line":"               help\u003d\u0027Path to extensions.\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ab29df4_e061b8d4","line":39,"updated":"2014-08-13 19:59:14.000000000","message":"I think it would be good to add some help for this.","commit_id":"9f10b57313b43f5fc75af1265b150b74559a8804"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"10608b76c9980da029494907de1cc337b43f7eb4","unresolved":false,"context_lines":[{"line_number":36,"context_line":"               secret\u003dTrue),"},{"line_number":37,"context_line":"    cfg.IntOpt(\u0027sql_idle_timeout\u0027, default\u003d3600),"},{"line_number":38,"context_line":"    cfg.BoolOpt(\u0027sql_query_log\u0027, default\u003dFalse),"},{"line_number":39,"context_line":"    cfg.StrOpt(\u0027bind_host\u0027, default\u003d\u00270.0.0.0\u0027),"},{"line_number":40,"context_line":"    cfg.IntOpt(\u0027bind_port\u0027, default\u003d8779),"},{"line_number":41,"context_line":"    cfg.StrOpt(\u0027api_extensions_path\u0027, default\u003d\u0027$pybasedir/extensions/routes\u0027,"},{"line_number":42,"context_line":"               help\u003d\u0027Path to extensions.\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_c8f4db89","line":39,"in_reply_to":"9ab29df4_e061b8d4","updated":"2014-08-17 22:04:43.000000000","message":"Agreed, can we please add a short help string for the docs?\n\nThanks!","commit_id":"9f10b57313b43f5fc75af1265b150b74559a8804"}]}