)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"94487a0781c52cc9b86ccb926345926978ebec0f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Co-Authored-By: Mat Lowery \u003cmlowery@ebaysf.com\u003e"},{"line_number":14,"context_line":"Co-Authored-By: svenkataramanaia \u003csvenkataramanaia@ebaysf.com\u003e"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Partially implements: blueprint clustering"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Id45f692df377a32310a30487e27cf0f017c93c86"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"1abeadc6_bee2142d","line":16,"updated":"2014-08-27 08:54:19.000000000","message":"This link doesn\u0027t work for me.","commit_id":"e21865cd5f8d9d72c9c60e4cc6b27b7015ee8f46"},{"author":{"_account_id":10139,"name":"Ramashri Umale","email":"rumale@ebaysf.com","username":"rumale"},"change_message_id":"170c33e40ad74b717e51d9b29c9f5ea46064f753","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Co-Authored-By: Mat Lowery \u003cmlowery@ebaysf.com\u003e"},{"line_number":14,"context_line":"Co-Authored-By: svenkataramanaia \u003csvenkataramanaia@ebaysf.com\u003e"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Partially implements: blueprint clustering"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Id45f692df377a32310a30487e27cf0f017c93c86"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"1abeadc6_5ffc883e","line":16,"in_reply_to":"1abeadc6_bee2142d","updated":"2014-08-27 16:49:14.000000000","message":"Cant help that the search is not specific, but here is the link for your reference https://blueprints.launchpad.net/trove/+spec/clustering","commit_id":"e21865cd5f8d9d72c9c60e4cc6b27b7015ee8f46"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"744d06b34c8a0f1e6ab69ebcdba0d31fe2bfd222","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     amcrn \u003camcreynolds@ebaysf.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-08-29 13:59:58 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Clusters Guest Implementation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"adds guest impl code for creating a sharded mongodb"},{"line_number":10,"context_line":"cluster as the first implementation"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"fa98f980_05d2c7ff","line":7,"updated":"2014-09-02 23:28:51.000000000","message":"If you have to respin this for any reason, (or any one of the other three patches), please stick a DocImpact keyword on some one of them.","commit_id":"44683ae5d8a56f13fe1fdacce85d0839a4819ea3"}],"trove/common/strategies/mongodb/guestagent.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"13ef4dca3efaa4da9c6131792df9d384dd4c3983","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from trove.common.strategies import base"},{"line_number":18,"context_line":"from trove.guestagent import api as guest_api"},{"line_number":19,"context_line":"from trove.guestagent.api import AGENT_HIGH_TIMEOUT"},{"line_number":20,"context_line":"from trove.guestagent.api import AGENT_LOW_TIMEOUT"},{"line_number":21,"context_line":"from trove.openstack.common import log as logging"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_cf875a10","line":20,"updated":"2014-08-13 13:23:50.000000000","message":"redundant imports\n\nyou can get this timeouts by calling guest_api.AGENT_....","commit_id":"184e4d68a7d3a5bfc2f85822a4860502649ac960"},{"author":{"_account_id":10139,"name":"Ramashri Umale","email":"rumale@ebaysf.com","username":"rumale"},"change_message_id":"279013637fb867c5a4d6431b1080cea4765b4ac9","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from trove.common.strategies import base"},{"line_number":18,"context_line":"from trove.guestagent import api as guest_api"},{"line_number":19,"context_line":"from trove.guestagent.api import AGENT_HIGH_TIMEOUT"},{"line_number":20,"context_line":"from trove.guestagent.api import AGENT_LOW_TIMEOUT"},{"line_number":21,"context_line":"from trove.openstack.common import log as logging"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ab29df4_31822053","line":20,"in_reply_to":"baada198_cf875a10","updated":"2014-08-13 21:05:40.000000000","message":"Done","commit_id":"184e4d68a7d3a5bfc2f85822a4860502649ac960"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"13ef4dca3efaa4da9c6131792df9d384dd4c3983","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        return MongoDbGuestAgentAPI"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class MongoDbGuestAgentAPI(guest_api.API):"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def add_shard(self, replica_set_name, replica_set_member):"},{"line_number":38,"context_line":"        LOG.debug(\"Adding shard with replSet %(replica_set_name)s and member \""}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_6fd56ee5","line":35,"updated":"2014-08-13 13:23:50.000000000","message":"since you\u0027re using call method type in all methods, are there any responses from guest?","commit_id":"184e4d68a7d3a5bfc2f85822a4860502649ac960"},{"author":{"_account_id":10139,"name":"Ramashri Umale","email":"rumale@ebaysf.com","username":"rumale"},"change_message_id":"279013637fb867c5a4d6431b1080cea4765b4ac9","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        return MongoDbGuestAgentAPI"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class MongoDbGuestAgentAPI(guest_api.API):"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def add_shard(self, replica_set_name, replica_set_member):"},{"line_number":38,"context_line":"        LOG.debug(\"Adding shard with replSet %(replica_set_name)s and member \""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ab29df4_71f3b80a","line":35,"in_reply_to":"baada198_6fd56ee5","updated":"2014-08-13 21:05:40.000000000","message":"changed to return self._call to return responses if any","commit_id":"184e4d68a7d3a5bfc2f85822a4860502649ac960"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"d0cc6ddfef6a39ad0c55607f1654de9aa42f3c83","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 eBay Software Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":16,"id":"1abeadc6_c2535715","line":1,"updated":"2014-08-27 22:02:00.000000000","message":"please add periods into all logging calls.","commit_id":"cc2843242de21e68d02005f94b69cb1516a860b8"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"d0cc6ddfef6a39ad0c55607f1654de9aa42f3c83","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":23,"context_line":"CONF \u003d cfg.CONF"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class MongoDbGuestAgentStrategy(base.BaseGuestAgentStrategy):"}],"source_content_type":"text/x-python","patch_set":16,"id":"1abeadc6_423f47b4","line":23,"updated":"2014-08-27 22:02:00.000000000","message":"seems like CONF is not needed here","commit_id":"cc2843242de21e68d02005f94b69cb1516a860b8"}],"trove/guestagent/datastore/mongodb/manager.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"f498c54f385fa35a6d0fbf44ee76d07f74d8f024","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                self.app.status.is_config_server \u003d True"},{"line_number":96,"context_line":"                self.app.start_db_with_conf_changes(config_contents)"},{"line_number":97,"context_line":"                # TODO(ramashri) see if hardcoding of times can be removed"},{"line_number":98,"context_line":"                utils.poll_until(db_running, sleep_time\u003d60, time_out\u003d1000)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"            elif cluster_config[\u0027instance_type\u0027] \u003d\u003d \"member\":"},{"line_number":101,"context_line":"                self.app.start_db_with_conf_changes(config_contents)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7ac7a964_5849168a","line":98,"range":{"start_line":98,"start_character":16,"end_line":98,"end_character":21},"updated":"2014-08-16 14:38:20.000000000","message":"wouldn\u0027t it be too long for sleep time out? The whole minute.","commit_id":"36e2f1ef0d4ac3b0e50fc99677eb7cbcb62e8e2f"},{"author":{"_account_id":10139,"name":"Ramashri Umale","email":"rumale@ebaysf.com","username":"rumale"},"change_message_id":"c76b7a368a55e8cfd47016660ff5783f46302ed6","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                self.app.status.is_config_server \u003d True"},{"line_number":96,"context_line":"                self.app.start_db_with_conf_changes(config_contents)"},{"line_number":97,"context_line":"                # TODO(ramashri) see if hardcoding of times can be removed"},{"line_number":98,"context_line":"                utils.poll_until(db_running, sleep_time\u003d60, time_out\u003d1000)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"            elif cluster_config[\u0027instance_type\u0027] \u003d\u003d \"member\":"},{"line_number":101,"context_line":"                self.app.start_db_with_conf_changes(config_contents)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1abeadc6_0fe1f8fd","line":98,"in_reply_to":"7ac7a964_5849168a","updated":"2014-08-21 00:55:50.000000000","message":"good point, on looking further.... don\u0027t think this line is really required since start_db does have its own timeout for starting db. will look into it","commit_id":"36e2f1ef0d4ac3b0e50fc99677eb7cbcb62e8e2f"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"f498c54f385fa35a6d0fbf44ee76d07f74d8f024","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            elif cluster_config[\u0027instance_type\u0027] \u003d\u003d \"member\":"},{"line_number":101,"context_line":"                self.app.start_db_with_conf_changes(config_contents)"},{"line_number":102,"context_line":"                # TODO(ramashri) see if hardcoding of times can be removed"},{"line_number":103,"context_line":"                utils.poll_until(db_running, sleep_time\u003d60, time_out\u003d1000)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"            else:"},{"line_number":106,"context_line":"                LOG.error(\"Bad cluster configuration; instance type given \""}],"source_content_type":"text/x-python","patch_set":9,"id":"7ac7a964_785fb241","line":103,"updated":"2014-08-16 14:38:20.000000000","message":"same","commit_id":"36e2f1ef0d4ac3b0e50fc99677eb7cbcb62e8e2f"},{"author":{"_account_id":10139,"name":"Ramashri Umale","email":"rumale@ebaysf.com","username":"rumale"},"change_message_id":"c76b7a368a55e8cfd47016660ff5783f46302ed6","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            elif cluster_config[\u0027instance_type\u0027] \u003d\u003d \"member\":"},{"line_number":101,"context_line":"                self.app.start_db_with_conf_changes(config_contents)"},{"line_number":102,"context_line":"                # TODO(ramashri) see if hardcoding of times can be removed"},{"line_number":103,"context_line":"                utils.poll_until(db_running, sleep_time\u003d60, time_out\u003d1000)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"            else:"},{"line_number":106,"context_line":"                LOG.error(\"Bad cluster configuration; instance type given \""}],"source_content_type":"text/x-python","patch_set":9,"id":"1abeadc6_8fec28f5","line":103,"in_reply_to":"7ac7a964_785fb241","updated":"2014-08-21 00:55:50.000000000","message":"same reply as above","commit_id":"36e2f1ef0d4ac3b0e50fc99677eb7cbcb62e8e2f"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"f498c54f385fa35a6d0fbf44ee76d07f74d8f024","unresolved":false,"context_lines":[{"line_number":255,"context_line":"            self.app.add_members(members)"},{"line_number":256,"context_line":"            LOG.debug(\"add_members called\")"},{"line_number":257,"context_line":"            LOG.debug(\"args: members\u003d%s\" % members)"},{"line_number":258,"context_line":"        except Exception:"},{"line_number":259,"context_line":"            self.status.set_status(ds_instance.ServiceStatuses.FAILED)"},{"line_number":260,"context_line":"            raise"},{"line_number":261,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7ac7a964_b8594a5c","line":258,"updated":"2014-08-16 14:38:20.000000000","message":"I don\u0027t like the idea of expecting too broad exception. Please find out the list of exception that can occur while creating member node","commit_id":"36e2f1ef0d4ac3b0e50fc99677eb7cbcb62e8e2f"},{"author":{"_account_id":10139,"name":"Ramashri Umale","email":"rumale@ebaysf.com","username":"rumale"},"change_message_id":"c76b7a368a55e8cfd47016660ff5783f46302ed6","unresolved":false,"context_lines":[{"line_number":255,"context_line":"            self.app.add_members(members)"},{"line_number":256,"context_line":"            LOG.debug(\"add_members called\")"},{"line_number":257,"context_line":"            LOG.debug(\"args: members\u003d%s\" % members)"},{"line_number":258,"context_line":"        except Exception:"},{"line_number":259,"context_line":"            self.status.set_status(ds_instance.ServiceStatuses.FAILED)"},{"line_number":260,"context_line":"            raise"},{"line_number":261,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1abeadc6_00892beb","line":258,"in_reply_to":"7ac7a964_b8594a5c","updated":"2014-08-21 00:55:50.000000000","message":"The intent of catching the brad exception is to handle any and every case of exception and have it be handled so that the service status is set correctly. If we expect specific types of exception we could risk ServiceStatus not being set appropriately for an unexpected Exception","commit_id":"36e2f1ef0d4ac3b0e50fc99677eb7cbcb62e8e2f"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"f498c54f385fa35a6d0fbf44ee76d07f74d8f024","unresolved":false,"context_lines":[{"line_number":264,"context_line":"            self.app.add_config_servers(config_servers)"},{"line_number":265,"context_line":"            LOG.debug(\"add_config_servers called\")"},{"line_number":266,"context_line":"            LOG.debug(\"args: config_servers\u003d%s\" % config_servers)"},{"line_number":267,"context_line":"        except Exception:"},{"line_number":268,"context_line":"            self.status.set_status(ds_instance.ServiceStatuses.FAILED)"},{"line_number":269,"context_line":"            raise"},{"line_number":270,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7ac7a964_d8544623","line":267,"updated":"2014-08-16 14:38:20.000000000","message":"I don\u0027t like the idea of expecting too broad exception. Please find out the list of exception that can occur while creating config server node","commit_id":"36e2f1ef0d4ac3b0e50fc99677eb7cbcb62e8e2f"},{"author":{"_account_id":10139,"name":"Ramashri Umale","email":"rumale@ebaysf.com","username":"rumale"},"change_message_id":"c76b7a368a55e8cfd47016660ff5783f46302ed6","unresolved":false,"context_lines":[{"line_number":264,"context_line":"            self.app.add_config_servers(config_servers)"},{"line_number":265,"context_line":"            LOG.debug(\"add_config_servers called\")"},{"line_number":266,"context_line":"            LOG.debug(\"args: config_servers\u003d%s\" % config_servers)"},{"line_number":267,"context_line":"        except Exception:"},{"line_number":268,"context_line":"            self.status.set_status(ds_instance.ServiceStatuses.FAILED)"},{"line_number":269,"context_line":"            raise"},{"line_number":270,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1abeadc6_4f405034","line":267,"in_reply_to":"7ac7a964_d8544623","updated":"2014-08-21 00:55:50.000000000","message":"same justification as above","commit_id":"36e2f1ef0d4ac3b0e50fc99677eb7cbcb62e8e2f"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"f498c54f385fa35a6d0fbf44ee76d07f74d8f024","unresolved":false,"context_lines":[{"line_number":274,"context_line":"            LOG.debug(\"add_shard called\")"},{"line_number":275,"context_line":"            LOG.debug(\"args: replica_set_name\u003d%s, replica_set_member\u003d%s\" % ("},{"line_number":276,"context_line":"                replica_set_name, replica_set_member))"},{"line_number":277,"context_line":"        except Exception:"},{"line_number":278,"context_line":"            self.status.set_status(ds_instance.ServiceStatuses.FAILED)"},{"line_number":279,"context_line":"            raise"},{"line_number":280,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7ac7a964_1836be03","line":277,"updated":"2014-08-16 14:38:20.000000000","message":"I don\u0027t like the idea of expecting too broad exception. Please find out the list of exception that can occur while creating shard","commit_id":"36e2f1ef0d4ac3b0e50fc99677eb7cbcb62e8e2f"},{"author":{"_account_id":10139,"name":"Ramashri Umale","email":"rumale@ebaysf.com","username":"rumale"},"change_message_id":"c76b7a368a55e8cfd47016660ff5783f46302ed6","unresolved":false,"context_lines":[{"line_number":274,"context_line":"            LOG.debug(\"add_shard called\")"},{"line_number":275,"context_line":"            LOG.debug(\"args: replica_set_name\u003d%s, replica_set_member\u003d%s\" % ("},{"line_number":276,"context_line":"                replica_set_name, replica_set_member))"},{"line_number":277,"context_line":"        except Exception:"},{"line_number":278,"context_line":"            self.status.set_status(ds_instance.ServiceStatuses.FAILED)"},{"line_number":279,"context_line":"            raise"},{"line_number":280,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1abeadc6_8f46e84d","line":277,"in_reply_to":"7ac7a964_1836be03","updated":"2014-08-21 00:55:50.000000000","message":"same justification as above","commit_id":"36e2f1ef0d4ac3b0e50fc99677eb7cbcb62e8e2f"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"94487a0781c52cc9b86ccb926345926978ebec0f","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            config_contents, conf_changes)"},{"line_number":83,"context_line":"        if cluster_config is None:"},{"line_number":84,"context_line":"            self.app.start_db_with_conf_changes(config_contents)"},{"line_number":85,"context_line":"        else:"},{"line_number":86,"context_line":"            if cluster_config[\u0027instance_type\u0027] \u003d\u003d \"query_router\":"},{"line_number":87,"context_line":"                self.app.reset_configuration({\u0027config_contents\u0027:"},{"line_number":88,"context_line":"                                              config_contents})"}],"source_content_type":"text/x-python","patch_set":13,"id":"1abeadc6_bed694ef","line":85,"updated":"2014-08-27 08:54:19.000000000","message":"How about extracting the logic of this \"else\" block to the method?","commit_id":"e21865cd5f8d9d72c9c60e4cc6b27b7015ee8f46"},{"author":{"_account_id":10139,"name":"Ramashri Umale","email":"rumale@ebaysf.com","username":"rumale"},"change_message_id":"170c33e40ad74b717e51d9b29c9f5ea46064f753","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            config_contents, conf_changes)"},{"line_number":83,"context_line":"        if cluster_config is None:"},{"line_number":84,"context_line":"            self.app.start_db_with_conf_changes(config_contents)"},{"line_number":85,"context_line":"        else:"},{"line_number":86,"context_line":"            if cluster_config[\u0027instance_type\u0027] \u003d\u003d \"query_router\":"},{"line_number":87,"context_line":"                self.app.reset_configuration({\u0027config_contents\u0027:"},{"line_number":88,"context_line":"                                              config_contents})"}],"source_content_type":"text/x-python","patch_set":13,"id":"1abeadc6_bf4d9c9b","line":85,"in_reply_to":"1abeadc6_bed694ef","updated":"2014-08-27 16:49:14.000000000","message":"Not sure what you mean here... Is there a concern with the else block being as it is?","commit_id":"e21865cd5f8d9d72c9c60e4cc6b27b7015ee8f46"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"744d06b34c8a0f1e6ab69ebcdba0d31fe2bfd222","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            LOG.debug(\"Mounted the volume %(path)s as %(mount)s\" %"},{"line_number":70,"context_line":"                      {\u0027path\u0027: device_path, \"mount\": mount_point})"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        conf_changes \u003d self.get_config_changes(cluster_config, mount_point)"},{"line_number":73,"context_line":"        config_contents \u003d self.app.update_config_contents("},{"line_number":74,"context_line":"            config_contents, conf_changes)"},{"line_number":75,"context_line":"        if cluster_config is None:"}],"source_content_type":"text/x-python","patch_set":19,"id":"fa98f980_25e988e6","line":72,"updated":"2014-09-02 23:28:51.000000000","message":"will have to refactor for mount point changes ...","commit_id":"44683ae5d8a56f13fe1fdacce85d0839a4819ea3"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"744d06b34c8a0f1e6ab69ebcdba0d31fe2bfd222","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                self.app.start_db_with_conf_changes(config_contents)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"            else:"},{"line_number":93,"context_line":"                LOG.error(\"Bad cluster configuration; instance type given \""},{"line_number":94,"context_line":"                          \"as %s\" % cluster_config[\u0027instance_type\u0027])"},{"line_number":95,"context_line":"                self.status.set_status(ds_instance.ServiceStatuses.FAILED)"},{"line_number":96,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":19,"id":"fa98f980_c21fd26a","line":93,"updated":"2014-09-02 23:28:51.000000000","message":"please i18n","commit_id":"44683ae5d8a56f13fe1fdacce85d0839a4819ea3"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"744d06b34c8a0f1e6ab69ebcdba0d31fe2bfd222","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            # TODO(ramashri) remove smallfiles config at end of dev testing"},{"line_number":106,"context_line":"            if cluster_config[\"instance_type\"] \u003d\u003d \"config_server\":"},{"line_number":107,"context_line":"                config_changes[\"configsvr\"] \u003d \"true\""},{"line_number":108,"context_line":"                config_changes[\"smallfiles\"] \u003d \"true\""},{"line_number":109,"context_line":"            elif cluster_config[\"instance_type\"] \u003d\u003d \"member\":"},{"line_number":110,"context_line":"                config_changes[\"replSet\"] \u003d cluster_config[\"replica_set_name\"]"},{"line_number":111,"context_line":"                config_changes[\"smallfiles\"] \u003d \"true\""}],"source_content_type":"text/x-python","patch_set":19,"id":"fa98f980_a58ad818","line":108,"updated":"2014-09-02 23:28:51.000000000","message":"should smallfiles be removed? It says so in the #TODO ...","commit_id":"44683ae5d8a56f13fe1fdacce85d0839a4819ea3"}],"trove/guestagent/datastore/mongodb/service.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"d0cc6ddfef6a39ad0c55607f1654de9aa42f3c83","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        This method is used by query router (mongos) instances."},{"line_number":213,"context_line":"        \"\"\""},{"line_number":214,"context_line":"        config_contents \u003d self._read_config()"},{"line_number":215,"context_line":"        configdb_contents \u003d \u0027,\u0027.join([\u0027%s:27019\u0027 % host"},{"line_number":216,"context_line":"                                      for host in config_server_hosts])"},{"line_number":217,"context_line":"        LOG.debug(\"Config server list %s\" % configdb_contents)"},{"line_number":218,"context_line":"        # remove db path from config and update configdb"}],"source_content_type":"text/x-python","patch_set":16,"id":"1abeadc6_426667ee","line":215,"updated":"2014-08-27 22:02:00.000000000","message":"i\u0027d suggest to find a way to pull out port from any possible source, but not write it as hard-coded string.","commit_id":"cc2843242de21e68d02005f94b69cb1516a860b8"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"744d06b34c8a0f1e6ab69ebcdba0d31fe2bfd222","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        configdb_contents \u003d \u0027,\u0027.join([\u0027%s:27019\u0027 % host"},{"line_number":216,"context_line":"                                      for host in config_server_hosts])"},{"line_number":217,"context_line":"        LOG.debug(\"Config server list %s\" % configdb_contents)"},{"line_number":218,"context_line":"        # remove db path from config and update configdb"},{"line_number":219,"context_line":"        contents \u003d self._delete_config_parameters(config_contents,"},{"line_number":220,"context_line":"                                                  [\"dbpath\", \"nojournal\","},{"line_number":221,"context_line":"                                                   \"smallfiles\", \"journal\","}],"source_content_type":"text/x-python","patch_set":19,"id":"fa98f980_a5b818c9","line":218,"updated":"2014-09-02 23:28:51.000000000","message":"this comment seems to be out of date now.","commit_id":"44683ae5d8a56f13fe1fdacce85d0839a4819ea3"}],"trove/guestagent/datastore/mongodb/system.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"f498c54f385fa35a6d0fbf44ee76d07f74d8f024","unresolved":false,"context_lines":[{"line_number":30,"context_line":"FIND_PID \u003d \"ps xau | grep \u0027mongo[ds]\u0027\""},{"line_number":31,"context_line":"TIME_OUT \u003d 1000"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"INIT_EXEC_MONGOS \u003d \"start-stop-daemon --start --quiet --chuid mongodb \" \\"},{"line_number":34,"context_line":"                   \"--exec  /usr/bin/mongos -- --config %s\" % CONFIG"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"MONGOS_UPSTART_CONTENTS \u003d \"\"\"pre-start script"}],"source_content_type":"text/x-python","patch_set":9,"id":"7ac7a964_58403656","line":33,"updated":"2014-08-16 14:38:20.000000000","message":"please do not use \\ for string formatting, it\u0027s not pythonic way.","commit_id":"36e2f1ef0d4ac3b0e50fc99677eb7cbcb62e8e2f"},{"author":{"_account_id":10139,"name":"Ramashri Umale","email":"rumale@ebaysf.com","username":"rumale"},"change_message_id":"c76b7a368a55e8cfd47016660ff5783f46302ed6","unresolved":false,"context_lines":[{"line_number":30,"context_line":"FIND_PID \u003d \"ps xau | grep \u0027mongo[ds]\u0027\""},{"line_number":31,"context_line":"TIME_OUT \u003d 1000"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"INIT_EXEC_MONGOS \u003d \"start-stop-daemon --start --quiet --chuid mongodb \" \\"},{"line_number":34,"context_line":"                   \"--exec  /usr/bin/mongos -- --config %s\" % CONFIG"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"MONGOS_UPSTART_CONTENTS \u003d \"\"\"pre-start script"}],"source_content_type":"text/x-python","patch_set":9,"id":"1abeadc6_41e737ac","line":33,"in_reply_to":"7ac7a964_58403656","updated":"2014-08-21 00:55:50.000000000","message":"will fix","commit_id":"36e2f1ef0d4ac3b0e50fc99677eb7cbcb62e8e2f"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"f498c54f385fa35a6d0fbf44ee76d07f74d8f024","unresolved":false,"context_lines":[{"line_number":33,"context_line":"INIT_EXEC_MONGOS \u003d \"start-stop-daemon --start --quiet --chuid mongodb \" \\"},{"line_number":34,"context_line":"                   \"--exec  /usr/bin/mongos -- --config %s\" % CONFIG"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"MONGOS_UPSTART_CONTENTS \u003d \"\"\"pre-start script"},{"line_number":37,"context_line":"    mkdir -p /var/log/mongodb/"},{"line_number":38,"context_line":"end script"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7ac7a964_7826d2cf","line":36,"updated":"2014-08-16 14:38:20.000000000","message":"I\u0027d suggest to move this content into\ntemplates/mongodb/node.upstart","commit_id":"36e2f1ef0d4ac3b0e50fc99677eb7cbcb62e8e2f"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"44f987cb87fbb197ef71edf7e91249241b1e0158","unresolved":false,"context_lines":[{"line_number":33,"context_line":"INIT_EXEC_MONGOS \u003d \"start-stop-daemon --start --quiet --chuid mongodb \" \\"},{"line_number":34,"context_line":"                   \"--exec  /usr/bin/mongos -- --config %s\" % CONFIG"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"MONGOS_UPSTART_CONTENTS \u003d \"\"\"pre-start script"},{"line_number":37,"context_line":"    mkdir -p /var/log/mongodb/"},{"line_number":38,"context_line":"end script"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1abeadc6_a5c90528","line":36,"in_reply_to":"7ac7a964_7826d2cf","updated":"2014-08-20 17:42:48.000000000","message":"it’d be the first time a template was introduced that wasn’t configuration-group-specific, which should give us pause. given it’s a one-off, I see no need to rock the boat and make it a template, because i\u0027d be afraid of the precedent it\u0027d set.","commit_id":"36e2f1ef0d4ac3b0e50fc99677eb7cbcb62e8e2f"}]}