)]}'
{"CONTRIBUTING.rst":[{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"change_message_id":"7a712ced8ce2a5bcc351e99b71016ce4b03a2730","unresolved":false,"context_lines":[{"line_number":28,"context_line":"       improvement is irrefutable,"},{"line_number":29,"context_line":"     * The change violates the OpenStack Commit Message guidelines"},{"line_number":30,"context_line":"       https://wiki.openstack.org/wiki/GitCommitMessages, or some well"},{"line_number":31,"context_line":"       understood OpenStack procedure(s),"},{"line_number":32,"context_line":"     * The change contains content that is demonstrably inappropriate,"},{"line_number":33,"context_line":"     * The test cases do not exercise the change(s) being proposed."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_7f159647","line":31,"updated":"2014-08-21 13:38:26.000000000","message":"I thought we all agreed that -1 for a commit message was *never* a good thing. The commit message has nothing to do with the code and should not hold up reviews. It may need to be fixed before it is merged but we should never -1 a commit message itself.","commit_id":"f4fd93d5c608a5b09c89821ecd95d78f5a6807a0"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"6f75b6f3474f8aa724ea3044cfdacce54cbf40bc","unresolved":false,"context_lines":[{"line_number":28,"context_line":"       improvement is irrefutable,"},{"line_number":29,"context_line":"     * The change violates the OpenStack Commit Message guidelines"},{"line_number":30,"context_line":"       https://wiki.openstack.org/wiki/GitCommitMessages, or some well"},{"line_number":31,"context_line":"       understood OpenStack procedure(s),"},{"line_number":32,"context_line":"     * The change contains content that is demonstrably inappropriate,"},{"line_number":33,"context_line":"     * The test cases do not exercise the change(s) being proposed."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_b57aef21","line":31,"in_reply_to":"1abeadc6_7f159647","updated":"2014-08-21 14:12:29.000000000","message":"Yup, that\u0027s what we decided. I will change it.","commit_id":"f4fd93d5c608a5b09c89821ecd95d78f5a6807a0"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"e57a72407e81b89d4b5f5f21f9441bfb1bdc4eaf","unresolved":false,"context_lines":[{"line_number":29,"context_line":"     * The subject matter of the change (not the commit message)"},{"line_number":30,"context_line":"       violates the some well understood OpenStack procedure(s),"},{"line_number":31,"context_line":"     * The change contains content that is demonstrably inappropriate,"},{"line_number":32,"context_line":"     * The test cases do not exercise the change(s) being proposed."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"   - A rating of 0 on a code review is indicated if:"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1abeadc6_99060d1c","line":32,"updated":"2014-08-21 14:26:40.000000000","message":"sometimes it is impossible, since we still can have deps over multiple projects.","commit_id":"3c740532e77206fa95574fc2d94071ae2666bbe4"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"e57a72407e81b89d4b5f5f21f9441bfb1bdc4eaf","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"     * The reason why you believe that the proposed change needs"},{"line_number":37,"context_line":"       improvement is merely an opinion,"},{"line_number":38,"context_line":"     * The proposed change is functional but you believe that there is"},{"line_number":39,"context_line":"       a different, better, or more appropriate way in which to"},{"line_number":40,"context_line":"       acheive the end result being sought by the proposed change,"},{"line_number":41,"context_line":"     * There is an issue of some kind with the Commit Message,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1abeadc6_398ed979","line":38,"updated":"2014-08-21 14:26:40.000000000","message":"This is actually a reason for -1 (only if proposed improvement was based upon evidences).","commit_id":"3c740532e77206fa95574fc2d94071ae2666bbe4"},{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"change_message_id":"9785e52c2b3511d02286ec323f87b859346c760a","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"     * The reason why you believe that the proposed change needs"},{"line_number":37,"context_line":"       improvement is merely an opinion,"},{"line_number":38,"context_line":"     * The proposed change is functional but you believe that there is"},{"line_number":39,"context_line":"       a different, better, or more appropriate way in which to"},{"line_number":40,"context_line":"       acheive the end result being sought by the proposed change,"},{"line_number":41,"context_line":"     * There is an issue of some kind with the Commit Message,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1abeadc6_bca3b7fe","line":38,"in_reply_to":"1abeadc6_398ed979","updated":"2014-08-21 14:48:22.000000000","message":"Denis this is just an example, however as was discussed if your comment on the code is merrily a better way to organize the code it should not be a -1. Only if the code is bad fundamentally, ie the code introduces a actual bug or is duplicating logic in other parts of the code.","commit_id":"3c740532e77206fa95574fc2d94071ae2666bbe4"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"dffbdc43e6dfa73320988fbb5c5c814f95183c70","unresolved":false,"context_lines":[{"line_number":37,"context_line":"       improvement is merely an opinion,"},{"line_number":38,"context_line":"     * The proposed change is functional but you believe that there is"},{"line_number":39,"context_line":"       a different, better, or more appropriate way in which to"},{"line_number":40,"context_line":"       acheive the end result being sought by the proposed change,"},{"line_number":41,"context_line":"     * There is an issue of some kind with the Commit Message,"},{"line_number":42,"context_line":"       including violations of the Commit Message guidelines,"},{"line_number":43,"context_line":"     * There is a typographical or formatting error in the commit"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1abeadc6_d3ebfe75","line":40,"updated":"2014-08-21 17:17:02.000000000","message":"Maybe we should indicate here that if a *second* reviewer agrees that the proposed change is better, a -1 is then justified (as also discussed)?","commit_id":"421823dc40e9f00e92f8aca674ccbe528834ed85"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"fc041ec99143e9880579990e23bbf995b3625b47","unresolved":false,"context_lines":[{"line_number":49,"context_line":"       improvement is irrefutable, or it is a widely shared opinion as"},{"line_number":50,"context_line":"       indicated by a number of +0 coments,"},{"line_number":51,"context_line":"     * The subject matter of the change (not the commit message)"},{"line_number":52,"context_line":"       violates the some well understood OpenStack procedure(s),"},{"line_number":53,"context_line":"     * The change contains content that is demonstrably inappropriate,"},{"line_number":54,"context_line":"     * The test cases do not exercise the change(s) being proposed."},{"line_number":55,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1abeadc6_221bfd73","line":52,"updated":"2014-08-21 17:47:45.000000000","message":"I just noticed that this seems grammatically incorrect (or maybe just awkward).  I\u0027ll follow the instructions here and make this a +0 to see if others agree.","commit_id":"e1d495583026972b05b437b9e047e584b0d8134d"},{"author":{"_account_id":9683,"name":"Mat Lowery","email":"mlowery@ebaysf.com","username":"mat-lowery"},"change_message_id":"59b249f7c439efe17303a76457836b425fc3abc8","unresolved":false,"context_lines":[{"line_number":28,"context_line":"       considered for merging."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"   - A rating of 0 on a code review is indicated if:"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"     * The reason why you believe that the proposed change needs"},{"line_number":34,"context_line":"       improvement is merely an opinion,"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1abeadc6_c02ad37d","line":31,"updated":"2014-08-25 21:41:25.000000000","message":"Another item that could be a zero is simply asking a question to the author. In other words, getting clarification on why something is like it is, is a 0.","commit_id":"b79e49d0969342ee1edcdc3dc073a173a3567424"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"a26c4903e5bad93098c67320d59916f4cb7e0bc6","unresolved":false,"context_lines":[{"line_number":28,"context_line":"       considered for merging."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"   - A rating of 0 on a code review is indicated if:"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"     * The reason why you believe that the proposed change needs"},{"line_number":34,"context_line":"       improvement is merely an opinion,"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1abeadc6_e56d19ce","line":31,"in_reply_to":"1abeadc6_c02ad37d","updated":"2014-08-26 02:30:42.000000000","message":"Done","commit_id":"b79e49d0969342ee1edcdc3dc073a173a3567424"},{"author":{"_account_id":9683,"name":"Mat Lowery","email":"mlowery@ebaysf.com","username":"mat-lowery"},"change_message_id":"59b249f7c439efe17303a76457836b425fc3abc8","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"     * The reason why you believe that the proposed change needs"},{"line_number":49,"context_line":"       improvement is irrefutable, or it is a widely shared opinion as"},{"line_number":50,"context_line":"       indicated by a number of +0 coments,"},{"line_number":51,"context_line":"     * The subject matter of the change (not the commit message)"},{"line_number":52,"context_line":"       violates some well understood OpenStack procedure(s),"},{"line_number":53,"context_line":"     * The change contains content that is demonstrably inappropriate,"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1abeadc6_ec998b20","line":50,"updated":"2014-08-25 21:41:25.000000000","message":"typo: coments\n\nIt\u0027s irrefutable. :)","commit_id":"b79e49d0969342ee1edcdc3dc073a173a3567424"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"a26c4903e5bad93098c67320d59916f4cb7e0bc6","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"     * The reason why you believe that the proposed change needs"},{"line_number":49,"context_line":"       improvement is irrefutable, or it is a widely shared opinion as"},{"line_number":50,"context_line":"       indicated by a number of +0 coments,"},{"line_number":51,"context_line":"     * The subject matter of the change (not the commit message)"},{"line_number":52,"context_line":"       violates some well understood OpenStack procedure(s),"},{"line_number":53,"context_line":"     * The change contains content that is demonstrably inappropriate,"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1abeadc6_a57321b3","line":50,"in_reply_to":"1abeadc6_ec998b20","updated":"2014-08-26 02:30:42.000000000","message":"Done","commit_id":"b79e49d0969342ee1edcdc3dc073a173a3567424"},{"author":{"_account_id":9683,"name":"Mat Lowery","email":"mlowery@ebaysf.com","username":"mat-lowery"},"change_message_id":"59b249f7c439efe17303a76457836b425fc3abc8","unresolved":false,"context_lines":[{"line_number":56,"context_line":"Some other reviewing guidelines:"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"   - In general, when in doubt, a rating of 0 is advised,"},{"line_number":59,"context_line":"   - The hacking rules accepted by the project are part of tox.ini, a"},{"line_number":60,"context_line":"     violation of some other hacking rule(s), or pep8 is not a reason"},{"line_number":61,"context_line":"     to -1 a change."},{"line_number":62,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1abeadc6_4c88bfc6","line":59,"updated":"2014-08-25 21:41:25.000000000","message":"\"hacking\" is such a generic term and perhaps some don\u0027t know it\u0027s the name of a set of style guidelines. Perhaps a link (http://docs.openstack.org/developer/hacking/) would help?\n\nI was confused by the flow of this sentence and I think it could be clarified using a semi-colon or period after tox.ini and removing the comma in line 60.","commit_id":"b79e49d0969342ee1edcdc3dc073a173a3567424"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"a26c4903e5bad93098c67320d59916f4cb7e0bc6","unresolved":false,"context_lines":[{"line_number":56,"context_line":"Some other reviewing guidelines:"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"   - In general, when in doubt, a rating of 0 is advised,"},{"line_number":59,"context_line":"   - The hacking rules accepted by the project are part of tox.ini, a"},{"line_number":60,"context_line":"     violation of some other hacking rule(s), or pep8 is not a reason"},{"line_number":61,"context_line":"     to -1 a change."},{"line_number":62,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1abeadc6_8547054b","line":59,"in_reply_to":"1abeadc6_4c88bfc6","updated":"2014-08-26 02:30:42.000000000","message":"Done","commit_id":"b79e49d0969342ee1edcdc3dc073a173a3567424"},{"author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"change_message_id":"e3fb0c6989f5ea43f308e0a548d7a406500b3779","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"   - A rating of +1 on a code review is indicated if:"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"     * If it is your opinion that the change, as proposed, should be"},{"line_number":28,"context_line":"       considered for merging."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1abeadc6_f3a59504","line":27,"updated":"2014-08-27 15:57:08.000000000","message":"Just a small nit: there is already an \"If\" above so this should be removed and the sentence can start with \"It\".","commit_id":"9ccc042b150a5154104d8d2fcd8b65444387152d"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"788b3c7f5207e9f6317d8430f480005f5c8afb4f","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"   - A rating of +1 on a code review is indicated if:"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"     * If it is your opinion that the change, as proposed, should be"},{"line_number":28,"context_line":"       considered for merging."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa98f980_30f60f64","line":27,"in_reply_to":"1abeadc6_f3a59504","updated":"2014-09-03 14:20:01.000000000","message":"I agree with Ionut on this one.  The double \u0027if\u0027 makes it grammatically incorrect, so as per the instructions I\u0027m bumping to -1 ;)","commit_id":"9ccc042b150a5154104d8d2fcd8b65444387152d"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"fe7aa70b59838a76c2e0ee3d45af3e7eb587f835","unresolved":false,"context_lines":[{"line_number":71,"context_line":"   - https://wiki.openstack.org/wiki/ReviewChecklist"},{"line_number":72,"context_line":"   - https://wiki.openstack.org/wiki/GitCommitMessages"},{"line_number":73,"context_line":"   - http://docs.openstack.org/developer/hacking/"},{"line_number":74,"context_line":"   - https://review.openstack.org/#/c/116176/"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"fa98f980_2077eb3c","line":74,"range":{"start_line":74,"start_character":5,"end_line":74,"end_character":45},"updated":"2014-09-09 15:32:29.000000000","message":"Maybe link the actual page: https://github.com/openstack-infra/config/blob/master/doc/source/gerrit.rst","commit_id":"75599929450942c66669e30b539fb63b0f680e1c"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"f8e3632be7b0457065e4e1e00394db99d5e94bdd","unresolved":false,"context_lines":[{"line_number":71,"context_line":"   - https://wiki.openstack.org/wiki/ReviewChecklist"},{"line_number":72,"context_line":"   - https://wiki.openstack.org/wiki/GitCommitMessages"},{"line_number":73,"context_line":"   - http://docs.openstack.org/developer/hacking/"},{"line_number":74,"context_line":"   - https://review.openstack.org/#/c/116176/"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"fa98f980_adb9fa16","line":74,"range":{"start_line":74,"start_character":5,"end_line":74,"end_character":45},"in_reply_to":"fa98f980_2077eb3c","updated":"2014-09-10 11:39:26.000000000","message":"+1.\nAlso i\u0027d suggest to use RST style formatting for links to avoid showing links directly - just show it verbose name,\nsuch as:\n\n - Code review guid lines\n\n\netc.","commit_id":"75599929450942c66669e30b539fb63b0f680e1c"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"784b9129463991d52de3f99e7e30a7ddaf998a26","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"   - In general, when in doubt, a rating of 0 is advised,"},{"line_number":63,"context_line":"   - The code style guidelines accepted by the project are part of"},{"line_number":64,"context_line":"     tox.ini, a violation of some other hacking rule(s), or pep8 is"},{"line_number":65,"context_line":"     not a reason to -1 a change."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Other references:"}],"source_content_type":"text/x-rst","patch_set":12,"id":"9aa7fdbe_07acfcec","line":64,"updated":"2014-10-20 08:28:27.000000000","message":"I think there still might be some confusion here. \n\nRunning tox does run pep8, so a violation of pep8 does indeed cause a -1 by Jenkins. Is the implication that folks should not -1 since a -1 from Jenkins should suffice?\n\nOr is the implication that folks should not -1 for a PEP 8 violation that pep8 didn\u0027t catch?","commit_id":"52b78a9d87351a542441a27396d3c7c38cc2d3ce"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b76fb77648474d91150a27710691ae13642ad1a0","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"   - In general, when in doubt, a rating of 0 is advised,"},{"line_number":63,"context_line":"   - The code style guidelines accepted by the project are part of"},{"line_number":64,"context_line":"     tox.ini, a violation of some other hacking rule(s), or pep8 is"},{"line_number":65,"context_line":"     not a reason to -1 a change."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Other references:"}],"source_content_type":"text/x-rst","patch_set":12,"id":"9aa7fdbe_fbfead37","line":64,"in_reply_to":"9aa7fdbe_07acfcec","updated":"2014-10-20 11:21:40.000000000","message":"The intent was both of the things you mention. If I recall correctly, the discussion was this.\n\nIf a potential reviewer saw a human -1 on a review, it was more of a disincentive to review the change than if it was merely a -1 for a pep8 failure which one would reasonably assume would get fixed.\n\nTherefore, the intent of the statement was this.\n\nIf pep8 rules adopted by the project in tox.ini included some set of rules [R1, R2, ... ignore R5, R6] then that is the standard that the project wishes to hold itself to.\n\nDon\u0027t -1 a change because the code proposed would violate some other pep8 rule R20 which isn\u0027t part of tox.ini\n\nFurthermore if some change set failed pep8 (python 26 or python 27) don\u0027t further go land a human -1 on it with the comment that adds no further value that says \"fix pep8 please\".\n\nSo, yes, I\u0027ll clarify this sentence if you think it needs further clarification.","commit_id":"52b78a9d87351a542441a27396d3c7c38cc2d3ce"}]}