)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"da0d4b43746d9847b84181e47f0871e1298a9900","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2014-08-22 14:56:03 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use the service discovery for redis and cassandra datastore backends"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I2c78c78677a76c8dd01ddabe901a60d18ceaeaad"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1abeadc6_fcafc67a","line":8,"updated":"2014-08-22 14:25:57.000000000","message":"Sorry, but you need to address this patch to a specific bug report or the BP. See https://wiki.openstack.org/wiki/Gerrit_Workflow","commit_id":"94a9fb363b5109ac7e4284689220adf2fe2ba6aa"}],"trove/guestagent/datastore/cassandra/service.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"04a8bdbd099c15a53ce58a0528aac92521aed089","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def _enable_db_on_boot(self):"},{"line_number":54,"context_line":"        cassandra_service \u003d operating_system.service_discovery("},{"line_number":55,"context_line":"            system.SERVICE_CANDIDATES)"},{"line_number":56,"context_line":"        utils.execute_with_timeout("},{"line_number":57,"context_line":"            cassandra_service[\u0027cmd_enable\u0027], shell\u003dTrue)"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_67e2d530","line":55,"updated":"2014-08-26 15:23:17.000000000","message":"This snippet should be moved to global variables or become a singleton, because services candidates needs to be defined only one time - when datastore gets deployed. No need to look for the same values multiple times. So you need to build a dict of commands.","commit_id":"7794db298b565540b5bbded8141ecc16cbbe29df"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"400f0e2fc5f0e77e00257366f5b1ab08f42113b5","unresolved":false,"context_lines":[{"line_number":30,"context_line":"CONF \u003d cfg.CONF"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"packager \u003d pkg.Package()"},{"line_number":33,"context_line":"cassandra_service \u003d operating_system.service_discovery("},{"line_number":34,"context_line":"    system.SERVICE_CANDIDATES)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_2e770bd6","line":33,"updated":"2014-09-01 10:43:07.000000000","message":"Actuall this wouldn\u0027t work if VM doesn\u0027t have installed datastore package. You need to find out another way to initialize service discovery right after package deployment.","commit_id":"a047c9e6b24c806a489130aa8244c5f91018f379"}],"trove/guestagent/datastore/redis/service.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"400f0e2fc5f0e77e00257366f5b1ab08f42113b5","unresolved":false,"context_lines":[{"line_number":207,"context_line":"        if do_not_start_on_reboot:"},{"line_number":208,"context_line":"            self._disable_redis_on_boot()"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        redis_service \u003d operating_system.service_discovery("},{"line_number":211,"context_line":"            system.SERVICE_CANDIDATES)"},{"line_number":212,"context_line":"        utils.execute_with_timeout(redis_service[\u0027cmd_stop\u0027], shell\u003dTrue)"},{"line_number":213,"context_line":"        if not self.status.wait_for_real_status_to_change_to("}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_ee442376","line":210,"updated":"2014-09-01 10:43:07.000000000","message":"same here, you just need to have one instance of service discovery, and it should be initialized once deployment is done.","commit_id":"a047c9e6b24c806a489130aa8244c5f91018f379"}]}
