)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"39cc46059930c9c758e2ef22ab61c20ec10ac682","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  ENABLED_SERVICES+\u003d,ceilometer-anotification,ceilometer-collector"},{"line_number":34,"context_line":"  ENABLED_SERVICES+\u003d,ceilometer-alarm-evaluator,ceilometer-alarm-notifier"},{"line_number":35,"context_line":"  ENABLED_SERVICES+\u003d,ceilometer-api"},{"line_number":36,"context_line":"You should use python-pythonclient with this change:"},{"line_number":37,"context_line":"  I5a76e11d428c63d33f6d2c2021426090ebf8340c"},{"line_number":38,"context_line":"You should use devstack with this change to setup notification"},{"line_number":39,"context_line":"options automatically:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"5a890539_1e167049","line":36,"updated":"2014-12-03 13:17:41.000000000","message":"python-troveclient","commit_id":"30bfb9088ed4b33330d7ca95866c5a3762c3ffad"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"1a1db0bd81f8967e67ab1ae8224cff1bdc376a2d","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  ENABLED_SERVICES+\u003d,ceilometer-anotification,ceilometer-collector"},{"line_number":34,"context_line":"  ENABLED_SERVICES+\u003d,ceilometer-alarm-evaluator,ceilometer-alarm-notifier"},{"line_number":35,"context_line":"  ENABLED_SERVICES+\u003d,ceilometer-api"},{"line_number":36,"context_line":"You should use python-pythonclient with this change:"},{"line_number":37,"context_line":"  I5a76e11d428c63d33f6d2c2021426090ebf8340c"},{"line_number":38,"context_line":"You should use devstack with this change to setup notification"},{"line_number":39,"context_line":"options automatically:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"5a890539_fe536437","line":36,"in_reply_to":"5a890539_1e167049","updated":"2014-12-03 13:32:57.000000000","message":"ah, good eyes, will update in next ps :)","commit_id":"30bfb9088ed4b33330d7ca95866c5a3762c3ffad"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"4f1dfa27db2365c33a75035e7a4d9eae7e2ef18b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  ENABLED_SERVICES+\u003d,ceilometer-anotification,ceilometer-collector"},{"line_number":34,"context_line":"  ENABLED_SERVICES+\u003d,ceilometer-alarm-evaluator,ceilometer-alarm-notifier"},{"line_number":35,"context_line":"  ENABLED_SERVICES+\u003d,ceilometer-api"},{"line_number":36,"context_line":"You should use python-pythonclient with this change:"},{"line_number":37,"context_line":"  I5a76e11d428c63d33f6d2c2021426090ebf8340c"},{"line_number":38,"context_line":"You should use devstack with this change to setup notification"},{"line_number":39,"context_line":"options automatically:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"5a890539_b3039c0b","line":36,"updated":"2014-12-04 12:57:32.000000000","message":"python-troveclient","commit_id":"c4acdd571021da4f8d13a0cb64c8ef201b8306b3"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b8b1bbe44cab62c122db7c9b5a24218a1239679b","unresolved":false,"context_lines":[{"line_number":48,"context_line":"Cinder, and some others are working in progress."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Change-Id: I580cce8d2b3c4ec9ce625ac09de6f14e1249f6f5"},{"line_number":51,"context_line":"Signed-off-by: Zhi Yan Liu \u003czhiyanl@cn.ibm.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"3a961159_de5c7880","line":51,"updated":"2015-01-11 20:35:16.000000000","message":"But, this is you, no?","commit_id":"3b098b3c372e8f73970700297be556f0d5dd571b"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"0d4dd7dbbc2d3f6c85246aae797d5d1b98efe33d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"Cinder, and some others are working in progress."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Change-Id: I580cce8d2b3c4ec9ce625ac09de6f14e1249f6f5"},{"line_number":51,"context_line":"Signed-off-by: Zhi Yan Liu \u003czhiyanl@cn.ibm.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"3a961159_4f4ff434","line":51,"in_reply_to":"3a961159_de5c7880","updated":"2015-01-12 02:46:12.000000000","message":"yes, it is.","commit_id":"3b098b3c372e8f73970700297be556f0d5dd571b"}],"etc/trove/api-paste.ini":[{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"ff13ced3fe5dc7ea9a665e6414c097c1e8e3749b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"[filter:osprofiler]"},{"line_number":42,"context_line":"paste.filter_factory \u003d osprofiler.web:WsgiMiddleware.factory"},{"line_number":43,"context_line":"hmac_keys \u003d SECRET_KEY"},{"line_number":44,"context_line":"enabled \u003d yes"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"[app:troveapp]"},{"line_number":47,"context_line":"paste.app_factory \u003d trove.common.api:app_factory"}],"source_content_type":"text/x-properties","patch_set":10,"id":"9aa7fdbe_071de166","line":44,"updated":"2014-10-20 01:05:14.000000000","message":"should not default to being on.","commit_id":"002db1f9f62d96454a22259ef8d5f8cfd19d6b65"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"2386652fda0654421ba482b82a950823c8044d9b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"[filter:osprofiler]"},{"line_number":42,"context_line":"paste.filter_factory \u003d osprofiler.web:WsgiMiddleware.factory"},{"line_number":43,"context_line":"hmac_keys \u003d SECRET_KEY"},{"line_number":44,"context_line":"enabled \u003d yes"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"[app:troveapp]"},{"line_number":47,"context_line":"paste.app_factory \u003d trove.common.api:app_factory"}],"source_content_type":"text/x-properties","patch_set":10,"id":"9aa7fdbe_e73d3dbd","line":44,"in_reply_to":"9aa7fdbe_071de166","updated":"2014-10-20 01:10:24.000000000","message":"This argument will be removed in future versions of osprofiler. I do think that it should be just disabled by default via CONF (which is similar)","commit_id":"002db1f9f62d96454a22259ef8d5f8cfd19d6b65"}],"trove/common/cfg.py":[{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"ff13ced3fe5dc7ea9a665e6414c097c1e8e3749b","unresolved":false,"context_lines":[{"line_number":378,"context_line":"    \u0027profiler\u0027, title\u003d\u0027Profiler options\u0027,"},{"line_number":379,"context_line":"    help\u003d\"Oslo option group designed for profiler\")"},{"line_number":380,"context_line":"profiler_opts \u003d ["},{"line_number":381,"context_line":"    cfg.BoolOpt(\"enabled\", default\u003dTrue,"},{"line_number":382,"context_line":"                help\u003d\"If False fully disable profiling feature.\"),"},{"line_number":383,"context_line":"    cfg.BoolOpt(\"trace_sqlalchemy\", default\u003dTrue,"},{"line_number":384,"context_line":"                help\u003d\"If False doesn\u0027t trace SQL requests.\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"9aa7fdbe_e70ffd2c","line":381,"updated":"2014-10-20 01:05:14.000000000","message":"this should not default to being on.","commit_id":"002db1f9f62d96454a22259ef8d5f8cfd19d6b65"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"ef6d94d4d2f1bb70881d20773116119115d7019e","unresolved":false,"context_lines":[{"line_number":378,"context_line":"    \u0027profiler\u0027, title\u003d\u0027Profiler options\u0027,"},{"line_number":379,"context_line":"    help\u003d\"Oslo option group designed for profiler\")"},{"line_number":380,"context_line":"profiler_opts \u003d ["},{"line_number":381,"context_line":"    cfg.BoolOpt(\"enabled\", default\u003dTrue,"},{"line_number":382,"context_line":"                help\u003d\"If False fully disable profiling feature.\"),"},{"line_number":383,"context_line":"    cfg.BoolOpt(\"trace_sqlalchemy\", default\u003dTrue,"},{"line_number":384,"context_line":"                help\u003d\"If False doesn\u0027t trace SQL requests.\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"9aa7fdbe_bddc2276","line":381,"in_reply_to":"9aa7fdbe_e70ffd2c","updated":"2014-10-20 05:32:51.000000000","message":"Done","commit_id":"002db1f9f62d96454a22259ef8d5f8cfd19d6b65"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"17e44b35c32c5fbd82a55b57e77d07abe488ada0","unresolved":false,"context_lines":[{"line_number":777,"context_line":"CONF.register_opts(common_opts)"},{"line_number":778,"context_line":""},{"line_number":779,"context_line":"CONF.register_group(profiler_group)"},{"line_number":780,"context_line":"CONF.register_opts(profiler_opts, profiler_group)"},{"line_number":781,"context_line":""},{"line_number":782,"context_line":"CONF.register_group(mysql_group)"},{"line_number":783,"context_line":"CONF.register_group(percona_group)"}],"source_content_type":"text/x-python","patch_set":20,"id":"da86d52c_523db32b","line":780,"updated":"2015-02-16 05:18:27.000000000","message":"It would be more consistent to shift this register_opts to be with other register_opts","commit_id":"fe2542262802508d45f3babf8282f74992b1acb8"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"b773af17f1388293c993ac33655f4aa4e417711f","unresolved":false,"context_lines":[{"line_number":777,"context_line":"CONF.register_opts(common_opts)"},{"line_number":778,"context_line":""},{"line_number":779,"context_line":"CONF.register_group(profiler_group)"},{"line_number":780,"context_line":"CONF.register_opts(profiler_opts, profiler_group)"},{"line_number":781,"context_line":""},{"line_number":782,"context_line":"CONF.register_group(mysql_group)"},{"line_number":783,"context_line":"CONF.register_group(percona_group)"}],"source_content_type":"text/x-python","patch_set":20,"id":"da86d52c_14030c77","line":780,"in_reply_to":"da86d52c_452dd4fc","updated":"2015-02-16 18:53:30.000000000","message":"So, as I see there is a grouping of register_group and another grouping of register_opts\n\nlocation you may choose whichever you like beginning or last, but should look similar to what has been written earlier, so that it becomes easier while finding them later.","commit_id":"fe2542262802508d45f3babf8282f74992b1acb8"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"44b3a197bf5f7e715f6832372542e9e657fa8a6b","unresolved":false,"context_lines":[{"line_number":777,"context_line":"CONF.register_opts(common_opts)"},{"line_number":778,"context_line":""},{"line_number":779,"context_line":"CONF.register_group(profiler_group)"},{"line_number":780,"context_line":"CONF.register_opts(profiler_opts, profiler_group)"},{"line_number":781,"context_line":""},{"line_number":782,"context_line":"CONF.register_group(mysql_group)"},{"line_number":783,"context_line":"CONF.register_group(percona_group)"}],"source_content_type":"text/x-python","patch_set":20,"id":"da86d52c_452dd4fc","line":780,"in_reply_to":"da86d52c_523db32b","updated":"2015-02-16 16:48:55.000000000","message":"Would it?  These have nothing to do with the datastores.  (Besides, where would you put them, with the register_opts above or the ones below?)  I kinda like them here by themselves...","commit_id":"fe2542262802508d45f3babf8282f74992b1acb8"}],"trove/common/profile.py":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"edb17ea6532c7cd6ee922b4df1effe10186fa223","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                     \"trigger profiler, only admin user can retrieve trace \""},{"line_number":44,"context_line":"                     \"information.\\n\""},{"line_number":45,"context_line":"                     \"To disable OSprofiler set in configure file:\\n\""},{"line_number":46,"context_line":"                     \"[profiler]\\nenabled\u003dfalse\"))"},{"line_number":47,"context_line":"    else:"},{"line_number":48,"context_line":"        web.disable()"}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_d29e3a63","line":46,"updated":"2015-01-30 21:18:14.000000000","message":"If I understand this message correctly, perhaps the following would be clearer:\n\n  LOG.warn(_LW(\"The OpenStack Profiler is enabled.  Using one of the\\n\"\n               \"hmac_keys specified in /etc/trove/api-paste.ini, a trace\\n\"\n               \"can be made of all requests.  Only an admin user can\\n\"\n               \"retrieve the trace information, however.\\n\"\n               \"To disable the profiler, add the following to the\\n\"\n               \"configuration file:\\n\"\n               \"[profiler]\\n\"\n               \"enabled\u003dfalse\\n\"))","commit_id":"69c0db54963fbabbb5b633b4cfcd995ecfb0a959"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"e40ca45597f625ff4ecb1d0ee5141fc4135921be","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                     \"trigger profiler, only admin user can retrieve trace \""},{"line_number":44,"context_line":"                     \"information.\\n\""},{"line_number":45,"context_line":"                     \"To disable OSprofiler set in configure file:\\n\""},{"line_number":46,"context_line":"                     \"[profiler]\\nenabled\u003dfalse\"))"},{"line_number":47,"context_line":"    else:"},{"line_number":48,"context_line":"        web.disable()"}],"source_content_type":"text/x-python","patch_set":19,"id":"da86d52c_c8310ba4","line":46,"in_reply_to":"da86d52c_d29e3a63","updated":"2015-02-02 06:06:14.000000000","message":"I was thinking if it\u0027s worth to be consistent, e.g.  https://github.com/openstack/cinder/blob/master/cinder/service.py#L89 , but it\u0027s not a big deal to me, let me know if you stick to your idea.","commit_id":"69c0db54963fbabbb5b633b4cfcd995ecfb0a959"}],"trove/common/rpc/service.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b8b1bbe44cab62c122db7c9b5a24218a1239679b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from trove.common import cfg"},{"line_number":30,"context_line":"from trove.common import profile"},{"line_number":31,"context_line":"from trove import rpc"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"CONF \u003d cfg.CONF"},{"line_number":35,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a961159_be9c0c10","line":32,"updated":"2015-01-11 20:35:16.000000000","message":"do you need this blank line?","commit_id":"3b098b3c372e8f73970700297be556f0d5dd571b"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"0d4dd7dbbc2d3f6c85246aae797d5d1b98efe33d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from trove.common import cfg"},{"line_number":30,"context_line":"from trove.common import profile"},{"line_number":31,"context_line":"from trove import rpc"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"CONF \u003d cfg.CONF"},{"line_number":35,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a961159_2f52a8de","line":32,"in_reply_to":"3a961159_be9c0c10","updated":"2015-01-12 02:46:12.000000000","message":"Same reason  like https://review.openstack.org/#/c/116653/18/trove/rpc.py","commit_id":"3b098b3c372e8f73970700297be556f0d5dd571b"}],"trove/rpc.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b8b1bbe44cab62c122db7c9b5a24218a1239679b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    \u0027TRANSPORT_ALIASES\u0027,"},{"line_number":31,"context_line":"]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"from oslo.config import cfg"},{"line_number":35,"context_line":"from oslo import messaging"},{"line_number":36,"context_line":"from osprofiler import profiler"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a961159_3e901ced","line":33,"updated":"2015-01-11 20:35:16.000000000","message":"blank line?","commit_id":"3b098b3c372e8f73970700297be556f0d5dd571b"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"0d4dd7dbbc2d3f6c85246aae797d5d1b98efe33d","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    \u0027TRANSPORT_ALIASES\u0027,"},{"line_number":31,"context_line":"]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"from oslo.config import cfg"},{"line_number":35,"context_line":"from oslo import messaging"},{"line_number":36,"context_line":"from osprofiler import profiler"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a961159_2fbb8810","line":33,"in_reply_to":"3a961159_3e901ced","updated":"2015-01-12 02:46:12.000000000","message":"Yes I\u0027d like to use double blank to separated a global var and module importing block. I think it\u0027s a minor thing which could belongs with this patch, but if you don\u0027t like it or don\u0027t think it should be related with this MP, I can keep and it is not a big deal to me.","commit_id":"3b098b3c372e8f73970700297be556f0d5dd571b"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b8b1bbe44cab62c122db7c9b5a24218a1239679b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"from oslo.config import cfg"},{"line_number":35,"context_line":"from oslo import messaging"},{"line_number":36,"context_line":"from osprofiler import profiler"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"from trove.common.context import TroveContext"},{"line_number":39,"context_line":"import trove.common.exception"},{"line_number":40,"context_line":"from trove.openstack.common import jsonutils"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a961159_5e8de8d2","line":37,"updated":"2015-01-11 20:35:16.000000000","message":"blank line?","commit_id":"3b098b3c372e8f73970700297be556f0d5dd571b"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"0d4dd7dbbc2d3f6c85246aae797d5d1b98efe33d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"from oslo.config import cfg"},{"line_number":35,"context_line":"from oslo import messaging"},{"line_number":36,"context_line":"from osprofiler import profiler"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"from trove.common.context import TroveContext"},{"line_number":39,"context_line":"import trove.common.exception"},{"line_number":40,"context_line":"from trove.openstack.common import jsonutils"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a961159_cf43e411","line":37,"in_reply_to":"3a961159_5e8de8d2","updated":"2015-01-12 02:46:12.000000000","message":"I used a single blank to separated 3rd module and built-in trove modules as most practice from other places.","commit_id":"3b098b3c372e8f73970700297be556f0d5dd571b"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b8b1bbe44cab62c122db7c9b5a24218a1239679b","unresolved":false,"context_lines":[{"line_number":38,"context_line":"from trove.common.context import TroveContext"},{"line_number":39,"context_line":"import trove.common.exception"},{"line_number":40,"context_line":"from trove.openstack.common import jsonutils"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"CONF \u003d cfg.CONF"},{"line_number":44,"context_line":"TRANSPORT \u003d None"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a961159_7eb9c47b","line":41,"updated":"2015-01-11 20:35:16.000000000","message":"blank line?","commit_id":"3b098b3c372e8f73970700297be556f0d5dd571b"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"0d4dd7dbbc2d3f6c85246aae797d5d1b98efe33d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"from trove.common.context import TroveContext"},{"line_number":39,"context_line":"import trove.common.exception"},{"line_number":40,"context_line":"from trove.openstack.common import jsonutils"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"CONF \u003d cfg.CONF"},{"line_number":44,"context_line":"TRANSPORT \u003d None"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a961159_ef47c01c","line":41,"in_reply_to":"3a961159_7eb9c47b","updated":"2015-01-12 02:46:12.000000000","message":"The same reason as above first reply.","commit_id":"3b098b3c372e8f73970700297be556f0d5dd571b"}]}