)]}'
{"trove/db/sqlalchemy/migrate_repo/versions/020_configurations.py":[{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"9c32f9a716c855db0983bdf1210f9111e46dc73c","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    # If the tables to be created already exist, we\u0027ll skip this upgrade and"},{"line_number":62,"context_line":"    # log a warning message"},{"line_number":63,"context_line":"    tables_exist \u003d (migrate_engine.has_table(\u0027configurations\u0027) or"},{"line_number":64,"context_line":"                    migrate_engine.has_table(\u0027configuration_parameters\u0027))"},{"line_number":65,"context_line":"    if tables_exist:"},{"line_number":66,"context_line":"        logger.warn(\u0027Table(s) to be created already exist. \u0027"},{"line_number":67,"context_line":"                    \u0027Skipping this upgrade.\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_ec73867d","line":64,"updated":"2014-08-29 21:07:41.000000000","message":"what if only one of the table exists? if this migration errored out mid way?","commit_id":"c0fb04e04e6c5aa6211110d26d2d2c5aa686728c"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"de3086801feb150b1cc27121244127f062a344a5","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    # If the tables to be created already exist, we\u0027ll skip this upgrade and"},{"line_number":62,"context_line":"    # log a warning message"},{"line_number":63,"context_line":"    tables_exist \u003d (migrate_engine.has_table(\u0027configurations\u0027) or"},{"line_number":64,"context_line":"                    migrate_engine.has_table(\u0027configuration_parameters\u0027))"},{"line_number":65,"context_line":"    if tables_exist:"},{"line_number":66,"context_line":"        logger.warn(\u0027Table(s) to be created already exist. \u0027"},{"line_number":67,"context_line":"                    \u0027Skipping this upgrade.\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_0065d9ad","line":64,"in_reply_to":"1abeadc6_8c093297","updated":"2014-08-30 15:57:23.000000000","message":"Yeah I agree with you Simon","commit_id":"c0fb04e04e6c5aa6211110d26d2d2c5aa686728c"},{"author":{"_account_id":10266,"name":"Simon Chang","email":"schang@tesora.com","username":"changsimon"},"change_message_id":"13c285ab4f169efb96cb7f6d752748947c07fc67","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    # If the tables to be created already exist, we\u0027ll skip this upgrade and"},{"line_number":62,"context_line":"    # log a warning message"},{"line_number":63,"context_line":"    tables_exist \u003d (migrate_engine.has_table(\u0027configurations\u0027) or"},{"line_number":64,"context_line":"                    migrate_engine.has_table(\u0027configuration_parameters\u0027))"},{"line_number":65,"context_line":"    if tables_exist:"},{"line_number":66,"context_line":"        logger.warn(\u0027Table(s) to be created already exist. \u0027"},{"line_number":67,"context_line":"                    \u0027Skipping this upgrade.\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_8c093297","line":64,"in_reply_to":"1abeadc6_ec73867d","updated":"2014-08-29 21:20:26.000000000","message":"How about changing the \"or\" to \"and\"? If only one of these tables exist, the situation is odd enough that it warrants a fatal exception to be thrown. Your thoughts?","commit_id":"c0fb04e04e6c5aa6211110d26d2d2c5aa686728c"}]}